From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 455C6A04DC; Sun, 22 Nov 2020 09:44:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 202CFFFA; Sun, 22 Nov 2020 09:44:09 +0100 (CET) Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by dpdk.org (Postfix) with ESMTP id 5A47123D for ; Sun, 22 Nov 2020 09:44:07 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Sun, 22 Nov 2020 00:44:07 -0800 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sun, 22 Nov 2020 08:44:05 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Sun, 22 Nov 2020 08:44:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a1HabQvGAFk+FE6q8iEuZqcpcNLt+UR7WC9zuXeabpukTRPe6kLEx7rrHOir07izFeGCS6cBvaC2Fw/H8vDNg6m2Ed58WaQWrjC/IQyAo3kH3aYxtbAOV4+SsfVGF6h2xgnSaLi/lKYPEh0Jfjv2gJYFAoJrHyAcAXOOOibzk5drA21U85z+zjUqR/S4x/S6zxPiepIBoQZbCQgw9ziMGO0mso/udZphogsnJmkEXrZ1Mrzjc3WLNvXND8GW7wLj2cIe0OAWt+CoRWBNwjs/5VEWKwKY1H2JIEVq1c7lX8vdGyRJrlkNKTjn4ghhZNcymbItc8NVRrV9SIfBvW2c7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3MjIPT6wFZ3ovPkOQtSs2UhfMkrUuY6KxV63NismHSw=; b=BH2vPpUVfCOR+PXa87qcSZCKIMNWl/8hW54axZP/fahl+ESGtqu5f8ZP4yRLeI657hjy1c2Pm7BekRIy5a6EsJBnXPfDtxZr4FArN1/Pi5IKVO0KENjjU3OEW2WfPkJB6lFon93vB+CcKVuVvCVHR1mm9E0xFLvfmhL15pwBVGAPDfurS5pCbVjcLOapTxFn5CQuTW82R2g13MVljULMSHJ1m1gDn7Bb1hG9kwSttwJOJNj9lVUDfoC1EC3V6d9yPgj5YBWJtcp0IyJnoTMw/b6pDvIqo5FV1eohT+03UqdGc+cjTMykAula2AW13WyuVAPe4bwnGZb2IBUs8j0x1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MWHPR12MB1501.namprd12.prod.outlook.com (2603:10b6:301:f::18) by MWHPR1201MB0253.namprd12.prod.outlook.com (2603:10b6:301:52::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.22; Sun, 22 Nov 2020 08:44:02 +0000 Received: from MWHPR12MB1501.namprd12.prod.outlook.com ([fe80::ec4d:f17d:402c:78b4]) by MWHPR12MB1501.namprd12.prod.outlook.com ([fe80::ec4d:f17d:402c:78b4%6]) with mapi id 15.20.3589.022; Sun, 22 Nov 2020 08:44:02 +0000 From: Slava Ovsiienko To: Alexander Kozyrev , "dev@dpdk.org" CC: Raslan Darawsheh , Matan Azrad Thread-Topic: [PATCH] net/mlx5: fix mbufs overflow in vectorized MPRQ Thread-Index: AQHWv7hoV123RN3qiE2XDNQ98Ay7P6nT16Nw Date: Sun, 22 Nov 2020 08:44:01 +0000 Message-ID: References: <20201121034239.13404-1-akozyrev@nvidia.com> In-Reply-To: <20201121034239.13404-1-akozyrev@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.163.75.192] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 48f6b45e-2dad-4824-7ddb-08d88ec2c34e x-ms-traffictypediagnostic: MWHPR1201MB0253: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2733; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xHmI/xQmimERsrKnDQzfkPqtyFdHndEs+NuMoD2ZDDmsLH0ny+DjMajCNCz1GrmM5+8yzk1JkDT22Hv9DZyWX1cmg+8pLU+COC/qBJxpdrif4VStvQEpeb22DCxB1WOpRmn9aFDA3OLuSk5Sex6qN7WKrkZlUaMdL65SoMuOuLJnBQGkrInD8pjbnS7nrAoTZ0BqR7R0yLkl2IoYy4VaJ3xLJG2wvKGJCS53KeLQVK2UwcMWPOr6LKvsdpCnHLqw2a4UU2bb6BxNr+NxRhphEsHyxnx77UsXoirrBAinMfGiOjPc2mTEiIs2lrdHwjRh2XR01GufVfJVlH9zvUHUTw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR12MB1501.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39850400004)(396003)(366004)(346002)(376002)(136003)(71200400001)(52536014)(5660300002)(76116006)(4744005)(66556008)(26005)(66946007)(64756008)(316002)(66446008)(33656002)(66476007)(54906003)(186003)(110136005)(83380400001)(86362001)(2906002)(4326008)(478600001)(55236004)(6506007)(53546011)(7696005)(55016002)(9686003)(8676002)(8936002)(107886003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: PvvVKho9G30QOlzP/k7p9JBkinM/zBJSXlnz7kSzVCDbeAF97QNKfcSQOO4I2ESrca+yAQELDLiH3xnpJbIn7Q7wO8RS/qW0/0yXkdrESI3gGamb9XDtC3Mntb8Df8Wk7DEbaii25QzcfYw9K9bV7dDs38gel5yEMaefz4EJLhVTwQ5nQtT11yHRKyJK56us2uoeypTlQnEN5PuAG2dk/b7jhPRgJcv6JtT1mIxLA4f9dsWVZxeIYrul18hJRSsDxVMNg4L7yijJJOooeVsUNPWXiPkSFUVcy0F3ixyumRHJu7FdjrmRyEuWIPkEBjUjgehVt3ke6m5jlS7oFh11Rqg15vFnyfbmo02moRE6HglRpHXZxWpShlqZWvmduR7ID6Ng04jFMrWyu6uUtUhCyB1kIjJ2KKIIO7VoCEcIq76qApXyCBRUxB9KywbvzqdV/9vjLaJq+vq+1CKlDe8CcwxhN0VXWqkZT6IN7XLC8VumWQWGsf4sfShnu3s1UoDP4GvolydvUyIFe/S6SO2JEWW/FHu7xC6CgNoSxT9LNYXYVSspu2JmV1milYPCpPiv5qV0U3ul10VraEKM4KawvCeKayCaRmgAzPQSw/K/h45E8yM8Cf7xtQeFPmF1+8t3Eh2hgcUFgf/LNNMGdw7Ebw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR12MB1501.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 48f6b45e-2dad-4824-7ddb-08d88ec2c34e X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2020 08:44:01.9138 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: E1ahQC2PmkMKoFksy91PWlg8jodYBQTPprfaGpcbQ9FuFYbryks8SGvoEaNcFvgZiw0/Fu6fEBQm7Ew0HuUTUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1201MB0253 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1606034647; bh=3MjIPT6wFZ3ovPkOQtSs2UhfMkrUuY6KxV63NismHSw=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=HrkTSKhDN2VErpy82LcxZl7epvI4M1Tmrtizg27FJZb6R52VF5yczFOcne/PFp7dF 4hm96JEK/oT1bYmDovnzUoeGtQgPC6Ar3qSXLwT7EBD2O2kcS3P5Hq1rmYaQg8Vttf DZRKrNYH4i+v/R/edEOgxwquOMGs9698hUq+5TFz8Ljx8dVnSEs11EOPBlhpdhkkgM eNGo6HCLQ2/TM9riFNC7nGStrplgITyeF6N5RMi7LqThhyByIbEOetuO5vD+E3zXYN 4w6GyMb38iPzIdXM423dU5GgpydlLkCfs8puFd+Dvxx0ZC9HcjtuI7d6/KVPn3lLCX ukXz2kik7qwUA== Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix mbufs overflow in vectorized MPRQ X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Alexander Kozyrev > Sent: Saturday, November 21, 2020 5:43 > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Slava Ovsiienko > ; Matan Azrad > Subject: [PATCH] net/mlx5: fix mbufs overflow in vectorized MPRQ >=20 > Changing the allocation scheme to improve mbufs locality caused mbufs > overrun in some cases. Revert the previous replenish logic back. > Calculate a number of unused mbufs and replenish max this number of mbufs= . >=20 > Mark the last 4 mbufs as fake mbufs to prevent overflowing into consumed > mbufs in the future. Keep the consumed index and the produced index 4 > mbufs apart for this purpose. >=20 > Replenish some mbufs only in case the consumed index is within the replen= ish > threshold of the produced index in order to retain the cache locality for= the > vectorized MPRQ routine. >=20 > Fixes: 5c68764377 ("net/mlx5: improve vectorized MPRQ descriptors localit= y") >=20 > Signed-off-by: Alexander Kozyrev Acked-by: Viacheslav Ovsiienko