From: Slava Ovsiienko <viacheslavo@nvidia.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Raslan Darawsheh <rasland@nvidia.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
Matan Azrad <matan@nvidia.com>,
Alexander Kozyrev <akozyrev@nvidia.com>,
Ori Kam <orika@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH v4 0/6] net/mlx5: add Rx buffer split support
Date: Mon, 26 Oct 2020 17:38:52 +0000 [thread overview]
Message-ID: <MWHPR12MB1501FE733D726FBF65A7DF51DF190@MWHPR12MB1501.namprd12.prod.outlook.com> (raw)
In-Reply-To: <3e0a7114-87d1-99fc-f8b6-6a94e339f4e3@intel.com>
Hi, Ferruh
PSB
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Monday, October 26, 2020 19:04
> To: Raslan Darawsheh <rasland@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; dev@dpdk.org
> Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; Matan Azrad
> <matan@nvidia.com>; Alexander Kozyrev <akozyrev@nvidia.com>; Ori Kam
> <orika@nvidia.com>
> Subject: Re: [dpdk-dev] [PATCH v4 0/6] net/mlx5: add Rx buffer split support
>
> On 10/26/2020 3:25 PM, Raslan Darawsheh wrote:
> > Hi,
> >
> >> -----Original Message-----
> >> From: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> >> Sent: Monday, October 26, 2020 1:55 PM
> >> To: dev@dpdk.org
> >> Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; Matan Azrad
> >> <matan@nvidia.com>; Alexander Kozyrev <akozyrev@nvidia.com>; Raslan
> >> Darawsheh <rasland@nvidia.com>; Ori Kam <orika@nvidia.com>
> >> Subject: [PATCH v4 0/6] net/mlx5: add Rx buffer split support
> >>
> >> This patch adds to PMD the functionality for the receiving buffer
> >> split feasture [1]
> >>
> >> [1]
> >> https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatc
> >> h
> es.dpdk.org%2Fpatch%2F81154%2F&data=02%7C01%7Crasland%40nvid
> >>
> ia.com%7Ccf4913c6b58346b50b1b08d879a60608%7C43083d15727340c1b7db
> 3
> >>
> 9efd9ccc17a%7C0%7C0%7C637393101256743078&sdata=fyiL3PS8r8wv8u
> >> pyOYUtITkVqId9DZsF9LvSJQL9fdM%3D&reserved=0
> >>
> >> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> >>
> >> ---
> >> v1:
> >> https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatc
> >> h
> es.dpdk.org%2Fpatch%2F81808%2F&data=02%7C01%7Crasland%40nvid
> >>
> ia.com%7Ccf4913c6b58346b50b1b08d879a60608%7C43083d15727340c1b7db
> 3
> >>
> 9efd9ccc17a%7C0%7C0%7C637393101256743078&sdata=NPBFlGmVN6bi
> >> GUpzHC%2FrOVmdMoK2fkYRC0%2FDB%2BNlNno%3D&reserved=0
> >>
> >> v2:
> >> https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatc
> >> h
> es.dpdk.org%2Fpatch%2F81923%2F&data=02%7C01%7Crasland%40nvid
> >>
> ia.com%7Ccf4913c6b58346b50b1b08d879a60608%7C43083d15727340c1b7db
> 3
> >>
> 9efd9ccc17a%7C0%7C0%7C637393101256743078&sdata=YwYjMz3jrSYU6
> >> RBgwl0DmQfmjwwymNJTFjMdx0rsm2U%3D&reserved=0
> >> - typos
> >> - documentation is updated
> >>
> >> v3:
> >> https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatc
> >> h
> es.dpdk.org%2Fpatch%2F82177%2F&data=02%7C01%7Crasland%40nvid
> >>
> ia.com%7Ccf4913c6b58346b50b1b08d879a60608%7C43083d15727340c1b7db
> 3
> >>
> 9efd9ccc17a%7C0%7C0%7C637393101256743078&sdata=HVvLbWS0sJxu
> >> v%2Bc%2BKIMqllBq3edC4v0GD%2BtrwS7%2FsRo%3D&reserved=0
> >> - extra parameter checks in PMD rx_queue_setup removed
> >> - minor optimizations in PMD
> >>
> >> v4: - rebasing
> >>
> >> Viacheslav Ovsiienko (6):
> >> net/mlx5: add extended Rx queue setup routine
> >> net/mlx5: configure Rx queue to support split
> >> net/mlx5: register multiple pool for Rx queue
> >> net/mlx5: update Rx datapath to support split
> >> net/mlx5: report Rx segmentation capabilities
> >> doc: add buffer split feature limitation to mlx5 guide
> >>
> >> doc/guides/nics/mlx5.rst | 6 +-
> >> drivers/net/mlx5/mlx5.h | 3 +
> >> drivers/net/mlx5/mlx5_ethdev.c | 4 ++
> >> drivers/net/mlx5/mlx5_mr.c | 3 +
> >> drivers/net/mlx5/mlx5_rxq.c | 136
> >> +++++++++++++++++++++++++++++++++++-----
> >> drivers/net/mlx5/mlx5_rxtx.c | 3 +-
> >> drivers/net/mlx5/mlx5_rxtx.h | 13 +++-
> >> drivers/net/mlx5/mlx5_trigger.c | 20 +++---
> >> 8 files changed, 160 insertions(+), 28 deletions(-)
> >>
> >> --
> >> 1.8.3.1
> >
> > Series applied to next-net-mlx,
> >
>
> The feature was references with different name in each commit, I tried to unify
> it as "Rx buffer split" in next-net.
> Can you please double check the updated commit log/titles?
>> doc: add Rx buffer split limitation to mlx5 guide
>> net/mlx5: report Rx buffer split capabilities
OK about above.
>> net/mlx5: support Rx buffer split
It would be better: "net/mlx5: support Rx buffer split on datapath
>> net/mlx5: register multiple pool for Rx queue
OK
>> net/mlx5: configure Rx buffer split
It would be better: "net/mlx5: configure Rx queue for buffer split"
>> net/mlx5: receive Rx buffer split description
IMO, it would be better: "net/mlx5: handle Rx buffer split description"
or
"net/mlx5: support Rx buffer split description"
Could you, please, also squash the hotfix:
http://patches.dpdk.org/patch/82218/
Thanks in advance,
Slava
next prev parent reply other threads:[~2020-10-26 17:39 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 15:42 [dpdk-dev] [PATCH 0/5] " Viacheslav Ovsiienko
2020-10-22 15:42 ` [dpdk-dev] [PATCH 1/5] net/mlx5: add extended Rx queue setup routine Viacheslav Ovsiienko
2020-10-23 9:46 ` [dpdk-dev] [PATCH v2 0/5] net/mlx5: add Rx buffer split support Viacheslav Ovsiienko
2020-10-23 9:46 ` [dpdk-dev] [PATCH v2 1/5] net/mlx5: configure Rx queue to support split Viacheslav Ovsiienko
2020-10-23 9:46 ` [dpdk-dev] [PATCH v2 2/5] net/mlx5: register multiple pool for Rx queue Viacheslav Ovsiienko
2020-10-23 9:46 ` [dpdk-dev] [PATCH v2 3/5] net/mlx5: update Rx datapath to support split Viacheslav Ovsiienko
2020-10-23 9:46 ` [dpdk-dev] [PATCH v2 4/5] net/mlx5: report Rx segmentation capabilities Viacheslav Ovsiienko
2020-10-23 9:46 ` [dpdk-dev] [PATCH v2 5/5] doc: add buffer split feature limitation to mlx5 guide Viacheslav Ovsiienko
2020-10-26 10:11 ` [dpdk-dev] [PATCH v3 0/6] net/mlx5: add Rx buffer split support Viacheslav Ovsiienko
2020-10-26 10:11 ` [dpdk-dev] [PATCH v3 1/6] net/mlx5: add extended Rx queue setup routine Viacheslav Ovsiienko
2020-10-26 10:11 ` [dpdk-dev] [PATCH v3 2/6] net/mlx5: configure Rx queue to support split Viacheslav Ovsiienko
2020-10-26 10:11 ` [dpdk-dev] [PATCH v3 3/6] net/mlx5: register multiple pool for Rx queue Viacheslav Ovsiienko
2020-10-26 10:11 ` [dpdk-dev] [PATCH v3 4/6] net/mlx5: update Rx datapath to support split Viacheslav Ovsiienko
2020-10-26 10:11 ` [dpdk-dev] [PATCH v3 5/6] net/mlx5: report Rx segmentation capabilities Viacheslav Ovsiienko
2020-10-26 10:11 ` [dpdk-dev] [PATCH v3 6/6] doc: add buffer split feature limitation to mlx5 guide Viacheslav Ovsiienko
2020-10-26 11:54 ` [dpdk-dev] [PATCH v4 0/6] net/mlx5: add Rx buffer split support Viacheslav Ovsiienko
2020-10-26 11:55 ` [dpdk-dev] [PATCH v4 1/6] net/mlx5: add extended Rx queue setup routine Viacheslav Ovsiienko
2020-10-26 11:55 ` [dpdk-dev] [PATCH v4 2/6] net/mlx5: configure Rx queue to support split Viacheslav Ovsiienko
2020-10-26 11:55 ` [dpdk-dev] [PATCH v4 3/6] net/mlx5: register multiple pool for Rx queue Viacheslav Ovsiienko
2020-10-26 11:55 ` [dpdk-dev] [PATCH v4 4/6] net/mlx5: update Rx datapath to support split Viacheslav Ovsiienko
2020-10-26 11:55 ` [dpdk-dev] [PATCH v4 5/6] net/mlx5: report Rx segmentation capabilities Viacheslav Ovsiienko
2020-10-26 11:55 ` [dpdk-dev] [PATCH v4 6/6] doc: add buffer split feature limitation to mlx5 guide Viacheslav Ovsiienko
2020-10-26 15:25 ` [dpdk-dev] [PATCH v4 0/6] net/mlx5: add Rx buffer split support Raslan Darawsheh
2020-10-26 17:04 ` Ferruh Yigit
2020-10-26 17:38 ` Slava Ovsiienko [this message]
2020-10-27 11:05 ` Ferruh Yigit
2020-10-27 19:05 ` Slava Ovsiienko
2020-10-29 13:09 ` Ferruh Yigit
2020-10-29 14:21 ` Slava Ovsiienko
2020-10-26 17:17 ` [dpdk-dev] [PATCH] net/mlx5: fix Rx queue initialization for scattered segment Viacheslav Ovsiienko
2020-10-26 18:07 ` Raslan Darawsheh
2020-10-22 15:42 ` [dpdk-dev] [PATCH 2/5] net/mlx5: configure Rx queue to support split Viacheslav Ovsiienko
2020-10-22 15:42 ` [dpdk-dev] [PATCH 3/5] net/mlx5: register multiple pool for Rx queue Viacheslav Ovsiienko
2020-10-22 15:42 ` [dpdk-dev] [PATCH 4/5] net/mlx5: update Rx datapath to support split Viacheslav Ovsiienko
2020-10-22 15:42 ` [dpdk-dev] [PATCH 5/5] net/mlx5: report Rx segmentation capabilies Viacheslav Ovsiienko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR12MB1501FE733D726FBF65A7DF51DF190@MWHPR12MB1501.namprd12.prod.outlook.com \
--to=viacheslavo@nvidia.com \
--cc=akozyrev@nvidia.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).