From: Suanming Mou <suanmingm@nvidia.com>
To: Junyu Jiang <junyux.jiang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Beilei Xing <beilei.xing@intel.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix flow flush with invalid port
Date: Wed, 14 Oct 2020 10:16:21 +0000 [thread overview]
Message-ID: <MWHPR12MB1743DE99FD5A2997200B609DC1050@MWHPR12MB1743.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20201014083005.64428-1-junyux.jiang@intel.com>
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Junyu Jiang
> Sent: Wednesday, October 14, 2020 4:30 PM
> To: dev@dpdk.org
> Cc: Beilei Xing <beilei.xing@intel.com>; Wenzhuo Lu <wenzhuo.lu@intel.com>;
> Junyu Jiang <junyux.jiang@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] app/testpmd: fix flow flush with invalid port
>
> There is no error info displayed when running flow flush command with invalid
> port. This patch fixed the issue.
>
> Fixes: 2a449871a12d ("app/testpmd: align behaviour of multi-port detach")
> Cc: stable@dpdk.org
>
> Signed-off-by: Junyu Jiang <junyux.jiang@intel.com>
> ---
> app/test-pmd/config.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> fe31a9d52..cc4527386 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -1775,16 +1775,17 @@ port_flow_flush(portid_t port_id)
> struct rte_port *port = &ports[port_id];
> int ret = 0;
>
> + if (port_id_is_invalid(port_id, ENABLED_WARN) ||
> + port_id == (portid_t)RTE_PORT_ALL)
> + return -EINVAL;
> +
Also better to move the port initialize after this check to make the code clean?
Reviewed-by: Suanming Mou <suanmingm@nvidia.com>
> if (port->flow_list == NULL)
> return ret;
>
> /* Poisoning to make sure PMDs update it in case of error. */
> memset(&error, 0x44, sizeof(error));
> if (rte_flow_flush(port_id, &error)) {
> - ret = port_flow_complain(&error);
> - if (port_id_is_invalid(port_id, DISABLED_WARN) ||
> - port_id == (portid_t)RTE_PORT_ALL)
> - return ret;
> + port_flow_complain(&error);
> }
>
> while (port->flow_list) {
> --
> 2.17.1
next prev parent reply other threads:[~2020-10-14 10:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 8:30 Junyu Jiang
2020-10-14 10:16 ` Suanming Mou [this message]
2020-10-15 22:14 ` Ferruh Yigit
2020-10-16 1:27 ` Jiang, JunyuX
2020-10-16 2:03 ` [dpdk-dev] [PATCH v2] " Junyu Jiang
2020-10-16 13:04 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR12MB1743DE99FD5A2997200B609DC1050@MWHPR12MB1743.namprd12.prod.outlook.com \
--to=suanmingm@nvidia.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=junyux.jiang@intel.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).