From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4647A056D; Tue, 3 Mar 2020 04:11:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0319B1BFF7; Tue, 3 Mar 2020 04:11:03 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id AF1A11BFF4; Tue, 3 Mar 2020 04:11:01 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0233ARLJ014461; Mon, 2 Mar 2020 19:11:01 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=gbMEZgq4SfKxwTFV7Hxe6t7iCXPmzaoU9GzEqnukkcQ=; b=XOT2n0QOf1DVRd3URqMXgnfCd5Sl4HqolCT4TAv2reFMtwxHnAXNsb/zIHvQCZQXMqtM RwdQfxRpnR+u+QUxh9guf+6kMuJX3tqzpH0mg4RjdlZk+GA4GxP7lcOuybRUprAKVtOM yF5Tb8RdI34qHGWyG9oxSkgADAOxe2O2rxkKu4l1ExCLtaNsQ1OU3r+IXRrYYFrvthmE wYSKhh2gU149LUxsG6bgGAxDV5ngPlD/3upnWuXpN6PhhMeQL4mhRRS+T7Mb6MRrKPLV IfPmXUQ79etNcJeFECASqDi6RqbA8SCIP3kTDUNtPZKjyFGa5gsmme5SGjv5xRu76Ex9 1Q== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 2yfrbu268d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 02 Mar 2020 19:11:00 -0800 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 2 Mar 2020 19:10:58 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 2 Mar 2020 19:10:58 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oWv2Up/JSFb5aGoz7HGOPNckdPUbDtpZh7ZaIcJLwOQWdkK+b/Ce9tVssyPcEKxMqMcmcSb/9Uaghh9f+Wo0tcGCZxcjOaFZvi9tE9Eo2T3npB62bHdb1D2YKtmFvyaEn71KVrMkC6TAYqC5hOAh4lJiv5Vga/rt1Ba3tk7eowA9TvE1ufL3HHI4POkiwYCNHBO+imL4pFeuJzL17tQzpoLzYuF8XGLF52jt+q2aytExqOEozM8ndFha5RvbBYHCTxa1Yd3lj3efahKhnBr6VVmDn9eWKQi1O4Iw+kvIOSuu4mDO85EIToGfGE9FsjbE3g8YyqrlA9EPJPwtPLDmYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gbMEZgq4SfKxwTFV7Hxe6t7iCXPmzaoU9GzEqnukkcQ=; b=MfGKpQIsLhMtbYycUVJrrqLJA33mm67AP4wdQ8cF25vd1tvskK5JtEAAlbBMjhNSUXWJsUabeZrrf7rBVkSpvXfLZel0nm4jNx9oUGbdAD59LDXAZ5i64eO2ZCMnLfWTRdjh+5Ue5F3AuNQptswEjAsWEz9dZU8L1qxvOuCt8x3AxNcFS1LWTUuN3KIebmedrnoU8pDo7b099FEzJciHk7u76yXz6weAWSnJ5NQqI3hucaRPMajawzNSeB/36GN2iNC+W7ezbZpoMty5wYiWeqYMsMuFXueVPA4dci/fYgxrCR2YnZX7RG/KJ2xCz4gQbvC7vm0eDXyB/2dsQhoR7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gbMEZgq4SfKxwTFV7Hxe6t7iCXPmzaoU9GzEqnukkcQ=; b=M6IkXzkJdC2bpfbjBks9+guYY//Cfew+uN9feSqJz9NtWr4fohtaKx+UyJm5dvwoJpqGh1kd2GtZxZq4TcHMT+SbnZ+FbpOhv5gsvGBFzWpO6sSw54/qJfZ7H7LZ1GoF0GwefcOR0CtxKpBjOmG4dG34hoo/TSe0BN6NIvid8Us= Received: from MWHPR1801MB1934.namprd18.prod.outlook.com (2603:10b6:301:64::34) by MWHPR1801MB2078.namprd18.prod.outlook.com (2603:10b6:301:62::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.19; Tue, 3 Mar 2020 03:10:57 +0000 Received: from MWHPR1801MB1934.namprd18.prod.outlook.com ([fe80::55a:3c86:4065:da79]) by MWHPR1801MB1934.namprd18.prod.outlook.com ([fe80::55a:3c86:4065:da79%3]) with mapi id 15.20.2772.019; Tue, 3 Mar 2020 03:10:56 +0000 From: Amit Gupta To: Bruce Richardson CC: Harman Kalra , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [EXT] Re: [dpdk-dev] [PATCH v2 1/1] net/octeontx: fix meson build for disabled octeontx drivers Thread-Index: AQHV8FxVG/y/qXHeZkSxvje0XidVBqg1INGAgAEQmEA= Date: Tue, 3 Mar 2020 03:10:56 +0000 Message-ID: References: <1581925669-15294-1-git-send-email-agupta3@marvell.com> <1583130716-28360-1-git-send-email-agupta3@marvell.com> <20200302105313.GA1603@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20200302105313.GA1603@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c2d55b6d-d5d5-414d-68a0-08d7bf207df5 x-ms-traffictypediagnostic: MWHPR1801MB2078: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4303; x-forefront-prvs: 03319F6FEF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(376002)(39860400002)(346002)(136003)(396003)(189003)(199004)(4326008)(54906003)(316002)(478600001)(9686003)(53546011)(7696005)(55016002)(6506007)(66946007)(8676002)(8936002)(71200400001)(64756008)(66446008)(81166006)(66556008)(81156014)(66476007)(33656002)(5660300002)(86362001)(6916009)(76116006)(52536014)(2906002)(26005)(186003)(55236004); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR1801MB2078; H:MWHPR1801MB1934.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xHXJSkhWFPfOBDZj0DrBk7fUVYZtj62gz6W8uWnds34cGoWVi15souicRGUrV1zbl9ffmDMCDJtbfk08sF7CuDevlLvZqvE5mU1f9KNgGyDUT6jtl0iY/PTkmKMymTK36dsB190EcnRH8aeBPDcBJv/5fkpEzKublQXFNxDRusvmPv8ccCL+Bu1xUT8fyS5ms605A3k5EUcnf6RvcVp+J+7aoKnL+AxdPOzDl6k+1qjqXehI8WDeNzXZA89Exu9fAvHdEyHl1cwf4eHuuDZ/l1xow8l5nPGHGgw/844ST8lzezDxE70QZBRmUKl4/UOMbYRV8sWK4fpXZd5OZWJuzdKP0g40M7l99X+DElSXfVo0qlGjzKjXetJwrj+OcmoY9SK0VW0s9//mr1a7lpO3N9cGpn1UpqWura+v4fG3pCjNIbjHYicBAafyvaTuc6bG x-ms-exchange-antispam-messagedata: 5Y8OBdsuB8CykyIJabkAHGpiX4Vq9sRtgi7BI5W8fvlMHOGLkHD+oukuwZH08S+qBRZJxgldrJExOUWnAZnYzwEWlYSPWWGmDvWQwTrL327RVy6gE7Uo+3s8DrJxWVjNWzmZg96saHJrZyge4u24cQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: c2d55b6d-d5d5-414d-68a0-08d7bf207df5 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2020 03:10:56.6919 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OvxXoB8s1t1N6udtQc+NiWH7Q7M1P/OiZoepMUte850BfWO0qPFtHWHOp/Lpzh6XERJLii1CWPAcpL76Ut0Mkw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1801MB2078 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-03-02_09:2020-03-02, 2020-03-02 signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/1] net/octeontx: fix meson build for disabled octeontx drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" test_dep_obj is being formatted as string object, so can't be used as stati= c obj.. Amit > -----Original Message----- > From: Bruce Richardson > Sent: Monday, March 2, 2020 4:23 PM > To: Amit Gupta > Cc: Harman Kalra ; dev@dpdk.org; stable@dpdk.org > Subject: [EXT] Re: [dpdk-dev] [PATCH v2 1/1] net/octeontx: fix meson buil= d > for disabled octeontx drivers >=20 > External Email >=20 > ---------------------------------------------------------------------- > On Mon, Mar 02, 2020 at 12:01:55PM +0530, agupta3@marvell.com wrote: > > From: Amit Gupta > > > > Add a additional condition to check if all required internal > > dependencies are met before building octeontx drivers using meson. > > > > Bugzilla ID: 387 > > > > Fixes: 7f615033d64f ("drivers/net: build Cavium NIC PMDs with meson") > > > > Signed-off-by: Amit Gupta > > --- > > v2: > > - rebased to v20.02 > > - upstream comments incorporated. > > > > drivers/net/octeontx/base/meson.build | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/octeontx/base/meson.build > > b/drivers/net/octeontx/base/meson.build > > index a06a2c8..035aeda 100644 > > --- a/drivers/net/octeontx/base/meson.build > > +++ b/drivers/net/octeontx/base/meson.build > > @@ -10,7 +10,11 @@ sources =3D [ > > depends =3D ['ethdev', 'mempool_octeontx'] static_objs =3D [] foreac= h > > d: depends > > - static_objs +=3D [get_variable('static_rte_' + d)] > > + test_dep_obj =3D '@0@'.format(get_variable('static_rte_' + d, '')) > > + if test_dep_obj =3D=3D '' > > + subdir_done() > > + endif > > + static_objs +=3D get_variable('static_rte_' + d) > > endforeach >=20 > very minor nit - you can use "test_dep_obj" here rather than calling > get_variable twice. >=20 > /Bruce