From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04018A04F1; Mon, 6 Jan 2020 16:11:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6FA521D6B9; Mon, 6 Jan 2020 16:11:49 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 642DF1D162; Mon, 6 Jan 2020 14:44:38 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 006DhXOt021228; Mon, 6 Jan 2020 05:44:37 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=H1zb7TLlQfO2jqOZkfUTeEptX5HOMouPaoPOXH44Uio=; b=WPjUOuFZDzgnHoegstqaByIlwUBkc60zaZMJDpNQRdZlQJVF2qsl8deO1PUUN52iTh20 z3looqZvLbGR9ejmI11zgN/hyZn6be3Mrhg1SigdiBOxt/+16t5pyj2nO/5HzRPJ2py+ G/POEHxNMvacyg0UsGPZ716UxLc6zZZv2YDWGvGVSlRrh6B5+EaVG/fbMlstxsub/XlY bYNjgzEEyPHHnStJkFKkyzwz+IxDZAAYsjN7OM4mq+RWMTdYewHsZYc8BGL1KhpFiLF8 wnUOa6YJn7T5ieIdKuTeArvTNZAZ1pbBL+RQsTRYr/B4x3HA0cxVsTUnXVYMwyazbulr yw== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 2xarxv5y6e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 06 Jan 2020 05:44:37 -0800 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 6 Jan 2020 05:44:36 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 6 Jan 2020 05:44:36 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e8EBiE+YUaencmnElWkV0IUoQTgiTnTGmBqH5gCqei6QVPpdk2RIKxEPS1wUjD1Oi4dA+J1vL0lURlEC9dOQhgbnk/TpDShZLXQfGyw8rz76Tnc9XDYqlfG9E09IcECKVhU513oBA5WloTdjDDnXaQAnK8nOf04MJRNV0Zx6A3V4eZ3DyXPf5xJNi2iDt6rlLZEYbL/1V8NgpaLj4fMHhG5fHAiJAmqviwhozSpZewl7UYQcBCLdviXwY9TnhStA2ma+ckwdNJCtkiS9dpv/c3mFEFKVn5szMB8yV3BnB+2LPl+cupzHJufr6dTMCgQD1tdm63mVXreuQ7BJcCDIVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H1zb7TLlQfO2jqOZkfUTeEptX5HOMouPaoPOXH44Uio=; b=og8mghsYFucmDb+QjRC0wRYBxu3fiKWCraIqsSxM0PPRhsK96gg6ChqO7Yq+9tqQ/PR/yZwPhuxzdqX40twgoaPaSxLXivg4HVOGvn6jEWjnDFTGTHhzmAp1RnPSvkKya/I79u+8ncOuU8Ktdx6AEGzCbeuaCn/wi2h93xoA8ppK7r8xjbQvYtuK8kyN7K9kTGDQAcGZJm2h+1ViplwWqFMWCUX85Qed8zGXK/yT5JjoBbMFK+ry097PqBVNMPpOFWc1/79f9eezxNr3JLSOju30o8XbH1lvQAHp6b4q1IZru75enrOkxvDk5lISpFwQW6hlh9OpW77Hx41fEqs0Vw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H1zb7TLlQfO2jqOZkfUTeEptX5HOMouPaoPOXH44Uio=; b=rmEYu+ZGBrJyeu5QW1Uz/fyc6cjwrqGYZ+TOPte/au3VHfJHXel3d7WAjSbKz/LQRp979J6FJGpwog4iNyCJn0RlTd+j7zTqZY9u7609QW2a80Vv1bx4Oq/LNvw1JKQ1/zS9bYwjFQDgdO7ivBWICzhmu4M3mZMX4jTIJILWxVQ= Received: from MWHPR1801MB2077.namprd18.prod.outlook.com (10.164.205.141) by MWHPR1801MB1823.namprd18.prod.outlook.com (10.164.203.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2602.15; Mon, 6 Jan 2020 13:44:34 +0000 Received: from MWHPR1801MB2077.namprd18.prod.outlook.com ([fe80::e915:3526:7ea0:26a1]) by MWHPR1801MB2077.namprd18.prod.outlook.com ([fe80::e915:3526:7ea0:26a1%3]) with mapi id 15.20.2602.015; Mon, 6 Jan 2020 13:44:34 +0000 From: Archana Muniganti To: Akhil Goyal , "marko.kovacevic@intel.com" , "roy.fan.zhang@intel.com" CC: Sucharitha Sarananaga , Anoob Joseph , Abed Mohammad Kamaluddin , Jerin Jacob Kollanukkaran , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] examples/fips_validation: fix parsing of cipher length for AES-GCM Thread-Index: AQHVxHSSF2IH6zTxjEycThb8AyY7kqfdYTwAgABCHSA= Date: Mon, 6 Jan 2020 13:44:33 +0000 Message-ID: References: <1578303191-24846-1-git-send-email-marchana@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9d19b01c-ce05-468d-5e09-08d792ae906c x-ms-traffictypediagnostic: MWHPR1801MB1823: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2958; x-forefront-prvs: 0274272F87 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(136003)(396003)(376002)(346002)(39860400002)(189003)(199004)(13464003)(86362001)(7696005)(6506007)(53546011)(8676002)(81156014)(55236004)(26005)(186003)(5660300002)(71200400001)(4326008)(52536014)(478600001)(33656002)(8936002)(2906002)(110136005)(54906003)(81166006)(9686003)(55016002)(76116006)(66446008)(64756008)(66556008)(66476007)(66946007)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR1801MB1823; H:MWHPR1801MB2077.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jchyYbeNw0+s5L9WlzbkCFzjcmBghQRUJpuQRX6/wko0hrIwkVy82jvjLeXMO1ZwGgSIsyVjQMlNH59E24GdLRpnTqvgZrlgO1Y05iQ4IxjbouYrh9k8TlM8Y8P8gYNliJnS0p32XWyHHm+OOog2KJBVyE2qSTCaIZjc7pLDMD2ytemwScz7KX08oV2fXROctLuXp6DabHTCUnMV7DuBqYXkZ7tdfskDu5oMk9xYBE264rJwgPCYYFjodbKnGq6Awg//w0MEwtHBdHTyTiGNNHTBN2GQyA1/wFFkjikf+WVEyF1qdEL6Bum6HFo4wHfMp0Ip9Slw7z4NR6y4L8Y07TSMY50KLjQXwlHWYo1y2Xvyv0ecqu0Pbp51KNeUwEgQuoawY27NV0cXE0rL52ZhE524YWsdRscPDo+csvLC58bkB+OE9YENr6ZBAI46ENxn/KtNIAvq4jD0ULgHwRnbPddGAAgHK+p/+1tVgZwR9j32n9lEJOWlwe+vrajWLGOP Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 9d19b01c-ce05-468d-5e09-08d792ae906c X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2020 13:44:33.9791 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EGR68tVkDaC5Ytj/v0VLhyDlroP4sDaR1oD5tU5pYK1zxBo/tk3cFGRrghq42mDEedqDD3Mh18AcSv8e6SaTMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1801MB1823 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2020-01-06_04:2020-01-06,2020-01-06 signatures=0 X-Mailman-Approved-At: Mon, 06 Jan 2020 16:11:46 +0100 Subject: Re: [dpdk-dev] [PATCH] examples/fips_validation: fix parsing of cipher length for AES-GCM X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, Please see inline. Thanks, Archana > -----Original Message----- > From: Akhil Goyal > Sent: Monday, January 6, 2020 3:09 PM > To: Archana Muniganti ; > marko.kovacevic@intel.com; roy.fan.zhang@intel.com > Cc: Sucharitha Sarananaga ; Anoob Joseph > ; Abed Mohammad Kamaluddin > ; Jerin Jacob Kollanukkaran > ; dev@dpdk.org; stable@dpdk.org > Subject: [EXT] RE: [PATCH] examples/fips_validation: fix parsing of ciphe= r > length for AES-GCM >=20 > External Email >=20 > ---------------------------------------------------------------------- > > From: Sucharitha Sarananaga > > > > Cipher length need to be updated in case of AES-GCM decryption. > > > > Fixes: 4aaad2995e13 ("examples/fips_validation: support GCM parsing") > > > > Signed-off-by: Archana Muniganti > > Signed-off-by: Sucharitha Sarananaga > > --- > > examples/fips_validation/fips_validation_gcm.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/examples/fips_validation/fips_validation_gcm.c > > b/examples/fips_validation/fips_validation_gcm.c > > index ea48ddf..f295025 100644 > > --- a/examples/fips_validation/fips_validation_gcm.c > > +++ b/examples/fips_validation/fips_validation_gcm.c > > @@ -19,6 +19,7 @@ > > #define PTLEN_STR "PTlen =3D " > > #define AADLEN_STR "AADlen =3D " > > #define TAGLEN_STR "Taglen =3D " > > +#define CTLEN_STR "PTlen =3D " > Typo. Should be CTlen [Archana] NIST request file for AES-GCM test vectors contains 'PTlen =3D' f= ield. This field holds plain text length when encrypt test vectors are used. And = same field holds cipher text length when decrypt test vectors are used. Hence added a new macro that will be used in AES-GCM 'decryption'