Re: [dpdk-dev] [PATCH] security: allow application to specify UDP ports to PMD

[Tejasree Kondoj <ktejasree@marvell.com>]

Hi Akhil,

Please see inline.

Thanks
Tejasree

> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Tuesday, January 12, 2021 12:50 AM
> To: Tejasree Kondoj <ktejasree@marvell.com>; Radu Nicolau
> <radu.nicolau@intel.com>
> Cc: Narayana Prasad Raju Athreya <pathreya@marvell.com>; Anoob Joseph
> <anoobj@marvell.com>; dev@dpdk.org
> Subject: [EXT] RE: [PATCH] security: allow application to specify UDP ports to
> PMD
> 
> External Email
> 
> ----------------------------------------------------------------------
> Hi Tejasree,
> 
> > > > >
> > > > > I think we should add some usage of these newly added params
> > > > > - either in app/test or in examples/ipsec-secgw
> > > >
> > > > [Tejasree] You mean adding test case in either of the above apps
> > > > or addition of PMD implementation also? Also is the proposal sounds
> fine?
> > > >
> > > I would say both, so that the newly added parameters are tested.
> > > I am ok with the proposal with a minor comment,
> > >
> > > We can have udp_src_port and udp_dst_port directly into
> > > rte_security_ipsec_xform Instead of adding a new struct
> > > rte_security_ipsec_udp_encapsulation.
> >
> > [Tejasree] Okay. We'll defer the patch for now.
> > Will add usage of the params and address the comment later.
> >
> Any updates on this patch.

[Tejasree] Not yet. We'll address it later as it needs internal firmware changes.

>
> Regards,
> Akhil