From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2EE2A0546; Tue, 6 Apr 2021 17:01:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 50A0314118F; Tue, 6 Apr 2021 17:01:31 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id CF014141169 for ; Tue, 6 Apr 2021 17:01:29 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 136F0UPV015128; Tue, 6 Apr 2021 08:01:28 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2168.outbound.protection.outlook.com [104.47.57.168]) by mx0b-0016f401.pphosted.com with ESMTP id 37redma0kq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 06 Apr 2021 08:01:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U24pWCg5kJOjR5oOM4UDx0JH74zMDa8d15H2rmdGD7IDroMlFcHVyINTJc3cRqNEiFRUVJW+ZRC1XRoS/n6dJ3cO54BO7wTo0KfA4Uu01OV1GkD9w85A8pVZkSMxRU8dDDLQJuhu8H39V+YdMsjQAkHsc1Y8ZsArJy0IvOHr5aOCOOauj0TxP5+RbLRkrkXRTVAG0ZYKTY9F0SQm3Jybfc2EZvcCSXKgNmBX8sZ55kr2y8xzqPAH50yvxkCiy5p+Td0IZ6WFCs1yBOL2Lq8Ptolimqz0sFVVvPhUystXAZCTwH/OErOYQVv6NhMEtzrIrjT4244wqggCgL/oeaPhIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Eqm9VfbPxzC3NAYEubDrKh+7Rz9domQug/XnN5c5X5o=; b=VyxFViL3FhP8oWLhT2TW4RSasd8+AFowzgGnI3SU3Y+i5Q28JMMr+xg/33NRurnbGxecd4C2kqM7wArGG+ZlDUig+abWVa4ltzvt7GKxt/d9ALRMD1QLX5AyRaoPH/IoCkHDG42rBV6Ey5CeF7wiXMBYtwz5707xiogmYlTpuRREuOXC0gdhDLHuzbTd0EiY5xw4XoLkWd7j6woIzhtZLUHtr2ec9BeSyRW9266B56HgCtNb5c8X/cwzhG1GAj89TKVpycza5Kzk11WZN0VEzOWYsdZOVH8L1qWXxrISnm+x/tA22FfRVBjTyYeYYd5b4NkDPtP3GjFkmTZMsaDmVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Eqm9VfbPxzC3NAYEubDrKh+7Rz9domQug/XnN5c5X5o=; b=b5Tdb5TxVvCCZlhVp/WhDImP2msmluuDuzLpZsVNND1UOI0gMA3YtBIWPxMesMcxiD8zHrhstACBmFMCmee7N2qYl3O5XcKQqyHAtH939KVZoKG6jJb50ggMjEIsSPO3AmBDrxo8Kav6yGqmHxx+60kt+iduiC0qx7IsrEP2awI= Received: from MWHPR18MB1168.namprd18.prod.outlook.com (2603:10b6:300:a6::12) by MW2PR18MB2124.namprd18.prod.outlook.com (2603:10b6:907:d::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.28; Tue, 6 Apr 2021 15:01:16 +0000 Received: from MWHPR18MB1168.namprd18.prod.outlook.com ([fe80::f493:6155:49bb:4726]) by MWHPR18MB1168.namprd18.prod.outlook.com ([fe80::f493:6155:49bb:4726%8]) with mapi id 15.20.3999.032; Tue, 6 Apr 2021 15:01:16 +0000 From: Anoob Joseph To: "Gujjar, Abhinandan S" CC: "thomas@monjalon.net" , Jerin Jacob Kollanukkaran , "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" , "sachin.saxena@oss.nxp.com" , "matan@nvidia.com" , "Zhang, Roy Fan" , "g.singh@nxp.com" , "Carrillo, Erik G" , "Jayatheerthan, Jay" , Pavan Nikhilesh Bhagavatula , "Van Haaren, Harry" , Akhil Goyal , Shijith Thotton , "dev@dpdk.org" Thread-Topic: [PATCH v4 2/3] event/octeontx2: support crypto adapter forward mode Thread-Index: AQHXJ+H+hkw4NTuGtUG1jMrHyeOgn6qilkuAgAUEGtA= Date: Tue, 6 Apr 2021 15:01:16 +0000 Message-ID: References: <91bf3d89521f46fb714c12d0a7f7eb5c7f7c8e01.1617382596.git.sthotton@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [2409:4073:391:b544:c5b9:566a:8bce:dcfe] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 48ce2a39-c97f-4f3f-349e-08d8f90cd40c x-ms-traffictypediagnostic: MW2PR18MB2124: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: i0tYYRtsdOfJJZPOTh51HcQzGHEdUQ8Hq/Nj/pQ6jmSvJRm7rp6c2wwY7kf9UN/9cSoeQIb3ViQRevwSGno46ELRF+3Vi6FvZ4KGUE3Kw7KDSbC0tNhgxV3NwSmN6EZeY90zvBJB+tAPdL4cPuJEmLuVH6R48fskx5/Axzx1ddJYzfBrliEh8kmdmyZP/woQVRxgsme+NBfMXOMuZq9yuqXE1q+QTCkaa3VZM38vRjE6Va3QQi52s0vPJr8mtMPtZGGXrnH8iFAWUX5MOZjpb9tRzbqQTnK5IxJ+MK/+OPgxYerYgrxkBICCYrdnaDaz0M46ZntJYo7bkkE1Izvyt5j8ck1oWhH2o4i9oEYy1iu1selLXFx2skw/PgNHx9sdUKNxYWCH/oDgZRRUl7ep0v4TqqJ4SgCqpi0YM/lf9f8nfV0s3wxIk9l+Hu2oiudyTkDO7xhV44LQqAUXtjdTaSiBvVN+1FUliMaA43eb+LbzMGDhCaKl2GaS/iGTSwHbM/76Q68yXJg/08rkr0LpeOLBbRQ5sxQpDwoyuujL4T3VYUQLLEWR9N7/HFlshjnaB3xvHdbclNOMDnw5fDdSS8XWXqbSrBEcJAHh8uNXYE5S48k43TMsTrw64fWoFPRbM4j8fn0ygYVOe5Pr9KsTVg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR18MB1168.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(64756008)(2906002)(4326008)(66476007)(76116006)(66556008)(186003)(5660300002)(7416002)(38100700001)(66946007)(6506007)(7696005)(33656002)(9686003)(8936002)(86362001)(498600001)(55016002)(52536014)(6916009)(83380400001)(54906003)(8676002)(66446008)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?FwduwrsHe5sv+ZS9+pkJHdmv+QM1QADJWrea1Vl86MrxiuFN+xpUrl52OroX?= =?us-ascii?Q?QP7Xq896+DpxM/QP0323x1vMXdxITNoL3Nst65gkUKvfh028nr0S2A0jjkEP?= =?us-ascii?Q?mYolvnvradkHVzD1jUkVfc1fgeA08Ovivutb84mYEZjAg+AhvkgwHc7d/T/T?= =?us-ascii?Q?4U2CIWYEeKeHXgxAks3PYmJUHWP792FffLnwm4wIUlfAbb8U5kYpxxBXMcHu?= =?us-ascii?Q?vLubZ814yWCf4i38VwZNVD72rB3E/pdwCRLXqJ0vh+0KfV4vEFN3rpz/cFeH?= =?us-ascii?Q?w9GbAhIUTl15dG3Gf2AwWdvGPtR+hWBSaTKB5+qUtWr2TcGW9SL1R6znXu8n?= =?us-ascii?Q?TJRwpGhFTBshUlzCBSJRzh8wxx+PGRFHyUTI9rBi3VGCv4DNpljLifFqO5s1?= =?us-ascii?Q?her8JDSoY99csuB5I2pEAsxOpm6tickedu+DTxB22bb9CA0e98wB1YNlApz+?= =?us-ascii?Q?zMkqAYvYt7vhmImVlljwpsXWurcdWevveoJc7q1C7POXZ9ZIJn/J4mRwVqMT?= =?us-ascii?Q?uSJighvqWmxfikvmpIPWeQigdkVCxfiv18rmFAZ2NSr9Kz7mXPM68Rcdb2PZ?= =?us-ascii?Q?Z6Q65lGR9c4Py0VqPBJSz3Pafc27Z7qi4A/0nH6DiMFGeeMgdUemhpoe/LHc?= =?us-ascii?Q?Ih2URp6XqkHtcj7Ngpd5wHnTWfZ7bt4Msv/eDSUQsVY6m6ctxoIWxuj1GSB5?= =?us-ascii?Q?8mX/w9DACKb3CRt2b8GiY4H1f3rbYea7Npyy9S/ZxWygMs0pT1aCQGjpUWl2?= =?us-ascii?Q?xIdo110ZYrwbyX03b5ugB1/ZI7bNeYuRtQ4x8ac4ydJHdIRCInMe4GUZDwsQ?= =?us-ascii?Q?+ShA9kV9aI7ziNQRPIYOTzTb56kFQxxE861tZZrCVYhrdoFhxXPWukcFQ3uo?= =?us-ascii?Q?JoQ3PrNigpzQ2vVEUQ7r/uMA02gpnTQqNG6nO8gpvr7pAjfmcrCDGVgb3JU1?= =?us-ascii?Q?XGCn2MEcB5EQpO2dUNohV4acns9v3L/sH+IyVwM0T5HdXc5OfbB/GCT+s/4p?= =?us-ascii?Q?WdGf2wf4DI5/4X4gEhLacogb+U0zHzd+XMkXTkUZqBGPlCdlPlR6J18XohaH?= =?us-ascii?Q?lMAWCsWD10Tb+/+LbMPnbvymAQkWNXv/k+i4GiI86+ECVx5/HwAI441wO3Du?= =?us-ascii?Q?M/TfhnZR9LzTdtgtBg/BDnrHGffRzQhIZRC5gTqEUgZUbk7QiuTPFv+puVrE?= =?us-ascii?Q?NKF96L1BlmaSblOAntW478HLjy2o4lqy2Ds80MNEC/K8dF1p56CoNaoan+gc?= =?us-ascii?Q?lpM5xUIH2urMiBBdzjsr2v8FzsfpTp1fx201SQ94W39SGllh+a2lTim7Jj5m?= =?us-ascii?Q?S1Y0UiPtvX85U04NvTMMPzGYQ5vmGQl4zNDV/UayUc0HIRqQsRyZrDwx4sjJ?= =?us-ascii?Q?uKbUxjc=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR18MB1168.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 48ce2a39-c97f-4f3f-349e-08d8f90cd40c X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Apr 2021 15:01:16.3319 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GZs0t3brnScHnkqs22EEfVTCaB1bZbr4Q6wgCt98Dg5TOWRepmSlxijZMy9Ph3KPKbi45nmTmU37UYs9h591Tw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR18MB2124 X-Proofpoint-GUID: 6pfrFLWKON-qOoIZEjb9jw9JyNY9M2L5 X-Proofpoint-ORIG-GUID: 6pfrFLWKON-qOoIZEjb9jw9JyNY9M2L5 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-04-06_04:2021-04-01, 2021-04-06 signatures=0 Subject: Re: [dpdk-dev] [PATCH v4 2/3] event/octeontx2: support crypto adapter forward mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Abhinandan, Please see inline. Thanks, Anoob > > > > Advertise crypto adapter forward mode capability and set crypto > > adapter enqueue function in driver. > > > > Signed-off-by: Shijith Thotton [snip] > > + > > + if (!ev->sched_type) > > + otx2_ssogws_head_wait(tag_op); > > + if (qp->ca_enable) > > + return cdev->enqueue_burst(qp, &crypto_op, 1); > > + > > +free_op: > > + rte_pktmbuf_free(crypto_op->sym->m_src); > > + rte_crypto_op_free(crypto_op); > > + return 0; > > +} >=20 > I am trying to understand this in requirement perspective. This enqueue > function is same as SW adapter's enqueue function. > Currently, application could directly enqueue to cryptodev in NEW mode. B= y > having this in PMD, how is FORWARD mode taken care? >=20 [Anoob] Difference is the ordering point when used with ORDERED flows. If application is working on an ORDERED flow, with OP_NEW, application woul= d require to queue to an ATOMIC queue before submitting to cryptodev (to ma= intain ordering). But with OP_FORWARD, application can provide an event to = the event PMD and internally it can take care of ordering as well enqueue t= o crypto "hardware". This becomes particularly useful when event hardware c= an support ordering while enqueueing to crypto hardware(and hence the "inte= rnal port"). With the current spec, OP_FORWARD would allow application to enqueue crypto= _op as an event to event device. But this event doesn't have any additional= information which would indicate it is destined to crypto. The new API wou= ld solve this issue. [snip]