From: "Takeshi T Yoshimura" <TYOS@jp.ibm.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: anatoly.burakov@intel.com, chaozhu@linux.vnet.ibm.com,
dev@dpdk.org, Takeshi Yoshimura <t.yoshimura8869@gmail.com>
Subject: Re: [dpdk-dev] [PATCH] eal/vfio: fix sPAPR IOMMU mapping
Date: Tue, 7 Aug 2018 02:28:35 +0000 [thread overview]
Message-ID: <OF3C714A82.A327DF0B-ON002582E2.000D4709-002582E2.000D9A6E@notes.na.collabserv.com> (raw)
In-Reply-To: <4068541.lKVHRX04u0@xps>
>06/08/2018 10:43, Takeshi Yoshimura:
>> Commit 73a639085938 ("vfio: allow to map other memory regions")
>> introduced a bug in sPAPR IOMMU mapping. The commit removed
>necessary
>> ioctl with VFIO_IOMMU_SPAPR_REGISTER_MEMORY. Also,
>vfio_spapr_map_walk
>> should call vfio_spapr_dma_do_map instead of
>vfio_spapr_dma_mem_map.
>
>This is fixing an old patch:
> INVALID URI REMOVED
>k_commit_-3Fid-3D73a639085938&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=EZR
>6Jx10q0q3dTopeH3WIQ&m=JqmiDyEAYS0sG-jH6aSYikeyXYLr12jnaWDUpBN1mgI&s=7
>bvq2dyXbquauFqqhuOTPVOpoqEPKg8MoncacU4OdJU&e=
>
>> Fixes: 73a639085938 ("vfio: allow to map other memory regions")
>
>You probably want it to be backported in previous release,
>so you need to add Cc: stable@dpdk.org
>
>> Signed-off-by: Takeshi Yoshimura <tyos@jp.ibm.com>
>
>It is common to have bugs in sPAPR implementation.
>How can we be sure this one is OK?
>Should it be added in last minute of 18.08?
>Or can it wait 18.11?
>
>Adding Anatoly and Chao who are maintainers to decide.
>
OK. I will resend the patch with Cc: stable@dpdk.org.
next prev parent reply other threads:[~2018-08-07 2:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 8:43 Takeshi Yoshimura
2018-08-06 9:50 ` Thomas Monjalon
2018-08-07 8:39 ` Burakov, Anatoly
2018-08-07 2:28 ` Takeshi T Yoshimura [this message]
2018-08-07 2:32 ` Takeshi Yoshimura
2018-08-07 2:35 ` [dpdk-dev] [PATCH v2] " Takeshi Yoshimura
2018-10-28 21:21 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OF3C714A82.A327DF0B-ON002582E2.000D4709-002582E2.000D9A6E@notes.na.collabserv.com \
--to=tyos@jp.ibm.com \
--cc=anatoly.burakov@intel.com \
--cc=chaozhu@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=t.yoshimura8869@gmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).