From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id 033B81B05B for ; Tue, 7 Aug 2018 04:28:42 +0200 (CEST) Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w772NYLJ087336 for ; Mon, 6 Aug 2018 22:28:41 -0400 Received: from smtp.notes.na.collabserv.com (smtp.notes.na.collabserv.com [158.85.210.108]) by mx0a-001b2d01.pphosted.com with ESMTP id 2kq01dvddu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 06 Aug 2018 22:28:41 -0400 Received: from localhost by smtp.notes.na.collabserv.com with smtp.notes.na.collabserv.com ESMTP for from ; Tue, 7 Aug 2018 02:28:40 -0000 Received: from us1b3-smtp01.a3dr.sjc01.isc4sb.com (10.122.7.174) by smtp.notes.na.collabserv.com (10.122.47.46) with smtp.notes.na.collabserv.com ESMTP; Tue, 7 Aug 2018 02:28:35 -0000 Received: from us1b3-mail157.a3dr.sjc03.isc4sb.com ([10.160.174.125]) by us1b3-smtp01.a3dr.sjc01.isc4sb.com with ESMTP id 2018080702283478-1129135 ; Tue, 7 Aug 2018 02:28:34 +0000 In-Reply-To: <4068541.lKVHRX04u0@xps> From: "Takeshi T Yoshimura" To: Thomas Monjalon Cc: anatoly.burakov@intel.com, chaozhu@linux.vnet.ibm.com, dev@dpdk.org, Takeshi Yoshimura Date: Tue, 7 Aug 2018 02:28:35 +0000 Sensitivity: Importance: Normal X-Priority: 3 (Normal) References: <4068541.lKVHRX04u0@xps>,<20180806084309.5489-1-tyos@jp.ibm.com> X-Mailer: IBM iNotes ($HaikuForm 1011.1) | IBM Domino Build SCN1812108_20180501T0841 May 01, 2018 at 08:41 X-KeepSent: 3C714A82:A327DF0B-002582E2:000D4709; type=4; name=$KeepSent X-LLNOutbound: False X-Disclaimed: 8635 X-TNEFEvaluated: 1 X-LLNXfer: False x-cbid: 18080702-7845-0000-0000-00000457A4FE X-IBM-SpamModules-Scores: BY=0.170593; FL=0; FP=0; FZ=0; HX=0; KW=0; PH=0; SC=0.394266; ST=0; TS=0; UL=0; ISC=; MB=0.000085 X-IBM-SpamModules-Versions: BY=3.00009498; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000266; SDB=6.01070501; UDB=6.00550947; IPR=6.00849789; BA=6.00006066; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00022550; XFM=3.00000015; UTC=2018-08-07 02:28:38 X-IBM-AV-DETECTION: SAVI=unsuspicious REMOTE=unsuspicious XFE=unused X-IBM-AV-VERSION: SAVI=2018-08-07 00:19:55 - 6.00008799 x-cbparentid: 18080702-7846-0000-0000-000010B0B216 Message-Id: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: Quoted-printable MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-08-06_12:, , signatures=0 X-Proofpoint-Spam-Reason: safe Subject: Re: [dpdk-dev] [PATCH] eal/vfio: fix sPAPR IOMMU mapping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Aug 2018 02:28:43 -0000 >06/08/2018 10:43, Takeshi Yoshimura: >> Commit 73a639085938 ("vfio: allow to map other memory regions") >> introduced a bug in sPAPR IOMMU mapping. The commit removed >necessary >> ioctl with VFIO_IOMMU_SPAPR_REGISTER_MEMORY. Also, >vfio_spapr_map_walk >> should call vfio_spapr_dma_do_map instead of >vfio_spapr_dma_mem_map. > >This is fixing an old patch: > INVALID URI REMOVED >k_commit_-3Fid-3D73a639085938&d=3DDwICAg&c=3Djf_iaSHvJObTbx-siA1ZOg&r=3DEZR >6Jx10q0q3dTopeH3WIQ&m=3DJqmiDyEAYS0sG-jH6aSYikeyXYLr12jnaWDUpBN1mgI&s=3D7 >bvq2dyXbquauFqqhuOTPVOpoqEPKg8MoncacU4OdJU&e=3D > >> Fixes: 73a639085938 ("vfio: allow to map other memory regions") > >You probably want it to be backported in previous release, >so you need to add Cc: stable@dpdk.org > >> Signed-off-by: Takeshi Yoshimura > >It is common to have bugs in sPAPR implementation. >How can we be sure this one is OK? >Should it be added in last minute of 18.08? >Or can it wait 18.11? > >Adding Anatoly and Chao who are maintainers to decide. > OK. I will resend the patch with Cc: stable@dpdk.org.