From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <wang.yong19@zte.com.cn>
Received: from out1.zte.com.cn (out1.zte.com.cn [202.103.147.172])
 by dpdk.org (Postfix) with ESMTP id 251FF591E
 for <dev@dpdk.org>; Wed,  4 Jan 2017 07:55:38 +0100 (CET)
X-MAILFROM: <wang.yong19@zte.com.cn>
X-RCPTTO: <dev@dpdk.org>
X-FROMIP: 10.30.3.20
X-SEG-Scaned: 1
X-Received: unknown,10.30.3.20,20170104144826
Received: from unknown (HELO mse01.zte.com.cn) (10.30.3.20)
 by localhost with (AES256-SHA encrypted) SMTP; 4 Jan 2017 06:48:26 -0000
Received: from notes_smtp.zte.com.cn ([10.30.1.239])
 by mse01.zte.com.cn with ESMTP id v046tHvs096878;
 Wed, 4 Jan 2017 14:55:17 +0800 (GMT-8)
 (envelope-from wang.yong19@zte.com.cn)
In-Reply-To: <20170104040210.GE21228@yliu-dev.sh.intel.com>
References: <1483502275-18482-1-git-send-email-wang.yong19@zte.com.cn>
 <20170104040210.GE21228@yliu-dev.sh.intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: dev@dpdk.org
MIME-Version: 1.0
X-KeepSent: B33FBBB1:6E0FAAD1-4825809E:00216EB4;
 type=4; name=$KeepSent
X-Mailer: Lotus Notes Release 8.5.3 September 15, 2011
Message-ID: <OFB33FBBB1.6E0FAAD1-ON4825809E.00216EB4-4825809E.002605B9@zte.com.cn>
From: wang.yong19@zte.com.cn
Date: Wed, 4 Jan 2017 14:55:34 +0800
X-MIMETrack: Serialize by Router on notes_smtp/zte_ltd(Release
 8.5.3FP6|November 21, 2013) at 2017-01-04 14:54:58,
 Serialize complete at 2017-01-04 14:54:58
X-MAIL: mse01.zte.com.cn v046tHvs096878
X-HQIP: 127.0.0.1
Content-Type: text/plain; charset="US-ASCII"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: [dpdk-dev] =?gb2312?b?tPC4tDogUmU6IFtQQVRDSF0gbGliL2xpYnJ0ZV92?=
 =?gb2312?b?aG9zdDogZml4IG1lbW9yeSBsZWFr?=
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Jan 2017 06:55:40 -0000

> Yuanhan Liu <yuanhan.liu@linux.intel.com> 
> 2017/01/04 12:02
> 
> to
> 
> Yong Wang <wang.yong19@zte.com.cn>, 
> 
> cc
> 
> dev@dpdk.org
> 
> subject
> 
> Re: [PATCH] lib/librte_vhost: fix memory leak
> 
> On Tue, Jan 03, 2017 at 10:57:55PM -0500, Yong Wang wrote:
> > In function vhost_new_device(), current code dose not free 'dev'
> > in "i == MAX_VHOST_DEVICE" condition statements. It will lead to a
> > memory leak.
> 
> Nice catch!
> 
> Here are few minor stuff you might need pay attention to for future
> contribution:
> 
> - a fix patch needs a fixline, like following
> 
>   Fixes: 45ca9c6f7bc6 ("vhost: get rid of linked list for devices")
> 
> - the prefix for vhost lib is "vhost: ". And FYI, for PMD drivers, it's
>   'net/PMD_NAME', say 'net/virtio'.
> 
> 
> For you convenience, I have fixed the two while applying. And thanks
> for the fix.
> 
> Applied to dpdk-next-virtio.
> 
>    --yliu

Thanks for your advice.