From: Wathsala Vithanage <wathsala.vithanage@arm.com>
To: Shani Peretz <shperetz@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "getelson@nvidia.com" <getelson@nvidia.com>,
"bingz@nvidia.com" <bingz@nvidia.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Bruce Richardson <bruce.richardson@intel.com>,
Dhruv Tripathi <Dhruv.Tripathi@arm.com>, nd <nd@arm.com>
Subject: RE: [PATCH] config/arm: support crypto in cortex-a78ae mcpu
Date: Mon, 25 Aug 2025 12:50:57 +0000 [thread overview]
Message-ID: <PAWPR08MB8909F6D501EA994F2EBE38549F3EA@PAWPR08MB8909.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20250805062233.222260-1-shperetz@nvidia.com>
Reviewed-by: Wathsala Vithanage <wathsala.vithanage@arm.com>
> -----Original Message-----
> From: Shani Peretz <shperetz@nvidia.com>
> Sent: Tuesday, August 5, 2025 1:23 AM
> To: dev@dpdk.org
> Cc: getelson@nvidia.com; bingz@nvidia.com; Shani Peretz
> <shperetz@nvidia.com>; Wathsala Vithanage <wathsala.vithanage@arm.com>;
> stable@dpdk.org; Bruce Richardson <bruce.richardson@intel.com>; Dhruv
> Tripathi <Dhruv.Tripathi@arm.com>
> Subject: [PATCH] config/arm: support crypto in cortex-a78ae mcpu
>
> ARM cortex-a78ae configuration (part number 0xd42) is being built without the
> necessary crypto extensions. This results in infinite loops in the crypto
> performance tests applications because the hardware crypto features are not
> properly enabled.
> This fix enables the crypto extension in the mcpu definition.
>
> Fixes: c02c01dbf907 ("config/arm: prefer strict use of -mcpu if supported")
> Cc: wathsala.vithanage@arm.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Shani Peretz <shperetz@nvidia.com>
> ---
> config/arm/meson.build | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build index
> 35b7553e74..82661b7cfe 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -84,8 +84,7 @@ part_number_config_arm = {
> ]
> },
> '0xd42': {
> - 'march': 'armv8.4-a',
> - 'mcpu' : 'cortex-a78ae',
> + 'mcpu' : 'mcpu_cortex-a78ae',
> 'flags': [
> ['RTE_MAX_LCORE', 16],
> ['RTE_MAX_NUMA_NODES', 1]
> @@ -689,6 +688,10 @@ mcpu_defs = {
> 'march': 'armv8-a',
> 'march_extensions': ['simd'],
> },
> + 'mcpu_cortex-a78ae': {
> + 'march': 'armv8.4-a',
> + 'march_extensions': ['crypto']
> + }
> }
>
> '''
> --
> 2.34.1
prev parent reply other threads:[~2025-08-25 12:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-05 6:22 Shani Peretz
2025-08-25 12:50 ` Wathsala Vithanage [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PAWPR08MB8909F6D501EA994F2EBE38549F3EA@PAWPR08MB8909.eurprd08.prod.outlook.com \
--to=wathsala.vithanage@arm.com \
--cc=Dhruv.Tripathi@arm.com \
--cc=bingz@nvidia.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=getelson@nvidia.com \
--cc=nd@arm.com \
--cc=shperetz@nvidia.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).