From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08E7442F9B; Mon, 31 Jul 2023 07:10:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D795740A89; Mon, 31 Jul 2023 07:10:51 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2053.outbound.protection.outlook.com [40.107.20.53]) by mails.dpdk.org (Postfix) with ESMTP id 89C4340150 for ; Mon, 31 Jul 2023 07:10:50 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h976c3IMuMGU1hTcSEST70qBOe9LML5ffiU1ia79NSryj/1X1gGuEJ25QO/+z7X4ce8T2/Bd6gVIQXvIfVLUiMZacBpbUlX6H+mmxRf8qjORXwlUzhMB6P/vaVZPDgZ77ypdshK9nSYWZC/mbE3bp6vUJC/9FVvSRvnrgWVIhnr6W1WrsHcGX0/jxgBwOsO2Rum1qxcHDnsS6nNFqHJDNkGpFT1dQFVo6FBCOA4PSxmHblS0jfUHtdb2i9YA4CnEZRhaZAMnWpaHBWGFNBPpggcjh84NmEvyl59qjeFkd414g7W1Af9VcgjJrH5OrnJnAb1btrxP6vxJePH5F87xNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F+TEfpiJdAazop3zvq+vAGQBcuj6kDmxGB7tL3WOFW0=; b=gV5p32LG9q888lWubWXtJgnggCpfsefn4qbK+TbrEZVeANbVQnVkRUes926gBu+7otgRjhNV3rHdhAjKIO2asvLERVTkJwyCFy+WYfxCJrg8NgIq5WZ6f1ZoHSoLuNTm3yYrwz6x2t/Vn1vy00y8AfUnFfoJDjdvQ78ydBxWFzWT6gcC70tLL77S0BgAT6EnPYOmX76594VHvalE/XrxL6WClHlH4auMdEcLjlQg30EWncWncvTE7O1bW0/PB4GHXVBq2ZxmtGlJR+FYzoBbgPe8MaaCqAuRu36yiSF3rPqJL+bWud2uyLvcmNVIP4o+SFVB7S3coSpLCudMdKS6GQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F+TEfpiJdAazop3zvq+vAGQBcuj6kDmxGB7tL3WOFW0=; b=qAv/VcZPxYOkJh2bEAYclDpcm9ZlAim41PbFlF99gLjLO3YSljby8s1DGg1iKk3MhkdM8OZzwUu4+Bu+GKxqCs82iPQjj0gFfqK7r6tJuz01f25I2tm8QDHR6wM3Y/4+0I47q1xuc+geIZwzU5BqBJbuHloUAlD8FYs+eQAenlQ= Received: from PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) by AM9PR04MB8259.eurprd04.prod.outlook.com (2603:10a6:20b:3e4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.43; Mon, 31 Jul 2023 05:10:48 +0000 Received: from PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::450d:89ac:4f6a:6ae2]) by PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::450d:89ac:4f6a:6ae2%4]) with mapi id 15.20.6631.042; Mon, 31 Jul 2023 05:10:48 +0000 From: Hemant Agrawal To: Akhil Goyal , "dev@dpdk.org" CC: "ciara.power@intel.com" , "fanzhang.oss@gmail.com" , "anoobj@marvell.com" Subject: RE: [PATCH] app/crypto-perf: return ENOTSUP for unsupported cases Thread-Topic: [PATCH] app/crypto-perf: return ENOTSUP for unsupported cases Thread-Index: AQHZw2Jw4zNg6eS2h0mWXRMidbHhia/TU8pQ Date: Mon, 31 Jul 2023 05:10:48 +0000 Message-ID: References: <20230731035221.932405-1-gakhil@marvell.com> In-Reply-To: <20230731035221.932405-1-gakhil@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PAXPR04MB9328:EE_|AM9PR04MB8259:EE_ x-ms-office365-filtering-correlation-id: 311953d8-b9a7-4875-de91-08db9184808c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sO2BVnerJHRCA8jHQLnQtteUhZP55k2Kn9Dcl/cwSpWbiV8itGpJZMEo2hk3wFAQYqCdldtVaQdkTHJO1r3RBOMKiGwDp0AhzWrKmV+evyhey8SiMzpaBLrkPoooF5GSiWn6wSgN2fJzc+FYrxqk0SSKvhM0Gv17kfKopS1V8FzPbZqIIbtGrWhviSrEK2SnCvSlCYL9+oQUDvxvz8Zmr3a24BN8U6N/Thvjma5IG4qgN+hPlCmBsw7iO4JJRWwmAqfqscEh211vyVzyM7o+tYevaO7S8bKPwqsoOPOsAoCHsEodE94qblMfxUi/FTQ4LKE9CpEFOjupvzNmeKIFQSdfnFdquuVQWbfEIJfQPJF+VjPTmhHrYQwHLqi713/RjV5bGwc9+gOjGTkbFzBgRp3CvtJho04dc1oCk6hPlYKYqy1+dsyChJRqW71F7jB9hLKt2j4kFpPx4Pob833+fH+ldoiCwjP4fcNFd8aSEW0LZ2ik+4aDSVhAPWnJn+KTn/4/8Ckw0+IkjkQsBa/ya2ml57VII578fZ5HEDyK7Z+Tdn/GbGRBS2imf1fZZjI6IGe/6YOWO/umKEeDN+OrTvdH3NEzKAMkyxgedTZqINhUZPZ9qoKXD01e95MxdsCK x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB9328.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(376002)(136003)(39860400002)(346002)(366004)(451199021)(9686003)(71200400001)(7696005)(33656002)(186003)(83380400001)(86362001)(38070700005)(122000001)(38100700002)(26005)(6506007)(55236004)(55016003)(52536014)(5660300002)(41300700001)(8936002)(8676002)(76116006)(66946007)(64756008)(66556008)(66476007)(66446008)(2906002)(316002)(478600001)(110136005)(54906003)(4326008)(44832011); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cgDg37Qi+yq1dnZsBf8EY6pMwMNQvyOH2/gCtWTIe9bUbHsp9Q0mWStU/Gr7?= =?us-ascii?Q?7Ecila2910gtjRC4CMRaJmhac+OgNx73IMq2A6bLReMCCF/nxVUb2TdgiG/1?= =?us-ascii?Q?cSSFIScnQjIt64qaXrjU1WvIFu4VbT5GhOX1a8LJAoX4q9uioGujPU65ASk/?= =?us-ascii?Q?KO12qOy5bvjlMAK/vP21O9CAxnsItItpavlHeFgEuTGVDDtn6xIMQE26W6WM?= =?us-ascii?Q?KFz5VFTSoX03TNvs/xA6cfCCbwvAhIld4XzZRhtiLiBmd4/muISWwO7sBYVy?= =?us-ascii?Q?UineF3TD3LQqMmriQmjWUi2xjFdCzDqC+l+STBVFQQFEwWxiFfxoDg8m+u/J?= =?us-ascii?Q?aYhJDbP8l2TR5qfEGEZp/b/mGmHddYT5VYJecpTvhrfhacPgJpGMC76UsdSx?= =?us-ascii?Q?7C9DuAdZDH2A/qBUOI2wn7w+jKjphDeNkXVHi1sZkRUMvBrXlbZZ+OCB+5Bz?= =?us-ascii?Q?i2EFu3eflmp5bHPFLfFp3JUTwVQvprijDhJSZrp+12qUd5rrSDQ02OH7cah3?= =?us-ascii?Q?N/Kf2+7iNRfIksNh8lAu+3tsEhLcqN7QX58iGdixZ6ORxoVd0zDN9dooltua?= =?us-ascii?Q?Ps1IlPUDpbpyaCONzpVCHwBfA03Gp5CPmMuiEKEGsDkzhGk+Tzyf4Jqiqnmw?= =?us-ascii?Q?Q+m16sIPqemZsyuCM07fM/p305h0OrGSM0V5oKcUGSL3fFa/dYY4yVLDtxR0?= =?us-ascii?Q?+8hcMnb3moI8VGZHPfkGil36s2U4O2zIxzxRTSmlBAdj8VjcjqUVtaWOO9E5?= =?us-ascii?Q?tyQ3jWeKImL7Q2XiM15kaI22nCDAihcLJXNynQkafymnVhghw9ZW0CI3QSsi?= =?us-ascii?Q?X30dOrR0k9b3VnLkURKyh9Pe9xqZfM0rwzT3c31rLbKtFDAjHATowVzwnu5Y?= =?us-ascii?Q?LvLtxsYjN7U3DGog4p2+ougia5ATA7lSpHsUtcPA9U6pDLay7iUNmr3YfGVK?= =?us-ascii?Q?nHVmti4SuX1AonTbGWqlrPa3d2FALkAYgnoY7VGMCatwXColSeJhIr0r75gC?= =?us-ascii?Q?IdQpI7bqoTPDTryVn1hIuk/zjLyd1zRolQZ13lvs656Y14/ciGnG1ORxR0sN?= =?us-ascii?Q?HRWfIxUczOgRzkEjTd4b4DgKW6SJpspAaTEDYy+90NW1LusC+5Qgs1D61WIe?= =?us-ascii?Q?cHqCAE8p4SSU7v+Llrj4k3L5kXJRotRrzHH/OS5A4NNyNs9VCbI73BTSEbC5?= =?us-ascii?Q?iIjsa7b7tSCIVQw6mhRnXRL8kX/te5EJIBZU8TEIkAEtHlhAGKodGyobeLFS?= =?us-ascii?Q?x8xX7zVruFIxjkkY9JUqInAqVk7Y5bkHyk5MSeZgH8RFmaii1RY6u1GJWCAp?= =?us-ascii?Q?ONAmT+nFGH1w0QOrKE9kpicRTeZKhJmDiVGJskIpkgmQQ3U+xO/NSIJZeBOs?= =?us-ascii?Q?/ptUh+/uyJICN4zPoA6/6UOe1sHHuqprzujyYa7dXt6ZVDfBAquDXu10OXke?= =?us-ascii?Q?ghKZHXdZMdFQrRljXjfOP2q5gI+vYL+pB9gnVeICBjnG0LtdcODGbGOawtCT?= =?us-ascii?Q?o0Rjvw7STJLwCT0Sz1FERfNqEnpgkx9kaLDLopXs+PwyniW49/oQj2pUQjQw?= =?us-ascii?Q?PIi034DD/dvHS9lqCweRWr/seGupr9Ptb+QIdUVT?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9328.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 311953d8-b9a7-4875-de91-08db9184808c X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jul 2023 05:10:48.1104 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: atmjaL+Ibl9BZTcrc6m+uUdbgE2ct6wXBo3Wh0vAC4NswPrAl1x/PPO47KnrNioOxnQgHxjVyE00eXQr2nBeMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8259 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Akhil Goyal >=20 > dpdk-test-crypto-perf application returns failure for all the cases which= are > not supported by the device. >=20 > This patch captures rte_errno to check if the case run is supported or no= t, if > not supported, the application would now return ENOTSUP which can be > used in automation to identify between failed and unsupported cases. >=20 > Signed-off-by: Akhil Goyal > --- > app/test-crypto-perf/main.c | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c in= dex > bc1f0f9659..6a2e5762a3 100644 > --- a/app/test-crypto-perf/main.c > +++ b/app/test-crypto-perf/main.c > @@ -9,6 +9,7 @@ > #include > #include > #include > +#include > #include > #ifdef RTE_CRYPTO_SCHEDULER > #include > @@ -560,6 +561,7 @@ main(int argc, char **argv) >=20 > int ret; > uint32_t lcore_id; > + bool cap_unsupported =3D false; >=20 > /* Initialise DPDK EAL */ > ret =3D rte_eal_init(argc, argv); > @@ -600,6 +602,7 @@ main(int argc, char **argv) > if (ret) { > RTE_LOG(ERR, USER1, "Crypto device type does not support > " > "capabilities requested\n"); > + cap_unsupported =3D true; > goto err; > } >=20 > @@ -819,6 +822,10 @@ main(int argc, char **argv) > rte_free(opts.imix_buffer_sizes); > free_test_vector(t_vec, &opts); >=20 > + if (rte_errno =3D=3D ENOTSUP || cap_unsupported) { > + RTE_LOG(ERR, USER1, "Unsupported case: errno: %u\n", > rte_errno); > + return -ENOTSUP; > + } > printf("\n"); > return EXIT_FAILURE; > } > -- > 2.25.1 Acked-by: Hemant Agrawal