RE: [PATCH 2/3] net/dpaa2: clear active VDQ state when freeing Rx queues

[Hemant Agrawal <hemant.agrawal@nxp.com>]

[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]


Le jeu. 6 nov. 2025, 20:29, Stephen Hemminger <stephen@networkplumber.org<mailto:stephen@networkplumber.org>> a écrit :
On Thu,  6 Nov 2025 22:08:06 +0530
Hemant Agrawal <hemant.agrawal@nxp.com<mailto:hemant.agrawal@nxp.com>> wrote:

> +static void
> +dpaa2_clear_queue_active_dps(struct dpaa2_queue *q, int num_lcores)
> +{
> +     int i;
> +
> +     for (i = 0; i < num_lcores; i++) {
> +             struct queue_storage_info_t *qs = q->q_storage[i];
> +
> +             if (!qs)
> +                     continue;
> +
> +             if (qs->active_dqs) {
> +                     clear_swp_active_dqs(qs->active_dpio_id);
> +                     qs->active_dqs = NULL;
> +             }
> +     }
> +}
> +

Why not use RTE_LCORE_FOREACH() here?

For the loop, I did it the same way as in dpaa2_queue_storage_alloc(), to stay aligned with the rest of the driver instead of using RTE_LCORE_FOREACH().

Thanks Hemant for upstreaming my patch. However, you added my email in .mailmap as a new entry — it should instead be added as a second email under the existing Maxime Leroy entry.
[Hemant]
Will send v2

[-- Attachment #2: Type: text/html, Size: 4290 bytes --]