DPDK patches and discussions
 help / color / mirror / Atom feed
From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Amit Prakash Shukla <amitprakashs@marvell.com>,
	Chengwen Feng <fengchengwen@huawei.com>,
	Kevin Laatz <kevin.laatz@intel.com>,
	Bruce Richardson <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"jerinj@marvell.com" <jerinj@marvell.com>,
	 "conor.walsh@intel.com" <conor.walsh@intel.com>,
	"vattunuru@marvell.com" <vattunuru@marvell.com>,
	Gagandeep Singh <G.Singh@nxp.com>,
	"Sachin Saxena (OSS)" <sachin.saxena@oss.nxp.com>,
	"cheng1.jiang@intel.com" <cheng1.jiang@intel.com>,
	"ndabilpuram@marvell.com" <ndabilpuram@marvell.com>,
	"anoobj@marvell.com" <anoobj@marvell.com>,
	"mb@smartsharesystems.com" <mb@smartsharesystems.com>
Subject: RE: [PATCH] test/dma: fix for buffer auto free
Date: Wed, 1 Nov 2023 14:08:53 +0000	[thread overview]
Message-ID: <PAXPR04MB9328A3D274C28E41088DDB2D89A7A@PAXPR04MB9328.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20231101101809.3546500-1-amitprakashs@marvell.com>

> diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c index
> 216f84b6bb..3d4cb37ee6 100644
> --- a/app/test/test_dmadev.c
> +++ b/app/test/test_dmadev.c
> @@ -49,6 +49,8 @@ struct dma_add_test dma_add_test[] = {
>  	[TEST_M2D_AUTO_FREE] = {.name = "m2d_auto_free", .enabled =
> false},  };
> 
> +static bool dev_init;

[Hemant]  should't it be per device id? 

> +
>  static void
>  __rte_format_printf(3, 4)
>  print_err(const char *func, int lineno, const char *format, ...) @@ -837,7
> +839,6 @@ test_m2d_auto_free(int16_t dev_id, uint16_t vchan)
>  	};
>  	uint32_t buf_cnt1, buf_cnt2;
>  	struct rte_mempool_ops *ops;
> -	static bool dev_init;
>  	uint16_t nb_done = 0;
>  	bool dma_err = false;
>  	int retry = 100;
> @@ -1011,6 +1012,7 @@ test_dmadev_instance(int16_t dev_id)
> 
>  	if ((info.dev_capa & RTE_DMA_CAPA_M2D_AUTO_FREE) &&
>  	    dma_add_test[TEST_M2D_AUTO_FREE].enabled == true) {
> +		dev_init = false;
>  		if (runtest("m2d_auto_free", test_m2d_auto_free, 128,
> dev_id, vchan,
>  			    CHECK_ERRS) < 0)
>  			goto err;
> --
> 2.25.1


  reply	other threads:[~2023-11-01 14:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-01 10:18 Amit Prakash Shukla
2023-11-01 14:08 ` Hemant Agrawal [this message]
2023-11-02  2:06 ` fengchengwen
2023-11-02  9:40   ` [EXT] " Amit Prakash Shukla
2023-11-03 18:30 ` [PATCH v2] " Amit Prakash Shukla
2023-11-06  1:08   ` fengchengwen
2023-11-14 14:58     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PAXPR04MB9328A3D274C28E41088DDB2D89A7A@PAXPR04MB9328.eurprd04.prod.outlook.com \
    --to=hemant.agrawal@nxp.com \
    --cc=G.Singh@nxp.com \
    --cc=amitprakashs@marvell.com \
    --cc=anoobj@marvell.com \
    --cc=bruce.richardson@intel.com \
    --cc=cheng1.jiang@intel.com \
    --cc=conor.walsh@intel.com \
    --cc=dev@dpdk.org \
    --cc=fengchengwen@huawei.com \
    --cc=jerinj@marvell.com \
    --cc=kevin.laatz@intel.com \
    --cc=mb@smartsharesystems.com \
    --cc=ndabilpuram@marvell.com \
    --cc=sachin.saxena@oss.nxp.com \
    --cc=vattunuru@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).