From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B37D43399; Wed, 22 Nov 2023 08:23:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0028D402EC; Wed, 22 Nov 2023 08:23:38 +0100 (CET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2058.outbound.protection.outlook.com [40.107.21.58]) by mails.dpdk.org (Postfix) with ESMTP id 5F6A74028C for ; Wed, 22 Nov 2023 08:23:37 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nc8vs71GZQBfC3zdGYSF/FUwp6NkKfvigiWRhHTJrxCxklsE2BEUk264PdgEOTiDZVaYVz6sBz2puec7xQssArPAQAkZjrSCYEnaQzI25XFB51Ul4syHnPsdJwt5MTUAB3or0giGen6UJso6JcAu6cI4xIuaaf2Aw4xVfTRl9FiAZT52zWneOyQSfXwKSOYA0aMK5YIJvwp5oCi2zxiN3SwrWEMEfUwIfuShmKsVFmZ/YY+OICkRxa2QEmAgEqbXhL+3ZKq/kNkLkJQ2xLhsKiQrZ6mab19Nvmbs9hrqux2bKo+Fa3qR8gQBibx8u5QyLpk3V9w40XS/JxixLFmNug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rgeHPjGG75wUwsxuAbMFeY08VRKafBKHT1Bw0ZtURYw=; b=CMBADDFEmmwuxxiUQOBAJbwd18PSZ1nHEzCVZcu/BHSIZeevmKwXb6WFB3b1IY7ezZ9HY9W11J7+xU9C73lz8cou6sOwBkCp1O4pC+iJkxebwY9fJOf5JIe3qPx+z/FyyotGBECAK7w5vySlkAS6tQ0FXGclKIxqRkjwLUfaNOchTwvotinqxzHMa80AvllhtUNhuV4vxr1celWc1a60JNi75ei7kluOhTdbS7j6h1nCgCBj1EPpMJ4G0UKCujGTyT0ecQ8i6LOMA3F7mHP+iMcsQmbBjrL6S9vouUAb7+h57K9CB+OCR+qjRuOMawG5isk0T5nPhlNkXfblBeHhWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rgeHPjGG75wUwsxuAbMFeY08VRKafBKHT1Bw0ZtURYw=; b=XuxfNgwzbl3h78PpVE7r1+kFrM9JEKt5kRVOWMRKXo9ruXxYITe0yXcjSu05/qsVJfatduarobkLiEoH4VxdnlkBBzEdcsOX89rU3ZeTeeYvg8ODpxHzoOH6sqVt0oFI/HEL+P0opn4Wjj3e8h5JxUuIuMUGiHg0LnKj2k0GbPw= Received: from PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) by AS1PR04MB9312.eurprd04.prod.outlook.com (2603:10a6:20b:4dc::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.17; Wed, 22 Nov 2023 07:23:36 +0000 Received: from PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::99b2:221d:bdda:3d6f]) by PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::99b2:221d:bdda:3d6f%5]) with mapi id 15.20.7025.017; Wed, 22 Nov 2023 07:23:36 +0000 From: Hemant Agrawal To: Tyler Retzlaff , Stephen Hemminger CC: "dev@dpdk.org" , Sachin Saxena , Gagandeep Singh Subject: RE: [PATCH v4 10/10] common/dpaxx: remove zero length array Thread-Topic: [PATCH v4 10/10] common/dpaxx: remove zero length array Thread-Index: AQHaG9RoX5hiMbAg/Uq1yUqincr6HLCEmQJggABj74CAAAjtgIAA6/Dg Date: Wed, 22 Nov 2023 07:23:36 +0000 Message-ID: References: <20230113215205.125767-1-stephen@networkplumber.org> <20231120170942.197172-1-stephen@networkplumber.org> <20231120170942.197172-11-stephen@networkplumber.org> <20231121084641.39e7b39b@hermes.local> <20231121171837.GA7518@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20231121171837.GA7518@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PAXPR04MB9328:EE_|AS1PR04MB9312:EE_ x-ms-office365-filtering-correlation-id: 6ee4d47d-6886-459c-084e-08dbeb2bf0e5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tEwjevs5faCMCCDK+dOvxNKouCezCj0PLM2fR/eelNztLcPqGjEJ5lwP/X1nhDiOm35B98IilPNWTgwjKIqAYqyCuyg/j56wO7P4FlO590zGa5sbSD28EfgUdry9eOiTN1lT34ukECNT/m6k9+0VwIkOhPIz/3BhLLdaA8LJLUdGGcnOEvCqzq36chzkDZjZ++v7SfVc8htPaenLl/b15ZOlpk/rPrkcAJs1b1PiBBVA+0xLEocR6dFwngOylOHYuDZGDe3YqqjKiMrBzpZ/Uqiy88tv6r1dcSiJEllcjdq4lZ5VU/gldFpPGvMH/miH7IDelZMdXounKqUTjsnPbeESXFEaFb0opRHFqkQ6461uCJI9EJsASFI3+O0TuG0I+4LlokQpR14sjn6AyBPu2f+KsFki/QaS3Imof/PPl/SlXXXmjLE8Mg613+lFH74bWzMjJNckYwxC+BRPQ9CLS5wUcJUocD516b7WXVOff+Ub6Feg3vCaap1U9TJHDz/7FH2lXfkNOYrgAE1ai7VfSBy1SiwGhJkic82fmyXoTeIgxfyOvLJ60trn+hX9PiFdg3YV+Bh2saHVWrjflN3tbaxHz4IWvskMmzOxFZ6mwMDaTSLEYdK0839htF3dUvHhQKjUnNZEdDba1ctHKqlS6+5maBp2Iu073j7rryGuXyQ= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB9328.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(366004)(136003)(396003)(39860400002)(376002)(230922051799003)(230173577357003)(230273577357003)(451199024)(186009)(1800799012)(64100799003)(86362001)(38100700002)(122000001)(38070700009)(33656002)(110136005)(316002)(66476007)(66446008)(76116006)(66556008)(54906003)(44832011)(64756008)(26005)(55016003)(66946007)(478600001)(7696005)(6506007)(71200400001)(5660300002)(55236004)(53546011)(9686003)(4326008)(41300700001)(2906002)(8936002)(52536014)(8676002)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XdZfxLaQZo3/uuq/HV4M2RIjSB/c6VpLRbA5HEAJKMT19gaiABaV+dvnvzuV?= =?us-ascii?Q?S8x8gPFEiaGX0Ni4b5RFICYhfQXFBMlRkC0eWNtaB83CNDHKJ4PUFy/VCwVS?= =?us-ascii?Q?a8qgNAri5Ye2kG1fHatOP91plTN7iWMfJkm02y7yE7kdejRQF2E2+4GQ7sDk?= =?us-ascii?Q?Ip/MxbY2IiB/56MptsaFAKVywUZYiaDj8haltlIcElVL6XeOl7+WyaOgEZb3?= =?us-ascii?Q?3kHy/H5f+4NT14yN+hWFIfdjr+QSpE7Dd8jw6z7EFvn2UB77WTLsuuZf0V44?= =?us-ascii?Q?rJIS0+HXzenEcG3CkyVyrkG3sdadHEg7xTL0/CmpN2gtChtOIcKHtkyT6skj?= =?us-ascii?Q?UbiIcURv3vtN28FrVNEPaoJ21X106DpDZVfROX9bRl9e805VuOhQZZRvR7Yo?= =?us-ascii?Q?56XO3Uq3UuGnmJHzMvWoA3ltinqKkeYgr8xsnIXnPYK8pHSHEJjtze0iCPnx?= =?us-ascii?Q?H2rc1om0EC+Prf9INiO9dfiGIUtFFWf7wENDUC1lR1UBYJI13m2inH6SyHyB?= =?us-ascii?Q?XTxOs1x7o8/pYPuOWbfkDc4TH4BiqR4M6wGnIlSyTEVA9pdM6aiOMfWXOSLo?= =?us-ascii?Q?mM5DOcG6uLw8HezUDexjzFlMMGo7PihizvS7QZ6Z7ynTvv2dzcGCgGY2NMa1?= =?us-ascii?Q?/l0bNLZiyMQKyps8lJoZeviZZOw61ZJoBB/YjEN+/CR8kS4pjmO9/gmjUo1G?= =?us-ascii?Q?ckZw+0r5ariVjWGXPwxULjW6jmUdIyVAte7E4wi5TIXAXNpQJilMWl/iHs7G?= =?us-ascii?Q?7ArD21rrQKhPxrflf+J5KvsgTqx9ixuu3vc29YI3LJKp6+DK9v7G94tJ+V+v?= =?us-ascii?Q?mjWdx8PINJP3y66MxD+71WviIaF+bDSM9fU6wkmifYkzC1f37xGT+Pv/sKQZ?= =?us-ascii?Q?ItfGrKHo0lWzo5j5i+Pdb+5dtIZfofSIl+9dpFDesa+Bbcg4udjHzAKNH6Lb?= =?us-ascii?Q?dQ0PVR/cDAUVR0xVWO6F06dcSoICDIyiaoo5Uz9AQzWIfjee6w++9J81abdc?= =?us-ascii?Q?a3dmhnJ3o0V59cAt5IMVb5If+FkpHbaEGU4nYJg6DvVlhT8Uk9e2m8QtPE3i?= =?us-ascii?Q?qzlQGoIgXEgnbZ+Uo+NnUKNicNg/l28gZ1e1BZm0ElgVAmieneMC0thycaH8?= =?us-ascii?Q?L0SbfCL/wkad9Isg+sMPAORKk1pBLvfoMtfhrQDGE/Mh9BFCrllu2W0G7Jto?= =?us-ascii?Q?VonqptViqfWZRpB4U5JKVTUB7j4L3eKFA0kOa9Z1S+NXLq+B88TqKofJ1dCu?= =?us-ascii?Q?nX8buf76pa40e74LiX2iCVTB7NwX3GgRHdOyLDPL3uEk9gwqiecDwcEDunrY?= =?us-ascii?Q?7YQ9vyrcSLVZzaPkT8RBb9XBMbQPGs7HcWWgbp0YLXsmMDRKocFLHOxVl8HG?= =?us-ascii?Q?q+CXWH8ZT4OOGG5MsFB18N/K98WUvEaNCQf89ym2I0Cow9axNU6spy4V+PVE?= =?us-ascii?Q?rf4FGot7QCBjfwAK0PRoxrQe+QtenNHg5wf9pNn4Pd7ij12BCAzcqdzulg7m?= =?us-ascii?Q?y2rAP+C9GeDVR0kWsjXBIRj5INlqZlU3F5vWNO38ZLV32LUpX1qwc1atMemH?= =?us-ascii?Q?QtnJrWvTP1gqf8Mv2wmCLOSpE3N2EYPN/72P/z9t?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9328.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ee4d47d-6886-459c-084e-08dbeb2bf0e5 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2023 07:23:36.0565 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: X4iTwUEu6XfKoRUr2mgRXAujked7u669dxsF9eKboHysO23vsWHLEy4bupDSuUxHLt9d0X4nOQpeYLrunIKYlg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9312 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Tyler Retzlaff > Sent: Tuesday, November 21, 2023 10:49 PM > To: Stephen Hemminger > Cc: Hemant Agrawal ; dev@dpdk.org; Sachin > Saxena ; Gagandeep Singh > Subject: Re: [PATCH v4 10/10] common/dpaxx: remove zero length array > Importance: High >=20 > On Tue, Nov 21, 2023 at 08:46:41AM -0800, Stephen Hemminger wrote: > > On Tue, 21 Nov 2023 10:49:59 +0000 > > Hemant Agrawal wrote: > > > > > > struct ipsec_encap_pdb { > > > > uint32_t options; > > > > @@ -350,7 +349,6 @@ struct ipsec_encap_pdb { > > > > }; > > > > uint32_t spi; > > > > uint32_t ip_hdr_len; > > > > - uint8_t ip_hdr[0]; > > > [Hemant] This should be replaced with > > > uint8_t ip_hdr[]; > > > > }; > > > > > > > > That won't work because the structure is embedded in another struct > > and then clang will correctly report an error. >=20 > Hemant if the field is not referenced what's the harm in removing it? It is being used indirectly, e.g. dpaa_sec.h usages it for ip address descr= iption preparation for the hardware. struct ipsec_encap_pdb encap_pdb; union { struct ip ip4_hdr; struct rte_ipv6_hdr ip6_hdr; }; We need to change it, however in the interim, I will like to add "-Wno-gnu-= variable-sized-type-not-at-end" for both caam_jr and dpaa_sec to avoid this= warning.