From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2EC484340D; Thu, 30 Nov 2023 06:48:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B615B40297; Thu, 30 Nov 2023 06:48:45 +0100 (CET) Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2081.outbound.protection.outlook.com [40.107.249.81]) by mails.dpdk.org (Postfix) with ESMTP id DAD07400D6 for ; Thu, 30 Nov 2023 06:48:44 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FY++PLLpeWa+RArz0ntiQnRcCAnXCxqNzMVY1gR26CsoJlNoFtZO7m3DPDDBbKkbfZjFtjdDK5DxHOsQRT2x0Cx5S1RNEVWk3g42PpMMZDSObTVGvP24/KQRjWbu3Nofnzi+BpFn9+uSP8ytOL1LAEuTPE7XguI9OEW3txtVok50efqsEGq2Dg4ikjaGewjL1WU+jOQ8N5RfROcmzmUhNGaZ3yY+sjym1ABlL5Kx4VMiYsQ8HP9e+Au7NnnDeYTZcycrwYn62FZHYuo8Hhh8e9cspdanUhHHOG3AQvW0jD47bhqWT3oB8rn55gTJmTX13vZCvAYRckS7OzP5hmFHhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+VET4QTJpx4ZFpZRkKkQbtITbGy2OsjFsEIUKejrauk=; b=lsqawRp5R6lSrq8ISK79oYrE5TAOFPaPd/OVXEgMtKT4O2VXx5c0NI6A1NfSooxK2WOCmFI62SNrCzHLHlrnFjZknl7ShaXYAWL1Q5PfIN/9PmBB50dAYF+PtkVszXL44iGcFpw2UWBLcgk1tQgk7ClgzRssa6e3Uq7GlvUi0Tl9tv3jga/YXdwBX/XAb+xX7PGEEe+qQtLNhTtRTtiw13uyJ+6EaIP/V6of226BB2lw5pf1rUVhANh4Xg3nbCc75kVV4msvklMXzRdOAgkuNW9iM8LjC8YcSihuuZxQgFVCws5wGhGZrCAFRz+r/E0AtSlAXiYiDswmKo3RACEWyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+VET4QTJpx4ZFpZRkKkQbtITbGy2OsjFsEIUKejrauk=; b=DeWKt0GInlHqudnjK7qfnwg+a1GW+9OglZPsoLd4KHAzv3hVs/ERUkkMpQhB/KlHmJrhfDnGb6i765RCQyytpyCBfa1zIWpSyLMr8LAvWMmxGqDZtRLCstMvGCDGjmhokbemZhbKar5hVSBFlILHaj5iQGW85wC4xCi07Oc0pLw= Received: from PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) by AS8PR04MB7655.eurprd04.prod.outlook.com (2603:10a6:20b:292::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.13; Thu, 30 Nov 2023 05:48:40 +0000 Received: from PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::99b2:221d:bdda:3d6f]) by PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::99b2:221d:bdda:3d6f%5]) with mapi id 15.20.7046.015; Thu, 30 Nov 2023 05:48:40 +0000 From: Hemant Agrawal To: Stephen Hemminger , "dev@dpdk.org" CC: Cristian Dumitrescu , Konstantin Ananyev , David Hunt , Chengwen Feng , Kevin Laatz , Bruce Richardson , Yipeng Wang , Sameh Gobriel , Vladimir Medvedkin , Harman Kalra , Chas Williams , "Min Hu (Connor)" , Sachin Saxena , Erik Gabriel Carrillo Subject: RE: [PATCH v5 03/19] test: replace use word sanity Thread-Topic: [PATCH v5 03/19] test: replace use word sanity Thread-Index: AQHaIunqcDts3I+nqECa0tYeXG9yXLCSW7pQ Date: Thu, 30 Nov 2023 05:48:40 +0000 Message-ID: References: <20230802232550.125487-1-stephen@networkplumber.org> <20231129173122.126895-1-stephen@networkplumber.org> <20231129173122.126895-4-stephen@networkplumber.org> In-Reply-To: <20231129173122.126895-4-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PAXPR04MB9328:EE_|AS8PR04MB7655:EE_ x-ms-office365-filtering-correlation-id: 717ab37a-fcf4-4680-a8a9-08dbf1680188 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BbCgFS+KL2af8yK7Y90ISqKGKCrcXJo69y7eR1Vd+0omgL+busSJ11URSGqhlKalz4Bsqf0GC3WwhiNNLZrApe7VswLuGBldXGzVpNvdwktX0A7ySU1k3tddkhEEIncXGHCNA9VgxYaKvT/b7K/hNVQnPlYEreljg57iI+t+g1sxR1J7S2BvNWlaPjKa5ea8Uj391pncd3+IVSxNtaIer33BxfDi59yZw1KgmkHyak8dn/FpT2dQBFQMt71Jvbdv4LewcEgR+vBkUpMghxVDMJyUxXBKJsENbWEtdBwyl13IHZ3IvPkus7UKX7ZSYRuyA+zMYkfbezNrLjfUSSeVAxeCLzB/qffo4Kt+/PkTC2QwHAj49zIk8qRU+Zzva+fn/88wmeAH86VbfdrzNr0kbvMCbmAM4u6dyztei+TCYtg8GVlHSLMr517jtRCVx0YQ4tD1vZaAV81tFZ1lLYX/s14EzCA8pHtfvPMM032I1N5gNVlA2ZKInBvo5pqwZ/ik64wittPD11eekpRKfNNeCerWVxtcz1wMI+aVNFaAKJjRpv+1GOna/MmsWefyoht1ungnw0/M4PMqk/KpkvrDE51Rle3leQjzzG5aLdnvf81nzltR5a9zyb+3S7K0p7Bw+Fi0DwZ6dTq5KFUCTz2jLlG+RdkZA5zCdsoiZXQGEoA= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB9328.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(396003)(39860400002)(346002)(376002)(136003)(230922051799003)(186009)(64100799003)(1800799012)(451199024)(86362001)(44832011)(52536014)(4326008)(8936002)(8676002)(26005)(122000001)(55016003)(202311291699003)(38100700002)(41300700001)(38070700009)(76116006)(9686003)(83380400001)(5660300002)(30864003)(7416002)(2906002)(110136005)(64756008)(66556008)(66476007)(66446008)(66946007)(33656002)(478600001)(316002)(55236004)(54906003)(53546011)(6506007)(7696005)(71200400001)(579004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mVB1Gv+P+d83k+mzAdoU+2bUlp6SXxco2RMpzgFyrUyPW25JMdVDoOyD9rbZ?= =?us-ascii?Q?11MWXga7qrwka9uRMr1QiiQvho6QJZ5H0ZwWLiqKRaaa9L71EXDsG/OCMnkA?= =?us-ascii?Q?A6veZCXFnoVal3nAjN0j+BS9uFqTfT7XNTaDosKMjzb5zQncMNptu4KrUd9k?= =?us-ascii?Q?oBD35z14eK6kA3c7iUg7cjkgah3wF2fpnfoycxbNKwxjE1Z+AIf80okku61O?= =?us-ascii?Q?P16bqp4h9+tRY6QMmauh56wCVbY5j4BXZ1OcDqhKor/0/dXoU8hQWWEnaZIy?= =?us-ascii?Q?AQPeU77XaOOL6P5C+mMDtF36KWeE99xF9iYp5tnzqCjpHjLS46ayg8o/aW4V?= =?us-ascii?Q?cweMiSpUz7NoL+rezR7hOWNN1c6/NoMYuqUG5BG6FgDYl7+X4ZoWNCfEOnJu?= =?us-ascii?Q?puo2Zwg542k1niIRJ1zTttWLfyibwoIN4amEz3KB/YI8pqCGJ0wnfJGk0l3E?= =?us-ascii?Q?RCdh45A3YpNad4rtVZ11Q+FaHl5QxrkLjB2ivoCOuXLraQjylQ1TZ2WKwzYS?= =?us-ascii?Q?pUb+cQmEEVOophoRxy8S/TnaA+XdEkdakWvfSrpEmxfJ13KUE2u2mz2nAnUa?= =?us-ascii?Q?0kQsS7YMqPAQxW5xdF5U/iszJqn/yXwbjyQL31Q4YCAN/J1Kg9lv1Cv0JKjk?= =?us-ascii?Q?YqdQfPxIRjmr7syztHoSxE0zX0lEsyHs+1rwdZBaQ8T0GUYRhfe9O+ungsiE?= =?us-ascii?Q?ep+CH8YyDSWqfySE2Ne8IyRQ2/CLltiLOcKkMiq1uVsuwp7ulSc/beov/S+l?= =?us-ascii?Q?VOsOSXtEQF3ho82I7no3jBtpDoKMJ8sbNynbWa2VH+6NybYefuI0gTbs9IDU?= =?us-ascii?Q?VB9Ii0cIzUFbWLNyWQu8shJRBX/tAMdoIPTN9z2u8p0vtnx3t6GE/sbop+gh?= =?us-ascii?Q?J3JI7fjZjBGcxpGQuF3raLTTR1Kjk3pr3jTUSCrQGyE64tonmKcf/jpVw0yW?= =?us-ascii?Q?+wJZ3l90qgSFZ4MaSiS70OhIvX95Lf3/+B7fZcoNpchbCvQo8B9bivzuozPd?= =?us-ascii?Q?iLNCosImfU3UakjvtOEZ2NkhbfO8DQqOZIU0Ch8P6Ai6/tTfkLiwugqPIbwm?= =?us-ascii?Q?XaJa/x9MZ6aYk2sfsyukX0B3AZDaevD6Rmji31IvaKKYeN32QObvWyeT34m6?= =?us-ascii?Q?hevMglFS4tekoXp+r/a8JAbY1LtTk7ePbAd9HNNLnv5hgu7Sov6CxplGa+rA?= =?us-ascii?Q?GGFSvUPO87x2tCiCPMWrizU7jwFboJwENgcwoGo2rV3S1f4Q2utytcvBqWUm?= =?us-ascii?Q?2lJ3ILiLQqXM/PnU88fRlJRC0mupQZMuezkLzuiE9PdMEz0vQFULxj2fB4eq?= =?us-ascii?Q?Bbcb+A8MCL6PfEIloRSTa7J/tO1N07hcJ8rjal6zVu4qj6oSA94rD7MWP1bZ?= =?us-ascii?Q?HqsTjSB81Cd3a29HEdk8kndfz8evSq7ZJeywKXdji77FZcorxqi0QikxmYFG?= =?us-ascii?Q?ZLgu3Y+D561+cMfu1L6InOKyYLjzHN1nuwRmaC9bXDdj3hWQjnQwsZTU970C?= =?us-ascii?Q?EoIKUoQTbbQzzwstSPQtOwKVi5ube4Gmmld+YYbT6xNRMJHsw2FGqlxlW3r3?= =?us-ascii?Q?oN6B8YE4c63qXf6QajmAZRv1msJMJM1J3peM3n6h?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9328.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 717ab37a-fcf4-4680-a8a9-08dbf1680188 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2023 05:48:40.7526 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /9lQ3mdimebalpASB0KaktKtediRbM7sgH8swX8RV3myb4+2IQSeNXpBULuN+QYxpfosEpGUgi/VV7h2BepVtA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7655 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: Wednesday, November 29, 2023 10:56 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Cristian > Dumitrescu ; Konstantin Ananyev > ; David Hunt ; > Chengwen Feng ; Kevin Laatz > ; Bruce Richardson ; > Yipeng Wang ; Sameh Gobriel > ; Vladimir Medvedkin > ; Harman Kalra ; > Chas Williams ; Min Hu (Connor) ; > Sachin Saxena ; Hemant Agrawal > ; Erik Gabriel Carrillo > Subject: [PATCH v5 03/19] test: replace use word sanity > Importance: High >=20 > The word "sanity" is on the not-allowed inclusive naming list. Replace th= e > unnecessary usage in tests. >=20 > Signed-off-by: Stephen Hemminger > --- > app/test/test_bitmap.c | 4 +-- > app/test/test_bpf.c | 6 ++-- > app/test/test_common.c | 2 +- > app/test/test_distributor.c | 46 +++++++++++++++--------------- > app/test/test_dmadev.c | 2 +- > app/test/test_eal_flags.c | 20 ++++++------- > app/test/test_hash.c | 2 +- > app/test/test_interrupts.c | 9 +++--- > app/test/test_link_bonding_mode4.c | 2 +- > app/test/test_mbuf.c | 2 +- > app/test/test_rawdev.c | 2 +- > app/test/test_timer.c | 10 +++---- > 12 files changed, 54 insertions(+), 53 deletions(-) >=20 > diff --git a/app/test/test_bitmap.c b/app/test/test_bitmap.c index > bab11812c767..a074b64f2e98 100644 > --- a/app/test/test_bitmap.c > +++ b/app/test/test_bitmap.c > @@ -33,7 +33,7 @@ test_bitmap_scan_operations(struct rte_bitmap *bmp) > } >=20 > if (slab1_magic !=3D out_slab) { > - printf("Scan operation sanity failed.\n"); > + printf("Scan operation magic number check failed.\n"); > return TEST_FAILED; > } >=20 > @@ -43,7 +43,7 @@ test_bitmap_scan_operations(struct rte_bitmap *bmp) > } >=20 > if (slab2_magic !=3D out_slab) { > - printf("Scan operation sanity failed.\n"); > + printf("Scan operation magic number check failed.\n"); > return TEST_FAILED; > } >=20 > diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c index > f83e72a9adfd..ffadcece2212 100644 > --- a/app/test/test_bpf.c > +++ b/app/test/test_bpf.c > @@ -3329,9 +3329,9 @@ test_bpf_match(pcap_t *pcap, const char *str, > return ret; > } >=20 > -/* Basic sanity test can we match a IP packet */ > +/* Basic test can we match a IP packet */ > static int > -test_bpf_filter_sanity(pcap_t *pcap) > +test_bpf_filter_match(pcap_t *pcap) > { > const uint32_t plen =3D 100; > struct rte_mbuf mb, *m; > @@ -3463,7 +3463,7 @@ test_bpf_convert(void) > return -1; > } >=20 > - rc =3D test_bpf_filter_sanity(pcap); > + rc =3D test_bpf_filter_match(pcap); > for (i =3D 0; i < RTE_DIM(sample_filters); i++) > rc |=3D test_bpf_filter(pcap, sample_filters[i]); >=20 > diff --git a/app/test/test_common.c b/app/test/test_common.c index > 21eb2285e1b2..784cdaf3d640 100644 > --- a/app/test/test_common.c > +++ b/app/test/test_common.c > @@ -19,7 +19,7 @@ > {printf(x "() test failed!\n");\ > return -1;} >=20 > -/* this is really a sanity check */ > +/* this is really a consistency check */ > static int > test_macros(int __rte_unused unused_parm) { diff --git > a/app/test/test_distributor.c b/app/test/test_distributor.c index > 6cb27f4de111..915de3027bd0 100644 > --- a/app/test/test_distributor.c > +++ b/app/test/test_distributor.c > @@ -80,7 +80,7 @@ clear_packet_count(void) > __ATOMIC_RELAXED); > } >=20 > -/* this is the basic worker function for sanity test > +/* this is the basic worker function > * it does nothing but return packets and count them. > */ > static int > @@ -105,7 +105,7 @@ handle_work(void *arg) > return 0; > } >=20 > -/* do basic sanity testing of the distributor. This test tests the follo= wing: > +/* do basic testing of the distributor. This test tests the following: > * - send 32 packets through distributor with the same tag and ensure th= ey > * all go to the one worker > * - send 32 packets through the distributor with two different tags and= @@ > -117,7 +117,7 @@ handle_work(void *arg) > * not necessarily in the same order (as different flows). > */ > static int > -sanity_test(struct worker_params *wp, struct rte_mempool *p) > +basic_test(struct worker_params *wp, struct rte_mempool *p) > { > struct rte_distributor *db =3D wp->dist; > struct rte_mbuf *bufs[BURST]; > @@ -126,7 +126,7 @@ sanity_test(struct worker_params *wp, struct > rte_mempool *p) > unsigned int retries; > unsigned int processed; >=20 > - printf("=3D=3D=3D Basic distributor sanity tests =3D=3D=3D\n"); > + printf("=3D=3D=3D Basic distributor tests =3D=3D=3D\n"); > clear_packet_count(); > if (rte_mempool_get_bulk(p, (void *)bufs, BURST) !=3D 0) { > printf("line %d: Error getting mbufs from pool\n", __LINE__); > @@ -163,7 +163,7 @@ sanity_test(struct worker_params *wp, struct > rte_mempool *p) > printf("Worker %u handled %u packets\n", i, > __atomic_load_n(&worker_stats[i].handled_packets, > __ATOMIC_RELAXED)); > - printf("Sanity test with all zero hashes done.\n"); > + printf("Test with all zero hashes done.\n"); >=20 > /* pick two flows and check they go correctly */ > if (rte_lcore_count() >=3D 3) { > @@ -191,7 +191,7 @@ sanity_test(struct worker_params *wp, struct > rte_mempool *p) > __atomic_load_n( > &worker_stats[i].handled_packets, > __ATOMIC_RELAXED)); > - printf("Sanity test with two hash values done\n"); > + printf("Test with two hash values done\n"); > } >=20 > /* give a different hash value to each packet, @@ -219,11 +219,11 > @@ sanity_test(struct worker_params *wp, struct rte_mempool *p) > printf("Worker %u handled %u packets\n", i, > __atomic_load_n(&worker_stats[i].handled_packets, > __ATOMIC_RELAXED)); > - printf("Sanity test with non-zero hashes done\n"); > + printf("Test with non-zero hashes done\n"); >=20 > rte_mempool_put_bulk(p, (void *)bufs, BURST); >=20 > - /* sanity test with BIG_BATCH packets to ensure they all arrived back > + /* test with BIG_BATCH packets to ensure they all arrived back > * from the returned packets function */ > clear_packet_count(); > struct rte_mbuf *many_bufs[BIG_BATCH], > *return_bufs[BIG_BATCH]; @@ -288,7 +288,7 @@ sanity_test(struct > worker_params *wp, struct rte_mempool *p) > return -1; > } > } > - printf("Sanity test of returned packets done\n"); > + printf("Test of returned packets done\n"); >=20 > rte_mempool_put_bulk(p, (void *)many_bufs, BIG_BATCH); >=20 > @@ -326,20 +326,20 @@ handle_work_with_free_mbufs(void *arg) > return 0; > } >=20 > -/* Perform a sanity test of the distributor with a large number of packe= ts, > +/* Perform a test of the distributor with a large number of packets, > * where we allocate a new set of mbufs for each burst. The workers then > * free the mbufs. This ensures that we don't have any packet leaks in t= he > * library. > */ > static int > -sanity_test_with_mbuf_alloc(struct worker_params *wp, struct > rte_mempool *p) > +basic_test_with_mbuf_alloc(struct worker_params *wp, struct > rte_mempool > +*p) > { > struct rte_distributor *d =3D wp->dist; > unsigned i; > struct rte_mbuf *bufs[BURST]; > unsigned int processed; >=20 > - printf("=3D=3D=3D Sanity test with mbuf alloc/free (%s) =3D=3D=3D\n", w= p->name); > + printf("=3D=3D=3D Test with mbuf alloc/free (%s) =3D=3D=3D\n", wp->name= ); >=20 > clear_packet_count(); > for (i =3D 0; i < ((1< @@ sanity_test_with_mbuf_alloc(struct worker_params *wp, struct > rte_mempool *p) > return -1; > } >=20 > - printf("Sanity test with mbuf alloc/free passed\n\n"); > + printf("Test with mbuf alloc/free passed\n\n"); > return 0; > } >=20 > @@ -433,13 +433,13 @@ handle_work_for_shutdown_test(void *arg) } >=20 >=20 > -/* Perform a sanity test of the distributor with a large number of packe= ts, > +/* Perform a test of the distributor with a large number of packets, > * where we allocate a new set of mbufs for each burst. The workers then > * free the mbufs. This ensures that we don't have any packet leaks in t= he > * library. > */ > static int > -sanity_test_with_worker_shutdown(struct worker_params *wp, > +basic_test_with_worker_shutdown(struct worker_params *wp, > struct rte_mempool *p) > { > struct rte_distributor *d =3D wp->dist; > @@ -449,7 +449,7 @@ sanity_test_with_worker_shutdown(struct > worker_params *wp, > unsigned int failed =3D 0; > unsigned int processed =3D 0; >=20 > - printf("=3D=3D=3D Sanity test of worker shutdown =3D=3D=3D\n"); > + printf("=3D=3D=3D Test of worker shutdown =3D=3D=3D\n"); >=20 > clear_packet_count(); >=20 > @@ -515,7 +515,7 @@ sanity_test_with_worker_shutdown(struct > worker_params *wp, > if (failed) > return -1; >=20 > - printf("Sanity test with worker shutdown passed\n\n"); > + printf("Test with worker shutdown passed\n\n"); > return 0; > } >=20 > @@ -611,13 +611,13 @@ handle_and_mark_work(void *arg) > return 0; > } >=20 > -/* sanity_mark_test sends packets to workers which mark them. > +/* mark_test sends packets to workers which mark them. > * Every packet has also encoded sequence number. > * The returned packets are sorted and verified if they were handled > * by proper workers. > */ > static int > -sanity_mark_test(struct worker_params *wp, struct rte_mempool *p) > +mark_test(struct worker_params *wp, struct rte_mempool *p) > { > const unsigned int buf_count =3D 24; > const unsigned int burst =3D 8; > @@ -898,13 +898,13 @@ test_distributor(void) >=20 > rte_eal_mp_remote_launch(handle_work, > &worker_params, SKIP_MAIN); > - if (sanity_test(&worker_params, p) < 0) > + if (basic_test(&worker_params, p) < 0) > goto err; > quit_workers(&worker_params, p); >=20 >=20 > rte_eal_mp_remote_launch(handle_work_with_free_mbufs, > &worker_params, SKIP_MAIN); > - if (sanity_test_with_mbuf_alloc(&worker_params, p) < 0) > + if (basic_test_with_mbuf_alloc(&worker_params, p) < 0) > goto err; > quit_workers(&worker_params, p); >=20 > @@ -912,7 +912,7 @@ test_distributor(void) >=20 > rte_eal_mp_remote_launch(handle_work_for_shutdown_test, > &worker_params, > SKIP_MAIN); > - if > (sanity_test_with_worker_shutdown(&worker_params, > + if > (basic_test_with_worker_shutdown(&worker_params, > p) < 0) > goto err; > quit_workers(&worker_params, p); > @@ -927,7 +927,7 @@ test_distributor(void) >=20 >=20 > rte_eal_mp_remote_launch(handle_and_mark_work, > &worker_params, SKIP_MAIN); > - if (sanity_mark_test(&worker_params, p) < 0) > + if (mark_test(&worker_params, p) < 0) > goto err; > quit_workers(&worker_params, p); >=20 > diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c index > 7581fc2b4cb0..899786b345ed 100644 > --- a/app/test/test_dmadev.c > +++ b/app/test/test_dmadev.c > @@ -1087,7 +1087,7 @@ test_dma(void) >=20 > parse_dma_env_var(); >=20 > - /* basic sanity on dmadev infrastructure */ > + /* basic validation on dmadev infrastructure */ > if (test_apis() < 0) > ERR_RETURN("Error performing API tests\n"); >=20 > diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c index > 6cb4b0675730..9c082ff91496 100644 > --- a/app/test/test_eal_flags.c > +++ b/app/test/test_eal_flags.c > @@ -314,7 +314,7 @@ get_number_of_sockets(void) >=20 > /* > * Test that the app doesn't run with invalid allow option. > - * Final tests ensures it does run with valid options as sanity check (o= ne > + * Final tests ensures it does run with valid options as basic test > + (one > * test for with Domain+BDF, second for just with BDF) > */ > static int > @@ -382,7 +382,7 @@ test_allow_flag(void) >=20 > /* > * Test that the app doesn't run with invalid blocklist option. > - * Final test ensures it does run with valid options as sanity check > + * Final test ensures it does run with valid options as basic check. > */ > static int > test_invalid_b_flag(void) > @@ -429,7 +429,7 @@ test_invalid_b_flag(void) >=20 > /* > * Test that the app doesn't run with invalid vdev option. > - * Final test ensures it does run with valid options as sanity check > + * Final test ensures it does run with valid options basic check. > */ > static int > test_invalid_vdev_flag(void) > @@ -554,7 +554,7 @@ test_missing_c_flag(void) > /* bad coremask value */ > const char *argv3[] =3D { prgname, prefix, mp_flag, > "-c", "error" }; > - /* sanity check of tests - valid coremask value */ > + /* check of tests - valid coremask value */ > const char *argv4[] =3D { prgname, prefix, mp_flag, > "-c", "1" }; > /* -l flag but no corelist value */ > @@ -581,7 +581,7 @@ test_missing_c_flag(void) > "-l", RTE_STR(RTE_MAX_LCORE) }; > const char * const argv14[] =3D { prgname, prefix, mp_flag, > "-l", "1-"RTE_STR(RTE_MAX_LCORE) }; > - /* sanity check test - valid corelist value */ > + /* check test - valid corelist value */ > const char * const argv15[] =3D { prgname, prefix, mp_flag, > "-l", "1-2,3" }; >=20 > @@ -613,7 +613,7 @@ test_missing_c_flag(void) > "--lcores", "(4-7)=3D(1,3)" }; > const char * const argv28[] =3D { prgname, prefix, mp_flag, > "--lcores", "[4-7]@(1,3)" }; > - /* sanity check of tests - valid lcores value */ > + /* more complex valid lcores value */ > const char * const argv29[] =3D { prgname, prefix, mp_flag, > "--lcores", > "0-1,2@(5-7),(3-5)@(0,2),(0,6),7"}; > @@ -744,7 +744,7 @@ test_main_lcore_flag(void) >=20 > /* > * Test that the app doesn't run with invalid -n flag option. > - * Final test ensures it does run with valid options as sanity check > + * Final test ensures it does run with valid options as basic check. > * Since -n is not compulsory for MP, we instead use --no-huge and --no- > shconf > * flags. > */ > @@ -772,10 +772,10 @@ test_invalid_n_flag(void) > /* zero is invalid */ > const char *argv3[] =3D { prgname, prefix, no_huge, no_shconf, > "-n", "0" }; > - /* sanity test - check with good value */ > + /* check with good value */ > const char *argv4[] =3D { prgname, prefix, no_huge, no_shconf, > "-n", "2" }; > - /* sanity test - check with no -n flag */ > + /* check with no -n flag */ > const char *argv5[] =3D { prgname, prefix, no_huge, no_shconf}; >=20 > if (launch_proc(argv1) =3D=3D 0 > @@ -977,7 +977,7 @@ test_misc_flags(void) > * All cases, apart from the first, app should run. > * No further testing of output done. > */ > - /* sanity check - failure with invalid option */ > + /* failure with invalid option */ > const char *argv0[] =3D {prgname, prefix, mp_flag, "--invalid-opt"}; >=20 > /* With --no-pci */ > diff --git a/app/test/test_hash.c b/app/test/test_hash.c index > d586878a2244..54e751b5eede 100644 > --- a/app/test/test_hash.c > +++ b/app/test/test_hash.c > @@ -1088,7 +1088,7 @@ fbk_hash_unit_test(void) > .socket_id =3D 0, > }; >=20 > - /* this is a sanity check for "same name" test > + /* this is a check for "same name" test > * creating this hash will check if we are actually able to create > * multiple hashes with different names (instead of having just one). > */ > diff --git a/app/test/test_interrupts.c b/app/test/test_interrupts.c inde= x > 3952f9685fd9..42b830e9368a 100644 > --- a/app/test/test_interrupts.c > +++ b/app/test/test_interrupts.c > @@ -48,7 +48,7 @@ static union intr_pipefds pfds; > * Check if the interrupt handle is valid. > */ > static inline int > -test_interrupt_handle_sanity_check(struct rte_intr_handle *intr_handle) > +test_interrupt_handle_check(struct rte_intr_handle *intr_handle) > { > if (!intr_handle || rte_intr_fd_get(intr_handle) < 0) > return -1; > @@ -164,7 +164,7 @@ test_interrupt_handle_compare(struct > rte_intr_handle *intr_handle_l, #else > /* to be implemented for bsd later */ > static inline int > -test_interrupt_handle_sanity_check(struct rte_intr_handle *intr_handle) > +test_interrupt_handle_check(struct rte_intr_handle *intr_handle) > { > RTE_SET_USED(intr_handle); >=20 > @@ -215,7 +215,7 @@ test_interrupt_callback(void *arg) > return; > } >=20 > - if (test_interrupt_handle_sanity_check(intr_handle) < 0) { > + if (test_interrupt_handle_check(intr_handle) < 0) { > printf("null or invalid intr_handle for %s\n", __func__); > flag =3D -1; > return; > @@ -241,7 +241,8 @@ static void > test_interrupt_callback_1(void *arg) > { > struct rte_intr_handle *intr_handle =3D arg; > - if (test_interrupt_handle_sanity_check(intr_handle) < 0) { > + > + if (test_interrupt_handle_check(intr_handle) < 0) { > printf("null or invalid intr_handle for %s\n", __func__); > flag =3D -1; > return; > diff --git a/app/test/test_link_bonding_mode4.c > b/app/test/test_link_bonding_mode4.c > index ff13dbed93f3..299b89f669ee 100644 > --- a/app/test/test_link_bonding_mode4.c > +++ b/app/test/test_link_bonding_mode4.c > @@ -224,7 +224,7 @@ add_member(struct member_conf *member, > uint8_t start) > struct rte_ether_addr addr, addr_check; > int retval; >=20 > - /* Some sanity check */ > + /* Some basic tests. */ > RTE_VERIFY(test_params.member_ports <=3D member && > member - test_params.member_ports < > (int)RTE_DIM(test_params.member_ports)); > RTE_VERIFY(member->bonding =3D=3D 0); > diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index > 261c6e5d71e9..7c73880090d4 100644 > --- a/app/test/test_mbuf.c > +++ b/app/test/test_mbuf.c > @@ -1701,7 +1701,7 @@ test_mbuf_validate_tx_offload(const char > *test_name, > struct rte_mbuf *m =3D NULL; > int ret =3D 0; >=20 > - /* alloc a mbuf and do sanity check */ > + /* alloc a mbuf and do some basic checks */ > m =3D rte_pktmbuf_alloc(pktmbuf_pool); > if (m =3D=3D NULL) > GOTO_FAIL("%s: mbuf allocation failed!\n", __func__); diff -- > git a/app/test/test_rawdev.c b/app/test/test_rawdev.c index > d34691dacf5f..0d4f0ce1fa17 100644 > --- a/app/test/test_rawdev.c > +++ b/app/test/test_rawdev.c > @@ -47,7 +47,7 @@ test_rawdev_selftests(void) > int ret =3D 0; > int i; >=20 > - /* basic sanity on rawdev infrastructure */ > + /* basic check on rawdev infrastructure */ > if (test_rawdev_selftest_skeleton() < 0) > return -1; >=20 [Hemant]=20 Acked-by: Hemant Agrawal