Re: [dpdk-dev] [EXT] Re: [PATCH v6 3/5] net/enetfec: support queue configuration

[Apeksha Gupta <apeksha.gupta@nxp.com>]

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Wednesday, October 27, 2021 7:53 PM
> To: Apeksha Gupta <apeksha.gupta@nxp.com>; david.marchand@redhat.com;
> andrew.rybchenko@oktetlabs.ru; ferruh.yigit@intel.com
> Cc: dev@dpdk.org; Sachin Saxena <sachin.saxena@nxp.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>
> Subject: [EXT] Re: [dpdk-dev] [PATCH v6 3/5] net/enetfec: support queue
> configuration
> 
> Caution: EXT Email
> 
> On 10/21/2021 5:46 AM, Apeksha Gupta wrote:
> > This patch adds Rx/Tx queue configuration setup operations.
> > On packet reception the respective BD Ring status bit is set
> > which is then used for packet processing.
> >
> > Signed-off-by: Sachin Saxena <sachin.saxena@nxp.com>
> > Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>
> 
> <...>
> 
> >
> > +/* Supported Rx offloads */
> > +static uint64_t dev_rx_offloads_sup =
> > +             DEV_RX_OFFLOAD_IPV4_CKSUM |
> > +             DEV_RX_OFFLOAD_UDP_CKSUM |
> > +             DEV_RX_OFFLOAD_TCP_CKSUM |
> > +             DEV_RX_OFFLOAD_VLAN_STRIP |
> > +             DEV_RX_OFFLOAD_CHECKSUM;
> > +
> > +static uint64_t dev_tx_offloads_sup =
> > +             DEV_TX_OFFLOAD_IPV4_CKSUM |
> > +             DEV_TX_OFFLOAD_UDP_CKSUM |
> > +             DEV_TX_OFFLOAD_TCP_CKSUM;
> > +
> 
> The macro names are updated in ethdev, can you please update them?
> 
> 
> Also these offloads are advertised, but some of them are not
> checked anywhere in the driver, like 'DEV_TX_OFFLOAD_*_CKSUM'.
> Are they really supported?
> If they are not supported in the datapath, please don't advertise
> them.
[Apeksha] Sure, we will update the macro names and remove all unused offloads.