From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46DC8A09E4; Thu, 21 Jan 2021 11:38:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F1A70140CFC; Thu, 21 Jan 2021 11:38:26 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 8E9E6140D07 for ; Wed, 20 Jan 2021 14:01:46 +0100 (CET) IronPort-SDR: JtID4hpwfC7ntRRlU2jkwF6zwAbkTwAOOriPDWdMPJEv5KGM9EcWEx4rtNHtT/i5A6bV39JOvM mrYhTuVmAefA== X-IronPort-AV: E=McAfee;i="6000,8403,9869"; a="158874547" X-IronPort-AV: E=Sophos;i="5.79,361,1602572400"; d="scan'208";a="158874547" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2021 05:01:43 -0800 IronPort-SDR: 6kHsOPCtwAoUjXHjfFOIZXVRm3vqfw92VufyTOdKdS9qZEnLXtjymSSjkwwZemvfyG+K/yPokJ u0JzK4CBRLVw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,361,1602572400"; d="scan'208";a="573885734" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP; 20 Jan 2021 05:01:43 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 20 Jan 2021 05:01:43 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 20 Jan 2021 05:01:43 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 20 Jan 2021 05:01:43 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 20 Jan 2021 05:01:43 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nirttlJfiUGYyk6fhiBt5bWsHVg8Eta1erG1PeD3J3gyCDEi6DI+W3j8yjzNfX4m9MMUpqWjDRWyouXygG/kPu/kAGQdUyzQFPmgE0VqPCxxHYa+ezLCRzFoOPGeAoNyzUkKDfxPDde93Daxq3nkz+g5Hu0UmZIlrTHHrbO0Vg4qjvrkA5+tN6XZuVmK+4xQdqIhHtD8EmSq4YvwOdV/3mmyDJhQoxn1Cew3+GLPRfsXJuRzL0sJoBnjPImgQBQetAZkSpbj3f9ijJOEFs46WJ0uDqZPlteWGnaPTVSkWYhO6qdHjZjRJ5A8BfELdvHC/nAYydYo4pNG3VooEY8ylw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=udEOmEAZKUvWiqLDhKkSAEBsJ6XLOoslsnyIPPvn18o=; b=Gt+iDN9n27/iIG6/sXW1tJV4GrBo9cvDKtS0+SpW4WMFHIG58ZDMYdO6gFWnbTJGN/WUaTCPvCAqOBKbNrnhA11EpRfXkuYQb5ftrf3MaQVL9GxzRLy+ZJLwvp/8Nj2ABN9N0kdfEuipm2qwBH5KRUqWYX12+UCF5UajEmwvcGh4i1Mx2H2Q7oKPv6AunZFGGKEIQABab6IEgKC1Z8843ay7Fdo/mckkolCS4IGbty/axoj+eCBa8TovEF96kYP9Xwf4x3CzfHJl9P4IJLStUhXBbuWR7rwe2/cgQsAltkvQmkhYyDk/HXBerowjD+qmQw57xbWz8bx/uhWnUSOs3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=udEOmEAZKUvWiqLDhKkSAEBsJ6XLOoslsnyIPPvn18o=; b=FLQLYj2FeBwZhaJxTSYCRkIW+aoQblbpdpHK7UWVi2Bnhmlow24YGaFAFmnJFHVTMqD9lwD8QIJT1aXD3l8cQ0ueXTKpqGuGsRubJAXQbjgX+l3iUeAdOm7NhqwZGQlGCTyW0mdpfeBSanbV4tYmLn+WQbwX1Vx1Zagq/HnJohI= Received: from PH0PR11MB4776.namprd11.prod.outlook.com (2603:10b6:510:30::14) by PH0PR11MB4872.namprd11.prod.outlook.com (2603:10b6:510:32::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.11; Wed, 20 Jan 2021 13:01:42 +0000 Received: from PH0PR11MB4776.namprd11.prod.outlook.com ([fe80::516d:3e18:d496:487e]) by PH0PR11MB4776.namprd11.prod.outlook.com ([fe80::516d:3e18:d496:487e%2]) with mapi id 15.20.3763.015; Wed, 20 Jan 2021 13:01:42 +0000 From: "Kinsella, Ray" To: Thomas Monjalon , "Gujjar, Abhinandan S" CC: "dev@dpdk.org" , "Ananyev, Konstantin" , Akhil Goyal , "aconole@redhat.com" , "david.marchand@redhat.com" Thread-Topic: [dpdk-dev] [PATCH v7 1/2] cryptodev: support enqueue and dequeue callback functions Thread-Index: AQHW7pFrfIVZaKiL1kCiG9GHMpi77aowMhhA Date: Wed, 20 Jan 2021 13:01:42 +0000 Message-ID: References: <20201222144243.552262-1-abhinandan.gujjar@intel.com> <20201222144243.552262-2-abhinandan.gujjar@intel.com> <5458566.rWvySYnu6v@thomas> In-Reply-To: <5458566.rWvySYnu6v@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [89.124.12.13] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f4e7a202-80f2-4196-14e2-08d8bd438886 x-ms-traffictypediagnostic: PH0PR11MB4872: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 28mstIgxFNFwMSekFYYl8QV3Z15jMaD/ucjdpWYVGm+bx8B+5JewpfwUs7VdDfkebXaj8QTKHGmCD7CW2Vw5CbINKsftyQgSE5kMWVngHAp4HKQcxQMfxTXeG2e+uqwKhEwYsQ0qQLANmdlrKF73EICejd1eTbdhvNb4Ibv6bBP/F9bBTrbl6tcuKAzl/hXOzUJOfSYsOvYgnRQyjkfLz3EVfz6pSr/hfCWSNUV2LiRBdKllLbmsVmj4nkVWFDoYemq6muHSJORHTM0ksSwo9mUoaCa5sHagngPEWeICG+pTT43TrROcUQ/oq581SXok+ynJ2HCD4bAvRvrpZtZMZy6L+TPY4zTTBX08u2QLBAuVBYfuMyAhadAjy1LvTcvMkx8iz1TKEIWQ/q/aMsw87g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB4776.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(396003)(346002)(39860400002)(136003)(366004)(478600001)(86362001)(6506007)(2906002)(52536014)(53546011)(110136005)(66946007)(71200400001)(6636002)(76116006)(5660300002)(66556008)(66446008)(8676002)(33656002)(54906003)(26005)(83380400001)(66476007)(64756008)(8936002)(55016002)(4326008)(186003)(316002)(7696005)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?IhCjI9mRyGwaxZl//c+MDT+eDM5UGKE1bCOW5XvU4CePwllu9XDreMYlbqRP?= =?us-ascii?Q?IH6y9+wbvXEyUEOFmlCSnNIjfKIHIyQWrE0iwpZHXdKi/3PL6PASO9NJEFvh?= =?us-ascii?Q?Hs6W6loozVJB9fY2NzadzK6yoLdEcG8WTiD/s19hFTu+CXxNB/axPI0yNlBr?= =?us-ascii?Q?NxxEUOVQQfFoHIv3b+5db/mG/b9DynSWNp2Py/bMkHsNJX7P9uOkwgg3+0ow?= =?us-ascii?Q?iJyjrbr2VgXPClPEhMSxa7W1WN9Jh5wZl6g/uo/yAcxi3UIxiOHr9mubo/kY?= =?us-ascii?Q?MQsO+AbTBRHs73lHGl+gDuCf2DRi0oorvDQu83p38nTANyyk71DmjsamRu2Z?= =?us-ascii?Q?ikY1H40EPsx7OoUMig4fJ8kCNBkE2qKUcMPuIC2N8iltfIiEmf7/ipOvvKDI?= =?us-ascii?Q?XDTL+3bEFQeUflBSa1N3Qloj+QkUlDc2wJEnk2OUGBmOj2NimGQMKVThfgYU?= =?us-ascii?Q?tpAAH3TZuoTq1YqQwoAJivXz7awFqwLuwgYn25r8AxqRz0Q2uvhbf8qPJu58?= =?us-ascii?Q?SvRCPydGA1DaDjj6h000d2XfRTKgPhoVR1JamTLKVQVxCVlilIyk9hG8OrER?= =?us-ascii?Q?uTEA1VZa4dUxe7v0aOVE3Qo5oyzDnNTkk9LXFnh4LrmQJ5LLnXDsSDONVnWH?= =?us-ascii?Q?PuWD1LCzG6Aa/2w1afZidfgDqJiKABrCn9Ciuz3sE/wgwxg4FuKfX+O/104F?= =?us-ascii?Q?WKmQEci+sr6rkAxDKPDwn5lt+WB3k6cQlWqSqVTHPFi8r7Jo2QBAoiYHGOKy?= =?us-ascii?Q?GbADSG1KGPJYBsGVfeNmrOTpbH9G9wOUOPetz3AroiS2sWhmM9o+t8HV+ch9?= =?us-ascii?Q?0evJu+DpRd7W2gC1dGk7DDVhFpZK3nxJGfpFdTRcAc2bxoJGacIA0ioi8VVf?= =?us-ascii?Q?nNXzkegzjKWyAgIHplQUymOzT+TigeT4WsRAZE8jA/y45e4LX3M6HaeSy+p8?= =?us-ascii?Q?xYQTw6nT1OsDcdp2Mh9NeDRcKoRXeTM7aNrR7sVmwp6wR8wRNASzHDJcKLWb?= =?us-ascii?Q?/xGQwP2979N9OZApIjANPgmBxyD9MpDB2FEUV2HIgNgrUGaPb4RD7W9xnwNF?= =?us-ascii?Q?3FvqNhbX?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4776.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4e7a202-80f2-4196-14e2-08d8bd438886 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jan 2021 13:01:42.2219 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PYfl2gISRqtUusKPgHkdtNhmvncf9b3rW6nhje+KxxvA8+R93gQSKRUBWVR6Cn4rxrfIl9qELLNbIOm6XPXMDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4872 X-OriginatorOrg: intel.com X-Mailman-Approved-At: Thu, 21 Jan 2021 11:38:26 +0100 Subject: Re: [dpdk-dev] [PATCH v7 1/2] cryptodev: support enqueue and dequeue callback functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday 19 January 2021 18:32 > To: Gujjar, Abhinandan S > Cc: dev@dpdk.org; Ananyev, Konstantin ; > Akhil Goyal ; Kinsella, Ray > ; aconole@redhat.com; david.marchand@redhat.com > Subject: Re: [dpdk-dev] [PATCH v7 1/2] cryptodev: support enqueue and > dequeue callback functions >=20 > 15/01/2021 17:01, Akhil Goyal: > > > This patch adds APIs to add/remove callback functions on crypto > > > enqueue/dequeue burst. The callback function will be called for > each > > > burst of crypto ops received/sent on a given crypto device queue > > > pair. > > > > > > Signed-off-by: Abhinandan Gujjar > > > Acked-by: Konstantin Ananyev > > > --- > > Series applied to dpdk-next-crypto >=20 >=20 > It is missing a rule to ignore the false positive ABI break: >=20 > --- a/devtools/libabigail.abignore > +++ b/devtools/libabigail.abignore > @@ -11,3 +11,8 @@ > ; Explicit ignore for driver-only ABI > [suppress_type] > name =3D eth_dev_ops > + > +; Ignore fields inserted in cacheline boundary of rte_cryptodev > +[suppress_type] > + name =3D rte_cryptodev > + has_data_member_inserted_between =3D {0, 1023} >=20 This is a bit of a blunt instrument as the range quiet large? {offset_after(attached), end} instead works better - I will send a patch. > I'll add this change while pulling in the main tree. >=20 BTW - can people use ashroe.eu, not intel.com for ABI stuff.=20 Ray K