DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhou, Xiangyun" <xiangyun.zhou@intel.com>
To: Konstantin Ananyev <konstantin.ananyev@huawei.com>,
	Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Xu, Bowen" <bowen.xu@intel.com>
Subject: RE: C++20 report error at file rte_spinlock.h
Date: Tue, 20 Dec 2022 02:11:42 +0000	[thread overview]
Message-ID: <PH0PR11MB4776589C0F34EF38D0FF8093F2EA9@PH0PR11MB4776.namprd11.prod.outlook.com> (raw)
In-Reply-To: <a57e2a6a2ef04934b1d9ce4a5ce3e8c2@huawei.com>

Thanks very much  for Konstantin and Tyler's analyzing.

I agree that removal of 'volatile' is enough. A spinlock has already used to protect these variables.

-----Original Message-----
From: Konstantin Ananyev <konstantin.ananyev@huawei.com> 
Sent: Tuesday, December 20, 2022 12:51 AM
To: Tyler Retzlaff <roretzla@linux.microsoft.com>; Zhou, Xiangyun <xiangyun.zhou@intel.com>
Cc: dev@dpdk.org; Xu, Bowen <bowen.xu@intel.com>
Subject: RE: C++20 report error at file rte_spinlock.h


> On Tue, Dec 13, 2022 at 06:11:06AM +0000, Zhou, Xiangyun wrote:
> > Dear dpdk dev,
> >
> > I'm using dpdk 21.11 LTS, when compile my program with CPP flag 
> > "-std=c++20", the compiler report below errors. After checking file
> rte_spinlock.h, I think the error report by compiler is valid, there 
> should be a potential issue when using functions 
> rte_spinlock_recursive_lock, rte_spinlock_recursive_unlock and 
> rte_spinlock_recursive_trylock in multi-thread, we could either remove "volatile" definition to ask users to handle the multi-thread issue, or using atomic operatings instead of self-increment and self-decrement.
> >
> >
> > /home/dpdk/lib/eal/include/generic/rte_spinlock.h:221:12: error: 
> > increment of object of volatile-qualified type 'volatile int' is
> deprecated [-Werror,-Wdeprecated-volatile]
> >         slr->count++;
> >                   ^
> > /home/dpdk/lib/eal/include/generic/rte_spinlock.h:231:6: error: 
> > decrement of object of volatile-qualified type 'volatile int' is
> deprecated [-Werror,-Wdeprecated-volatile]
> >         if (--(slr->count) == 0) {
> >             ^
> > /home/dpdk/lib/eal/include/generic/rte_spinlock.h:255:12: error: 
> > increment of object of volatile-qualified type 'volatile int' is
> deprecated [-Werror,-Wdeprecated-volatile]
> >         slr->count++;
> >
> 
> i have work in progress to optionally use standard atomics but in the 
> meantime the correct thing to do here is to use the gcc builtins that 
> match the requirements of the c++11 memory model.
> 
> the code should be converted to use __atomic_fetch_{add,sub} or 
> __atomic_{add,sub}_fetch as appropriate.
> 
> ty.

From looking at the code, I don't think it is necessary:
both 'user' and 'count' supposed to be protected by 'sl'.
In fact, it looks safe just to remove 'volatile' qualifier here.
 


  reply	other threads:[~2022-12-21 10:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-13  6:11 Zhou, Xiangyun
2022-12-19 16:30 ` Tyler Retzlaff
2022-12-19 16:51   ` Konstantin Ananyev
2022-12-20  2:11     ` Zhou, Xiangyun [this message]
2022-12-21 16:37       ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR11MB4776589C0F34EF38D0FF8093F2EA9@PH0PR11MB4776.namprd11.prod.outlook.com \
    --to=xiangyun.zhou@intel.com \
    --cc=bowen.xu@intel.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@huawei.com \
    --cc=roretzla@linux.microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).