From: "Kinsella, Ray" <ray.kinsella@intel.com>
To: Mohsin Kazmi <mohsin.kazmi14@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
Olivier Matz <olivier.matz@6wind.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>,
Tomasz Kulasek <tomaszx.kulasek@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net: prepare the outer ipv4 hdr for checksum
Date: Tue, 29 Jun 2021 17:24:46 +0000 [thread overview]
Message-ID: <PH0PR11MB47765C490FBE28B18A2EB92A90029@PH0PR11MB4776.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210629170658.19452-1-mohsin.kazmi14@gmail.com>
Please mark [PATCH v2], and record changes under the ---
Ray K
> -----Original Message-----
> From: Mohsin Kazmi <mohsin.kazmi14@gmail.com>
> Sent: Tuesday 29 June 2021 18:07
> To: dev@dpdk.org
> Cc: Kinsella, Ray <ray.kinsella@intel.com>; Mohsin Kazmi
> <mohsin.kazmi14@gmail.com>; stable@dpdk.org; Olivier Matz
> <olivier.matz@6wind.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Thomas Monjalon
> <thomas.monjalon@6wind.com>; Tomasz Kulasek <tomaszx.kulasek@intel.com>
> Subject: [PATCH] net: prepare the outer ipv4 hdr for checksum
>
> Preparation the headers for the hardware offload misses the outer ipv4
> checksum offload.
> It results in bad checksum computed by hardware NIC.
>
> This patch fixes the issue by setting the outer ipv4 checksum field to
> 0.
>
> Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Mohsin Kazmi <mohsin.kazmi14@gmail.com>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> lib/net/rte_net.h | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/lib/net/rte_net.h b/lib/net/rte_net.h index
> 434435ffa2..e47365099e 100644
> --- a/lib/net/rte_net.h
> +++ b/lib/net/rte_net.h
> @@ -128,8 +128,18 @@ rte_net_intel_cksum_flags_prepare(struct rte_mbuf
> *m, uint64_t ol_flags)
> if (!(ol_flags & (PKT_TX_IP_CKSUM | PKT_TX_L4_MASK |
> PKT_TX_TCP_SEG)))
> return 0;
>
> - if (ol_flags & (PKT_TX_OUTER_IPV4 | PKT_TX_OUTER_IPV6))
> + if (ol_flags & (PKT_TX_OUTER_IPV4 | PKT_TX_OUTER_IPV6)) {
> inner_l3_offset += m->outer_l2_len + m->outer_l3_len;
> + /*
> + * prepare outer ipv4 header checksum by setting it to 0,
> + * in order to be computed by hardware NICs.
> + */
> + if (ol_flags & PKT_TX_OUTER_IP_CKSUM) {
> + ipv4_hdr = rte_pktmbuf_mtod_offset(m,
> + struct rte_ipv4_hdr *, m->outer_l2_len);
> + ipv4_hdr->hdr_checksum = 0;
> + }
> + }
>
> /*
> * Check if headers are fragmented.
> --
> 2.17.1
next prev parent reply other threads:[~2021-06-30 6:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 17:06 Mohsin Kazmi
2021-06-29 17:24 ` Kinsella, Ray [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-06-24 15:28 Mohsin Kazmi
2021-06-29 11:54 ` Zhang, Qi Z
2021-06-24 15:14 Mohsin Kazmi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB47765C490FBE28B18A2EB92A90029@PH0PR11MB4776.namprd11.prod.outlook.com \
--to=ray.kinsella@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=mohsin.kazmi14@gmail.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
--cc=thomas.monjalon@6wind.com \
--cc=tomaszx.kulasek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).