From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D73DA00BE; Thu, 17 Feb 2022 14:34:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6A42140150; Thu, 17 Feb 2022 14:34:49 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 3385340042; Thu, 17 Feb 2022 14:34:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645104887; x=1676640887; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=LS+Y684SpFN0xEKh9wIL/hIsS+nBKtQilO9QzcLteTA=; b=brpoAezn2eJzikUKB/Re3KksJzMastqKNpnRkYEfTuNyhpb7+9VB2hs7 PrWjwZ02Gie5kJh5O02siQsSs6w8ts3nYKIuuFtRYDUFypSqLtAwfo3XP iN5JNigR913WndqgbqFtSHDn8g3GjXDZeDZwWS/ZYIiKR0U1kZl8lTxyg Zun1W9P4zsiBN+CCSOwzsC15O0VLPnH6aLcpUrVm6SxsDwA81bj/rTJzL clvYzoadpzoBHdZcA3gxrg3H7liqaB7sjPGbdb1uGiGV7IRyNohnwYWEM KM1T2ESmgmueh/3pWIy8nla9FKQEp8EE5c4xWwQJjjoAETLZ1bTF7vunR A==; X-IronPort-AV: E=McAfee;i="6200,9189,10260"; a="250816905" X-IronPort-AV: E=Sophos;i="5.88,375,1635231600"; d="scan'208";a="250816905" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2022 05:34:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,375,1635231600"; d="scan'208";a="681963942" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 17 Feb 2022 05:34:44 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 17 Feb 2022 05:34:44 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 17 Feb 2022 05:34:43 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 17 Feb 2022 05:34:43 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 17 Feb 2022 05:34:42 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E3SX3KknzK2p7FKVFFMblVp2/XRHs4vOm7vT2LihLlZ4C5mNPTKXK3wXI2XC0X/jj1dqXe9emGKIdcAzdKaXlbMMlEXWHxePQyA2dDTBsgYXUAqXvGDWxJxbuwPXmY7WdvwwO5I3NyLCDvIkhA7qoSGdmOMrsUz+LWcvxFaoMMI36V7H3SSm3G/4GdyU4rD07GGBJgLxTre5a1/I+iMFTvepWL8pElEnnyH+vc9TLQQDqAX9EDWJfppJIPzNdaMw1PqtiWXmyO0sJHRPfxU3GPE0w8rxqHEq0kn3dcsiGnIIaNmOitoY67CdIfSzkbHLHFDkauw9ESbbmEO5JuOS9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BO/T1rjAAfFirgtx2sM4LvMcA40VxpKNuE/zpdQMw8E=; b=Wuf0EjAXUD1ALUpPt6RUPz2zPiIR83Tl037Y3XG0C2zAHQzDwUUmiW9Hikq1sfMcUQbl0TCmIs1DIBt/y6OetdAHu8NMQCT0oar3IKHVDJtCIBz8gUYv5DYRu0AdgfwSSYPJtP1rM8Wa2j3DkV8h3+Y8lQ/0knd5QbnlmuH/hiq0xAgLCiRC7uul+yiFmfqOLC5O7Fsnyb89E2XwVFbymKwkff3qieipXDT0+6unDwfh++oA+D7vZZQKE3jSyvCBULkfkpV6OImWdyLFss/HW9txNe7O/F/tEuPuuQ1dXQEs/l/lr0Ou8syqvEwPbrZYk+OZd3nosYcZqU4E75rHyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB4791.namprd11.prod.outlook.com (2603:10b6:510:43::10) by PH0PR11MB5191.namprd11.prod.outlook.com (2603:10b6:510:3e::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Thu, 17 Feb 2022 13:34:38 +0000 Received: from PH0PR11MB4791.namprd11.prod.outlook.com ([fe80::b58f:bb46:9881:3771]) by PH0PR11MB4791.namprd11.prod.outlook.com ([fe80::b58f:bb46:9881:3771%5]) with mapi id 15.20.4995.016; Thu, 17 Feb 2022 13:34:38 +0000 From: "Loftus, Ciara" To: David Marchand , "dev@dpdk.org" CC: "stable@dpdk.org" , "Zhang, Qi Z" , Xiaolong Ye , "Yigit, Ferruh" , Stephen Hemminger , Luca Boccassi , "Laatz, Kevin" Subject: RE: [PATCH] net/af_xdp: add missing trailing newline in logs Thread-Topic: [PATCH] net/af_xdp: add missing trailing newline in logs Thread-Index: AQHYI/9EC+kVcDhuq0uKjdkDouQ3C6yXva+g Date: Thu, 17 Feb 2022 13:34:38 +0000 Message-ID: References: <20220217130614.23255-1-david.marchand@redhat.com> In-Reply-To: <20220217130614.23255-1-david.marchand@redhat.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ee68417e-b4be-4208-7ec5-08d9f21a3edd x-ms-traffictypediagnostic: PH0PR11MB5191:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1201; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uam4H9ebqe1uuEGcqb0wBo9MSE0keA5MtbZl9avY8Y+8B/XEBA5QFQ4qLxyF2lwdlG1w9r1wmQGSXLzGFawQVs9HKXeJ8NDp4HxiYDnNqpQtEzWInDr2jBUc4kHsNcJQp08chXzL43SInlCH0caXhJTFRwxQ7laPcoGdu3NxFCdhxfBZVer3yEWJ2xh7Xh3MAUl+ox5Qh+U7BoRvgU3s4uL+Gurd/AW5gc+HtugvqyIJLkFgoSfKaSG0Pww1jSoI1UWwHNE/17uFhKQJ5Sd49G+fkzv3FWym/fhBRojogCzIUqjN9nUAI1ay2ahdJA8td724ZhArlXC8/oZH9Isrri6x0uhtWqL2sD9iucf7L5ToICi5D3F+tXY4AaAMGMR3ML21Ffx0AFpGcV+xpIILhQutnTssqLQpRZvhivQgFyotFonzPkFkRvc+uP+AY++SllNR2Vz4kE2KTItiIrTRTUh3d38QwMfWpn1OQ9krjs4pvnA6cFvGroMRXUsIcltl2Vr6w4FJmxF/p2sVliQMscjTzgkLJPD90FHs2PzMzq5a+cNxTC3kR7iedKfDeig5rpW5rZ9FeaD9cG5oH12qN0hHtVva+8FJCDW0UIX3yiAT5MC6IP5akgCpQe8Gvp2f6k/IG3rpUW3wocLQ6aLWuwT291PDY78lQmhYwNBPdPhEluo2wF5jCPLbqsUAHMj2E1eUk3n0hbGEMEjMQbY2SQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB4791.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(38070700005)(55016003)(4326008)(52536014)(66476007)(8676002)(71200400001)(186003)(9686003)(82960400001)(122000001)(107886003)(6506007)(86362001)(8936002)(5660300002)(83380400001)(38100700002)(316002)(110136005)(2906002)(76116006)(64756008)(66946007)(66556008)(508600001)(66446008)(54906003)(33656002)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NaxZGeRqAlVM4F7khdE1xcO/TVoHDIbX7xbXJ/eBc/GruK43eqpFTKercJ9i?= =?us-ascii?Q?myOGk/1exmHPEnVaCkPqVotOuvxfhWbQbSKbW8Vn0AMXMSg2AMUjogGYBPiT?= =?us-ascii?Q?ZPMOWGwo71j40CDXE38m8hfmZTUX6rmdAvkZzJD+m+krxDkfgRfIDHR+CjTF?= =?us-ascii?Q?/8aRvIFuojF0L9YF2gi4PgfwTi4mZHTNuEDH0GxYqJDqldWskSyRvrOVFmhl?= =?us-ascii?Q?fHe8SX3adofszQlbTao0RPYNzDj/mNZQ942C0ppM446gPisyH5dmCJS8HQrx?= =?us-ascii?Q?KIeisMmdlJEG9lqyhimOKiQS6pEY98gMYc1t3YAEoGDznte31D6dR4V8g/FP?= =?us-ascii?Q?iugdGXsFKfG9WoE9xgpb/LGZhtsEIoOcqGQWoIrPA/qdc5W2njqVizS2osQ4?= =?us-ascii?Q?vLajX72EJmVgy876F8IkeoKSqhlMKpmpkZcQFSS6G6zwSpSypKF1eDlg7mNM?= =?us-ascii?Q?wCYuieaLzHXI6XGqDhMeIFgEgzkqEXJyT9t+hgyqQlq8uofG2MHicHsyLiiW?= =?us-ascii?Q?ZCXw+NyIv248zASvyLNur6c2+WSvAAIRMjUn7ODpIkNK+UMp1nIEce472rT4?= =?us-ascii?Q?fEJ9LMhXb7xLToEqIKaStW09tKddx3DbvHmlRHNmL76n09fZuuInPeWF6Ies?= =?us-ascii?Q?BkMzJi2zFJy6x8R7/lZk+khNHGy10pNbyoxHVpw67H1xxoRwEd/ABvMg0ME8?= =?us-ascii?Q?DhCPMTUHme0Qi7xpD1/SLx9LzcD8eLKduBhkANhswfvb4YXn/BFMqb7AGH0Y?= =?us-ascii?Q?M6GAgEUx/O+SA1+a5LG6UIl2kX9azN1m2nO2jajuU7Wkh7nmgQahHTjqwznN?= =?us-ascii?Q?3gwYjh3c45mdfIvX75NkSbWiHbmgdZZtIP3MLFkMiaZKsFkzpQWhMUqEgn+G?= =?us-ascii?Q?OsuR5sfjQLUSzksh77PtgFlzLI5S1SVaI9Y0bjdgUX+GJ90/864LaCr1FXos?= =?us-ascii?Q?JuXcentj0BLm0ONLdBjOjTQ4p7Z3L14Kgz6F/7KeG0k+jNrEaR0HM1DFrFq9?= =?us-ascii?Q?IVgA6pW0Z0rRJy8y/jJuPr+vBWqtcGaKkL/j++U+TNC4NIfX3gnqAfDnDJhw?= =?us-ascii?Q?AWoajW0b+dRH4GjVTfoVEvU3GvLMgLuHR+D3OFSMw4PWXmE0a9JH5WvthcbC?= =?us-ascii?Q?KWINI+wC5NP8YaXzL6IsHlQ5ed91/HDuJGa0WLs6A8XyKcFD/VkSVOHnL0AW?= =?us-ascii?Q?pGwceUJASy8/IMtYqNnfU0tL2Esj1wHd5mQrYn5t/i3/A8USdbOQQCTw8nUJ?= =?us-ascii?Q?Jbr/ZSemQzKXUGMjIncAEL1x4T/cdcfFCNM3GM4oXk2RhH6jDrEpZTKMAeB+?= =?us-ascii?Q?RyJEi5ej+XZZtBTfFS2GhFmjmV2s6C46CYTbt31IYlt+2qdAJj3DIGuF3Lk0?= =?us-ascii?Q?JU8oWiwTalxz3dzZlKuMNoG++y0/HxSNk8t0i8rJ8NOv2CrxGJflO/lAVfp4?= =?us-ascii?Q?qDIwYfcGNcQwpkg7IbZs9EISoIG9g0Pm4TOkqQyjubRbtEewAy7Z70hJpjO/?= =?us-ascii?Q?S7Q3pldNMdbw5P+TQ4CzGpgnalYlCA3m7BoC2pnCQlN0pdPT0qv+RvHaGdu+?= =?us-ascii?Q?InSeBzNPvBTUjYi0PJ+iOplN7xTZ2i9PFIHtow/pF/wxFzYWYTZTf5FXgXSu?= =?us-ascii?Q?eVJbYBXd8Uc2+8tEoqWMpMRUSK6RKhCbgz/ybQpqqGDQtYD0lV3bjwXtxh0p?= =?us-ascii?Q?S+Xhgg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4791.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee68417e-b4be-4208-7ec5-08d9f21a3edd X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2022 13:34:38.6785 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: j+NWlYeSR3NzFV416toObp2D4JM6/lkAN0QH3m0rCDWFX/Wc/SAxlAp9PgCpfzGwuZRDx+QpG/3c23kDnM9stg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5191 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Subject: [PATCH] net/af_xdp: add missing trailing newline in logs >=20 > Caught while trying --in-memory mode, some log messages in this driver > are not terminated with a newline: > rte_pmd_af_xdp_probe(): net_af_xdp: Failed to register multi-process IPC > callback: Operation not supportedvdev_probe(): failed to initialize > net_af_xdp device >=20 > Other locations in this driver had the same issue, fix all at once. >=20 > Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") > Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks") > Fixes: 9876cf8316b3 ("net/af_xdp: re-enable secondary process support") > Cc: stable@dpdk.org >=20 > Signed-off-by: David Marchand Thanks David, LGTM. Acked-by: Ciara Loftus > --- > drivers/net/af_xdp/rte_eth_af_xdp.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c > b/drivers/net/af_xdp/rte_eth_af_xdp.c > index 6ac710c6bd..8bdc2920cf 100644 > --- a/drivers/net/af_xdp/rte_eth_af_xdp.c > +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c > @@ -1071,7 +1071,7 @@ xsk_umem_info *xdp_umem_configure(struct > pmd_internals *internals, > umem =3D rte_zmalloc_socket("umem", sizeof(*umem), 0, > rte_socket_id()); > if (umem =3D=3D NULL) { > - AF_XDP_LOG(ERR, "Failed to allocate umem info"); > + AF_XDP_LOG(ERR, "Failed to allocate umem info\n"); > return NULL; > } >=20 > @@ -1084,7 +1084,7 @@ xsk_umem_info *xdp_umem_configure(struct > pmd_internals *internals, > ret =3D xsk_umem__create(&umem->umem, base_addr, > umem_size, > &rxq->fq, &rxq->cq, &usr_config); > if (ret) { > - AF_XDP_LOG(ERR, "Failed to create umem"); > + AF_XDP_LOG(ERR, "Failed to create umem\n"); > goto err; > } > umem->buffer =3D base_addr; > @@ -1124,7 +1124,7 @@ xsk_umem_info *xdp_umem_configure(struct > pmd_internals *internals, >=20 > umem =3D rte_zmalloc_socket("umem", sizeof(*umem), 0, > rte_socket_id()); > if (umem =3D=3D NULL) { > - AF_XDP_LOG(ERR, "Failed to allocate umem info"); > + AF_XDP_LOG(ERR, "Failed to allocate umem info\n"); > return NULL; > } >=20 > @@ -1160,7 +1160,7 @@ xsk_umem_info *xdp_umem_configure(struct > pmd_internals *internals, > &usr_config); >=20 > if (ret) { > - AF_XDP_LOG(ERR, "Failed to create umem"); > + AF_XDP_LOG(ERR, "Failed to create umem\n"); > goto err; > } > umem->mz =3D mz; > @@ -1847,7 +1847,7 @@ afxdp_mp_request_fds(const char *name, struct > rte_eth_dev *dev) > AF_XDP_LOG(DEBUG, "Sending multi-process IPC request for %s\n", > name); > ret =3D rte_mp_request_sync(&request, &replies, &timeout); > if (ret < 0 || replies.nb_received !=3D 1) { > - AF_XDP_LOG(ERR, "Failed to request fds from primary: %d", > + AF_XDP_LOG(ERR, "Failed to request fds from primary: > %d\n", > rte_errno); > return -1; > } > @@ -1996,7 +1996,7 @@ rte_pmd_af_xdp_probe(struct rte_vdev_device > *dev) > if (!afxdp_dev_count) { > ret =3D rte_mp_action_register(ETH_AF_XDP_MP_KEY, > afxdp_mp_send_fds); > if (ret < 0) { > - AF_XDP_LOG(ERR, "%s: Failed to register multi- > process IPC callback: %s", > + AF_XDP_LOG(ERR, "%s: Failed to register multi- > process IPC callback: %s\n", > name, strerror(rte_errno)); > return -1; > } > -- > 2.23.0