From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69C23A0093; Fri, 11 Mar 2022 12:12:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 018BA40140; Fri, 11 Mar 2022 12:12:48 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 7C20440042; Fri, 11 Mar 2022 12:12:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646997165; x=1678533165; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Vy32cOePYchbe2XZbfAI6h0y4/Qt1qxJ09qpamc4vqU=; b=aDOBHwFNVtgI7Iol2npk4ItaGdS3OyKw19C/VRnGXQr4yCNp7xW2qlj3 UVC+d6avrs+/WNPRnwnUGalQXnNSEKF8Cv33mZD5RTAaXg22f9+VFlkXo kTYsNRL7PHuLRIVYO9qbMNtSU5QSMGiLljcerjsgWxt+l+nkr9ShZYID7 kP23fF0aNWBtJkHhccpFvuj8ua9YGhveqA6OguJA+fsei4MmEim4ObLQi fwuCS1nlEVHadRDE7UwwnlYxxFUDOMGmYSxdwo5kxfwSaTDdrN2jmd9uF YnA7hjqtp/HforIpgZEdHn3EDiNZH0AGzDpJaQ+AYIf6zBZ/l+0BYqAqY g==; X-IronPort-AV: E=McAfee;i="6200,9189,10282"; a="237725780" X-IronPort-AV: E=Sophos;i="5.90,173,1643702400"; d="scan'208";a="237725780" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2022 03:12:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,173,1643702400"; d="scan'208";a="644903248" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga004.jf.intel.com with ESMTP; 11 Mar 2022 03:12:44 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 11 Mar 2022 03:12:44 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 11 Mar 2022 03:12:43 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Fri, 11 Mar 2022 03:12:43 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Fri, 11 Mar 2022 03:12:43 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SBnv5TYIvjurhzk/qYht/7fLNm3EqBTNAWqsu7o2sT0Hg5vljlzNp8ap1KAQfPkCCOni5KJ9KHBrXnJJ0CxWoF9Wrak9RGbvLOt80U6+DJN5zeL0pDrrEc+GT4tyKlpgttdJcit1RB6FeCipsBXTf9Q3e/3qC24MQddu2yMITDxRPPw6A0T7+1oeOQ7Ta5oEz/X4WQbRu1R3AGifb0HeGyiKnKE2OxRhTKbf6Ap3kJbYgcHsF5k5EyjYbjFiHaNLeeHdjwbJU8I1VCGJytaX/gfYJScWxMBfCrf2G4sHLFQmvfmwf1nDi/ROGoYu0v7ZURRphVWVuYaxtBPx+ZeafQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vy32cOePYchbe2XZbfAI6h0y4/Qt1qxJ09qpamc4vqU=; b=jc9Je7hlfhzam+x4c7S6d3KwwqrOyYNe1HxOstbE0EuHUOf2neFr5jC9adnw83pJrwerctI4wobz0p8e0X9YydrS/Kl1An9x67/DNek+fKJsPEPvzyh6yVpRdGGNowaP9fFpxn4ACLgfONob7zTLfXl/lNsKzoWbqx01k0ncNr3gyjwd5yZC2rC28wWYoPytG+Bl16VhVV2JFTBQcMI3AF3bYG4iHBNMFVpAQBp7Ebp3+HwbXwN2k+zmQIBTaQlCPtRuz2iXVz4fmibyGyiEuu4r/Fb6IrGkSX5BW2vZY2vORo6sEjB7jgSbmkeRqeqKF4lKb8wRclidYQlOIGfl8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB4791.namprd11.prod.outlook.com (2603:10b6:510:43::10) by CH0PR11MB5394.namprd11.prod.outlook.com (2603:10b6:610:b9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.22; Fri, 11 Mar 2022 11:12:42 +0000 Received: from PH0PR11MB4791.namprd11.prod.outlook.com ([fe80::10f6:8907:d46c:78d8]) by PH0PR11MB4791.namprd11.prod.outlook.com ([fe80::10f6:8907:d46c:78d8%9]) with mapi id 15.20.5061.024; Fri, 11 Mar 2022 11:12:42 +0000 From: "Loftus, Ciara" To: Thomas Monjalon , Junxiao Shi CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH] net/af_xdp: fix custom program loading with multiple queues Thread-Topic: [PATCH] net/af_xdp: fix custom program loading with multiple queues Thread-Index: AQHYM/1ATVFVURhk/0q5EfF+QlSH/Ky4TxvAgAGFb4CAADTEoA== Date: Fri, 11 Mar 2022 11:12:42 +0000 Message-ID: References: <2c42e3e23c18fd60@cs.arizona.edu> <3163221.44csPzL39Z@thomas> In-Reply-To: <3163221.44csPzL39Z@thomas> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 326b1d5d-99c3-45c2-3961-08da03500fdd x-ms-traffictypediagnostic: CH0PR11MB5394:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: G2h2mDLZjhD7sxTzThF1R68DEqVIV29JjU0HH4oO2Bc2zvOinRaFZ9/+0Y9veDEAvgmQe3zfcKKOH1JPSRLYVL2bBxCkBE/otm1eEs+1a43zSUkxcZxjsVuUfqv1dnuAgRmIMyOWryz/cQQDCyGiUwrMr2OPzWqJfU00BCXhFzJJGGBmhC7aET9w3td6vYLUw2+c+W2Ey86izFv3DdvRIJAz0D1u5fEFpWyJiZQe6XeywWnnL6TQ7WdyHyyubOQx7bQ+5oNr5Mtdq4Pd/AHNwOc6mRFljSbfrgYm+VlEi0QaSHP4sKNqD5uGfAcNTLqAkXgP3KjFEGKuaNj4c9Zetx9QJtoWHHnY7B/QF5F0V58ERD8BDYRZWHz583JpDR/vIdFRZNkW+uYE/uz0aLlnNBopMaEl8OWetuCVqFQafKz7TBFMXtOpIdAInohXalrurnx1ZE2/EZFk5t5o4SegNeToUuOWTzBgq1kbLP28NQNRd1iOUdCxyBMJVdDP5kRFa1CeXenvsP1tFqh/LaAYXp/+f++duaNF1kTpTqMp62nXu9yYCf/CEvdrTry36ZJhi7fLYlqxcbWX1ZGcpEIkXMG8C8v48cQYELb98BsL+VuahFz3oQvzPMbMgQbuulObugfNUZKY52u7D5fGdf7oBEwleBtWcLmByzLiJ3u5MDgYqwJXrAZBtZvItjEtUYUc/vv0eBHadayfUrCxNBbKkA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB4791.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(82960400001)(8936002)(2906002)(52536014)(54906003)(86362001)(38100700002)(122000001)(26005)(38070700005)(316002)(9686003)(110136005)(186003)(508600001)(71200400001)(66556008)(55016003)(7696005)(6506007)(66476007)(66946007)(4326008)(76116006)(8676002)(64756008)(66446008)(83380400001)(4744005)(33656002)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?p/lKo9RASJxUKvOLVHWnNyL8ngEVfXayA2dvSNEsttw4YD8LcXcBVkMLU+fc?= =?us-ascii?Q?q/YsdBVJd4LJDdzG4t5FZ7NenJi53N4IeYTmLWxiP5B0Fl0+T36oWr2gW8dx?= =?us-ascii?Q?risZF7LZ+V4sPQGxHZSzpfNeBXseQMjbXiN9QKvVHiS3ftUozREzS5iTHeOO?= =?us-ascii?Q?0e6P+X2qoGyZIcts9W4xzV9QcoA+LPQmFWzNSm8nNa9K4Efh881Y1wMuTpvu?= =?us-ascii?Q?cpZTHtnnenXdg3DRJLiQcGw2UZsV4NHG+oYt8Eg3YfbGtUG/T//kf1/R3TaW?= =?us-ascii?Q?PI9CWXdWOcpQ07VF82Aa4b1xLLwhDsFNG/WklF92Gw9vKFHltze+QEKVoTsd?= =?us-ascii?Q?mUW5ONe07DQkLw7JDCXZljT8DCNY0PabRZ90aIn4K0WlnWY+lhwgbAFw8P/I?= =?us-ascii?Q?TkfqOnDuwdnTu4Rm84zBTAre7405A7ylMfsNRkanGMAsldfkW4CQC7P5CiEg?= =?us-ascii?Q?sMDaF8KaeKySMKKqFv6psu5LK02B+JfaQYuO9QYrijEHQeYgYEzzeuEyxOUc?= =?us-ascii?Q?8H/pT9Yqh/HG3GOucHB2N6Vz41GMdqFlKH0pGpf6mytkhdIJFXGd8Kxz2Jdi?= =?us-ascii?Q?M4WKD0kwGoLKuEt125XTm5vZk+2eJVe7G9FGHofLEGA9ytsCoVYiXKyR6Z7C?= =?us-ascii?Q?POD4/vqEE+IOpxweSSZv/Xd+Rm1t+j0UKPSBJRHuCn9FGJMwnE6fLnI2Fx+i?= =?us-ascii?Q?T/RjLsoyJaekM8gXR0FgXv5sH77VUITuDosqUSSvn5rIkD/tLl1xeFAGT8pE?= =?us-ascii?Q?At56/nzn6UfyE8XZVD66ViDE8pKzt8ltmBSYxKj6X2apTZDrzB/OsUBmp/du?= =?us-ascii?Q?BF9/EF1wPvEBW8Xb6InQf0iRPiHmoXdGGk8lAVhHvwo797cTwe8lc16Vg4oG?= =?us-ascii?Q?aTBp7D/QeykYBLe23PpM8ta04OE+jlUFonQsavY1JnMweKJ6HSatbAOUQIoo?= =?us-ascii?Q?4Jv6kawUBC5GX4D+wiAEVvo2XGwuuLEAVrMk8oPhU49eUKH4FOG0jIa3OBOm?= =?us-ascii?Q?4dIqtYfJp5QKagy797pnsqqEcjs27m380UCITlXLxpyTGsFOhqn0TlSH6r1G?= =?us-ascii?Q?y4upDU/WAZXjDvTz5TqidO1Fwvx46glHkYz2fYQYEeQEvDdKl/HrTMQJfCeT?= =?us-ascii?Q?JZR5nZCvIh5qp6dVwbTM6d7GEz8JBl4jMgZA+apI0q98w9SSkBOYRMeCVP8i?= =?us-ascii?Q?RmJmJ1WiBXvZgHMoGPH23ckFa7b0V+6wanTq/7UQJ43Ncw74wqBIjs0gBMKo?= =?us-ascii?Q?rnYFdi7RlVk4NMfHOpd9wo8V3i8O+iq2oYXCImPTq5IFnoYJv6HQib8ZUmuD?= =?us-ascii?Q?pqE4kBEWGp/zVZVyAJpJa4DB3tutks9rnz8kD22gE1n5U8lL/8fV/FQ4V92k?= =?us-ascii?Q?RFQfbVJ4iAgUghiqlHagCDy1y6gA5Q7+8HGlNt79HwouC5ITI54nuK9Rvbn1?= =?us-ascii?Q?1+JwbZsQr7ZmO1Mi+IALuhAb4kXsIN23?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4791.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 326b1d5d-99c3-45c2-3961-08da03500fdd X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2022 11:12:42.4144 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wXbvJE+ir+yC2IiK8zg8OqawEbGW6EPplmgKRbMow8qItTANuuH0m80jMcxvRaot8y68570xXc1gpbTpXG0gow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5394 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >=20 > 10/03/2022 09:49, Loftus, Ciara: > > > When the PMD is configured to load a custom XDP program, it sets > > > XSK_LIBBPF_FLAGS__INHIBIT_PROG_LOAD flag to prevent libbpf from > > > loading its default XDP program. However, when queue_count is set to > > > greater than 1, this flag is only set for the first XSK socket but no= t > > > for subsequent XSK sockets. This causes XSK socket creation failure. > > > > > > This commit ensures that XSK_LIBBPF_FLAGS__INHIBIT_PROG_LOAD flag > is > > > set for all XSK socket creations when custom XDP program is being use= d. > > > > > > Fixes: 01fa83c94d7e ("net/af_xdp: workaround custom program loading") > > > > > > Signed-off-by: Junxiao Shi > > > > Thanks for the patch! > > It's probably too late to make it into 22.03 but cc-ing stable as it sh= ould be > backported to 21.11.x. > > > > Acked-by: Ciara Loftus >=20 > I can take it in -rc4. How much are you confident there is no regression? >=20 Thanks. I am confident there is no regression.