From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C2B1A0C46; Tue, 7 Sep 2021 10:58:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F5E2410EC; Tue, 7 Sep 2021 10:58:39 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 5A71D410EB for ; Tue, 7 Sep 2021 10:54:37 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10099"; a="220165571" X-IronPort-AV: E=Sophos;i="5.85,274,1624345200"; d="scan'208";a="220165571" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2021 01:54:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,274,1624345200"; d="scan'208";a="546643646" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga002.fm.intel.com with ESMTP; 07 Sep 2021 01:53:56 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 7 Sep 2021 01:53:55 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 7 Sep 2021 01:53:55 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 7 Sep 2021 01:53:55 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Tue, 7 Sep 2021 01:53:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VUYTGKcm4Hyng/j+DuFhKygg4HTLHP8BEz+RKMgUGfhkUSoq3q5TadwRARQd6dOYH5brFoEIZjrDabycjm5rRQEY8pCNdkzQKeCMY9OsX8noXq1O0MJS0hiU26wHdyBsZ1rxmZYZQM1b6QEf/aVQwAWIRZTVrEH3Mq4T5PCUNIEGSIJ/IZUrGHh5eP214VG1f7jTwMB5tSp/RK6recQtPuEVVrDvyT2d3VEcLyePJfUIFa7WwpCHzlwCXjDJJlQ1RVfjkEZpU9Fa4dFwxBrffCvkzK22gBs5ce9wg+zhpyqPl8JQ+ZfD83Odcl2WkivvEkuacsIIZask+wSfbglHdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=zZFZR6UY59Pq2e0mFTF8oqR9unW8skcdbXParAsJE6w=; b=i1CBUD+5sBJW7zcdZeuuvkd+BIOCCKvCBfiNtcB1bKy6xFQAup+nlKMjoAscZqyURfP2cBeEhYtZFgzSK1773ikwgEJJZnmGJ/ZBoE5ueeg7kPEzL5LoRKhbKZBDl+8fQTlFuBP48/jrXAO5DdTgz3Kokr13GNubNxzJqfcl+N6gcUdaf/+nuY28p9H+3cwOtIjDHHslfqAUtPV28EpVdXJD1oRcWD4CStgSLSMIxKWBSeJzBTlOosgpbIr3+eN8EO7A/LgLwtGHmDxKVY3MSWL+lG5v+y785JBlvbBVknfDWJ2O22TgJ/iblB0Wg+Kgap+9z38+PHDjgB+ABdC4Rg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zZFZR6UY59Pq2e0mFTF8oqR9unW8skcdbXParAsJE6w=; b=s6TaGHdWDZRi3gKN4MN5ILJ7r/nBgw5y44G83LPvZ2zCDUEvbKUSE6cEKdxKFj/yFO0bnsSlED1gXH9kcjhp3e1MelcYRJ9fR7VHrWjSq/eYjWXZeFjIshHmMTv9L3SZ4p71ywVnnH0t4A9jvde/Fx41YwGbCGDSJwZJKZr1GvE= Received: from PH0PR11MB4824.namprd11.prod.outlook.com (2603:10b6:510:38::13) by PH0PR11MB5080.namprd11.prod.outlook.com (2603:10b6:510:3f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.25; Tue, 7 Sep 2021 08:53:54 +0000 Received: from PH0PR11MB4824.namprd11.prod.outlook.com ([fe80::aca2:cce5:bef2:8a27]) by PH0PR11MB4824.namprd11.prod.outlook.com ([fe80::aca2:cce5:bef2:8a27%2]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 08:53:54 +0000 From: "Gujjar, Abhinandan S" To: Shijith Thotton , "dev@dpdk.org" CC: "jerinj@marvell.com" , "anoobj@marvell.com" , "pbhagavatula@marvell.com" , "gakhil@marvell.com" , Ray Kinsella , Ankur Dwivedi Thread-Topic: [PATCH v3] eventdev: update crypto adapter metadata structures Thread-Index: AQHXnj3WjnQgyKZ1dU+J5G+CJPvld6uYTrEg Date: Tue, 7 Sep 2021 08:53:54 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: df98dcdb-fac1-476c-a047-08d971dd0567 x-ms-traffictypediagnostic: PH0PR11MB5080: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: c0fEEM+ffzG+1rXvlznz+8s9oWAOoHLiBukbAmzkX8BUS0eOIJJFc12aQrDGzYGSH8dKxMEJvgSc3amhMc/6rrqgWgZg7iCm/20Tgk4XMPFOF0WJ2eywdVcggkGU4mVeV18ODthDxM7Q9UW/YwY8ZI5Y5AjBBdwJdnM2/6445P9O8Ds/YieFag4FyKim3H41+wppRsw0Wb8iwUixggeXKKmDWlLKxrx2ngYl0ssvY8zCaFCoN7VEWeC9yCA8NVct/gijYbSfAcB/V4x4qnkH52bpGwznmKT4dKf7WDqNo6EIwW5b+/v9GybBQam9IYkoVL2kjpQd59pV9fxkxagw+P9EG5YEkIN3ey1qGfrY0TL/ig57Pv6EE+2WuuiL8RYQyeAY+hdWhf+EVmo9V8QUXZf2E8/dyJyj4mkmHZeA+uxi81AIN1pMrDZt7fmBNZWz6jWXYDHbey3zO2vcPG99V7vAfyLwtT7VEGU/9V9xS/2ub5tevHD+A9Jbg0ahFYCOZ5mtV70E1FAOcHLY5ljk6qKxPBmQUza8aq/z2glu1a009rpyXuVGz558G/HOpJw5jWBwkgfBfVk3DQSq8iS94vJM1xnR9pCfqVNHpOuEbRzAV3XgLnVbfeDpQim/m6EngQaxAkYJNzRelivSic9rWVObccaASpxj4e8ZTB/A05cTRjZ0Zjf5S0s9aQkqtDWMAtdXWoXEVTNaag9cz98KEA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB4824.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(376002)(366004)(396003)(136003)(346002)(7696005)(53546011)(6506007)(30864003)(54906003)(5660300002)(186003)(316002)(8936002)(8676002)(71200400001)(110136005)(26005)(122000001)(83380400001)(52536014)(55016002)(86362001)(66946007)(9686003)(66556008)(66446008)(64756008)(66476007)(2906002)(38100700002)(4326008)(478600001)(38070700005)(15650500001)(76116006)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?08tEH4pxjfUZbTBgwLsQ5NAVneAkXExBPVEZ7bN+CfYQbbf2NvqsdREsNG+5?= =?us-ascii?Q?l8bNmem2NTIgu8l50WpCBe0ekwBSEmcge/wObnSC//Bztyzm+fqbfizQ3fqH?= =?us-ascii?Q?fLEuPmJ+enho40VAjS8paUEOGz6Zjq1yonkqe5ctvLIRL3wCU0KF9vkSQSrL?= =?us-ascii?Q?FdrEWMdQXelpov7hggzOKQ4LJdJl9C63v/cRXab3cl4qM7IRkQeyFd94wA1c?= =?us-ascii?Q?gGpdEJfWbDfrWA4FlpqVpBDAhkwNOdJsBv9BcHDQyk/tzmhlhujji9qlABq7?= =?us-ascii?Q?EXnDsyTbySFu4bAHTpFIAu0TE8iuHQhQyrGZXniMvHcIHtnOpm3kdoGWBz6U?= =?us-ascii?Q?WEYTIFvfB/qvyEe7aDWGSv5j4HaTFJ+EgAr3DFM6/9Qbm8XVbxTLrEYpovEE?= =?us-ascii?Q?Xt158r5ilL5U+jBNhZgLnkToG4NYTn1cHhTtcMy6CFykwzxA2VQ4m/1yzyyi?= =?us-ascii?Q?B7l9aBhHPOrYcyUJFDN7ArM0c122UvJghFyRx2SjLzj10sBA+ytksYEmLqZP?= =?us-ascii?Q?mMFf5s4VQ7WZm8Pa2oGJwFcvQEp3HVuA3jFXfe2rqlUkgG73EUmi5K74LysX?= =?us-ascii?Q?4kTgfsV4HirVsKI1DG1bX1wOGEdjeZMeabxMxTFcMCSfb3ISmyCGidrrmjGV?= =?us-ascii?Q?sn8N/KByY0i0sz2pKbOWwIe/8gzq4hybBZFfFUsT8t2i2SZoa4hQmOrr9V5j?= =?us-ascii?Q?rmERmedgTzoApkoFTLYwPhFhmqXtfjR1e1o0GZNuJiqrYTFd5G/Pktv9CZ4X?= =?us-ascii?Q?TZr8FFd58+8kRQzzGUlhz3Ic+h9U86kw0v5ferJWN/8WBKvwrT1qQ32ePsO8?= =?us-ascii?Q?wDvybV6zj5XGcNVGEJJHoPLmsNpMEULRF9Hi2PLmY219Aab0g4c86xc7wvp5?= =?us-ascii?Q?Hc0AKVHdhpOvA60silHbn/d1zPTOlvl7R0uiFcdCztyzO7oh6Vr1k73nNYc0?= =?us-ascii?Q?gfSEX+o64JI1jhIGxw4UqxYI+nzhFZVsYMS900fYGkCIR7vCUuglZutPxagP?= =?us-ascii?Q?ocY6FdkqR2D97xtRzMXDuaX+VVE3pDpa+hCkg2w96TcLg05+gXPvQbA88FSH?= =?us-ascii?Q?mtxlprJwqpEHJCant3HqbcDFFpy39v8HRHJfxjgudEypV+b81kc8mQu3U5Tk?= =?us-ascii?Q?Ei456VtzIsTkNdlVm4P/A4dH4ReoFoUCSVpKe6IuqsPS0tYkNE9ptSkgMiCR?= =?us-ascii?Q?R+nNTAIpqi/wMXFZ8DIBSs7AEeIXsdUuIDtMi95L6ZYO0EUhb+88YvT1UaCv?= =?us-ascii?Q?XbRhso11ba4kHqBVdONHo9MaMt6Cewu47W5xfPvlQf8vBSgvsHC5o86vBWap?= =?us-ascii?Q?pQz5nEzwL+Dm57LHBXs+FalK?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4824.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: df98dcdb-fac1-476c-a047-08d971dd0567 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2021 08:53:54.1138 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PuIowBLRas2OW+4eGx7PI1OScgNYLdXcWDM1Z7oeBg27ec+rzfbkVabZ5yrlqO/t84hlVfTsHlkVc2kv3gWo7GGXHWTfclN9VqnMiMUl3UY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5080 X-OriginatorOrg: intel.com X-Mailman-Approved-At: Tue, 07 Sep 2021 10:58:37 +0200 Subject: Re: [dpdk-dev] [PATCH v3] eventdev: update crypto adapter metadata structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Shijith, > -----Original Message----- > From: Shijith Thotton > Sent: Tuesday, August 31, 2021 1:27 PM > To: dev@dpdk.org > Cc: Shijith Thotton ; jerinj@marvell.com; > anoobj@marvell.com; pbhagavatula@marvell.com; gakhil@marvell.com; > Gujjar, Abhinandan S ; Ray Kinsella > ; Ankur Dwivedi > Subject: [PATCH v3] eventdev: update crypto adapter metadata structures >=20 > In crypto adapter metadata, reserved bytes in request info structure is a > space holder for response info. It enforces an order of operation if the > structures are updated using memcpy to avoid overwriting response info. I= t > is logical to move the reserved space out of request info. It also solves= the > ordering issue mentioned before. I would like to understand what kind of ordering issue you have faced with the current approach. Could you please give an example/sequence and explain= ? >=20 > This patch removes the reserve field from request info and makes event > crypto metadata type to structure from union to make space for response > info. >=20 > App and drivers are updated as per metadata change. >=20 > Signed-off-by: Shijith Thotton > Acked-by: Anoob Joseph > --- > v3: > * Updated ABI section of release notes. >=20 > v2: > * Updated deprecation notice. >=20 > v1: > * Rebased. >=20 > app/test/test_event_crypto_adapter.c | 14 +++++++------- > doc/guides/rel_notes/deprecation.rst | 6 ------ > doc/guides/rel_notes/release_21_11.rst | 2 ++ > drivers/crypto/octeontx/otx_cryptodev_ops.c | 8 ++++---- > drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 4 ++-- > .../event/octeontx2/otx2_evdev_crypto_adptr_tx.h | 4 ++-- > lib/eventdev/rte_event_crypto_adapter.c | 8 ++++---- > lib/eventdev/rte_event_crypto_adapter.h | 15 +++++---------- > 8 files changed, 26 insertions(+), 35 deletions(-) >=20 > diff --git a/app/test/test_event_crypto_adapter.c > b/app/test/test_event_crypto_adapter.c > index 3ad20921e2..0d73694d3a 100644 > --- a/app/test/test_event_crypto_adapter.c > +++ b/app/test/test_event_crypto_adapter.c > @@ -168,7 +168,7 @@ test_op_forward_mode(uint8_t session_less) { > struct rte_crypto_sym_xform cipher_xform; > struct rte_cryptodev_sym_session *sess; > - union rte_event_crypto_metadata m_data; > + struct rte_event_crypto_metadata m_data; > struct rte_crypto_sym_op *sym_op; > struct rte_crypto_op *op; > struct rte_mbuf *m; > @@ -368,7 +368,7 @@ test_op_new_mode(uint8_t session_less) { > struct rte_crypto_sym_xform cipher_xform; > struct rte_cryptodev_sym_session *sess; > - union rte_event_crypto_metadata m_data; > + struct rte_event_crypto_metadata m_data; > struct rte_crypto_sym_op *sym_op; > struct rte_crypto_op *op; > struct rte_mbuf *m; > @@ -406,7 +406,7 @@ test_op_new_mode(uint8_t session_less) > if (cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_SESSION_PRIVATE_DATA) { > /* Fill in private user data information */ > rte_memcpy(&m_data.response_info, > &response_info, > - sizeof(m_data)); > + sizeof(response_info)); > rte_cryptodev_sym_session_set_user_data(sess, > &m_data, sizeof(m_data)); > } > @@ -426,7 +426,7 @@ test_op_new_mode(uint8_t session_less) > op->private_data_offset =3D len; > /* Fill in private data information */ > rte_memcpy(&m_data.response_info, &response_info, > - sizeof(m_data)); > + sizeof(response_info)); > rte_memcpy((uint8_t *)op + len, &m_data, sizeof(m_data)); > } >=20 > @@ -519,7 +519,7 @@ configure_cryptodev(void) > DEFAULT_NUM_XFORMS * > sizeof(struct rte_crypto_sym_xform) + > MAXIMUM_IV_LENGTH + > - sizeof(union rte_event_crypto_metadata), > + sizeof(struct rte_event_crypto_metadata), > rte_socket_id()); > if (params.op_mpool =3D=3D NULL) { > RTE_LOG(ERR, USER1, "Can't create CRYPTO_OP_POOL\n"); > @@ -549,12 +549,12 @@ configure_cryptodev(void) > * to include the session headers & private data > */ > session_size =3D > rte_cryptodev_sym_get_private_session_size(TEST_CDEV_ID); > - session_size +=3D sizeof(union rte_event_crypto_metadata); > + session_size +=3D sizeof(struct rte_event_crypto_metadata); >=20 > params.session_mpool =3D rte_cryptodev_sym_session_pool_create( > "CRYPTO_ADAPTER_SESSION_MP", > MAX_NB_SESSIONS, 0, 0, > - sizeof(union rte_event_crypto_metadata), > + sizeof(struct rte_event_crypto_metadata), > SOCKET_ID_ANY); > TEST_ASSERT_NOT_NULL(params.session_mpool, > "session mempool allocation failed\n"); diff --git > a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index 76a4abfd6b..58ee95c020 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -266,12 +266,6 @@ Deprecation Notices > values to the function ``rte_event_eth_rx_adapter_queue_add`` using > the structure ``rte_event_eth_rx_adapter_queue_add``. >=20 > -* eventdev: Reserved bytes of ``rte_event_crypto_request`` is a space > holder > - for ``response_info``. Both should be decoupled for better clarity. > - New space for ``response_info`` can be made by changing > - ``rte_event_crypto_metadata`` type to structure from union. > - This change is targeted for DPDK 21.11. > - > * metrics: The function ``rte_metrics_init`` will have a non-void return > in order to notify errors instead of calling ``rte_exit``. >=20 > diff --git a/doc/guides/rel_notes/release_21_11.rst > b/doc/guides/rel_notes/release_21_11.rst > index d707a554ef..ab76d5dd55 100644 > --- a/doc/guides/rel_notes/release_21_11.rst > +++ b/doc/guides/rel_notes/release_21_11.rst > @@ -100,6 +100,8 @@ ABI Changes > Also, make sure to start the actual text at the margin. > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D >=20 > +* eventdev: Modified type of ``union rte_event_crypto_metadata`` to > +struct and > + removed reserved bytes from ``struct rte_event_crypto_request``. >=20 > Known Issues > ------------ > diff --git a/drivers/crypto/octeontx/otx_cryptodev_ops.c > b/drivers/crypto/octeontx/otx_cryptodev_ops.c > index eac6796cfb..c51be63146 100644 > --- a/drivers/crypto/octeontx/otx_cryptodev_ops.c > +++ b/drivers/crypto/octeontx/otx_cryptodev_ops.c > @@ -710,17 +710,17 @@ submit_request_to_sso(struct ssows *ws, > uintptr_t req, > ssovf_store_pair(add_work, req, ws->grps[rsp_info->queue_id]); } >=20 > -static inline union rte_event_crypto_metadata * > +static inline struct rte_event_crypto_metadata * > get_event_crypto_mdata(struct rte_crypto_op *op) { > - union rte_event_crypto_metadata *ec_mdata; > + struct rte_event_crypto_metadata *ec_mdata; >=20 > if (op->sess_type =3D=3D RTE_CRYPTO_OP_WITH_SESSION) > ec_mdata =3D rte_cryptodev_sym_session_get_user_data( > op->sym->session); > else if (op->sess_type =3D=3D RTE_CRYPTO_OP_SESSIONLESS && > op->private_data_offset) > - ec_mdata =3D (union rte_event_crypto_metadata *) > + ec_mdata =3D (struct rte_event_crypto_metadata *) > ((uint8_t *)op + op->private_data_offset); > else > return NULL; > @@ -731,7 +731,7 @@ get_event_crypto_mdata(struct rte_crypto_op *op) > uint16_t __rte_hot otx_crypto_adapter_enqueue(void *port, struct > rte_crypto_op *op) { > - union rte_event_crypto_metadata *ec_mdata; > + struct rte_event_crypto_metadata *ec_mdata; > struct cpt_instance *instance; > struct cpt_request_info *req; > struct rte_event *rsp_info; > diff --git a/drivers/crypto/octeontx2/otx2_cryptodev_ops.c > b/drivers/crypto/octeontx2/otx2_cryptodev_ops.c > index 42100154cd..952d1352f4 100644 > --- a/drivers/crypto/octeontx2/otx2_cryptodev_ops.c > +++ b/drivers/crypto/octeontx2/otx2_cryptodev_ops.c > @@ -453,7 +453,7 @@ otx2_ca_enqueue_req(const struct otx2_cpt_qp *qp, > struct rte_crypto_op *op, > uint64_t cpt_inst_w7) > { > - union rte_event_crypto_metadata *m_data; > + struct rte_event_crypto_metadata *m_data; > union cpt_inst_s inst; > uint64_t lmt_status; >=20 > @@ -468,7 +468,7 @@ otx2_ca_enqueue_req(const struct otx2_cpt_qp *qp, > } > } else if (op->sess_type =3D=3D RTE_CRYPTO_OP_SESSIONLESS && > op->private_data_offset) { > - m_data =3D (union rte_event_crypto_metadata *) > + m_data =3D (struct rte_event_crypto_metadata *) > ((uint8_t *)op + > op->private_data_offset); > } else { > diff --git a/drivers/event/octeontx2/otx2_evdev_crypto_adptr_tx.h > b/drivers/event/octeontx2/otx2_evdev_crypto_adptr_tx.h > index ecf7eb9f56..458e8306d7 100644 > --- a/drivers/event/octeontx2/otx2_evdev_crypto_adptr_tx.h > +++ b/drivers/event/octeontx2/otx2_evdev_crypto_adptr_tx.h > @@ -16,7 +16,7 @@ > static inline uint16_t > otx2_ca_enq(uintptr_t tag_op, const struct rte_event *ev) { > - union rte_event_crypto_metadata *m_data; > + struct rte_event_crypto_metadata *m_data; > struct rte_crypto_op *crypto_op; > struct rte_cryptodev *cdev; > struct otx2_cpt_qp *qp; > @@ -37,7 +37,7 @@ otx2_ca_enq(uintptr_t tag_op, const struct rte_event > *ev) > qp_id =3D m_data->request_info.queue_pair_id; > } else if (crypto_op->sess_type =3D=3D RTE_CRYPTO_OP_SESSIONLESS > && > crypto_op->private_data_offset) { > - m_data =3D (union rte_event_crypto_metadata *) > + m_data =3D (struct rte_event_crypto_metadata *) > ((uint8_t *)crypto_op + > crypto_op->private_data_offset); > cdev_id =3D m_data->request_info.cdev_id; diff --git > a/lib/eventdev/rte_event_crypto_adapter.c > b/lib/eventdev/rte_event_crypto_adapter.c > index e1d38d383d..6977391ae9 100644 > --- a/lib/eventdev/rte_event_crypto_adapter.c > +++ b/lib/eventdev/rte_event_crypto_adapter.c > @@ -333,7 +333,7 @@ eca_enq_to_cryptodev(struct > rte_event_crypto_adapter *adapter, > struct rte_event *ev, unsigned int cnt) { > struct rte_event_crypto_adapter_stats *stats =3D &adapter- > >crypto_stats; > - union rte_event_crypto_metadata *m_data =3D NULL; > + struct rte_event_crypto_metadata *m_data =3D NULL; > struct crypto_queue_pair_info *qp_info =3D NULL; > struct rte_crypto_op *crypto_op; > unsigned int i, n; > @@ -371,7 +371,7 @@ eca_enq_to_cryptodev(struct > rte_event_crypto_adapter *adapter, > len++; > } else if (crypto_op->sess_type =3D=3D > RTE_CRYPTO_OP_SESSIONLESS && > crypto_op->private_data_offset) { > - m_data =3D (union rte_event_crypto_metadata *) > + m_data =3D (struct rte_event_crypto_metadata *) > ((uint8_t *)crypto_op + > crypto_op->private_data_offset); > cdev_id =3D m_data->request_info.cdev_id; @@ - > 504,7 +504,7 @@ eca_ops_enqueue_burst(struct rte_event_crypto_adapter > *adapter, > struct rte_crypto_op **ops, uint16_t num) { > struct rte_event_crypto_adapter_stats *stats =3D &adapter- > >crypto_stats; > - union rte_event_crypto_metadata *m_data =3D NULL; > + struct rte_event_crypto_metadata *m_data =3D NULL; > uint8_t event_dev_id =3D adapter->eventdev_id; > uint8_t event_port_id =3D adapter->event_port_id; > struct rte_event events[BATCH_SIZE]; > @@ -523,7 +523,7 @@ eca_ops_enqueue_burst(struct > rte_event_crypto_adapter *adapter, > ops[i]->sym->session); > } else if (ops[i]->sess_type =3D=3D > RTE_CRYPTO_OP_SESSIONLESS && > ops[i]->private_data_offset) { > - m_data =3D (union rte_event_crypto_metadata *) > + m_data =3D (struct rte_event_crypto_metadata *) > ((uint8_t *)ops[i] + > ops[i]->private_data_offset); > } > diff --git a/lib/eventdev/rte_event_crypto_adapter.h > b/lib/eventdev/rte_event_crypto_adapter.h > index f8c6cca87c..3c24d9d9df 100644 > --- a/lib/eventdev/rte_event_crypto_adapter.h > +++ b/lib/eventdev/rte_event_crypto_adapter.h > @@ -200,11 +200,6 @@ enum rte_event_crypto_adapter_mode { > * provide event request information to the adapter. > */ > struct rte_event_crypto_request { > - uint8_t resv[8]; > - /**< Overlaps with first 8 bytes of struct rte_event > - * that encode the response event information. Application > - * is expected to fill in struct rte_event response_info. > - */ > uint16_t cdev_id; > /**< cryptodev ID to be used */ > uint16_t queue_pair_id; > @@ -223,16 +218,16 @@ struct rte_event_crypto_request { > * operation. If the transfer is done by SW, event response information > * will be used by the adapter. > */ > -union rte_event_crypto_metadata { > - struct rte_event_crypto_request request_info; > - /**< Request information to be filled in by application > - * for RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD mode. > - */ > +struct rte_event_crypto_metadata { > struct rte_event response_info; > /**< Response information to be filled in by application > * for RTE_EVENT_CRYPTO_ADAPTER_OP_NEW and > * RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD mode. > */ > + struct rte_event_crypto_request request_info; > + /**< Request information to be filled in by application > + * for RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD mode. > + */ > }; >=20 > /** > -- > 2.25.1