From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E2EEA00C3; Tue, 25 Jan 2022 14:39:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DCA1E426EB; Tue, 25 Jan 2022 14:39:56 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 6412A426E4 for ; Tue, 25 Jan 2022 14:39:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643117993; x=1674653993; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ES/TlegO+tclpabzaU0rcXxWYuQKlCDPY3BhFZGISVY=; b=fjPm2XzW2LPWJ9n0WtegezQLigCz5bRB79MCiuHZasy0fvox7IB2s6Be R8ZcBEVL6yhuTDZojCWpSxNi+MJDgAGhceGyLyUQx2WodqguNl/3j4E4+ ilU5XvKfgpzI07aDF/kBktDDqTo+2C+a53Dd5eYEEEc/VJ7DHnJUl3TuP oYq+mPbm4Pjky0tik31lEjv63JKevXF8AzpqOiNxMgCScLoulS3Nw6CuZ 6jxH26kO4/VC/wwjw9bg+A6KZHgD0eUSRdqvOxfv2nFpdybMCJrQCDSum 9G4JQ7+lCCElZV5p/l2UhVkU0MVxHczstqV5TAhFTVuRvB3+Cm35yq6R1 A==; X-IronPort-AV: E=McAfee;i="6200,9189,10237"; a="332653155" X-IronPort-AV: E=Sophos;i="5.88,315,1635231600"; d="scan'208";a="332653155" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2022 05:39:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,315,1635231600"; d="scan'208";a="673991199" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga001.fm.intel.com with ESMTP; 25 Jan 2022 05:39:51 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 25 Jan 2022 05:39:51 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 25 Jan 2022 05:39:50 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 25 Jan 2022 05:39:50 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 25 Jan 2022 05:39:50 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gbv/gqHQ7S43vd7rt6tXvAvACn2m9M2pMFrC0EcZn8knLZB/ke+CEKjw1qySHnT0n/8LDGenmCYZt02PaAGdnP5gmJRA9wfhfN8Kjs6xuA9P5H35Rf5CBmCcaxLlokraM5szmLtOllSgop+nY3104LnioVnjjW7P2LxkYIRIxW7lfWIeLqtM7afTSTNBgS6VNi/Rbh5dtn8ONDqMsZG2n8cBQda+OE1rlO4wumNGPA2kOUUfOjr/ipNnMHQWkT8PIkRYkFJEgbVtGoMR5CXpi0k7QJY+E9NC4De+MRRpgPxlRvq3/hQfBh7BQIESZLT2IGBA5GCnuy6UuXflUF/SEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/pKnDvRBKwqvF0Rvar0C1VgxnGbq0J5anYln8JidNRQ=; b=MqJUnx1SC5vaCnl5AumTnqO6yVGEN0Nbjh6dxN1aW1izzPXpehI9XjSz5juMMByH2cfezODRaFsnhOTxKYuUPutqsTOTyBMPYBFtpwMpaNgTw5aP0XBGSQxmmX5EWpAlHs3hhTK+Z61IGFJny4tLwkEj+zRo1SQ6c72Q3cAx2b9rdLXCacvPa1FHPBkUgB7EpzAdQbhehD2rlrtW24Q9wV1jbPtQJFZ26T5ujyKY6CxrcBAkhzLbiSfqmQGmIk74FKgI14RXU6ip0XFOfiFAPAUAFKGGlj19tM38NPclNN8wpMHVNgZXuQd2QzZXnDbbzy584TqWBpkP/Md7ICy3yQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from PH0PR11MB4824.namprd11.prod.outlook.com (2603:10b6:510:38::13) by DM8PR11MB5608.namprd11.prod.outlook.com (2603:10b6:8:35::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.13; Tue, 25 Jan 2022 13:39:48 +0000 Received: from PH0PR11MB4824.namprd11.prod.outlook.com ([fe80::8087:583f:a2f0:111a]) by PH0PR11MB4824.namprd11.prod.outlook.com ([fe80::8087:583f:a2f0:111a%6]) with mapi id 15.20.4909.019; Tue, 25 Jan 2022 13:39:48 +0000 From: "Gujjar, Abhinandan S" To: Shijith Thotton , "dev@dpdk.org" , "jerinj@marvell.com" CC: "anoobj@marvell.com" , "pbhagavatula@marvell.com" , "gakhil@marvell.com" Subject: RE: [PATCH v3] app/eventdev: add crypto producer mode Thread-Topic: [PATCH v3] app/eventdev: add crypto producer mode Thread-Index: AQHYAVatjp8Y9bS4UkqOt0F7dz8QJ6xw9xAwgALUPhA= Date: Tue, 25 Jan 2022 13:39:48 +0000 Message-ID: References: <5b7dadb222f6eb018c74983750052543eb5f0d8e.1640076426.git.sthotton@marvell.com> <736dc424a780b9547033f76f8911342ff06d3f87.1641292088.git.sthotton@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f541bd10-2b70-43fb-93cf-08d9e00827e8 x-ms-traffictypediagnostic: DM8PR11MB5608:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:156; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Sui8JcbN021JxvW9WxhDeSNuJPbXyfZTmHDION1PiAYIrULjngUjHTtW52E/dXonmnK2uW6yYeJX4RIrFw4OMZi9nVMpxn05eGnqKuSZaHMVG0XAWcUZagY95BtiUrfpltZ7S0678p5KqrEumdiBo65h7dduujf5XLSGOp0XAnogbDjA1j3RaNUQsPnjwFguMB04jGJXDiR7j9Eazh61lu59H4Owya+XQ9BkZB4QrZToPgmkwaRvVIk7mJfdMxR3VcCW7QGJ0fhKManW/EdsDlMR1yhUX2+cKhT5ZmV907mfky546XTlji7/ZdYoQWFjFzXhwbCvsS9anedZ54MrPFM0/dy6A+eIlTux06WqV3cLgP2rScEIEsiKOXIIdflfNMziiKZgfVfhypl9OZHtvwI0aCJSu7B9MxIZl1BmpTB0X9jagwlYF5chrBWcxhNWMx/8MeBEO7GUegqkA228dnrxnYvRdN0/HtRsbIwh459eOA5QOAJp4dOEkKfmoSv12J/W+KYPk7Svfmw771/c57wFSBUhnLH7I5XUHOnPI7Xd22ggyXaAzDXPOjpHp5f5uyr3LYsK+PVARemHYZ/GASVUhlylyQW8SvkDkH0+JTgnly57c6NNeB7epj8EK+MFr7V8eRMl0BBDDVkOyxURAzqMqVOkIwKTUb5+AltaAprXioiLhjIxbxMgEiLpCYljCR5w9HhViv+DqUYVrvUZ1A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB4824.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(83380400001)(8936002)(53546011)(6506007)(4326008)(30864003)(2906002)(7696005)(8676002)(33656002)(186003)(9686003)(26005)(66556008)(5660300002)(38100700002)(82960400001)(122000001)(76116006)(54906003)(71200400001)(52536014)(508600001)(86362001)(55016003)(38070700005)(316002)(110136005)(66446008)(64756008)(66476007)(66946007)(559001)(579004); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xzEboaScQFTz9xD9i1AfEKuLrqcaT6ZG2XD5E1I+eUxB+SxH6dGIcNKcViMm?= =?us-ascii?Q?OAHWk6s/ts0p38Yv2RTf5kimezb2vnvV3gb85aS+9bvDCMX0nHEv+0TL6wMt?= =?us-ascii?Q?uyLHRi4+b5TMVMruukN3/csvnID9p1aV5ceR6d3qM+5CTON3+JPJEyrv30BG?= =?us-ascii?Q?Oju9DGmuSlsNyl3aLob1IX+rSnlAuO2sPtobCxe5e5m65TPcsCdlOPLDZGTI?= =?us-ascii?Q?6pucSRt2h4IH3U6XL6kvtMxaVn7uz9PwB6rMZDtFu4GJ7hZUm58ypfsZzRGp?= =?us-ascii?Q?CaZH1DDiw72Q/qr33SOxzPK6G1IYAAQl4AnrEh2qsaJ7rqlzbtc6Wi5hhv/s?= =?us-ascii?Q?5ffNdfhD3x5aWDaw8Xotc/zdExtagB7vu8Vf00H/hbTTffeEFEl94TCEPbmN?= =?us-ascii?Q?IaUqYAr4OYkbKf9SP+BS918UTn+nMmPlZ8M5KcS+vZXmt5QNRIr09pmSUFff?= =?us-ascii?Q?GeWHDZ40w+pPzD9qNkE9euVNU1Ox1ceLznSY863X5p+ncv7Ym09O1iIrwLjQ?= =?us-ascii?Q?9rdQU18EUTEXTqfHgQzvc2r8exCg2ZL9IARnAPjR/dOBhZ+C3tfPcrc9kZKL?= =?us-ascii?Q?kWGNWTXJTlPhAiQMfgBShaVMLzN9ZYV/VmRH/cxBhWk7TViBduEpNpBxAPWF?= =?us-ascii?Q?tSvAgxVEfm83/gGamdK+FeJBnibzoIqhnGc0ndtVV5WRLhk1J6WpI4Lf0ny1?= =?us-ascii?Q?8s1SDNiF9zgxCqKi2eQ5k75G3bE6FdY4j6zD2VCCcCXKWXyQSKqKGLij+mC9?= =?us-ascii?Q?gMdNzjD8yj9apZtA3sfMmjRi8m0aat8Eyet3YIFeZEsAKTdKP8qn8XdJAz4A?= =?us-ascii?Q?mNkfSxOXwtaYx/rcG07J/hQBPLJEswt3jxtM916NA1kkEuLGovB69XoEExaA?= =?us-ascii?Q?TFFiY2Y0n+EzEMXSFwCIy5XJmCWfw64lbn3Iscu+tDeE1Bbg4Kd9bhg/8asZ?= =?us-ascii?Q?9waqzGPocDBuUj+LTAGSNFrjecFCGIcGyM51Og9JCu9fAzQwNKjVOWUO0Ifm?= =?us-ascii?Q?02EKvSi/LTbqcGaLTQ0jZyQz7UeCkBgtDnqlF+oKLrP+Y19uE219bBirsg0/?= =?us-ascii?Q?EpoONK1tBHeqapub7MW/5zaEIfVSjkFhI+TbI3xF7JFNPnxSS9B2fjZP6JzB?= =?us-ascii?Q?U2ncpWtZ86rg5NOpy1QzrFMVDgXST4/28KUg05d1d83huhob64RRDPYdDsdH?= =?us-ascii?Q?Bhxe8fMThxkbdmMRySzlgg0vmAXedjoOetpYKsSbaiTDW5iXS24XzP0gZOGM?= =?us-ascii?Q?i76V5k5mgHpgCaakNLDW131/f4j2kzWUgaAAx2ixia5AevKHfkATPg3Jcr6Y?= =?us-ascii?Q?L2mEQ4TNnznXT9TIFZ8l0PBX/WGlMANlg6y4US5Eyc/UMSrEaxenPjGTPjjR?= =?us-ascii?Q?pLZO1wihmDRC+ZdUY1LZ7xEih0l7AKwCpL2asszqla5In+xIFJoBdsIMwgcb?= =?us-ascii?Q?H7IGD5jTHL/SHuZ0/cAEpz8Os5OeqxWqVEErM42Vq0stRc16Nf3obr1Bjmcw?= =?us-ascii?Q?fTshyAT0IiSC+Q9p4zkqU5rjfklFoq2o+KmShEkRlKMIIdOsl7g4evx1MaoM?= =?us-ascii?Q?H+jx8u1Dd0sGdUBOyPNYZB7UFVTh11kTNz2ft1gAX2HsS5gxnt/mOwVLQmYX?= =?us-ascii?Q?pm3dr6+1uFah5MAddqE37xzntgMjuDFpFZhgY21PQOJ7slCsGf0ZqXWvgRgb?= =?us-ascii?Q?Hdt6dA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4824.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f541bd10-2b70-43fb-93cf-08d9e00827e8 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2022 13:39:48.2299 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mONVieks51HKJlAcaICSdLX3vDRebyztxltBEjWN3XGsGlyFOnwrcoKnhYudiW4cfnxZLcgXl0y9/oWRR9a1ebbezGNXifxSld2I+6HiiKQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5608 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Shijith, Some more comments. > -----Original Message----- > From: Gujjar, Abhinandan S > Sent: Monday, January 24, 2022 12:14 AM > To: Shijith Thotton ; dev@dpdk.org; > jerinj@marvell.com > Cc: anoobj@marvell.com; pbhagavatula@marvell.com; gakhil@marvell.com > Subject: RE: [PATCH v3] app/eventdev: add crypto producer mode >=20 > Hi Shijith, >=20 > Please find some comments inline. >=20 > > -----Original Message----- > > From: Shijith Thotton > > Sent: Tuesday, January 4, 2022 4:01 PM > > To: dev@dpdk.org; jerinj@marvell.com > > Cc: Shijith Thotton ; anoobj@marvell.com; > > pbhagavatula@marvell.com; gakhil@marvell.com; Gujjar, Abhinandan S > > > > Subject: [PATCH v3] app/eventdev: add crypto producer mode > > > > In crypto producer mode, producer core enqueues cryptodev with > > software generated crypto ops and worker core dequeues crypto > > completion events from the eventdev. Event crypto metadata used for > > above processing is pre- populated in each crypto session. > > > > Parameter --prod_type_cryptodev can be used to enable crypto producer > > mode. Parameter --crypto_adptr_mode can be set to select the crypto > > adapter mode, 0 for OP_NEW and 1 for OP_FORWARD. > > > > This mode can be used to measure the performance of crypto adapter. > > > > Example: > > ./dpdk-test-eventdev -l 0-2 -w -w -- \ > > --prod_type_cryptodev --crypto_adptr_mode 1 --test=3Dperf_atq \ > > --stlist=3Da --wlcores 1 --plcores 2 > > > > Signed-off-by: Shijith Thotton > > --- > > v3: > > * Reduce dereference inside loop. > > > > v2: > > * Fix RHEL compilation warning. > > > > app/test-eventdev/evt_common.h | 3 + > > app/test-eventdev/evt_main.c | 13 +- > > app/test-eventdev/evt_options.c | 27 ++ > > app/test-eventdev/evt_options.h | 12 + > > app/test-eventdev/evt_test.h | 6 + > > app/test-eventdev/test_perf_atq.c | 51 ++++ > > app/test-eventdev/test_perf_common.c | 410 > > ++++++++++++++++++++++++++- app/test- > > eventdev/test_perf_common.h | 16 ++ app/test- > > eventdev/test_perf_queue.c | 52 ++++ > > doc/guides/tools/testeventdev.rst | 13 + > > 10 files changed, 596 insertions(+), 7 deletions(-) > > > > diff --git a/app/test-eventdev/evt_common.h b/app/test- > > eventdev/evt_common.h index f466434459..2f301a7e79 100644 > > --- a/app/test-eventdev/evt_common.h > > +++ b/app/test-eventdev/evt_common.h > > @@ -7,6 +7,7 @@ > > > > #include > > #include > > +#include > > #include > > #include > > > > @@ -39,6 +40,7 @@ enum evt_prod_type { > > EVT_PROD_TYPE_SYNT, /* Producer type Synthetic i.e. CPU. */ > > EVT_PROD_TYPE_ETH_RX_ADPTR, /* Producer type Eth Rx Adapter. > > */ > > EVT_PROD_TYPE_EVENT_TIMER_ADPTR, /* Producer type Timer > Adapter. */ > > + EVT_PROD_TYPE_EVENT_CRYPTO_ADPTR, /* Producer type Crypto > > Adapter. */ > > EVT_PROD_TYPE_MAX, > > }; > > > > @@ -77,6 +79,7 @@ struct evt_options { > > uint64_t timer_tick_nsec; > > uint64_t optm_timer_tick_nsec; > > enum evt_prod_type prod_type; > > + enum rte_event_crypto_adapter_mode crypto_adptr_mode; > > }; > > > > static inline bool > > diff --git a/app/test-eventdev/evt_main.c > > b/app/test-eventdev/evt_main.c index 194c980c7a..cef0fb1382 100644 > > --- a/app/test-eventdev/evt_main.c > > +++ b/app/test-eventdev/evt_main.c > > @@ -161,12 +161,19 @@ main(int argc, char **argv) > > goto mempool_destroy; > > } > > } > New line required > > + /* Test specific cryptodev setup */ > > + if (test->ops.cryptodev_setup) { > > + if (test->ops.cryptodev_setup(test, &opt)) { > > + evt_err("%s: cryptodev setup failed", > > opt.test_name); > > + goto ethdev_destroy; > > + } > > + } > > > > /* Test specific eventdev setup */ > > if (test->ops.eventdev_setup) { > > if (test->ops.eventdev_setup(test, &opt)) { > > evt_err("%s: eventdev setup failed", > opt.test_name); > > - goto ethdev_destroy; > > + goto cryptodev_destroy; > > } > > } > > > > @@ -197,6 +204,10 @@ main(int argc, char **argv) > > if (test->ops.eventdev_destroy) > > test->ops.eventdev_destroy(test, &opt); > > > > +cryptodev_destroy: > > + if (test->ops.cryptodev_destroy) > > + test->ops.cryptodev_destroy(test, &opt); > > + > > ethdev_destroy: > > if (test->ops.ethdev_destroy) > > test->ops.ethdev_destroy(test, &opt); diff --git a/app/test- > > eventdev/evt_options.c b/app/test-eventdev/evt_options.c index > > 753a7dbd7d..5ad1491020 100644 > > --- a/app/test-eventdev/evt_options.c > > +++ b/app/test-eventdev/evt_options.c > > @@ -122,6 +122,26 @@ evt_parse_timer_prod_type_burst(struct > > evt_options *opt, > > return 0; > > } > > > > +static int > > +evt_parse_crypto_prod_type(struct evt_options *opt, > > + const char *arg __rte_unused) > > +{ > > + opt->prod_type =3D EVT_PROD_TYPE_EVENT_CRYPTO_ADPTR; > > + return 0; > > +} > > + > > +static int > > +evt_parse_crypto_adptr_mode(struct evt_options *opt, const char *arg) > { > > + uint8_t mode; > > + int ret; > > + > > + ret =3D parser_read_uint8(&mode, arg); > > + opt->crypto_adptr_mode =3D mode ? > > RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD : > > + > > RTE_EVENT_CRYPTO_ADAPTER_OP_NEW; > > + return ret; > > +} > > + > > static int > > evt_parse_test_name(struct evt_options *opt, const char *arg) { @@ - > > 335,6 +355,7 @@ usage(char *program) > > "\t--queue_priority : enable queue priority\n" > > "\t--deq_tmo_nsec : global dequeue timeout\n" > > "\t--prod_type_ethdev : use ethernet device as > producer.\n" > > + "\t--prod_type_cryptodev : use crypto device as > > producer.\n" > > "\t--prod_type_timerdev : use event timer device as > producer.\n" > > "\t expity_nsec would be the timeout\n" > > "\t in ns.\n" > > @@ -345,6 +366,8 @@ usage(char *program) > > "\t--timer_tick_nsec : timer tick interval in ns.\n" > > "\t--max_tmo_nsec : max timeout interval in ns.\n" > > "\t--expiry_nsec : event timer expiry ns.\n" > > + "\t--crypto_adptr_mode : 0 for OP_NEW mode (default) > > and\n" > > + "\t 1 for OP_FORWARD mode.\n" > > "\t--mbuf_sz : packet mbuf size.\n" > > "\t--max_pkt_sz : max packet size.\n" > > "\t--prod_enq_burst_sz : producer enqueue burst size.\n" > > @@ -415,8 +438,10 @@ static struct option lgopts[] =3D { > > { EVT_QUEUE_PRIORITY, 0, 0, 0 }, > > { EVT_DEQ_TMO_NSEC, 1, 0, 0 }, > > { EVT_PROD_ETHDEV, 0, 0, 0 }, > > + { EVT_PROD_CRYPTODEV, 0, 0, 0 }, > > { EVT_PROD_TIMERDEV, 0, 0, 0 }, > > { EVT_PROD_TIMERDEV_BURST, 0, 0, 0 }, > > + { EVT_CRYPTO_ADPTR_MODE, 1, 0, 0 }, > > { EVT_NB_TIMERS, 1, 0, 0 }, > > { EVT_NB_TIMER_ADPTRS, 1, 0, 0 }, > > { EVT_TIMER_TICK_NSEC, 1, 0, 0 }, > > @@ -455,8 +480,10 @@ evt_opts_parse_long(int opt_idx, struct > > evt_options > > *opt) > > { EVT_QUEUE_PRIORITY, evt_parse_queue_priority}, > > { EVT_DEQ_TMO_NSEC, evt_parse_deq_tmo_nsec}, > > { EVT_PROD_ETHDEV, evt_parse_eth_prod_type}, > > + { EVT_PROD_CRYPTODEV, evt_parse_crypto_prod_type}, > > { EVT_PROD_TIMERDEV, evt_parse_timer_prod_type}, > > { EVT_PROD_TIMERDEV_BURST, > > evt_parse_timer_prod_type_burst}, > > + { EVT_CRYPTO_ADPTR_MODE, > > evt_parse_crypto_adptr_mode}, > > { EVT_NB_TIMERS, evt_parse_nb_timers}, > > { EVT_NB_TIMER_ADPTRS, evt_parse_nb_timer_adptrs}, > > { EVT_TIMER_TICK_NSEC, evt_parse_timer_tick_nsec}, diff -- > git > > a/app/test-eventdev/evt_options.h b/app/test-eventdev/evt_options.h > > index 413d7092f0..2231c58801 100644 > > --- a/app/test-eventdev/evt_options.h > > +++ b/app/test-eventdev/evt_options.h > > @@ -9,6 +9,7 @@ > > #include > > > > #include > > +#include > > #include > > #include > > #include > > @@ -33,8 +34,10 @@ > > #define EVT_QUEUE_PRIORITY ("queue_priority") > > #define EVT_DEQ_TMO_NSEC ("deq_tmo_nsec") > > #define EVT_PROD_ETHDEV ("prod_type_ethdev") > > +#define EVT_PROD_CRYPTODEV ("prod_type_cryptodev") > > #define EVT_PROD_TIMERDEV ("prod_type_timerdev") > > #define EVT_PROD_TIMERDEV_BURST ("prod_type_timerdev_burst") > > +#define EVT_CRYPTO_ADPTR_MODE ("crypto_adptr_mode") > > #define EVT_NB_TIMERS ("nb_timers") > > #define EVT_NB_TIMER_ADPTRS ("nb_timer_adptrs") > > #define EVT_TIMER_TICK_NSEC ("timer_tick_nsec") > > @@ -249,6 +252,8 @@ evt_prod_id_to_name(enum evt_prod_type > > prod_type) > > return "Ethdev Rx Adapter"; > > case EVT_PROD_TYPE_EVENT_TIMER_ADPTR: > > return "Event timer adapter"; > > + case EVT_PROD_TYPE_EVENT_CRYPTO_ADPTR: > > + return "Event crypto adapter"; > > } > > > > return ""; > > @@ -288,6 +293,13 @@ evt_dump_producer_type(struct evt_options > *opt) > > evt_dump("timer_tick_nsec", "%"PRIu64"", > > opt->timer_tick_nsec); > > break; > > + case EVT_PROD_TYPE_EVENT_CRYPTO_ADPTR: > > + snprintf(name, EVT_PROD_MAX_NAME_LEN, > > + "Event crypto adapter producers"); > > + evt_dump("crypto adapter mode", "%s", > > + opt->crypto_adptr_mode ? "OP_FORWARD" : > > "OP_NEW"); > > + evt_dump("nb_cryptodev", "%u", rte_cryptodev_count()); > > + break; > > } > > evt_dump("prod_type", "%s", name); > > } > > diff --git a/app/test-eventdev/evt_test.h > > b/app/test-eventdev/evt_test.h index f07d2c3336..50fa474ec2 100644 > > --- a/app/test-eventdev/evt_test.h > > +++ b/app/test-eventdev/evt_test.h > > @@ -29,6 +29,8 @@ typedef int (*evt_test_mempool_setup_t) > > (struct evt_test *test, struct evt_options *opt); typedef int > > (*evt_test_ethdev_setup_t) > > (struct evt_test *test, struct evt_options *opt); > > +typedef int (*evt_test_cryptodev_setup_t) > > + (struct evt_test *test, struct evt_options *opt); > > typedef int (*evt_test_eventdev_setup_t) > > (struct evt_test *test, struct evt_options *opt); typedef int > > (*evt_test_launch_lcores_t) @@ -39,6 +41,8 @@ typedef void > > (*evt_test_eventdev_destroy_t) > > (struct evt_test *test, struct evt_options *opt); typedef void > > (*evt_test_ethdev_destroy_t) > > (struct evt_test *test, struct evt_options *opt); > > +typedef void (*evt_test_cryptodev_destroy_t) > > + (struct evt_test *test, struct evt_options *opt); > > typedef void (*evt_test_mempool_destroy_t) > > (struct evt_test *test, struct evt_options *opt); typedef void > > (*evt_test_destroy_t) @@ -52,10 +56,12 @@ struct evt_test_ops { > > evt_test_mempool_setup_t mempool_setup; > > evt_test_ethdev_setup_t ethdev_setup; > > evt_test_eventdev_setup_t eventdev_setup; > > + evt_test_cryptodev_setup_t cryptodev_setup; > > evt_test_launch_lcores_t launch_lcores; > > evt_test_result_t test_result; > > evt_test_eventdev_destroy_t eventdev_destroy; > > evt_test_ethdev_destroy_t ethdev_destroy; > > + evt_test_cryptodev_destroy_t cryptodev_destroy; > > evt_test_mempool_destroy_t mempool_destroy; > > evt_test_destroy_t test_destroy; > > }; > > diff --git a/app/test-eventdev/test_perf_atq.c b/app/test- > > eventdev/test_perf_atq.c index 8fd51004ee..dbb1dc8c0c 100644 > > --- a/app/test-eventdev/test_perf_atq.c > > +++ b/app/test-eventdev/test_perf_atq.c > > @@ -48,6 +48,22 @@ perf_atq_worker(void *arg, const int > > enable_fwd_latency) > > continue; > > } > > > > + if (prod_crypto_type && > > + (ev.event_type =3D=3D RTE_EVENT_TYPE_CRYPTODEV)) { > > + struct rte_crypto_op *op =3D ev.event_ptr; > > + > > + if (op->status =3D=3D > > RTE_CRYPTO_OP_STATUS_SUCCESS) { > > + if (op->sym->m_dst =3D=3D NULL) > > + ev.event_ptr =3D op->sym->m_src; > > + else > > + ev.event_ptr =3D op->sym->m_dst; > > + rte_crypto_op_free(op); > > + } else { > > + rte_crypto_op_free(op); > > + continue; > > + } > > + } > > + > > if (enable_fwd_latency && !prod_timer_type) > > /* first stage in pipeline, mark ts to compute fwd latency */ > > atq_mark_fwd_latency(&ev); > > @@ -87,6 +103,25 @@ perf_atq_worker_burst(void *arg, const int > > enable_fwd_latency) > > } > > > > for (i =3D 0; i < nb_rx; i++) { > > + if (prod_crypto_type && > > + (ev[i].event_type =3D=3D > > RTE_EVENT_TYPE_CRYPTODEV)) { > > + struct rte_crypto_op *op =3D ev[i].event_ptr; > > + > > + if (op->status =3D=3D > > + RTE_CRYPTO_OP_STATUS_SUCCESS) { > > + if (op->sym->m_dst =3D=3D NULL) > > + ev[i].event_ptr =3D > > + op->sym->m_src; > > + else > > + ev[i].event_ptr =3D > > + op->sym->m_dst; > > + rte_crypto_op_free(op); > > + } else { > > + rte_crypto_op_free(op); > > + continue; > > + } > > + } > > + > > if (enable_fwd_latency && !prod_timer_type) { > > rte_prefetch0(ev[i+1].event_ptr); > > /* first stage in pipeline. > > @@ -254,6 +289,20 @@ perf_atq_eventdev_setup(struct evt_test *test, > > struct evt_options *opt) > > return ret; > > } > > } > > + } else if (opt->prod_type =3D=3D > > EVT_PROD_TYPE_EVENT_CRYPTO_ADPTR) { > > + uint8_t cdev_id, cdev_count; > > + > > + cdev_count =3D rte_cryptodev_count(); > > + for (cdev_id =3D 0; cdev_id < cdev_count; cdev_id++) { > > + ret =3D rte_cryptodev_start(cdev_id); > > + if (ret) { > > + evt_err("Failed to start cryptodev %u", > > + cdev_id); > > + return ret; > > + } > > + } > > + > > + rte_event_crypto_adapter_start(t->crypto_adptr.id); > > } > > > > return 0; > > @@ -295,12 +344,14 @@ static const struct evt_test_ops perf_atq =3D { > > .opt_dump =3D perf_atq_opt_dump, > > .test_setup =3D perf_test_setup, > > .ethdev_setup =3D perf_ethdev_setup, > > + .cryptodev_setup =3D perf_cryptodev_setup, > > .mempool_setup =3D perf_mempool_setup, > > .eventdev_setup =3D perf_atq_eventdev_setup, > > .launch_lcores =3D perf_atq_launch_lcores, > > .eventdev_destroy =3D perf_eventdev_destroy, > > .mempool_destroy =3D perf_mempool_destroy, > > .ethdev_destroy =3D perf_ethdev_destroy, > > + .cryptodev_destroy =3D perf_cryptodev_destroy, > > .test_result =3D perf_test_result, > > .test_destroy =3D perf_test_destroy, > > }; > > diff --git a/app/test-eventdev/test_perf_common.c b/app/test- > > eventdev/test_perf_common.c index 9b73874151..91cb6748ee 100644 > > --- a/app/test-eventdev/test_perf_common.c > > +++ b/app/test-eventdev/test_perf_common.c > > @@ -6,6 +6,8 @@ > > > > #include "test_perf_common.h" > > > > +#define NB_CRYPTODEV_DESCRIPTORS 128 > > + > > int > > perf_test_result(struct evt_test *test, struct evt_options *opt) { > > @@ -272,6 > > +274,125 @@ perf_event_timer_producer_burst(void *arg) > > return 0; > > } > > > > +static inline void > > +crypto_adapter_enq_op_new(struct prod_data *p) { > > + struct rte_cryptodev_sym_session **crypto_sess =3D p->crypto_sess; > > + struct test_perf *t =3D p->t; > > + const uint32_t nb_flows =3D t->nb_flows; > > + const uint64_t nb_pkts =3D t->nb_pkts; > > + struct rte_mempool *pool =3D t->pool; > > + struct rte_crypto_sym_op *sym_op; > > + struct evt_options *opt =3D t->opt; > > + uint16_t qp_id =3D p->cdev_qp_id; > > + uint8_t cdev_id =3D p->cdev_id; > > + uint32_t flow_counter =3D 0; > > + struct rte_crypto_op *op; > > + struct rte_mbuf *m; > > + uint64_t count =3D 0; > > + uint16_t len; > > + > > + if (opt->verbose_level > 1) > > + printf("%s(): lcore %d queue %d cdev_id %u cdev_qp_id > > %u\n", > > + __func__, rte_lcore_id(), p->queue_id, p->cdev_id, > > + p->cdev_qp_id); > > + > > + len =3D opt->mbuf_sz ? opt->mbuf_sz : RTE_ETHER_MIN_LEN; > > + > > + while (count < nb_pkts && t->done =3D=3D false) { > > + m =3D rte_pktmbuf_alloc(pool); > > + if (m =3D=3D NULL) > > + continue; > > + > > + rte_pktmbuf_append(m, len); > > + op =3D rte_crypto_op_alloc(t->crypto_adptr.op_pool, NULL check for op is missing > > + > > RTE_CRYPTO_OP_TYPE_SYMMETRIC); > > + sym_op =3D op->sym; > > + sym_op->m_src =3D m; > > + sym_op->cipher.data.offset =3D 0; > > + sym_op->cipher.data.length =3D len; > > + rte_crypto_op_attach_sym_session( > > + op, crypto_sess[flow_counter++ % nb_flows]); > > + while (rte_cryptodev_enqueue_burst(cdev_id, qp_id, &op, > > 1) !=3D > > + 1) { > > + if (t->done) > > + break; > > + rte_pause(); > > + } > > + count++; > > + } > > +} > > + > > +static inline void > > +crypto_adapter_enq_op_fwd(struct prod_data *p) { > > + struct rte_cryptodev_sym_session **crypto_sess =3D p->crypto_sess; > > + const uint8_t dev_id =3D p->dev_id; > > + const uint8_t port =3D p->port_id; > > + struct test_perf *t =3D p->t; > > + const uint32_t nb_flows =3D t->nb_flows; > > + const uint64_t nb_pkts =3D t->nb_pkts; > > + struct rte_mempool *pool =3D t->pool; > > + struct evt_options *opt =3D t->opt; > > + struct rte_crypto_sym_op *sym_op; > > + uint32_t flow_counter =3D 0; > > + struct rte_crypto_op *op; > > + struct rte_event ev; > > + struct rte_mbuf *m; > > + uint64_t count =3D 0; > > + uint16_t len; > > + > > + if (opt->verbose_level > 1) > > + printf("%s(): lcore %d port %d queue %d cdev_id %u > > cdev_qp_id %u\n", > > + __func__, rte_lcore_id(), port, p->queue_id, p->cdev_id, > > + p->cdev_qp_id); > > + > > + ev.event =3D 0; > > + ev.op =3D RTE_EVENT_OP_NEW; So, this is an new event and adapter treats it as OP_FWD? > > + ev.queue_id =3D p->queue_id; > > + ev.sched_type =3D RTE_SCHED_TYPE_ATOMIC; > > + ev.event_type =3D RTE_EVENT_TYPE_CPU; > > + len =3D opt->mbuf_sz ? opt->mbuf_sz : RTE_ETHER_MIN_LEN; > > + > > + while (count < nb_pkts && t->done =3D=3D false) { > > + m =3D rte_pktmbuf_alloc(pool); > > + if (m =3D=3D NULL) > > + continue; > > + > > + rte_pktmbuf_append(m, len); > > + op =3D rte_crypto_op_alloc(t->crypto_adptr.op_pool, > > + > > RTE_CRYPTO_OP_TYPE_SYMMETRIC); > > + sym_op =3D op->sym; > > + sym_op->m_src =3D m; > > + sym_op->cipher.data.offset =3D 0; > > + sym_op->cipher.data.length =3D len; > > + rte_crypto_op_attach_sym_session( > > + op, crypto_sess[flow_counter++ % nb_flows]); > > + ev.event_ptr =3D op; > > + while (rte_event_crypto_adapter_enqueue(dev_id, port, > > &ev, 1) !=3D > > + 1) { If the adapter OP_FWD is supported by rte_event_enqueue_burst(), then even = that path has to be tested. Please add it. > > + if (t->done) > > + break; > > + rte_pause(); > > + } > > + count++; > > + } > > +} > > + > > +static inline int > > +perf_event_crypto_producer(void *arg) { > > + struct prod_data *p =3D arg; > > + struct evt_options *opt =3D p->t->opt; > > + > > + if (opt->crypto_adptr_mode =3D=3D > > RTE_EVENT_CRYPTO_ADAPTER_OP_NEW) > > + crypto_adapter_enq_op_new(p); > > + else > > + crypto_adapter_enq_op_fwd(p); > > + > > + return 0; > > +} > > + > > static int > > perf_producer_wrapper(void *arg) > > { > > @@ -298,6 +419,8 @@ perf_producer_wrapper(void *arg) > > else if (t->opt->prod_type =3D=3D > > EVT_PROD_TYPE_EVENT_TIMER_ADPTR && > > t->opt->timdev_use_burst) > > return perf_event_timer_producer_burst(arg); > > + else if (t->opt->prod_type =3D=3D > > EVT_PROD_TYPE_EVENT_CRYPTO_ADPTR) > > + return perf_event_crypto_producer(arg); > > return 0; > > } > > > > @@ -405,8 +528,10 @@ perf_launch_lcores(struct evt_test *test, struct > > evt_options *opt, > > if (remaining <=3D 0) { > > t->result =3D EVT_TEST_SUCCESS; > > if (opt->prod_type =3D=3D > > EVT_PROD_TYPE_SYNT || > > - opt->prod_type =3D=3D > > - > > EVT_PROD_TYPE_EVENT_TIMER_ADPTR) { > > + opt->prod_type =3D=3D > > + > > EVT_PROD_TYPE_EVENT_TIMER_ADPTR || > > + opt->prod_type =3D=3D > > + > > EVT_PROD_TYPE_EVENT_CRYPTO_ADPTR) { > > t->done =3D true; > > break; > > } > > @@ -415,7 +540,8 @@ perf_launch_lcores(struct evt_test *test, struct > > evt_options *opt, > > > > if (new_cycles - dead_lock_cycles > dead_lock_sample && > > (opt->prod_type =3D=3D EVT_PROD_TYPE_SYNT || > > - opt->prod_type =3D=3D > > EVT_PROD_TYPE_EVENT_TIMER_ADPTR)) { > > + opt->prod_type =3D=3D > > EVT_PROD_TYPE_EVENT_TIMER_ADPTR || > > + opt->prod_type =3D=3D > > EVT_PROD_TYPE_EVENT_CRYPTO_ADPTR)) { > > remaining =3D t->outstand_pkts - processed_pkts(t); > > if (dead_lock_remaining =3D=3D remaining) { > > rte_event_dev_dump(opt->dev_id, stdout); > @@ -537,6 +663,96 @@ > > perf_event_timer_adapter_setup(struct test_perf > > *t) > > return 0; > > } > > > > +static int > > +perf_event_crypto_adapter_setup(struct test_perf *t, > > + struct rte_event_port_conf port_conf) { > > + struct evt_options *opt =3D t->opt; > > + uint8_t cdev_id, cdev_count; > > + int ret; > > + > > + t->crypto_adptr.id =3D 0; > > + ret =3D rte_event_crypto_adapter_create(t->crypto_adptr.id, opt- > > >dev_id, > > + &port_conf, 0); > > + if (ret) > > + return ret; > > + > > + cdev_count =3D rte_cryptodev_count(); > > + for (cdev_id =3D 0; cdev_id < cdev_count; cdev_id++) { > > + uint32_t cap; > > + > > + ret =3D rte_event_crypto_adapter_caps_get(opt->dev_id, > > cdev_id, > > + &cap); > > + if (ret) { > > + evt_err("Failed to get crypto adapter capabilities"); > > + return ret; > > + } > > + > > + if (((opt->crypto_adptr_mode =3D=3D > > + RTE_EVENT_CRYPTO_ADAPTER_OP_NEW) && > > + !(cap & > > + > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW)) || > > + ((opt->crypto_adptr_mode =3D=3D > > + RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD) && > > + !(cap & > > + > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD))) { > > + evt_err("crypto adapter %s mode unsupported\n", > > + opt->crypto_adptr_mode ? "OP_FORWARD" > > : > > + "OP_NEW"); > > + return -EINVAL; > > + } > > + > > + if (!(cap & > > + > > RTE_EVENT_CRYPTO_ADAPTER_CAP_SESSION_PRIVATE_DATA)) { > > + evt_err("Storing crypto session not supported"); > > + return -EINVAL; > > + } > > + > > + if (cap & > > + > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) { > > + struct rte_event response_info; > > + > > + response_info.event =3D 0; It is good that you are covering even this case. Should not you fill event = with valid values? > > + ret =3D rte_event_crypto_adapter_queue_pair_add( > > + t->crypto_adptr.id, cdev_id, -1, > > + &response_info); > > + } else { > > + ret =3D rte_event_crypto_adapter_queue_pair_add( > > + t->crypto_adptr.id, cdev_id, -1, NULL); > > + } New line > > + if (ret) > > + return ret; > > + } > > + > > + return 0; > > +} > > + > > +static struct rte_cryptodev_sym_session * > > +cryptodev_sym_sess_create(struct prod_data *p, struct test_perf *t) { > > + struct rte_crypto_sym_xform cipher_xform; > > + struct rte_cryptodev_sym_session *sess; > > + > > + cipher_xform.type =3D RTE_CRYPTO_SYM_XFORM_CIPHER; > > + cipher_xform.cipher.algo =3D RTE_CRYPTO_CIPHER_NULL; > > + cipher_xform.cipher.op =3D RTE_CRYPTO_CIPHER_OP_ENCRYPT; > > + cipher_xform.next =3D NULL; > > + > > + sess =3D rte_cryptodev_sym_session_create(t- > > >crypto_adptr.sess_pool); > > + if (sess =3D=3D NULL) { > > + evt_err("Failed to create sym session"); > > + return NULL; > > + } > > + > > + if (rte_cryptodev_sym_session_init(p->cdev_id, sess, > > &cipher_xform, > > + t->crypto_adptr.sess_priv_pool)) { > > + evt_err("Failed to init session"); > > + return NULL; > > + } > > + > > + return sess; > > +} > > + > > int > > perf_event_dev_port_setup(struct evt_test *test, struct evt_options > *opt, > > uint8_t stride, uint8_t nb_queues, @@ - > 598,6 +814,55 @@ > > perf_event_dev_port_setup(struct evt_test *test, struct evt_options > > *opt, > > ret =3D perf_event_timer_adapter_setup(t); > > if (ret) > > return ret; > > + } else if (opt->prod_type =3D=3D > > EVT_PROD_TYPE_EVENT_CRYPTO_ADPTR) { > > + uint8_t cdev_id =3D 0; > > + uint16_t qp_id =3D 0; > > + > > + prod =3D 0; > > + for (; port < perf_nb_event_ports(opt); port++) { > > + struct rte_cryptodev_sym_session *crypto_sess; > > + union rte_event_crypto_metadata m_data; > > + struct prod_data *p =3D &t->prod[port]; > > + uint32_t flow_id; > > + > > + if (qp_id =3D=3D > > rte_cryptodev_queue_pair_count(cdev_id)) { > > + cdev_id++; > > + qp_id =3D 0; > > + } > > + > > + p->dev_id =3D opt->dev_id; > > + p->port_id =3D port; > > + p->queue_id =3D prod * stride; > > + p->cdev_id =3D cdev_id; > > + p->cdev_qp_id =3D qp_id; > > + p->crypto_sess =3D rte_zmalloc_socket( > > + NULL, sizeof(crypto_sess) * t->nb_flows, > > + RTE_CACHE_LINE_SIZE, opt->socket_id); > > + > > + m_data.request_info.cdev_id =3D p->cdev_id; > > + m_data.request_info.queue_pair_id =3D p- > > >cdev_qp_id; > > + m_data.response_info.op =3D RTE_EVENT_OP_NEW; > > + m_data.response_info.sched_type =3D > > RTE_SCHED_TYPE_ATOMIC; > > + m_data.response_info.event_type =3D > > RTE_EVENT_TYPE_CPU; > > + m_data.response_info.queue_id =3D p->queue_id; > > + for (flow_id =3D 0; flow_id < t->nb_flows; flow_id++) { > > + crypto_sess =3D > > cryptodev_sym_sess_create(p, t); > > + if (crypto_sess =3D=3D NULL) > > + return -ENOMEM; > > + > > + m_data.response_info.flow_id =3D flow_id; > > + rte_cryptodev_sym_session_set_user_data( > > + crypto_sess, &m_data, > > sizeof(m_data)); > > + p->crypto_sess[flow_id] =3D crypto_sess; > > + } New line > > + p->t =3D t; > > + qp_id++; > > + prod++; > > + } > > + > > + ret =3D perf_event_crypto_adapter_setup(t, *port_conf); > > + if (ret) > > + return ret; > > } else { > > prod =3D 0; > > for ( ; port < perf_nb_event_ports(opt); port++) { @@ -659,7 > > +924,8 @@ perf_opt_check(struct evt_options *opt, uint64_t nb_queues) > > } > > > > if (opt->prod_type =3D=3D EVT_PROD_TYPE_SYNT || > > - opt->prod_type =3D=3D > > EVT_PROD_TYPE_EVENT_TIMER_ADPTR) { > > + opt->prod_type =3D=3D EVT_PROD_TYPE_EVENT_TIMER_ADPTR || > > + opt->prod_type =3D=3D EVT_PROD_TYPE_EVENT_CRYPTO_ADPTR) { > > /* Validate producer lcores */ > > if (evt_lcores_has_overlap(opt->plcores, > > rte_get_main_lcore())) { > > @@ -767,8 +1033,7 @@ perf_ethdev_setup(struct evt_test *test, struct > > evt_options *opt) > > }, > > }; > > > > - if (opt->prod_type =3D=3D EVT_PROD_TYPE_SYNT || > > - opt->prod_type =3D=3D > > EVT_PROD_TYPE_EVENT_TIMER_ADPTR) > > + if (opt->prod_type !=3D EVT_PROD_TYPE_ETH_RX_ADPTR) > > return 0; > > > > if (!rte_eth_dev_count_avail()) { > > @@ -841,6 +1106,139 @@ void perf_ethdev_destroy(struct evt_test *test, > > struct evt_options *opt) > > } > > } > > > > +int > > +perf_cryptodev_setup(struct evt_test *test, struct evt_options *opt) { > > + uint8_t cdev_count, cdev_id, nb_plcores, nb_qps; > > + struct test_perf *t =3D evt_test_priv(test); > > + unsigned int max_session_size; > > + uint32_t nb_sessions; > > + int ret; > > + > > + if (opt->prod_type !=3D EVT_PROD_TYPE_EVENT_CRYPTO_ADPTR) > > + return 0; > How do you differentiate between this failed case as you are returning 0 = in > case of success? >=20 > > + > > + cdev_count =3D rte_cryptodev_count(); > > + if (cdev_count =3D=3D 0) { > > + evt_err("No crypto devices available\n"); > > + return -ENODEV; > > + } > > + > > + t->crypto_adptr.op_pool =3D rte_crypto_op_pool_create( > > + "crypto_op_pool", RTE_CRYPTO_OP_TYPE_SYMMETRIC, opt- > > >pool_sz, > > + 128, 0, rte_socket_id()); > > + if (t->crypto_adptr.op_pool =3D=3D NULL) { > > + evt_err("Failed to create crypto op pool"); > > + return -ENOMEM; > > + } > > + > > + nb_sessions =3D evt_nr_active_lcores(opt->plcores) * t->nb_flows; > > + t->crypto_adptr.sess_pool =3D > > rte_cryptodev_sym_session_pool_create( > > + "ca_sess_pool", nb_sessions, 0, 0, > > + sizeof(union rte_event_crypto_metadata), > > SOCKET_ID_ANY); > > + if (t->crypto_adptr.sess_pool =3D=3D NULL) { > > + evt_err("Failed to create sym session pool"); > > + ret =3D -ENOMEM; > > + goto err; > > + } > > + > > + max_session_size =3D 0; > > + for (cdev_id =3D 0; cdev_id < cdev_count; cdev_id++) { > > + unsigned int session_size; > > + > > + session_size =3D > > + > > rte_cryptodev_sym_get_private_session_size(cdev_id); > > + if (session_size > max_session_size) > > + max_session_size =3D session_size; > > + } > New line required > > + max_session_size +=3D sizeof(union rte_event_crypto_metadata); > > + t->crypto_adptr.sess_priv_pool =3D rte_mempool_create( > > + "ca_sess_priv_pool", nb_sessions, max_session_size, 0, 0, > > NULL, > > + NULL, NULL, NULL, SOCKET_ID_ANY, 0); > > + if (t->crypto_adptr.sess_priv_pool =3D=3D NULL) { > > + evt_err("failed to create sym session private pool"); > > + ret =3D -ENOMEM; > > + goto err; > > + } > > + > > + nb_plcores =3D evt_nr_active_lcores(opt->plcores); > > + nb_qps =3D (nb_plcores % cdev_count) ? (nb_plcores / cdev_count) + > > 1 : > > + nb_plcores / cdev_count; > Let's take an example: > Cdev1 -> 8 qps > Cdev2 -> 2 qps > Cdev_count =3D 2 > nb_plcores =3D 7 > As per above statement, nb_qps =3D ( 7 % 2 ) 7/2 + 1 =3D 4 qps So, this f= ails to > setup qps for cdev2 as it supports only 2 qps and test exits! Am I missin= g > anything? >=20 > > + for (cdev_id =3D 0; cdev_id < cdev_count; cdev_id++) { > > + struct rte_cryptodev_qp_conf qp_conf; > > + struct rte_cryptodev_config conf; > > + struct rte_cryptodev_info info; > > + int qp_id; > > + > > + rte_cryptodev_info_get(cdev_id, &info); > > + if (nb_qps > info.max_nb_queue_pairs) { > > + evt_err("Not enough queue pairs per cryptodev > > (%u)", > > + nb_qps); > > + ret =3D -EINVAL; > > + goto err; > > + } > > + > > + conf.nb_queue_pairs =3D nb_qps; > > + conf.socket_id =3D SOCKET_ID_ANY; > > + conf.ff_disable =3D RTE_CRYPTODEV_FF_SECURITY; > > + > > + ret =3D rte_cryptodev_configure(cdev_id, &conf); > > + if (ret) { > > + evt_err("Failed to configure cryptodev (%u)", > > cdev_id); > > + goto err; > > + } > > + > > + qp_conf.nb_descriptors =3D NB_CRYPTODEV_DESCRIPTORS; > > + qp_conf.mp_session =3D t->crypto_adptr.sess_pool; > > + qp_conf.mp_session_private =3D t- > > >crypto_adptr.sess_priv_pool; > > + > > + for (qp_id =3D 0; qp_id < conf.nb_queue_pairs; qp_id++) { > > + ret =3D rte_cryptodev_queue_pair_setup( > > + cdev_id, qp_id, &qp_conf, > > + rte_cryptodev_socket_id(cdev_id)); > > + if (ret) { > > + evt_err("Failed to setup queue pairs on > > cryptodev %u\n", > > + cdev_id); > > + goto err; > > + } > > + } > > + } > > + > > + return 0; > > +err: > > + rte_mempool_free(t->crypto_adptr.op_pool); > > + rte_mempool_free(t->crypto_adptr.sess_pool); > > + rte_mempool_free(t->crypto_adptr.sess_priv_pool); > > + > > + return ret; > > +} > > + > > +void > > +perf_cryptodev_destroy(struct evt_test *test, struct evt_options > > +*opt) { > > + uint8_t cdev_id, cdev_count =3D rte_cryptodev_count(); > > + struct test_perf *t =3D evt_test_priv(test); > > + > > + RTE_SET_USED(opt); > > + > > + if (opt->prod_type !=3D EVT_PROD_TYPE_EVENT_CRYPTO_ADPTR) > > + return; > > + > > + rte_event_crypto_adapter_stop(t->crypto_adptr.id); > > + > > + for (cdev_id =3D 0; cdev_id < cdev_count; cdev_id++) { > > + rte_cryptodev_stop(cdev_id); > > + rte_event_crypto_adapter_queue_pair_del(t- > > >crypto_adptr.id, > > + cdev_id, -1); > Any reason for passing -1? This can not ensure to cleanup all the > preconfigured qps as per API. > > + } > > + > > + rte_event_crypto_adapter_free(t->crypto_adptr.id); > > + > > + rte_mempool_free(t->crypto_adptr.op_pool); > > + rte_mempool_free(t->crypto_adptr.sess_pool); > > + rte_mempool_free(t->crypto_adptr.sess_priv_pool); > > +} > > + > > int > > perf_mempool_setup(struct evt_test *test, struct evt_options *opt) { > > diff - -git a/app/test-eventdev/test_perf_common.h b/app/test- > > eventdev/test_perf_common.h index 14dcf80429..d9ad3a0b0d 100644 > > --- a/app/test-eventdev/test_perf_common.h > > +++ b/app/test-eventdev/test_perf_common.h > > @@ -9,9 +9,11 @@ > > #include > > #include > > > > +#include > > #include > > #include > > #include > > +#include > > #include #include > > #include @@ -37,9 +39,18 > @@ > > struct prod_data { > > uint8_t dev_id; > > uint8_t port_id; > > uint8_t queue_id; > > + uint8_t cdev_id; > > + uint16_t cdev_qp_id; > > + struct rte_cryptodev_sym_session **crypto_sess; > > struct test_perf *t; > > } __rte_cache_aligned; > > > > +struct crypto_adptr_data { > > + uint8_t id; > > + struct rte_mempool *op_pool; > > + struct rte_mempool *sess_pool; > > + struct rte_mempool *sess_priv_pool; > > +}; > > > > struct test_perf { > > /* Don't change the offset of "done". Signal handler use this memory > > @@ -58,6 +69,7 @@ struct test_perf { > > uint8_t sched_type_list[EVT_MAX_STAGES] __rte_cache_aligned; > > struct rte_event_timer_adapter *timer_adptr[ > > RTE_EVENT_TIMER_ADAPTER_NUM_MAX] > > __rte_cache_aligned; > > + struct crypto_adptr_data crypto_adptr; > > } __rte_cache_aligned; > > > > struct perf_elt { > > @@ -81,6 +93,8 @@ struct perf_elt { > > const uint8_t port =3D w->port_id;\ > > const uint8_t prod_timer_type =3D \ > > opt->prod_type =3D=3D > > EVT_PROD_TYPE_EVENT_TIMER_ADPTR;\ > > + const uint8_t prod_crypto_type =3D \ > > + opt->prod_type =3D=3D > > EVT_PROD_TYPE_EVENT_CRYPTO_ADPTR;\ > > uint8_t *const sched_type_list =3D &t->sched_type_list[0];\ > > struct rte_mempool *const pool =3D t->pool;\ > > const uint8_t nb_stages =3D t->opt->nb_stages;\ @@ -154,6 +168,7 > @@ > > int perf_test_result(struct evt_test *test, struct evt_options *opt); > > int perf_opt_check(struct evt_options *opt, uint64_t nb_queues); int > > perf_test_setup(struct evt_test *test, struct evt_options *opt); int > > perf_ethdev_setup(struct evt_test *test, struct evt_options *opt); > > +int perf_cryptodev_setup(struct evt_test *test, struct evt_options > > +*opt); > > int perf_mempool_setup(struct evt_test *test, struct evt_options > > *opt); int perf_event_dev_port_setup(struct evt_test *test, struct > evt_options *opt, > > uint8_t stride, uint8_t nb_queues, @@ - > 164,6 +179,7 @@ int > > perf_launch_lcores(struct evt_test *test, struct evt_options *opt, > > void perf_opt_dump(struct evt_options *opt, uint8_t nb_queues); void > > perf_test_destroy(struct evt_test *test, struct evt_options *opt); > > void perf_eventdev_destroy(struct evt_test *test, struct evt_options > > *opt); > > +void perf_cryptodev_destroy(struct evt_test *test, struct evt_options > > +*opt); > > void perf_ethdev_destroy(struct evt_test *test, struct evt_options > > *opt); void perf_mempool_destroy(struct evt_test *test, struct > > evt_options *opt); > > > > diff --git a/app/test-eventdev/test_perf_queue.c b/app/test- > > eventdev/test_perf_queue.c index f4ea3a795f..5657c8b3cd 100644 > > --- a/app/test-eventdev/test_perf_queue.c > > +++ b/app/test-eventdev/test_perf_queue.c > > @@ -49,6 +49,23 @@ perf_queue_worker(void *arg, const int > > enable_fwd_latency) > > rte_pause(); > > continue; > > } > > + > > + if (prod_crypto_type && > > + (ev.event_type =3D=3D RTE_EVENT_TYPE_CRYPTODEV)) { > > + struct rte_crypto_op *op =3D ev.event_ptr; > > + > > + if (op->status =3D=3D > > RTE_CRYPTO_OP_STATUS_SUCCESS) { > > + if (op->sym->m_dst =3D=3D NULL) > > + ev.event_ptr =3D op->sym->m_src; > > + else > > + ev.event_ptr =3D op->sym->m_dst; > > + rte_crypto_op_free(op); > > + } else { > > + rte_crypto_op_free(op); > > + continue; > In case of failure, ops are freed and "ev.event_ptr" won't be set to mbuf= . > What would be the expected test result? > > + } > > + } > > + > > if (enable_fwd_latency && !prod_timer_type) > > /* first q in pipeline, mark timestamp to compute fwd latency > */ > > mark_fwd_latency(&ev, nb_stages); > > @@ -88,6 +105,25 @@ perf_queue_worker_burst(void *arg, const int > > enable_fwd_latency) > > } > > > > for (i =3D 0; i < nb_rx; i++) { > > + if (prod_crypto_type && > > + (ev[i].event_type =3D=3D > > RTE_EVENT_TYPE_CRYPTODEV)) { > > + struct rte_crypto_op *op =3D ev[i].event_ptr; > > + > > + if (op->status =3D=3D > > + RTE_CRYPTO_OP_STATUS_SUCCESS) { > > + if (op->sym->m_dst =3D=3D NULL) > > + ev[i].event_ptr =3D > > + op->sym->m_src; > > + else > > + ev[i].event_ptr =3D > > + op->sym->m_dst; > > + rte_crypto_op_free(op); > > + } else { > > + rte_crypto_op_free(op); > > + continue; > > + } > > + } > > + > > if (enable_fwd_latency && !prod_timer_type) { > > rte_prefetch0(ev[i+1].event_ptr); > > /* first queue in pipeline. > > @@ -269,6 +305,20 @@ perf_queue_eventdev_setup(struct evt_test > *test, > > struct evt_options *opt) > > return ret; > > } > > } > > + } else if (opt->prod_type =3D=3D > > EVT_PROD_TYPE_EVENT_CRYPTO_ADPTR) { > > + uint8_t cdev_id, cdev_count; > > + > > + cdev_count =3D rte_cryptodev_count(); > > + for (cdev_id =3D 0; cdev_id < cdev_count; cdev_id++) { > > + ret =3D rte_cryptodev_start(cdev_id); > > + if (ret) { > > + evt_err("Failed to start cryptodev %u", > > + cdev_id); > > + return ret; > > + } > > + } > > + > > + rte_event_crypto_adapter_start(t->crypto_adptr.id); > > } > > > > return 0; > > @@ -311,11 +361,13 @@ static const struct evt_test_ops perf_queue =3D = { > > .test_setup =3D perf_test_setup, > > .mempool_setup =3D perf_mempool_setup, > > .ethdev_setup =3D perf_ethdev_setup, > > + .cryptodev_setup =3D perf_cryptodev_setup, > > .eventdev_setup =3D perf_queue_eventdev_setup, > > .launch_lcores =3D perf_queue_launch_lcores, > > .eventdev_destroy =3D perf_eventdev_destroy, > > .mempool_destroy =3D perf_mempool_destroy, > > .ethdev_destroy =3D perf_ethdev_destroy, > > + .cryptodev_destroy =3D perf_cryptodev_destroy, > > .test_result =3D perf_test_result, > > .test_destroy =3D perf_test_destroy, > > }; > > diff --git a/doc/guides/tools/testeventdev.rst > > b/doc/guides/tools/testeventdev.rst > > index 48efb9ea6e..f7d813226d 100644 > > --- a/doc/guides/tools/testeventdev.rst > > +++ b/doc/guides/tools/testeventdev.rst > > @@ -120,6 +120,10 @@ The following are the application command-line > > options: > > > > Use burst mode event timer adapter as producer. > > > > +* ``--prod_type_cryptodev`` > > + > > + Use crypto device as producer. > > + > > * ``--timer_tick_nsec`` > > > > Used to dictate number of nano seconds between bucket > > traversal of the @@ -148,6 +152,11 @@ The following are the > > application command-line > > options: > > timeout is out of the supported range of event device it will b= e > > adjusted to the highest/lowest supported dequeue timeout > supported. > > > > +* ``--crypto_adptr_mode`` > > + > > + Set crypto adapter mode. Use 0 for OP_NEW (default) and 1 for > > + OP_FORWARD mode. > > + > > * ``--mbuf_sz`` > > > > Set packet mbuf size. Can be used to configure Jumbo Frames. > > Only @@ > > -420,6 +429,7 @@ Supported application command line options are > > following:: > > --prod_type_ethdev > > --prod_type_timerdev_burst > > --prod_type_timerdev > > + --prod_type_cryptodev > > --prod_enq_burst_sz > > --timer_tick_nsec > > --max_tmo_nsec > > @@ -427,6 +437,7 @@ Supported application command line options are > > following:: > > --nb_timers > > --nb_timer_adptrs > > --deq_tmo_nsec > > + --crypto_adptr_mode > > > > Example > > ^^^^^^^ > > @@ -529,12 +540,14 @@ Supported application command line options are > > following:: > > --prod_type_ethdev > > --prod_type_timerdev_burst > > --prod_type_timerdev > > + --prod_type_cryptodev > > --timer_tick_nsec > > --max_tmo_nsec > > --expiry_nsec > > --nb_timers > > --nb_timer_adptrs > > --deq_tmo_nsec > > + --crypto_adptr_mode > > > > Example > > ^^^^^^^ > > -- > > 2.25.1