From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B34D3A00C3; Tue, 25 Jan 2022 15:15:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 43B65426EE; Tue, 25 Jan 2022 15:15:25 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 7E751426E4 for ; Tue, 25 Jan 2022 15:15:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643120123; x=1674656123; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=to+UwGG9J2nI1eXXexFnJXSYPeFXEhiBfDndPBSn7rY=; b=dZVY270zHv3JNpaphhqw9OwcHUdxoseqhhIjEs2tUfDcG0d/c8AsAFIf gjm0bNmRcv1kMEcVF9lywWsc69JTI5qgycD1XaQwn9wa9NiKwzHH2gYHt oMM3p0Rj1NTJwA9FKai/328JdP8522P73NwExAlXGlK6mZUSBrvK+D+Jv ow+0DOTR+jUUec+1bubxJGzufJAsRqJXGRO0eEwGk1Oskrxg54K6corUT 7PQ6v3o+87goIoCW3k8NoorPVU4kk+4325W0nL2Wr764EIKiDD1azoh36 AomN4FsqFx7s692oOwSxMGT67mJ6LuJD4WHxyDwwx618qhOBPkryP6uJL A==; X-IronPort-AV: E=McAfee;i="6200,9189,10237"; a="229882866" X-IronPort-AV: E=Sophos;i="5.88,315,1635231600"; d="scan'208";a="229882866" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2022 06:15:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,315,1635231600"; d="scan'208";a="532425950" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga007.fm.intel.com with ESMTP; 25 Jan 2022 06:15:09 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 25 Jan 2022 06:15:08 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 25 Jan 2022 06:15:08 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 25 Jan 2022 06:15:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZX//A85o53Ddw7Jan34gE6YSlq3EtpYX9OhKqfYyqMRApBLa2/iHOY8NZAmsbKjh3GNBUQr2ykfSFJIZ3U4L3bzTUuVIY9gtSrCCuA1f+sTdDxQZPucmLNQk+KVFmDcdawhD59Lu/gNadQzqTVxNYv3/0CcSrQefl+LXRXxi5dSr/GLKNmN/vqHFgwPJz6HC+cYaXtX2NvX1p11cz26CWjdJJkcIlbFeFswFEoykIgRGaiU79tTZuUT98ekoEzs03JQnbAetZcyL0DFqd01dtuOe4zDMt1jhkllj3BAk5f5yel/re9V/dJzymL3Qkayi7lEBErSuV40ccWfEqefOsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N4uA/Ui082l9XyhLCE9QnBkz5+6U5DW5kaF216zTMLk=; b=aDyNN+PgmV7JDMUbFZmLmzeMz+yMj1QeeL7YHQR47JKs2Ffa53sSuAV6Tq6TdoxmyTurdDyYMClBVUYSo4pPb+w7Ad7Jov5LH5m5I9lB407Fw43fqKDlr34/f855r+z9Qm6wmlGojZ4WtkvREMR6Eb+dfcWRyDfk9ESDoxLZbv2zhf+e6niC1dEjSX3GA4kJbpfuGron+2LpTC3JWSOdu4iczQ/XrFaHd1T/TpEEx030BeatdzNCVpYewZIlzKAxm9lW2aRNlmuzS/J+3l3tbs3tcMSRXI7mbu8UbDVdY4jbL+09/iURg00J0+dRxksI50MfTSf1cN/dVaA0v5dJtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from PH0PR11MB4824.namprd11.prod.outlook.com (2603:10b6:510:38::13) by BN6PR11MB3924.namprd11.prod.outlook.com (2603:10b6:405:7a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.15; Tue, 25 Jan 2022 14:15:05 +0000 Received: from PH0PR11MB4824.namprd11.prod.outlook.com ([fe80::8087:583f:a2f0:111a]) by PH0PR11MB4824.namprd11.prod.outlook.com ([fe80::8087:583f:a2f0:111a%6]) with mapi id 15.20.4909.019; Tue, 25 Jan 2022 14:15:05 +0000 From: "Gujjar, Abhinandan S" To: Shijith Thotton , "dev@dpdk.org" , Jerin Jacob Kollanukkaran CC: Anoob Joseph , Pavan Nikhilesh Bhagavatula , Akhil Goyal Subject: RE: [PATCH v3] app/eventdev: add crypto producer mode Thread-Topic: [PATCH v3] app/eventdev: add crypto producer mode Thread-Index: AQHYAVatjp8Y9bS4UkqOt0F7dz8QJ6xw9xAwgADmB4CAAgrhQA== Date: Tue, 25 Jan 2022 14:15:05 +0000 Message-ID: References: <5b7dadb222f6eb018c74983750052543eb5f0d8e.1640076426.git.sthotton@marvell.com> <736dc424a780b9547033f76f8911342ff06d3f87.1641292088.git.sthotton@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 728d23c0-ef36-4ecc-343a-08d9e00d15a2 x-ms-traffictypediagnostic: BN6PR11MB3924:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:457; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RMY39H9EWZEzsHmcaIvJb9EJ033jVTJY2RUFPSjqh/aMoKpmNWBEbL3CyfzpOb75oTSqHA8jHgH4ura4uERfaZIvuPL3R54qbaAQtDG2SJ6tzXN3iCMIo6bWH6xQ6XYRxbX5YIRWXajvJVhTccPMTlscKYRRiHV2Xa9UsU+0LzKkuJrLGOU9qWafIFInND+/iM1xGyh97dXQFtT8Tfrm+X4Ax9bCkWhcg8w5el2nUz4WiGdORghZ/E07IyflB+6y51Uk3eF9rrla4m7UIE/OQkm8q7xZBCr8MV1Zfut2o0+UjwdxpBCQQbLfK/gW5hV1a7EMieh0MH87ev8oCznuqRERTLCVySIBPzV2gNLNJ+PPh8SUkbm0HTMc5YU9Vx6R4H94+g8WECeLFBSqFfZmp3cnq3qOI3E+iWnYI0i/MEEmP4kxlN6jFQ7W6fKmg+BqErPZJ/GXjEmfO7QzbQSRPZlWKBJdbVaWL3HbIy1Gu2tPjbAfmrj2LCVVUoLsU0tKp+OgUagzaKfpWPn5C64kW+95ZtOWxhglkwsNi/Bb1AAdvjBjb1Ro0dMC9oPnjBlizLNvW5ocGycw+hG0S/V9NbhFeB8ywQBmM9GMQtS6oMGnnEOCwFVot5Y41YfMbRickANjbvSHSwvNv1nOfgfJix1/TY8vOn9Z/IQjou3kjNPRAulpHTcsIqfYAdJdDX1eVweHFZK3JZjqdpdlMYJjqw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB4824.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(83380400001)(508600001)(54906003)(110136005)(186003)(316002)(71200400001)(33656002)(64756008)(66946007)(76116006)(66446008)(66556008)(26005)(66476007)(38070700005)(53546011)(7696005)(6506007)(122000001)(9686003)(52536014)(4326008)(8676002)(5660300002)(30864003)(8936002)(38100700002)(82960400001)(55016003)(2906002)(86362001)(579004)(559001)(20210929001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VS8Fsl/be5/WeyRqPYgHiRtGklw3u7Unj7IUczD6EuynFN3wpfAAsHUdGHDY?= =?us-ascii?Q?b7SQV8CbM52Fv5Tb1lTupq49EklWlG9IgK6NyouwQ6/Naetp0a4Zv3qy+qYU?= =?us-ascii?Q?kVgmZYe+7RN7q5nn7ch2Tmbc9pKAdqaXyVr7Gqh0RMOyaDskYgkb9Grs90le?= =?us-ascii?Q?FLPSxbz+DeMiQzvwHDT4cyrL8ixusi/vH4pyNThRLb0plowqP1IoxvpiHGlt?= =?us-ascii?Q?IkqTXcnQs2wjRNgbfH6H0l7qFPjsPvw/noZ4h3OSuDT8RKVB4RjdYh4T2gYV?= =?us-ascii?Q?6FvSl8WS9/7vuFEpTaguLf+/NAfhoAL2VUnsbmLYzmObyUm59cujSJwPwjT+?= =?us-ascii?Q?stKwySMnudoURFm1fPeDeXxWItVQ+QhLjni9LTTTI8oJEWrIQChOO6YRERz8?= =?us-ascii?Q?3deNAxGG9LCg2SFaAbJd3pNS13HT0MMuWIIuix6rJs3IPfesilM/EqDz2W8t?= =?us-ascii?Q?NwtxbSS2EDYJ4+u2jDne1X1si5A6Qquk635ZsV4mTyw3hq3QShM9dL6sBFvK?= =?us-ascii?Q?Hqf+a+hDPiR4HTw/LU3Va9LUavhZN+MsvNMUvLv+RWaX7c1NgXjmkvMXiJMz?= =?us-ascii?Q?JJakug91cMcBc8gHx6ZmVaRVpUt4ae2bz0/yZDBgbGoZ9WykASE0opyhKTQC?= =?us-ascii?Q?FeNBWtjm6DKbk8XLfJdWc/mLyWGNdGFs+ahX1lu5cP6XBhBqT56IqZMK2VD1?= =?us-ascii?Q?9yvo0UFy+BXtTa2ZzMqDCsjpHanitDNWJLxw2z5ufRXPEeQzEEpEGwBmcMgs?= =?us-ascii?Q?JFOoF4ztAhxiFk3BGTpvSxkqqwliun8S+oCEKTLJ1dpyPBKvHYsNPrfamWss?= =?us-ascii?Q?kW3B3PSrl3fqRHob7210avNpxA3wBAWPRLHui+1cM39lL94NCH7VgGSKkEyL?= =?us-ascii?Q?Hp5NNQy2W0/ooMq94nbAQvELiYjBH/9jqLfzvxqcGqv+ix8a4VJUqIZO37fu?= =?us-ascii?Q?dgdhCXfI4xfPo0JxNJuCnBLXPbojcOciCo79UUVzX2onNh1AuZ0SRhGOWAMz?= =?us-ascii?Q?pATq9He0jKjnFkazKU5/HhxiPD91Kju/yd2re5YUFJPHKmhZdYeBTVica+5B?= =?us-ascii?Q?ts9opeqYjzrWAiu7kzB3PtU1QnMA6pjoBGAc+uOtHP1o+6Z1iS1pRVog4IXo?= =?us-ascii?Q?m6Ou1giiRuSL/FG/fWNttIviJ6xYjQGGk1WMKpk+DEjJ+irSLxGl2K1Lny8J?= =?us-ascii?Q?lF2U4/Cd6E/Dz14J2qg+9kFoQ/79CbC3Sb/hOTliLrHLbcXJt+6hUu0lzkn0?= =?us-ascii?Q?I0lHm5hsuiGXx1HFDhlpU69b0QZgBUW/IKOhCRUhmxCpAAgm11mfHZVcF8/Y?= =?us-ascii?Q?FZauoSUyaFwuxnNsQDF5OlXEl/OBSZ3PelFGYLaeKps6kN4aMr96Fiva7a1+?= =?us-ascii?Q?3ie5+NIiM9zu7ALumuYlOEO5cm86Vl7zIFjB5dR0C3MhdVRAgbS65/BlJ8N6?= =?us-ascii?Q?Tn7i9TLNo63mAVCuQxwjf1Ra0YKXbiDa1leB0LkXxFQElly8Eco35vVKbOaS?= =?us-ascii?Q?QBsipWkDCyXRmrHEB7NyPSbCfvDI0Asoe3j5Fulr17jwHbi7L8HY7J48WU53?= =?us-ascii?Q?v4s2Cs1CHQzN7XOg7glCM/vxsNtTl3k7SLkjM3l53w3Qqx5hTGTU52ApXmrX?= =?us-ascii?Q?IW4S/m/thJHIaMP8wQkbAw11hE7n11AVBs+DalEOcO66TtMqkHm/GXb1lQNR?= =?us-ascii?Q?g1Q+TQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4824.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 728d23c0-ef36-4ecc-343a-08d9e00d15a2 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2022 14:15:05.0847 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QsIxqH8DwgIVPXWE6nijQAM2+mMhv2ZYhHoBHgIEyPFn9C83B3jILPD3E1Nd5SyosxNzPgnNJvtiPc46UoWctNGiVGqrppLoRpHZn6HDReY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB3924 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Shijith Thotton > Sent: Monday, January 24, 2022 12:29 PM > To: Gujjar, Abhinandan S ; dev@dpdk.org; > Jerin Jacob Kollanukkaran > Cc: Anoob Joseph ; Pavan Nikhilesh Bhagavatula > ; Akhil Goyal > Subject: RE: [PATCH v3] app/eventdev: add crypto producer mode >=20 > Missed some comments in last mail. >=20 > >> > >> In crypto producer mode, producer core enqueues cryptodev with > >> software generated crypto ops and worker core dequeues crypto > >> completion events from the eventdev. Event crypto metadata used for > >> above processing is pre- populated in each crypto session. > >> > >> Parameter --prod_type_cryptodev can be used to enable crypto producer > >> mode. Parameter --crypto_adptr_mode can be set to select the crypto > >> adapter mode, 0 for OP_NEW and 1 for OP_FORWARD. > >> > >> This mode can be used to measure the performance of crypto adapter. > >> > >> Example: > >> ./dpdk-test-eventdev -l 0-2 -w -w -- \ > >> --prod_type_cryptodev --crypto_adptr_mode 1 --test=3Dperf_atq \ > >> --stlist=3Da --wlcores 1 --plcores 2 > >> > >> Signed-off-by: Shijith Thotton > >> --- > >> v3: > >> * Reduce dereference inside loop. > >> > >> v2: > >> * Fix RHEL compilation warning. > >> > >> app/test-eventdev/evt_common.h | 3 + > >> app/test-eventdev/evt_main.c | 13 +- > >> app/test-eventdev/evt_options.c | 27 ++ > >> app/test-eventdev/evt_options.h | 12 + > >> app/test-eventdev/evt_test.h | 6 + > >> app/test-eventdev/test_perf_atq.c | 51 ++++ > >> app/test-eventdev/test_perf_common.c | 410 > >> ++++++++++++++++++++++++++- app/test- > >> eventdev/test_perf_common.h | 16 ++ app/test- > >> eventdev/test_perf_queue.c | 52 ++++ > >> doc/guides/tools/testeventdev.rst | 13 + > >> 10 files changed, 596 insertions(+), 7 deletions(-) > >> > >> diff --git a/app/test-eventdev/evt_common.h b/app/test- > >> eventdev/evt_common.h index f466434459..2f301a7e79 100644 > >> --- a/app/test-eventdev/evt_common.h > >> +++ b/app/test-eventdev/evt_common.h > >> @@ -7,6 +7,7 @@ > >> > >> #include > >> #include > >> +#include > >> #include > >> #include > >> > >> @@ -39,6 +40,7 @@ enum evt_prod_type { > >> EVT_PROD_TYPE_SYNT, /* Producer type Synthetic i.e. CPU. */ > >> EVT_PROD_TYPE_ETH_RX_ADPTR, /* Producer type Eth Rx Adapter. > >> */ > >> EVT_PROD_TYPE_EVENT_TIMER_ADPTR, /* Producer type Timer > Adapter. > >> */ > >> + EVT_PROD_TYPE_EVENT_CRYPTO_ADPTR, /* Producer type Crypto > >> Adapter. */ > >> EVT_PROD_TYPE_MAX, > >> }; > >> > >> @@ -77,6 +79,7 @@ struct evt_options { > >> uint64_t timer_tick_nsec; > >> uint64_t optm_timer_tick_nsec; > >> enum evt_prod_type prod_type; > >> + enum rte_event_crypto_adapter_mode crypto_adptr_mode; > >> }; > >> > >> static inline bool > >> diff --git a/app/test-eventdev/evt_main.c > >> b/app/test-eventdev/evt_main.c index 194c980c7a..cef0fb1382 100644 > >> --- a/app/test-eventdev/evt_main.c > >> +++ b/app/test-eventdev/evt_main.c > >> @@ -161,12 +161,19 @@ main(int argc, char **argv) > >> goto mempool_destroy; > >> } > >> } > >New line required > Will add. >=20 > >> + /* Test specific cryptodev setup */ > >> + if (test->ops.cryptodev_setup) { > >> + if (test->ops.cryptodev_setup(test, &opt)) { > >> + evt_err("%s: cryptodev setup failed", > >> opt.test_name); > >> + goto ethdev_destroy; > >> + } > >> + } > >> > >> /* Test specific eventdev setup */ > >> if (test->ops.eventdev_setup) { > >> if (test->ops.eventdev_setup(test, &opt)) { > >> evt_err("%s: eventdev setup failed", > opt.test_name); > >> - goto ethdev_destroy; > >> + goto cryptodev_destroy; > >> } > >> } > >> > >> @@ -197,6 +204,10 @@ main(int argc, char **argv) > >> if (test->ops.eventdev_destroy) > >> test->ops.eventdev_destroy(test, &opt); > >> > >> +cryptodev_destroy: > >> + if (test->ops.cryptodev_destroy) > >> + test->ops.cryptodev_destroy(test, &opt); > >> + > >> ethdev_destroy: > >> if (test->ops.ethdev_destroy) > >> test->ops.ethdev_destroy(test, &opt); diff --git a/app/test- > >> eventdev/evt_options.c b/app/test-eventdev/evt_options.c index > >> 753a7dbd7d..5ad1491020 100644 > >> --- a/app/test-eventdev/evt_options.c > >> +++ b/app/test-eventdev/evt_options.c > >> @@ -122,6 +122,26 @@ evt_parse_timer_prod_type_burst(struct > >> evt_options *opt, > >> return 0; > >> } > >> > >> +static int > >> +evt_parse_crypto_prod_type(struct evt_options *opt, > >> + const char *arg __rte_unused) > >> +{ > >> + opt->prod_type =3D EVT_PROD_TYPE_EVENT_CRYPTO_ADPTR; > >> + return 0; > >> +} > >> + > >> +static int > >> +evt_parse_crypto_adptr_mode(struct evt_options *opt, const char > *arg) { > >> + uint8_t mode; > >> + int ret; > >> + > >> + ret =3D parser_read_uint8(&mode, arg); > >> + opt->crypto_adptr_mode =3D mode ? > >> RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD : > >> + > >> RTE_EVENT_CRYPTO_ADAPTER_OP_NEW; > >> + return ret; > >> +} > >> + > >> static int > >> evt_parse_test_name(struct evt_options *opt, const char *arg) { @@ > >> - > >> 335,6 +355,7 @@ usage(char *program) > >> "\t--queue_priority : enable queue priority\n" > >> "\t--deq_tmo_nsec : global dequeue timeout\n" > >> "\t--prod_type_ethdev : use ethernet device as > producer.\n" > >> + "\t--prod_type_cryptodev : use crypto device as > >> producer.\n" > >> "\t--prod_type_timerdev : use event timer device as > producer.\n" > >> "\t expity_nsec would be the timeout\n" > >> "\t in ns.\n" > >> @@ -345,6 +366,8 @@ usage(char *program) > >> "\t--timer_tick_nsec : timer tick interval in ns.\n" > >> "\t--max_tmo_nsec : max timeout interval in ns.\n" > >> "\t--expiry_nsec : event timer expiry ns.\n" > >> + "\t--crypto_adptr_mode : 0 for OP_NEW mode (default) > >> and\n" > >> + "\t 1 for OP_FORWARD mode.\n" > >> "\t--mbuf_sz : packet mbuf size.\n" > >> "\t--max_pkt_sz : max packet size.\n" > >> "\t--prod_enq_burst_sz : producer enqueue burst size.\n" > >> @@ -415,8 +438,10 @@ static struct option lgopts[] =3D { > >> { EVT_QUEUE_PRIORITY, 0, 0, 0 }, > >> { EVT_DEQ_TMO_NSEC, 1, 0, 0 }, > >> { EVT_PROD_ETHDEV, 0, 0, 0 }, > >> + { EVT_PROD_CRYPTODEV, 0, 0, 0 }, > >> { EVT_PROD_TIMERDEV, 0, 0, 0 }, > >> { EVT_PROD_TIMERDEV_BURST, 0, 0, 0 }, > >> + { EVT_CRYPTO_ADPTR_MODE, 1, 0, 0 }, > >> { EVT_NB_TIMERS, 1, 0, 0 }, > >> { EVT_NB_TIMER_ADPTRS, 1, 0, 0 }, > >> { EVT_TIMER_TICK_NSEC, 1, 0, 0 }, > >> @@ -455,8 +480,10 @@ evt_opts_parse_long(int opt_idx, struct > >> evt_options > >> *opt) > >> { EVT_QUEUE_PRIORITY, evt_parse_queue_priority}, > >> { EVT_DEQ_TMO_NSEC, evt_parse_deq_tmo_nsec}, > >> { EVT_PROD_ETHDEV, evt_parse_eth_prod_type}, > >> + { EVT_PROD_CRYPTODEV, evt_parse_crypto_prod_type}, > >> { EVT_PROD_TIMERDEV, evt_parse_timer_prod_type}, > >> { EVT_PROD_TIMERDEV_BURST, > >> evt_parse_timer_prod_type_burst}, > >> + { EVT_CRYPTO_ADPTR_MODE, > >> evt_parse_crypto_adptr_mode}, > >> { EVT_NB_TIMERS, evt_parse_nb_timers}, > >> { EVT_NB_TIMER_ADPTRS, evt_parse_nb_timer_adptrs}, > >> { EVT_TIMER_TICK_NSEC, evt_parse_timer_tick_nsec}, diff -- > git > >> a/app/test-eventdev/evt_options.h b/app/test-eventdev/evt_options.h > >> index 413d7092f0..2231c58801 100644 > >> --- a/app/test-eventdev/evt_options.h > >> +++ b/app/test-eventdev/evt_options.h > >> @@ -9,6 +9,7 @@ > >> #include > >> > >> #include > >> +#include > >> #include > >> #include > >> #include > >> @@ -33,8 +34,10 @@ > >> #define EVT_QUEUE_PRIORITY ("queue_priority") > >> #define EVT_DEQ_TMO_NSEC ("deq_tmo_nsec") > >> #define EVT_PROD_ETHDEV ("prod_type_ethdev") > >> +#define EVT_PROD_CRYPTODEV ("prod_type_cryptodev") > >> #define EVT_PROD_TIMERDEV ("prod_type_timerdev") > >> #define EVT_PROD_TIMERDEV_BURST ("prod_type_timerdev_burst") > >> +#define EVT_CRYPTO_ADPTR_MODE ("crypto_adptr_mode") > >> #define EVT_NB_TIMERS ("nb_timers") > >> #define EVT_NB_TIMER_ADPTRS ("nb_timer_adptrs") > >> #define EVT_TIMER_TICK_NSEC ("timer_tick_nsec") > >> @@ -249,6 +252,8 @@ evt_prod_id_to_name(enum evt_prod_type > >> prod_type) > >> return "Ethdev Rx Adapter"; > >> case EVT_PROD_TYPE_EVENT_TIMER_ADPTR: > >> return "Event timer adapter"; > >> + case EVT_PROD_TYPE_EVENT_CRYPTO_ADPTR: > >> + return "Event crypto adapter"; > >> } > >> > >> return ""; > >> @@ -288,6 +293,13 @@ evt_dump_producer_type(struct evt_options > *opt) > >> evt_dump("timer_tick_nsec", "%"PRIu64"", > >> opt->timer_tick_nsec); > >> break; > >> + case EVT_PROD_TYPE_EVENT_CRYPTO_ADPTR: > >> + snprintf(name, EVT_PROD_MAX_NAME_LEN, > >> + "Event crypto adapter producers"); > >> + evt_dump("crypto adapter mode", "%s", > >> + opt->crypto_adptr_mode ? "OP_FORWARD" : > >> "OP_NEW"); > >> + evt_dump("nb_cryptodev", "%u", rte_cryptodev_count()); > >> + break; > >> } > >> evt_dump("prod_type", "%s", name); > >> } > >> diff --git a/app/test-eventdev/evt_test.h > >> b/app/test-eventdev/evt_test.h index f07d2c3336..50fa474ec2 100644 > >> --- a/app/test-eventdev/evt_test.h > >> +++ b/app/test-eventdev/evt_test.h > >> @@ -29,6 +29,8 @@ typedef int (*evt_test_mempool_setup_t) > >> (struct evt_test *test, struct evt_options *opt); typedef int > >> (*evt_test_ethdev_setup_t) > >> (struct evt_test *test, struct evt_options *opt); > >> +typedef int (*evt_test_cryptodev_setup_t) > >> + (struct evt_test *test, struct evt_options *opt); > >> typedef int (*evt_test_eventdev_setup_t) > >> (struct evt_test *test, struct evt_options *opt); typedef int > >> (*evt_test_launch_lcores_t) @@ -39,6 +41,8 @@ typedef void > >> (*evt_test_eventdev_destroy_t) > >> (struct evt_test *test, struct evt_options *opt); typedef void > >> (*evt_test_ethdev_destroy_t) > >> (struct evt_test *test, struct evt_options *opt); > >> +typedef void (*evt_test_cryptodev_destroy_t) > >> + (struct evt_test *test, struct evt_options *opt); > >> typedef void (*evt_test_mempool_destroy_t) > >> (struct evt_test *test, struct evt_options *opt); typedef void > >> (*evt_test_destroy_t) @@ -52,10 +56,12 @@ struct evt_test_ops { > >> evt_test_mempool_setup_t mempool_setup; > >> evt_test_ethdev_setup_t ethdev_setup; > >> evt_test_eventdev_setup_t eventdev_setup; > >> + evt_test_cryptodev_setup_t cryptodev_setup; > >> evt_test_launch_lcores_t launch_lcores; > >> evt_test_result_t test_result; > >> evt_test_eventdev_destroy_t eventdev_destroy; > >> evt_test_ethdev_destroy_t ethdev_destroy; > >> + evt_test_cryptodev_destroy_t cryptodev_destroy; > >> evt_test_mempool_destroy_t mempool_destroy; > >> evt_test_destroy_t test_destroy; > >> }; > >> diff --git a/app/test-eventdev/test_perf_atq.c b/app/test- > >> eventdev/test_perf_atq.c index 8fd51004ee..dbb1dc8c0c 100644 > >> --- a/app/test-eventdev/test_perf_atq.c > >> +++ b/app/test-eventdev/test_perf_atq.c > >> @@ -48,6 +48,22 @@ perf_atq_worker(void *arg, const int > >> enable_fwd_latency) > >> continue; > >> } > >> > >> + if (prod_crypto_type && > >> + (ev.event_type =3D=3D RTE_EVENT_TYPE_CRYPTODEV)) { > >> + struct rte_crypto_op *op =3D ev.event_ptr; > >> + > >> + if (op->status =3D=3D > >> RTE_CRYPTO_OP_STATUS_SUCCESS) { > >> + if (op->sym->m_dst =3D=3D NULL) > >> + ev.event_ptr =3D op->sym->m_src; > >> + else > >> + ev.event_ptr =3D op->sym->m_dst; > >> + rte_crypto_op_free(op); > >> + } else { > >> + rte_crypto_op_free(op); > >> + continue; > >> + } > >> + } > >> + > >> if (enable_fwd_latency && !prod_timer_type) > >> /* first stage in pipeline, mark ts to compute fwd latency */ > >> atq_mark_fwd_latency(&ev); > >> @@ -87,6 +103,25 @@ perf_atq_worker_burst(void *arg, const int > >> enable_fwd_latency) > >> } > >> > >> for (i =3D 0; i < nb_rx; i++) { > >> + if (prod_crypto_type && > >> + (ev[i].event_type =3D=3D > >> RTE_EVENT_TYPE_CRYPTODEV)) { > >> + struct rte_crypto_op *op =3D ev[i].event_ptr; > >> + > >> + if (op->status =3D=3D > >> + RTE_CRYPTO_OP_STATUS_SUCCESS) { > >> + if (op->sym->m_dst =3D=3D NULL) > >> + ev[i].event_ptr =3D > >> + op->sym->m_src; > >> + else > >> + ev[i].event_ptr =3D > >> + op->sym->m_dst; > >> + rte_crypto_op_free(op); > >> + } else { > >> + rte_crypto_op_free(op); > >> + continue; > >> + } > >> + } > >> + > >> if (enable_fwd_latency && !prod_timer_type) { > >> rte_prefetch0(ev[i+1].event_ptr); > >> /* first stage in pipeline. > >> @@ -254,6 +289,20 @@ perf_atq_eventdev_setup(struct evt_test *test, > >> struct evt_options *opt) > >> return ret; > >> } > >> } > >> + } else if (opt->prod_type =3D=3D > >> EVT_PROD_TYPE_EVENT_CRYPTO_ADPTR) { > >> + uint8_t cdev_id, cdev_count; > >> + > >> + cdev_count =3D rte_cryptodev_count(); > >> + for (cdev_id =3D 0; cdev_id < cdev_count; cdev_id++) { > >> + ret =3D rte_cryptodev_start(cdev_id); > >> + if (ret) { > >> + evt_err("Failed to start cryptodev %u", > >> + cdev_id); > >> + return ret; > >> + } > >> + } > >> + > >> + rte_event_crypto_adapter_start(t->crypto_adptr.id); > >> } > >> > >> return 0; > >> @@ -295,12 +344,14 @@ static const struct evt_test_ops perf_atq =3D { > >> .opt_dump =3D perf_atq_opt_dump, > >> .test_setup =3D perf_test_setup, > >> .ethdev_setup =3D perf_ethdev_setup, > >> + .cryptodev_setup =3D perf_cryptodev_setup, > >> .mempool_setup =3D perf_mempool_setup, > >> .eventdev_setup =3D perf_atq_eventdev_setup, > >> .launch_lcores =3D perf_atq_launch_lcores, > >> .eventdev_destroy =3D perf_eventdev_destroy, > >> .mempool_destroy =3D perf_mempool_destroy, > >> .ethdev_destroy =3D perf_ethdev_destroy, > >> + .cryptodev_destroy =3D perf_cryptodev_destroy, > >> .test_result =3D perf_test_result, > >> .test_destroy =3D perf_test_destroy, > >> }; > >> diff --git a/app/test-eventdev/test_perf_common.c b/app/test- > >> eventdev/test_perf_common.c index 9b73874151..91cb6748ee 100644 > >> --- a/app/test-eventdev/test_perf_common.c > >> +++ b/app/test-eventdev/test_perf_common.c > >> @@ -6,6 +6,8 @@ > >> > >> #include "test_perf_common.h" > >> > >> +#define NB_CRYPTODEV_DESCRIPTORS 128 > >> + > >> int > >> perf_test_result(struct evt_test *test, struct evt_options *opt) { > >> @@ -272,6 > >> +274,125 @@ perf_event_timer_producer_burst(void *arg) > >> return 0; > >> } > >> > >> +static inline void > >> +crypto_adapter_enq_op_new(struct prod_data *p) { > >> + struct rte_cryptodev_sym_session **crypto_sess =3D p->crypto_sess; > >> + struct test_perf *t =3D p->t; > >> + const uint32_t nb_flows =3D t->nb_flows; > >> + const uint64_t nb_pkts =3D t->nb_pkts; > >> + struct rte_mempool *pool =3D t->pool; > >> + struct rte_crypto_sym_op *sym_op; > >> + struct evt_options *opt =3D t->opt; > >> + uint16_t qp_id =3D p->cdev_qp_id; > >> + uint8_t cdev_id =3D p->cdev_id; > >> + uint32_t flow_counter =3D 0; > >> + struct rte_crypto_op *op; > >> + struct rte_mbuf *m; > >> + uint64_t count =3D 0; > >> + uint16_t len; > >> + > >> + if (opt->verbose_level > 1) > >> + printf("%s(): lcore %d queue %d cdev_id %u cdev_qp_id > >> %u\n", > >> + __func__, rte_lcore_id(), p->queue_id, p->cdev_id, > >> + p->cdev_qp_id); > >> + > >> + len =3D opt->mbuf_sz ? opt->mbuf_sz : RTE_ETHER_MIN_LEN; > >> + > >> + while (count < nb_pkts && t->done =3D=3D false) { > >> + m =3D rte_pktmbuf_alloc(pool); > >> + if (m =3D=3D NULL) > >> + continue; > >> + > >> + rte_pktmbuf_append(m, len); > >> + op =3D rte_crypto_op_alloc(t->crypto_adptr.op_pool, > >> + > >> RTE_CRYPTO_OP_TYPE_SYMMETRIC); > >> + sym_op =3D op->sym; > >> + sym_op->m_src =3D m; > >> + sym_op->cipher.data.offset =3D 0; > >> + sym_op->cipher.data.length =3D len; > >> + rte_crypto_op_attach_sym_session( > >> + op, crypto_sess[flow_counter++ % nb_flows]); > >> + while (rte_cryptodev_enqueue_burst(cdev_id, qp_id, &op, > >> 1) !=3D > >> + 1) { > >> + if (t->done) > >> + break; > >> + rte_pause(); > >> + } > >> + count++; > >> + } > >> +} > >> + > >> +static inline void > >> +crypto_adapter_enq_op_fwd(struct prod_data *p) { > >> + struct rte_cryptodev_sym_session **crypto_sess =3D p->crypto_sess; > >> + const uint8_t dev_id =3D p->dev_id; > >> + const uint8_t port =3D p->port_id; > >> + struct test_perf *t =3D p->t; > >> + const uint32_t nb_flows =3D t->nb_flows; > >> + const uint64_t nb_pkts =3D t->nb_pkts; > >> + struct rte_mempool *pool =3D t->pool; > >> + struct evt_options *opt =3D t->opt; > >> + struct rte_crypto_sym_op *sym_op; > >> + uint32_t flow_counter =3D 0; > >> + struct rte_crypto_op *op; > >> + struct rte_event ev; > >> + struct rte_mbuf *m; > >> + uint64_t count =3D 0; > >> + uint16_t len; > >> + > >> + if (opt->verbose_level > 1) > >> + printf("%s(): lcore %d port %d queue %d cdev_id %u > >> cdev_qp_id %u\n", > >> + __func__, rte_lcore_id(), port, p->queue_id, p->cdev_id, > >> + p->cdev_qp_id); > >> + > >> + ev.event =3D 0; > >> + ev.op =3D RTE_EVENT_OP_NEW; > >> + ev.queue_id =3D p->queue_id; > >> + ev.sched_type =3D RTE_SCHED_TYPE_ATOMIC; > >> + ev.event_type =3D RTE_EVENT_TYPE_CPU; > >> + len =3D opt->mbuf_sz ? opt->mbuf_sz : RTE_ETHER_MIN_LEN; > >> + > >> + while (count < nb_pkts && t->done =3D=3D false) { > >> + m =3D rte_pktmbuf_alloc(pool); > >> + if (m =3D=3D NULL) > >> + continue; > >> + > >> + rte_pktmbuf_append(m, len); > >> + op =3D rte_crypto_op_alloc(t->crypto_adptr.op_pool, > >> + > >> RTE_CRYPTO_OP_TYPE_SYMMETRIC); > >> + sym_op =3D op->sym; > >> + sym_op->m_src =3D m; > >> + sym_op->cipher.data.offset =3D 0; > >> + sym_op->cipher.data.length =3D len; > >> + rte_crypto_op_attach_sym_session( > >> + op, crypto_sess[flow_counter++ % nb_flows]); > >> + ev.event_ptr =3D op; > >> + while (rte_event_crypto_adapter_enqueue(dev_id, port, > >> &ev, 1) !=3D > >> + 1) { > >> + if (t->done) > >> + break; > >> + rte_pause(); > >> + } > >> + count++; > >> + } > >> +} > >> + > >> +static inline int > >> +perf_event_crypto_producer(void *arg) { > >> + struct prod_data *p =3D arg; > >> + struct evt_options *opt =3D p->t->opt; > >> + > >> + if (opt->crypto_adptr_mode =3D=3D > >> RTE_EVENT_CRYPTO_ADAPTER_OP_NEW) > >> + crypto_adapter_enq_op_new(p); > >> + else > >> + crypto_adapter_enq_op_fwd(p); > >> + > >> + return 0; > >> +} > >> + > >> static int > >> perf_producer_wrapper(void *arg) > >> { > >> @@ -298,6 +419,8 @@ perf_producer_wrapper(void *arg) > >> else if (t->opt->prod_type =3D=3D > >> EVT_PROD_TYPE_EVENT_TIMER_ADPTR && > >> t->opt->timdev_use_burst) > >> return perf_event_timer_producer_burst(arg); > >> + else if (t->opt->prod_type =3D=3D > >> EVT_PROD_TYPE_EVENT_CRYPTO_ADPTR) > >> + return perf_event_crypto_producer(arg); > >> return 0; > >> } > >> > >> @@ -405,8 +528,10 @@ perf_launch_lcores(struct evt_test *test, struct > >> evt_options *opt, > >> if (remaining <=3D 0) { > >> t->result =3D EVT_TEST_SUCCESS; > >> if (opt->prod_type =3D=3D > >> EVT_PROD_TYPE_SYNT || > >> - opt->prod_type =3D=3D > >> - > >> EVT_PROD_TYPE_EVENT_TIMER_ADPTR) { > >> + opt->prod_type =3D=3D > >> + > >> EVT_PROD_TYPE_EVENT_TIMER_ADPTR || > >> + opt->prod_type =3D=3D > >> + > >> EVT_PROD_TYPE_EVENT_CRYPTO_ADPTR) { > >> t->done =3D true; > >> break; > >> } > >> @@ -415,7 +540,8 @@ perf_launch_lcores(struct evt_test *test, struct > >> evt_options *opt, > >> > >> if (new_cycles - dead_lock_cycles > dead_lock_sample && > >> (opt->prod_type =3D=3D EVT_PROD_TYPE_SYNT || > >> - opt->prod_type =3D=3D > >> EVT_PROD_TYPE_EVENT_TIMER_ADPTR)) { > >> + opt->prod_type =3D=3D > >> EVT_PROD_TYPE_EVENT_TIMER_ADPTR || > >> + opt->prod_type =3D=3D > >> EVT_PROD_TYPE_EVENT_CRYPTO_ADPTR)) { > >> remaining =3D t->outstand_pkts - processed_pkts(t); > >> if (dead_lock_remaining =3D=3D remaining) { > >> rte_event_dev_dump(opt->dev_id, stdout); > @@ -537,6 +663,96 @@ > >> perf_event_timer_adapter_setup(struct test_perf > >> *t) > >> return 0; > >> } > >> > >> +static int > >> +perf_event_crypto_adapter_setup(struct test_perf *t, > >> + struct rte_event_port_conf port_conf) { > >> + struct evt_options *opt =3D t->opt; > >> + uint8_t cdev_id, cdev_count; > >> + int ret; > >> + > >> + t->crypto_adptr.id =3D 0; > >> + ret =3D rte_event_crypto_adapter_create(t->crypto_adptr.id, opt- > >> >dev_id, > >> + &port_conf, 0); > >> + if (ret) > >> + return ret; > >> + > >> + cdev_count =3D rte_cryptodev_count(); > >> + for (cdev_id =3D 0; cdev_id < cdev_count; cdev_id++) { > >> + uint32_t cap; > >> + > >> + ret =3D rte_event_crypto_adapter_caps_get(opt->dev_id, > >> cdev_id, > >> + &cap); > >> + if (ret) { > >> + evt_err("Failed to get crypto adapter capabilities"); > >> + return ret; > >> + } > >> + > >> + if (((opt->crypto_adptr_mode =3D=3D > >> + RTE_EVENT_CRYPTO_ADAPTER_OP_NEW) && > >> + !(cap & > >> + > >> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW)) || > >> + ((opt->crypto_adptr_mode =3D=3D > >> + RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD) && > >> + !(cap & > >> + > >> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD))) { > >> + evt_err("crypto adapter %s mode unsupported\n", > >> + opt->crypto_adptr_mode ? "OP_FORWARD" > >> : > >> + "OP_NEW"); > >> + return -EINVAL; > >> + } > >> + > >> + if (!(cap & > >> + > >> RTE_EVENT_CRYPTO_ADAPTER_CAP_SESSION_PRIVATE_DATA)) { > >> + evt_err("Storing crypto session not supported"); > >> + return -EINVAL; > >> + } > >> + > >> + if (cap & > >> + > >> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) { > >> + struct rte_event response_info; > >> + > >> + response_info.event =3D 0; > >> + ret =3D rte_event_crypto_adapter_queue_pair_add( > >> + t->crypto_adptr.id, cdev_id, -1, > >> + &response_info); > >> + } else { > >> + ret =3D rte_event_crypto_adapter_queue_pair_add( > >> + t->crypto_adptr.id, cdev_id, -1, NULL); > >> + } > >> + if (ret) > >> + return ret; > >> + } > >> + > >> + return 0; > >> +} > >> + > >> +static struct rte_cryptodev_sym_session * > >> +cryptodev_sym_sess_create(struct prod_data *p, struct test_perf *t) { > >> + struct rte_crypto_sym_xform cipher_xform; > >> + struct rte_cryptodev_sym_session *sess; > >> + > >> + cipher_xform.type =3D RTE_CRYPTO_SYM_XFORM_CIPHER; > >> + cipher_xform.cipher.algo =3D RTE_CRYPTO_CIPHER_NULL; > >> + cipher_xform.cipher.op =3D RTE_CRYPTO_CIPHER_OP_ENCRYPT; > >> + cipher_xform.next =3D NULL; > >> + > >> + sess =3D rte_cryptodev_sym_session_create(t- > >> >crypto_adptr.sess_pool); > >> + if (sess =3D=3D NULL) { > >> + evt_err("Failed to create sym session"); > >> + return NULL; > >> + } > >> + > >> + if (rte_cryptodev_sym_session_init(p->cdev_id, sess, > >> &cipher_xform, > >> + t->crypto_adptr.sess_priv_pool)) { > >> + evt_err("Failed to init session"); > >> + return NULL; > >> + } > >> + > >> + return sess; > >> +} > >> + > >> int > >> perf_event_dev_port_setup(struct evt_test *test, struct evt_options > *opt, > >> uint8_t stride, uint8_t nb_queues, @@ - > 598,6 +814,55 @@ > >> perf_event_dev_port_setup(struct evt_test *test, struct evt_options > >> *opt, > >> ret =3D perf_event_timer_adapter_setup(t); > >> if (ret) > >> return ret; > >> + } else if (opt->prod_type =3D=3D > >> EVT_PROD_TYPE_EVENT_CRYPTO_ADPTR) { > >> + uint8_t cdev_id =3D 0; > >> + uint16_t qp_id =3D 0; > >> + > >> + prod =3D 0; > >> + for (; port < perf_nb_event_ports(opt); port++) { > >> + struct rte_cryptodev_sym_session *crypto_sess; > >> + union rte_event_crypto_metadata m_data; > >> + struct prod_data *p =3D &t->prod[port]; > >> + uint32_t flow_id; > >> + > >> + if (qp_id =3D=3D > >> rte_cryptodev_queue_pair_count(cdev_id)) { > >> + cdev_id++; > >> + qp_id =3D 0; > >> + } > >> + > >> + p->dev_id =3D opt->dev_id; > >> + p->port_id =3D port; > >> + p->queue_id =3D prod * stride; > >> + p->cdev_id =3D cdev_id; > >> + p->cdev_qp_id =3D qp_id; > >> + p->crypto_sess =3D rte_zmalloc_socket( > >> + NULL, sizeof(crypto_sess) * t->nb_flows, > >> + RTE_CACHE_LINE_SIZE, opt->socket_id); > >> + > >> + m_data.request_info.cdev_id =3D p->cdev_id; > >> + m_data.request_info.queue_pair_id =3D p- > >> >cdev_qp_id; > >> + m_data.response_info.op =3D RTE_EVENT_OP_NEW; > >> + m_data.response_info.sched_type =3D > >> RTE_SCHED_TYPE_ATOMIC; > >> + m_data.response_info.event_type =3D > >> RTE_EVENT_TYPE_CPU; > >> + m_data.response_info.queue_id =3D p->queue_id; > >> + for (flow_id =3D 0; flow_id < t->nb_flows; flow_id++) { > >> + crypto_sess =3D > >> cryptodev_sym_sess_create(p, t); > >> + if (crypto_sess =3D=3D NULL) > >> + return -ENOMEM; > >> + > >> + m_data.response_info.flow_id =3D flow_id; > >> + rte_cryptodev_sym_session_set_user_data( > >> + crypto_sess, &m_data, > >> sizeof(m_data)); > >> + p->crypto_sess[flow_id] =3D crypto_sess; > >> + } > >> + p->t =3D t; > >> + qp_id++; > >> + prod++; > >> + } > >> + > >> + ret =3D perf_event_crypto_adapter_setup(t, *port_conf); > >> + if (ret) > >> + return ret; > >> } else { > >> prod =3D 0; > >> for ( ; port < perf_nb_event_ports(opt); port++) { @@ -659,7 > >> +924,8 @@ perf_opt_check(struct evt_options *opt, uint64_t > nb_queues) > >> } > >> > >> if (opt->prod_type =3D=3D EVT_PROD_TYPE_SYNT || > >> - opt->prod_type =3D=3D > >> EVT_PROD_TYPE_EVENT_TIMER_ADPTR) { > >> + opt->prod_type =3D=3D EVT_PROD_TYPE_EVENT_TIMER_ADPTR || > >> + opt->prod_type =3D=3D EVT_PROD_TYPE_EVENT_CRYPTO_ADPTR) { > >> /* Validate producer lcores */ > >> if (evt_lcores_has_overlap(opt->plcores, > >> rte_get_main_lcore())) { > >> @@ -767,8 +1033,7 @@ perf_ethdev_setup(struct evt_test *test, struct > >> evt_options *opt) > >> }, > >> }; > >> > >> - if (opt->prod_type =3D=3D EVT_PROD_TYPE_SYNT || > >> - opt->prod_type =3D=3D > >> EVT_PROD_TYPE_EVENT_TIMER_ADPTR) > >> + if (opt->prod_type !=3D EVT_PROD_TYPE_ETH_RX_ADPTR) > >> return 0; > >> > >> if (!rte_eth_dev_count_avail()) { > >> @@ -841,6 +1106,139 @@ void perf_ethdev_destroy(struct evt_test > >> *test, struct evt_options *opt) > >> } > >> } > >> > >> +int > >> +perf_cryptodev_setup(struct evt_test *test, struct evt_options *opt) = { > >> + uint8_t cdev_count, cdev_id, nb_plcores, nb_qps; > >> + struct test_perf *t =3D evt_test_priv(test); > >> + unsigned int max_session_size; > >> + uint32_t nb_sessions; > >> + int ret; > >> + > >> + if (opt->prod_type !=3D EVT_PROD_TYPE_EVENT_CRYPTO_ADPTR) > >> + return 0; > >How do you differentiate between this failed case as you are returning > >0 in case of success? >=20 > This is not a failed case. cryptodev setup is not needed in other modes a= nd is > ignored. Ok >=20 > >> + > >> + cdev_count =3D rte_cryptodev_count(); > >> + if (cdev_count =3D=3D 0) { > >> + evt_err("No crypto devices available\n"); > >> + return -ENODEV; > >> + } > >> + > >> + t->crypto_adptr.op_pool =3D rte_crypto_op_pool_create( > >> + "crypto_op_pool", RTE_CRYPTO_OP_TYPE_SYMMETRIC, opt- > >> >pool_sz, > >> + 128, 0, rte_socket_id()); > >> + if (t->crypto_adptr.op_pool =3D=3D NULL) { > >> + evt_err("Failed to create crypto op pool"); > >> + return -ENOMEM; > >> + } > >> + > >> + nb_sessions =3D evt_nr_active_lcores(opt->plcores) * t->nb_flows; > >> + t->crypto_adptr.sess_pool =3D > >> rte_cryptodev_sym_session_pool_create( > >> + "ca_sess_pool", nb_sessions, 0, 0, > >> + sizeof(union rte_event_crypto_metadata), > >> SOCKET_ID_ANY); > >> + if (t->crypto_adptr.sess_pool =3D=3D NULL) { > >> + evt_err("Failed to create sym session pool"); > >> + ret =3D -ENOMEM; > >> + goto err; > >> + } > >> + > >> + max_session_size =3D 0; > >> + for (cdev_id =3D 0; cdev_id < cdev_count; cdev_id++) { > >> + unsigned int session_size; > >> + > >> + session_size =3D > >> + > >> rte_cryptodev_sym_get_private_session_size(cdev_id); > >> + if (session_size > max_session_size) > >> + max_session_size =3D session_size; > >> + } > >New line required > Will add. >=20 > >> + max_session_size +=3D sizeof(union rte_event_crypto_metadata); > >> + t->crypto_adptr.sess_priv_pool =3D rte_mempool_create( > >> + "ca_sess_priv_pool", nb_sessions, max_session_size, 0, 0, > >> NULL, > >> + NULL, NULL, NULL, SOCKET_ID_ANY, 0); > >> + if (t->crypto_adptr.sess_priv_pool =3D=3D NULL) { > >> + evt_err("failed to create sym session private pool"); > >> + ret =3D -ENOMEM; > >> + goto err; > >> + } > >> + > >> + nb_plcores =3D evt_nr_active_lcores(opt->plcores); > >> + nb_qps =3D (nb_plcores % cdev_count) ? (nb_plcores / cdev_count) + > >> 1 : > >> + nb_plcores / cdev_count; > >Let's take an example: > >Cdev1 -> 8 qps > >Cdev2 -> 2 qps > >Cdev_count =3D 2 > >nb_plcores =3D 7 > >As per above statement, nb_qps =3D ( 7 % 2 ) 7/2 + 1 =3D 4 qps So, this > >fails to setup qps for cdev2 as it supports only 2 qps and test exits! > >Am I missing anything? > > > What you told is correct. But this is a simple logic to distribute qps ac= ross > multiple cdev and doesn't consider the case you mentioned. You could see > similar logic used in other apps. I will add a comment as below: > /* > * Calculate number of needed queue pairs, based on the amount > * of available number of logical cores and crypto devices. > * For instance, if there are 4 cores and 2 crypto devices, > * 2 queue pairs will be set up per device. > */ Sounds good. >=20 > >> + for (cdev_id =3D 0; cdev_id < cdev_count; cdev_id++) { > >> + struct rte_cryptodev_qp_conf qp_conf; > >> + struct rte_cryptodev_config conf; > >> + struct rte_cryptodev_info info; > >> + int qp_id; > >> + > >> + rte_cryptodev_info_get(cdev_id, &info); > >> + if (nb_qps > info.max_nb_queue_pairs) { > >> + evt_err("Not enough queue pairs per cryptodev > >> (%u)", > >> + nb_qps); > >> + ret =3D -EINVAL; > >> + goto err; > >> + } > >> + > >> + conf.nb_queue_pairs =3D nb_qps; > >> + conf.socket_id =3D SOCKET_ID_ANY; > >> + conf.ff_disable =3D RTE_CRYPTODEV_FF_SECURITY; > >> + > >> + ret =3D rte_cryptodev_configure(cdev_id, &conf); > >> + if (ret) { > >> + evt_err("Failed to configure cryptodev (%u)", > >> cdev_id); > >> + goto err; > >> + } > >> + > >> + qp_conf.nb_descriptors =3D NB_CRYPTODEV_DESCRIPTORS; > >> + qp_conf.mp_session =3D t->crypto_adptr.sess_pool; > >> + qp_conf.mp_session_private =3D t- > >> >crypto_adptr.sess_priv_pool; > >> + > >> + for (qp_id =3D 0; qp_id < conf.nb_queue_pairs; qp_id++) { > >> + ret =3D rte_cryptodev_queue_pair_setup( > >> + cdev_id, qp_id, &qp_conf, > >> + rte_cryptodev_socket_id(cdev_id)); > >> + if (ret) { > >> + evt_err("Failed to setup queue pairs on > >> cryptodev %u\n", > >> + cdev_id); > >> + goto err; > >> + } > >> + } > >> + } > >> + > >> + return 0; > >> +err: > >> + rte_mempool_free(t->crypto_adptr.op_pool); > >> + rte_mempool_free(t->crypto_adptr.sess_pool); > >> + rte_mempool_free(t->crypto_adptr.sess_priv_pool); > >> + > >> + return ret; > >> +} > >> + > >> +void > >> +perf_cryptodev_destroy(struct evt_test *test, struct evt_options > >> +*opt) { > >> + uint8_t cdev_id, cdev_count =3D rte_cryptodev_count(); > >> + struct test_perf *t =3D evt_test_priv(test); > >> + > >> + RTE_SET_USED(opt); > >> + > >> + if (opt->prod_type !=3D EVT_PROD_TYPE_EVENT_CRYPTO_ADPTR) > >> + return; > >> + > >> + rte_event_crypto_adapter_stop(t->crypto_adptr.id); > >> + > >> + for (cdev_id =3D 0; cdev_id < cdev_count; cdev_id++) { > >> + rte_cryptodev_stop(cdev_id); > >> + rte_event_crypto_adapter_queue_pair_del(t- > >> >crypto_adptr.id, > >> + cdev_id, -1); > >Any reason for passing -1? This can not ensure to cleanup all the > >preconfigured qps as per API. > Okay, I thought the behavior is like > rte_event_crypto_adapter_queue_pair_add. > Any reason, spec desn't consider -1 for > rte_event_crypto_adapter_queue_pair_del ? May be, there was no ask for it. >=20