From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 97162A0548; Fri, 24 Sep 2021 11:13:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7489B4122D; Fri, 24 Sep 2021 11:13:56 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 5382E40142; Fri, 24 Sep 2021 11:13:54 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10116"; a="309591947" X-IronPort-AV: E=Sophos;i="5.85,319,1624345200"; d="scan'208";a="309591947" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2021 02:13:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,319,1624345200"; d="scan'208";a="475930750" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga007.fm.intel.com with ESMTP; 24 Sep 2021 02:13:52 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 24 Sep 2021 02:13:52 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 24 Sep 2021 02:13:52 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 24 Sep 2021 02:13:52 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 24 Sep 2021 02:13:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h1pJ3AKg1+FHIMiHWt77xsjtE40l3KNAH8nPksF6T1eWQc/0wOeCrvs0JN1XxeWEmr9KEEZRsbFh8VsqVoDnTdf34TCxgsc1RNDlcFuVyGmMTr+INlE55Pj6UOaNEvSKqg63mfZ31UgwRU+llJ/7qZxFRVL5fQSIqRVfJItGzFxmYfulBFbkHVZkBS5vSuajt3FAocgYXuebV4cWmkQH9lsTPTGXcdRM8kcgrg+6C+ngzbsqHUQLjZQhlmOj+cO5ntZN4qWkaQdCJYdx02R90SOplJmMGNXCs0zdaYn9x02PcqgTDWNLz18+VBUPCpkbd8nHbKB2dfzMC73Dd0zfkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Pl5YzstQXrRe6h8huivuIxX96Qb0epE/kNY1W48HJYo=; b=kUYRlo5YI1RzV0VQFrYlqD/Wr5o7gMMO+uIK1cDZNoV8TYGYFaNl11xJOZ4x1Gaf5KDuQJ34nDulbDo/m7uOeCYaEPz85pBpYq+FrNvy/+2CYrIXeH3p61MZDEso7pAGnxPpq09XnGWKcZeEWgmVyJ0A/09dQQ62PqYaFgl6hOckDm0l0NgOHvKAD0A1X858ywGT0umaQX0owLmwQOUGRO6zBRoKTz9zui1gnUXJkwLJOyP0Ach7iq/o+C3fzDplMvwiMjTUv4mJYwUuno9UdJwkxiAe1ll4d/Wj8LeI5RLSAEU21k5ruJkBiZvNaR69X1edGM6NUwMZBwoHKA+lGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pl5YzstQXrRe6h8huivuIxX96Qb0epE/kNY1W48HJYo=; b=xeI0afEXyTBKErgrtzJm0Xn1lCictgADpy2EMLNOCZ/93XWDp30k3Ei3EfkR/ivt5IcoBucDbu5scAC00WI8YJhrWkjtLXnB5YsSLt9mRO53s6MV73AgbYERScQiuKF2vhtBSZKRjlF/AfHp8JE/xPPZFZvrB+DO++EFWJsO1jQ= Received: from PH0PR11MB4872.namprd11.prod.outlook.com (2603:10b6:510:32::18) by PH0PR11MB5045.namprd11.prod.outlook.com (2603:10b6:510:3f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.14; Fri, 24 Sep 2021 09:13:51 +0000 Received: from PH0PR11MB4872.namprd11.prod.outlook.com ([fe80::65ff:a198:2f1e:c730]) by PH0PR11MB4872.namprd11.prod.outlook.com ([fe80::65ff:a198:2f1e:c730%5]) with mapi id 15.20.4544.018; Fri, 24 Sep 2021 09:13:51 +0000 From: "Varghese, Vipin" To: "Kadam, Pallavi" , "dev@dpdk.org" CC: "stable@dpdk.org" , "thomas@monjalon.net" , "Menon, Ranjit" , "dmitry.kozliuk@gmail.com" , "talshn@nvidia.com" , "Narcisa.Vasile@microsoft.com" Thread-Topic: [PATCH] bus/pci: fix numa node return value Thread-Index: AQHXr/OTdjqqAnYFKEW41gtG6OL1dauy58BA Date: Fri, 24 Sep 2021 09:13:51 +0000 Message-ID: References: <20210922211906.2135-1-pallavi.kadam@intel.com> In-Reply-To: <20210922211906.2135-1-pallavi.kadam@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 46ae15c6-4052-470a-caff-08d97f3b9feb x-ms-traffictypediagnostic: PH0PR11MB5045: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: D7ypw9I46oj72K084DvZfQt9m1MEWgzoSIgOxqW0ykvqa1jcrmJwQczxTqKlc7nrQUQ7f4XzQSBtA3Eed1q+FOhp0qZmqQrqQTOb5rstsdr5jy4/R0pkE5l/E+rmirU+dv8CiU3d/wvTOFoPly1fXUVUegcNcw6FVRhbNEZRs3EIPb9GbkOjs324W/0xnI8MFT90L6LFwL2cPCvIHymG1UeTZwP3sedpkkpKFE76CBkeYpPGCVqT9iHX9VGCr05zOFKGz5rChLKV1jsPN48GZoHXTNtiXjCef4c1T3xt+3W1K6hmUu4Q//vMTIQeqdqTjHNSVr9qJy90KSsQE/Wnar2AT2YcB52UpJYPIlXF+m2oeqQhjmMEgcagwquxXzWs401l1rusMlfK1TjGUnJcrct/cUm8G02r6UDlHl4vlqIWdL5m4Ffm5oS/a2RFSE/C4TPT64A2mUYLuyxLuBDZCSRlNm0+PW3XF1D694XVs+LFBLKIbt4d3St7IjlxGXJJl9QPeojbQUU2etACb+pKNC26Em1rgeTQZ4kH4/XW61XI/KB62L1MF7aQSHkf7P7Ghmwr10gwMFZFTikz9w0/vErWmUmIalBeuVj6FWEyfBJNpANGm0cfWN3vSy1PVLHMSi1dAZ8oJ/ekwkWo0fS2h0JUMSkRgdlBkIjr3NjzBMPKAMYtdLzdV28Wo2keSceodRCQllhwPErTVSvsIFmOrA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB4872.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(4326008)(9686003)(66946007)(66446008)(64756008)(33656002)(66476007)(66556008)(4744005)(71200400001)(6506007)(508600001)(76116006)(38100700002)(122000001)(26005)(55016002)(186003)(316002)(2906002)(38070700005)(8936002)(54906003)(52536014)(5660300002)(110136005)(8676002)(83380400001)(7696005)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5wShIJY7bfQGDl9k73dPQi3bScgah+cyx0e0QQ98bxt2ektuxZ3ZErkTkOs1?= =?us-ascii?Q?tZkrlvyIb23YMPAQ8uZGTqtxDNLeEx40L7afAclS77S3wlr7rFFkUim8WOeS?= =?us-ascii?Q?whJDubIy7BL2mtYoQBUCDYGKPQ9yRvuOHopJmwfZtY+KjcfI8TKpNHfplMCD?= =?us-ascii?Q?vLG6a4tKUheMq/ObZsiNICRNlj30CLe9YK3H0QXb19Nkj7bMJPOn57dT0WHV?= =?us-ascii?Q?1LPRtKgNTU/LQEXypRB22GhwsZlOnyOLD69MiCzFj8kvNPJ1fVQRX2rciaRi?= =?us-ascii?Q?ckMa/jY5bxQbfkMcixxKD4UfcANlDrLTEOfYSt3CZYpsVfPOmPTzoyoXE6Lg?= =?us-ascii?Q?q3Vfd04aH5UT290FxwSjZWuQS5v9Z8IKg+tsO/Ei4+g6f3p0lI5A36Hl5cL+?= =?us-ascii?Q?4bQcVIUstln3wZv4/PgLIBQ3eDTDqjgp7L2FV/P6r+VckYDfF5ZcXgmXdl2o?= =?us-ascii?Q?Ao1zjAs3/NIK7NZ2x4SgkaByfLrwLCt941yEN9F9m4AsyDAj7uzzoJ2/qpcJ?= =?us-ascii?Q?AFzo3jVRhwc4TXdYLw7mTbKIq1+uhxSPZfcott+g4zI7gmvl3U6gbiSVcaQv?= =?us-ascii?Q?5x/N04GFjLdqNSnzDFX0csQ9OfAFWMQ/DP/0WdwhVY2wT7RJBeQ8QNers69q?= =?us-ascii?Q?R+f8Mltjpe4sUNTSMm5hZUHKdCS+R36+Zbp4XdfPGbqZ9aia8emfOgOqYfvb?= =?us-ascii?Q?u3Bz7ql6PK6ChvoaA7XBeeaakPdOWpHu9vuuj3KyDL2tnz85soMWw38vl/SM?= =?us-ascii?Q?V0wo7wCzHnMUyWso+FGhqwdVhTpupO9EbN5fE9tFxI4klGOzruF5rdTmSGrl?= =?us-ascii?Q?4DVxWal8HWk7K14knWv2Cz5/3RDQVxTqauDaAlbiFTeRStubSQCSyesdvNyj?= =?us-ascii?Q?y4CldnKr195KfgKVogz1V5tUJuZIZigin6LXAPxdQFoLTj0b69SIAzis8qgD?= =?us-ascii?Q?Czo/X8BeHROZiozG1tLfIOKPuNWhhzuLzJQJx6C5SYg1YCAclKDhBnbYLJtW?= =?us-ascii?Q?AHXAgUBcbfBj4+z2+kAyOlRiTjth3CjCW3WJSQRTNjjGoHaUdv5WiFnDcmyp?= =?us-ascii?Q?3JUh/B8JxkAG+8EjPD5C1U9hDX6cwvdpjvEcVesSDze6LCAAhlWFWfICXhaa?= =?us-ascii?Q?3yLqKbNmngMRtCKoBNtzPlewZVccDXN4TvAWtP04IGSKrBdBKNWoiTFRm/Ra?= =?us-ascii?Q?zS3eCf5zI9yJAoDSLamMaEBdcVmQ2mqlJd8CX0jienPd6D2I/ahmsEBpcaKL?= =?us-ascii?Q?T83V2TEylVrudfMm4megPE1FR5MIdVo9vM/MNLsndGHV1aGnuGRUs5bRbquV?= =?us-ascii?Q?w4F6THigsH2m3Gr7T1rSd0dk?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46ae15c6-4052-470a-caff-08d97f3b9feb X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Sep 2021 09:13:51.1040 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xsyR81W9NNgy8B46sgIQd0mDYpPcUiYIoruU6rX+znj2cIIxoYqQzkyUjjCpUlKmc7Qh84ngMXfw++L+pKTPrWEUQba6YymjrNFUlsIfZX8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5045 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix numa node return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Pallavi, Assuming the intention is set SOCKET_ID_ANY for faulty cases, couple of obs= ervation. In Linux ``` if (access(filename, F_OK) !=3D -1) { if (eal_parse_sysfs_value(filename, &tmp) =3D=3D 0) dev->device.numa_node =3D tmp; else dev->device.numa_node =3D -1; } else { dev->device.numa_node =3D 0; } ``` [snipped] =20 > @@ -243,7 +244,7 @@ get_device_resource_info(HDEVINFO dev_info, > DWORD error =3D GetLastError(); Set the default value as ` dev->device.numa_node =3D SOCKET_ID_ANY;` > if (error =3D=3D ERROR_NOT_FOUND) { > /* On older CPUs, NUMA is not bound to PCIe > locality. */ > - dev->device.numa_node =3D 0; > + dev->device.numa_node =3D SOCKET_ID_ANY; If the API is unsuccessful for ` ERROR_NOT_FOUND ` then you can set it to = `0` (as recommened in documentation) > return ERROR_SUCCESS; > } > RTE_LOG_WIN32_ERR("SetupDiGetDevicePropertyW" Else if if it other errors it will ` SOCKET_ID_ANY`. > -- > 2.31.1.windows.1