From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35BFC45ACD; Mon, 7 Oct 2024 09:32:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 00CD340E0B; Mon, 7 Oct 2024 09:32:15 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by mails.dpdk.org (Postfix) with ESMTP id 0524F40151 for ; Mon, 7 Oct 2024 09:32:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728286332; x=1759822332; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=hTg9SpyyA32Xg6QOZGOwz5btzGnIDeq434+KYFMNHy0=; b=BysmAlsbr8Db36Zphc3bzlcQVnjusUYbIKuaTnmy9FRYdv7OL6lpF9aI fsVW+oeg6R+zKViZDoBlxH0ck+h+RvUAaE9uxruqNQlFwL03ecDVEcNQO HsxrbuVWgA9CLgam5Kn+CAxVvfkxb2Mu9JAEoS6YiliWzsD1IThDufGfD GUi+zT3spT1dppj0PFlkt+tY23mlO27+3asc+3eSYXoLWGVhWwzflRNSa 9Zqpzogk93mYUzGDDdZLw5b7mN797AvvB0F7zj+OM4+X7BcZA4TsL0Bnl nXTEPJVZ9eVusq+5WE/zotD7EpreEqgV+puEl12t3bMkKv7vQo0aIfY7S w==; X-CSE-ConnectionGUID: kXPNOh6rS0KRRxeIzQgIyw== X-CSE-MsgGUID: VHRlJw68TT602ChjKI6qFA== X-IronPort-AV: E=McAfee;i="6700,10204,11217"; a="27306577" X-IronPort-AV: E=Sophos;i="6.11,183,1725346800"; d="scan'208";a="27306577" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2024 00:32:11 -0700 X-CSE-ConnectionGUID: dnjjE+3DRYyBpbXifriM5A== X-CSE-MsgGUID: JUvyHkbLSh6xx6a2UKVSfg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,183,1725346800"; d="scan'208";a="98704702" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 07 Oct 2024 00:32:11 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 7 Oct 2024 00:32:10 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 7 Oct 2024 00:32:10 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 7 Oct 2024 00:32:10 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.41) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 7 Oct 2024 00:32:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LcTpONaO2im1YwCWbx1prfB7pJkiz+i1x4dj0b4z9fmuAUpWXGxYo4ipT7MbIpZG2ULDKlJqWF1Tlmyeuimvf2KgevQNJlBk4jiW9crCqlkA9r0aYbn3vpF/eniqswyyQ7dPfJoUmIkFrFlBoLTb2cc+uWNnZMT8xR/vjxY+nE5kUu/CciyDqe7FmFobwOwE+7JtQd2ASiZz+eunlCTHSVVryw5+/YzimuFMxspfkPOWsHo7jkU6Me9N5ZK9IC2KmIqdxX1aGMCALG+uQUSXrS/RaXMgIrzbzp9OM4sEcHK0UdaDch7n1pcZLkd88uucefZjGFojUaEz6TS8+jEf6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wi8O+WTHoE0pEthP1A9UAwtq2hELIwFxzsGBO0NQkeo=; b=uPj6ybNAiGikkRmCv81Gu+XJWpLwjjX0+dgTF+Q+FdT696d1cjU7TFOua1OuSgDwz1ufizzKklhOFwVpwsVNprm4sI+AdI/dof5ybWgtuFDTnINDBDwjWkoFqQus7H8mOafoIhDCXkvR5E/PzfiUYDxODeZ4Ie42ZkH4GO3wwtCMU2nOZEmEt7S0f3rUhq5cDxgB+R3a15k3oF/Gq5rGIAjVYxMgNMLFba34CFbJf4T5rpTbkGcQ0mdP46S9JOx8gnA4gFpCO3GPBLEiw9tew9k5AHI+3sMtZo9REGDOoQt4F5mXC9SPeSe6LTlt/je/JsmfvDgw3n6El+Ms2Da5wA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by PH0PR11MB5831.namprd11.prod.outlook.com (2603:10b6:510:14b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.22; Mon, 7 Oct 2024 07:32:06 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::1c54:1589:8882:d22b]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::1c54:1589:8882:d22b%3]) with mapi id 15.20.8026.020; Mon, 7 Oct 2024 07:32:06 +0000 From: "Kusztal, ArkadiuszX" To: "Kusztal, ArkadiuszX" , "Gowrishankar Muthukrishnan" , "dev@dpdk.org" , Akhil Goyal , Fan Zhang CC: Anoob Joseph , "Richardson, Bruce" , "jerinj@marvell.com" , "Ji, Kai" , "jack.bond-preston@foss.arm.com" , "Marchand, David" , "hemant.agrawal@nxp.com" , "De Lara Guarch, Pablo" , "Trahe, Fiona" , "Doherty, Declan" , "matan@nvidia.com" , "ruifeng.wang@arm.com" , "Gujjar, Abhinandan S" , "maxime.coquelin@redhat.com" , "chenbox@nvidia.com" , "sunilprakashrao.uttarwar@amd.com" , "andrew.boyer@amd.com" , "ajit.khaparde@broadcom.com" , "raveendra.padasalagi@broadcom.com" , "vikas.gupta@broadcom.com" , "zhangfei.gao@linaro.org" , "g.singh@nxp.com" , "jianjay.zhou@huawei.com" , "Daly, Lee" , "Dooley, Brian" Subject: RE: [PATCH v2 1/2] cryptodev: fix RSA xform for ASN.1 syntax Thread-Topic: [PATCH v2 1/2] cryptodev: fix RSA xform for ASN.1 syntax Thread-Index: AQHbFiRXaZdlGX6C80O2Gl5Vm4E7SbJ65Y3QgAAByZA= Date: Mon, 7 Oct 2024 07:32:06 +0000 Message-ID: References: <20240905145612.1732-1-gmuthukrishn@marvell.com> <20241004061107.584-1-gmuthukrishn@marvell.com> <20241004061107.584-2-gmuthukrishn@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5013:EE_|PH0PR11MB5831:EE_ x-ms-office365-filtering-correlation-id: 6527d74e-1b9f-4cf3-dd4c-08dce6a22538 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|7416014|376014|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?tPGlThitO/PYk/Qwt/INXE3qP+EnFxh5UioB4yKtcdyZt5F4XBm85EnX/dZ6?= =?us-ascii?Q?3cs96Ad94+t24+Qb23Zp3SqlyZ+18aJVs/wzCLyvOr0NAx5fBCEnhzpKy9Q2?= =?us-ascii?Q?XBa9Ej6qsGz7S4dNMNEqNBYa19RrKBm71XDljJA1aAVzrUa1uhAP8Ddh1ZsH?= =?us-ascii?Q?W2vQ0iYpkzt2juInVpp+jlODWuAZ32S1ucFShjICwxa9juP1IKpeIa0247Sy?= =?us-ascii?Q?ZXgQWlEaGX0SiST8RQx2Yz5hb6spmZZQZEIIMro2p5JBtnZAxpQaQtYvbYFB?= =?us-ascii?Q?Gqzry/l7dahOt6/rn8wK41J0X6ENBlSNLsVcEbx3SZ5WqFBNbKdfQ8bz9PW7?= =?us-ascii?Q?vi/NS1iHAyAmJY+KvGphEX9kRBrgmtDr8Bm3aLankyu1L48bmhNY8Ai3KUuJ?= =?us-ascii?Q?6zeNy+jD+v2m7RR0BkLYe61LsJhllddDuqa4b07l2GjmCngCSanhW/g/Fkmm?= =?us-ascii?Q?kbnu4jYyCS1XtqOZhLwe3HCL1E0tXO7ZPJsfV8nkNska7ZHF6ma8mHIXfhTp?= =?us-ascii?Q?2mKYMATPHacYJd3C57hScfvUZNijK3p+BlTf0eRdaXpBtG38VOAR0l26ZlFr?= =?us-ascii?Q?muAk0pVpI6/pt5zyvLENpGhTdSuZMDoWGaJLreQ6i7iCSN2fSMNTWBDG/TqL?= =?us-ascii?Q?Gj5qI8SJftAOThmStDjgXpwbpq0DT9Psuk/dZpl91g5nbV5XxF/FtFMOT3dR?= =?us-ascii?Q?C5EiobgvdM64QIQ4u5j7OX6vFTRHh8eZhh0O2CkwH/WvFPW4e6klIDVx5EAf?= =?us-ascii?Q?qohuteD+GIdDWzun/W69teiYtw2NZPdYj85RM+P5nm5keqw83h83XclYnqrL?= =?us-ascii?Q?jIZ8GJDgvnG48XofcSugVNPrxZggHG6GSWuEoSvjVTEeNYFkNk6Nm2wtdMR7?= =?us-ascii?Q?gBtUED533ofMACgtqAUy4zlfRSu/DvRRvk25nsXd56WXjXUIp315qFOwUP1j?= =?us-ascii?Q?r66taEG4Rcn+RF035xyUzFsy7CSxSWTHw5+qAlTEMhPELYkUYMaOsD3qn7o6?= =?us-ascii?Q?0DK57xGYV7cd2+BDogEXIEmWffMZUKbCkDvOKcPazyc1pGvsbPTrc8HfBBLc?= =?us-ascii?Q?+QxUzdVuaOND4dZQjsI/qLjtJ87Teis1a1KBtIIL3aecVeaGqwbHzep+Cze+?= =?us-ascii?Q?yLfAhJNjOQkpkk4LYaxda7dkezwzVjeUzH1ig8eaH1N5v7Ga9eNAb/IK9l0O?= =?us-ascii?Q?u9n4Bx84yEufpF7/e1hpChe8tEWmzAVfh+F8WqyhnSUcb2PIQ91HkfLW3Cp9?= =?us-ascii?Q?1nkuJzw41kJZHGjrA64wxFUoXz06bo2afzcDbw/VhHvtEDM5MNq88k7w2BT4?= =?us-ascii?Q?gVy2jCsZ6A2opb5HBMAW4mdZhQdwtb89x+t70BYxOIKW5w=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(7416014)(376014)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cRzGJlsUxAKxWrn6esK0ge4IYb1A2Q8hK8U0P3O1TvMh5QHD8cMjy/oOlY2h?= =?us-ascii?Q?v9MET+cMRmj4TIYcGuAngpQdJyc9GistrojADfCckA2ezQfPhfCWuX7ooAKg?= =?us-ascii?Q?dbe/HZ9JXzr4NwOJivFxrNtz89bJQfpKoOyVcA2D1k2qNRt1ze6VB/v5rgS4?= =?us-ascii?Q?i7RkD0qRXZtbtUsxG/38izxYUK0Fd/vWCkNq+ljCB+uwITwq5QQqg7/EJwmO?= =?us-ascii?Q?Qpeaxj8Lst3O0HhCG9h8y5d2nltYiOm5iW2xA0OthYhSOij1DQ8KzMP6R/IL?= =?us-ascii?Q?tZvmJ3a7mSIEKSYSeqvNCe5EwdXUYlIDUyBzwPqCbmTIqxyMBzM5mLnyP36d?= =?us-ascii?Q?NFQ2gExwkO6vkbiOp5opNBlzw+6W3rvE+FnWcYKg8IVcBXZSxslJ8pC/L9nS?= =?us-ascii?Q?QFP8TJVN9BQJ1hCkyScBvtX8hfPnpXra1B+0N88XIOhkv8HhRcN1AEQ9bIub?= =?us-ascii?Q?zyOJmrkb89aUzXFPY+KDrkK6DdjDJp4Xf0EE1ULOHn97gkn9KeAwYZIp+IYS?= =?us-ascii?Q?WRVU00xZw4bEr33KdLLMnhvoJpJW7mFsTiqalUnQeqW//BYxhaET0atu0yvY?= =?us-ascii?Q?y6mTpUoWyQZeDBztSyJqSM0L5K4aZXqjRCjqAHklTJZchyfIdSgrgulKYvjX?= =?us-ascii?Q?Vyk815bCuzSFaHxp12WxaXDxmnc1iDOknTOoB2AWwM1J/xtEvOKmBHNk1Mot?= =?us-ascii?Q?k8yQ1I4UeSUgD1BmB4TRIkp26tY4/rAejn3kKTsAQdGBnT+ULMIpJOzIFq2s?= =?us-ascii?Q?djG33mZ1wXn8jZDRa37Bc4g7AHx0HbbqoEwN6gprePt/hIb7aot0gMGhv7WE?= =?us-ascii?Q?fePI1mvA8ER689gNbfOli5PcLJHH+Ci5ZHDT1uahi9GItsrNHnJT/qQ2xr3I?= =?us-ascii?Q?jZcT5tZCBebxki4mAw8l21BZMDmgmXwIh6JooFNK1nM+icUm0OgNvp5y1F3f?= =?us-ascii?Q?1gnzZqeXIjYW9XzqLKgkI0iQK1JBECyLw7h9uRGUORCYTOjMZn5iNqAmamnQ?= =?us-ascii?Q?MaqO+r+cjWazNXrT1FM2vXpeCqbFemd1oulcXO0K906iNUjpBhpsMPUTxsO6?= =?us-ascii?Q?+s5JOG/9htEVaS5nhz6aITGH2W0NbbwykMlrUVDVPYj3o/N5wDdN/s9YWZI4?= =?us-ascii?Q?LZ2mD4eqjrhkpC58H0FZJL97yaGThsNDPxGYcaDlUhyIV1hanulFQCwIzwBc?= =?us-ascii?Q?qei3/vOBU5siTHcF72RwFzv7KOSCxIYN3nI4lsdl4AvBcXA9lT1VSEt1qGcv?= =?us-ascii?Q?nuNGUjpa9jTmFzo/9c8vSYU9TI4ARlmNn7+Kx37aN6X/sKEvfabJfpVrU9BS?= =?us-ascii?Q?7CSLeNPZNSEMA/H3ZNM04+boS9licTNCcjGOqx9jvuAVQuyNAFvn4rJrnH2g?= =?us-ascii?Q?Csx3FHWd+KI9qe0t7ZvzCy7D/yOdQqK52UXhnik7xJwczjfcOaB6l3lM2Q/9?= =?us-ascii?Q?ZBiLDChpybKgwuxAiKp4k2pkk11KjFSZ8vs9Q98BgJ5mBFgpMLW1vfY2gRMy?= =?us-ascii?Q?MLhOnVcBdR0WBGQ0NsE8pHBr4YIkcP0ObtGso3APV3fHdba2AtMKIoEBl56I?= =?us-ascii?Q?d7+/BWr6QNZauUetMtNGzJh48qND634tY7V4mbl4irDgibYQe+g/Xuu/Zdre?= =?us-ascii?Q?4A=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6527d74e-1b9f-4cf3-dd4c-08dce6a22538 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2024 07:32:06.2834 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mrRLQcViM27N6+5jOqRhtX6+tDRQusK9FrHVmovAShTZKRreJR2xVBl3rYsioGy74CzAZC8bBLiPmistzbajHLhVfoGO3jIHAgsDhdb9ujQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5831 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Kusztal, ArkadiuszX > Sent: Monday, October 7, 2024 9:20 AM > To: Gowrishankar Muthukrishnan ; > dev@dpdk.org; Akhil Goyal ; Fan Zhang > > Cc: Anoob Joseph ; Richardson, Bruce > ; jerinj@marvell.com; Ji, Kai ; > jack.bond-preston@foss.arm.com; Marchand, David > ; hemant.agrawal@nxp.com; De Lara Guarch, > Pablo ; Trahe, Fiona > ; Doherty, Declan ; > matan@nvidia.com; ruifeng.wang@arm.com; Gujjar, Abhinandan S > ; maxime.coquelin@redhat.com; > chenbox@nvidia.com; sunilprakashrao.uttarwar@amd.com; > andrew.boyer@amd.com; ajit.khaparde@broadcom.com; > raveendra.padasalagi@broadcom.com; vikas.gupta@broadcom.com; > zhangfei.gao@linaro.org; g.singh@nxp.com; jianjay.zhou@huawei.com; Daly, > Lee ; Dooley, Brian > Subject: RE: [PATCH v2 1/2] cryptodev: fix RSA xform for ASN.1 syntax >=20 > Acked with a small comment. >=20 > > -----Original Message----- > > From: Gowrishankar Muthukrishnan > > Sent: Friday, October 4, 2024 8:11 AM > > To: dev@dpdk.org; Akhil Goyal ; Fan Zhang > > > > Cc: Anoob Joseph ; Richardson, Bruce > > ; jerinj@marvell.com; Kusztal, ArkadiuszX > > ; Ji, Kai ; jack.bond- > > preston@foss.arm.com; Marchand, David ; > > hemant.agrawal@nxp.com; De Lara Guarch, Pablo > > ; Trahe, Fiona > > ; Doherty, Declan ; > > matan@nvidia.com; ruifeng.wang@arm.com; Gujjar, Abhinandan S > > ; maxime.coquelin@redhat.com; > > chenbox@nvidia.com; sunilprakashrao.uttarwar@amd.com; > > andrew.boyer@amd.com; ajit.khaparde@broadcom.com; > > raveendra.padasalagi@broadcom.com; > > vikas.gupta@broadcom.com; zhangfei.gao@linaro.org; g.singh@nxp.com; > > jianjay.zhou@huawei.com; Daly, Lee ; Dooley, Brian > > ; Gowrishankar Muthukrishnan > > > > Subject: [PATCH v2 1/2] cryptodev: fix RSA xform for ASN.1 syntax Additionally, it should not be a fix. The RFC mandates usage of the ASN.1, but only in case sharing private key a= cross the network. How the Cryptodev should interpret it, is up to the implementation. > > > > As per ASN.1 syntax (RFC 3447 Appendix A.1.2), RSA private key would > > need > It could be RFC 8017 instead. > > specification of quintuple along with private exponent. > > It is up to the implementation to internally handle, but not at RTE > > itself to make them exclusive each other. Removing union on them > > allows asymmetric implementation in VirtIO to benefit from the xform as= per > ASN.1 syntax. > > > > Signed-off-by: Gowrishankar Muthukrishnan > > --- > > lib/cryptodev/rte_crypto_asym.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/cryptodev/rte_crypto_asym.h > > b/lib/cryptodev/rte_crypto_asym.h index 39d3da3952..c33be3b155 100644 > > --- a/lib/cryptodev/rte_crypto_asym.h > > +++ b/lib/cryptodev/rte_crypto_asym.h > > @@ -306,7 +306,7 @@ struct rte_crypto_rsa_xform { > > > > enum rte_crypto_rsa_priv_key_type key_type; > > > > - union { > > + struct { > > rte_crypto_uint d; > > /**< the RSA private exponent */ > > struct rte_crypto_rsa_priv_key_qt qt; > > -- > > 2.21.0 >=20 > Acked-by: Arkadiusz Kusztal