From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AFD4DA0545; Thu, 26 May 2022 13:46:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 99D9440151; Thu, 26 May 2022 13:46:12 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 887DB40150 for ; Thu, 26 May 2022 13:46:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653565571; x=1685101571; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ieKXX5MsqJfNxPrOFrPFhMfgXZDjAPBgYporaq7O8t4=; b=YiOdRKyL9UTFWRFV94W/303MpxU5L5cL6yxgrdw1xdW77lPv+yOr5Y3V 1Fl5mee0/Ick0r7xgsWQMGJ8EQExb5wutHijb6BGh/4YJOn+pLdTqUquI vB6R3mvjrMjqysHk3mYtlgotClJcDRuHPPSv4+vs86DKrZPzN3i9EnQu+ BbICEXk5D6aZ9jnaa97e3D8d2HQ081GheWGy4/58lKgd5J8TDy5ojiRWr g8ml9hAP3i/klJDHItZ5weVFZl+iaYVwLbKRmfsgWtHP2BR3KvlLlLnyC ZgUIKlatHQ+/Jcn47QnoPSHHu+158INvVAGDP80Os3f/l1QLtoxv2gwJK A==; X-IronPort-AV: E=McAfee;i="6400,9594,10358"; a="271701771" X-IronPort-AV: E=Sophos;i="5.91,252,1647327600"; d="scan'208";a="271701771" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 May 2022 04:46:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,252,1647327600"; d="scan'208";a="527356331" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga003.jf.intel.com with ESMTP; 26 May 2022 04:46:10 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 26 May 2022 04:46:09 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 26 May 2022 04:46:08 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 26 May 2022 04:46:08 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 26 May 2022 04:46:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y9SF0Yt+6krs3PY88EN/r/SFJLTYlAKo0XAeioHdSNo0fAckwZKfsVI1q6ClxS/8+7+eS+iSnvLROo2RGuh0wITNZksyfQ73IE77qDGmtayRLGIeRTSFf1qo6zIfOHpOmeAu/a01J3g5YG5lvj+ZKhMaKxzrnVKvI1FRoaplQiH7WKRMDQohtDcUOuWTBXOlnd9PazPBQB/gguOTI3Inu6VOBxcCK6FRg0NOLIWTNK0M3Xh4KVef0BWWALPQFTNNGfcmTco0k5S7ljsxAlxdIJRiNmf0SQdmItxcsL8o7oWdHugSXYrEz1BO4Gl1TiugzFTT0+LhWxYUrHX56jsUVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+sEsnOHxtuVoGOTGg1ri+AOj5GkV8+eLZ6d63yAaofQ=; b=WeftYt2it1fDHVyQFGofClUGthexIWdNR88hSeANBhaKH576jlo7/6x3Dh0de1FZaxmP3RthoLMTeDuMPIvnNq/oOflo6nwCaT/ELAgS7HORi9EtjBIFoS26ljyMRBtz67zpreWRBqGZPi0DZ0UjE/CXWEkoxSbbA/kaGaS30qbF8JsaTn6WKrkDOR46/BwXEiLvZdKz/nRWijl3Z8HZlZTohoUPBTcjeGLA+fHTtD5ZdAUwUUq3c23YREjIFoDdgCV+5MXrFpb36yS1xQRMgXLWxxqImNkmBUlRC4FCqFV3FW4GhcGTKM/1XgpsXanNcfLe295XstT37tJmEoqpow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by DM8PR11MB5606.namprd11.prod.outlook.com (2603:10b6:8:3c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 11:46:07 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::c1de:722f:b4f3:91b5]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::c1de:722f:b4f3:91b5%3]) with mapi id 15.20.5293.013; Thu, 26 May 2022 11:46:07 +0000 From: "Kusztal, ArkadiuszX" To: Akhil Goyal , "dev@dpdk.org" CC: "Zhang, Roy Fan" Subject: RE: [EXT] [PATCH v2 08/14] cryptodev: add public key verify option Thread-Topic: [EXT] [PATCH v2 08/14] cryptodev: add public key verify option Thread-Index: AQHYcFkf7d3vToO0AUW0BYRV3nfjLq0xCGOAgAADN0A= Date: Thu, 26 May 2022 11:46:07 +0000 Message-ID: References: <20220525155324.9288-1-arkadiuszx.kusztal@intel.com> <20220525155324.9288-9-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f05a26d5-08d7-42d1-5878-08da3f0d526d x-ms-traffictypediagnostic: DM8PR11MB5606:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BFwW+6xGGvmVKVGlhlv4YFnWFcgXgUJeZE2r5jRZF2FOixw3yshFtkai/te21OwVY5XFn8i9t4MxehGvUgXNhKOpTKMlX3mh5Fi0ETvzXJfazKqGBWck7RI+xPFulouNlRUGY0nQhQMVSUALmGwYkn8dTJuNk1BTaPTAW8TQe4mcXYcMIT1CcVL/V3WbjhpUV3Ur40+s75KtHcoPzTWZrVnE5TmkXT3gOg4y8Wt2lOx7fTOOS1akjrqd5o919uatySFRmDM20sCuILvTJGlcwu7z5R6nTO+aG0vS6MCCq/LSrqNStvSUS4gPhPDIXPSM/vstHIO2AEGqXzj4FINd1Q3FyR05ICSCPZ0DDHs0lFGimu9Sy6pJb3xySt3IvyxFIsDi3IgqgQwvKtB8C8Pa+TuT1DBIKQSzoy5zOk3aSbo1TO3+4uBEbikCeHQv7WrDPKsjatkoXpPKZuwl0NBALPq4lu1JxqChQuBKeDJmWqBCR3jolMrS3VHJC73Dm4bN38GqNxlea9TGtliwLOYZwb+/fwWiejARx5TiUoq9US4mx89PNsMLHR5yBbSulJGJfqftqBI8tiiH78elfuX7Vw+lrQ25qBxJNPjea+vwHVv/JDbIwcESxQscHxd1hf+7/V6TnXVH3lBJElDTYVj0Ka2xfKw7wcJOyP+Y+2RgO9ewwHZds0QlRgnLDizbQpE898f1Xin3lSAnocWANZ9Aww== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(110136005)(76116006)(38070700005)(122000001)(82960400001)(55016003)(38100700002)(316002)(83380400001)(107886003)(186003)(5660300002)(26005)(6506007)(508600001)(53546011)(9686003)(52536014)(15650500001)(33656002)(8936002)(71200400001)(7696005)(2906002)(8676002)(64756008)(86362001)(66556008)(66446008)(66476007)(4326008)(66946007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?syRdPGXcrsJbSqW9+kuiiq4rUfsVdsfvvQn45GxWvWhDvkerA2cMFtg4b99J?= =?us-ascii?Q?Ics3KAv/2bcEQU6Zf/NBjxW5KYsXdf6F4a+MzYylvQ/4ypLZOE0sSmJ4pgGJ?= =?us-ascii?Q?uJXhvESyJKtSGidGaF+xAU2DFI6vilGWtjohFwco2eNgo3TaVJlDMMqhUN9V?= =?us-ascii?Q?v8RgYHpBdxVzXN2jam6bwAbA544xAWJ1JHFHmHvgU/46lsU+23XuVN3on3mB?= =?us-ascii?Q?GtLHmjAHUI3iSDNoN4GjUzUr1RCYQIp5CwZ1SIyh1YX6ceD0EL3TPwJGXmcg?= =?us-ascii?Q?+xWBFGa0o/sF69hZAdj/iWQRaSe3dqR89h43rI6yBHJnnEEKKHo7AwHff605?= =?us-ascii?Q?0eU96M19GJ/Vfw82fmrUvdYvyLZof2BqJQ08WSNnEsXo0VhiyvRSFSm5dLXm?= =?us-ascii?Q?S7U1Dz6bQheBqPfqcl7W0OGmhkdI8ln9jFixZJ3sCT+wOxcnyYEDW1WAB291?= =?us-ascii?Q?LM51fwvRiwJNGIl6vD1VNwbiOLMm+ADWAD+r0hInVng+ZW9YKS6+ujggcY7l?= =?us-ascii?Q?Bt32nLhdiiled8H4v/MEeYfzjmQbEUnCa9cbgwLqkpTJgg+KQNVHSfTNJgX2?= =?us-ascii?Q?k14gX1HGMcXCUQjafDp0rahoDSRuNOc9Fnkc4kk9jasc7ptDy2eeGBU7CajP?= =?us-ascii?Q?WRfmdKzA5c+T0O8/8pu5D0Ny0J1JKFEWYlvf+NFyiit2tMnwuEI5yHElsO+8?= =?us-ascii?Q?PvESGDT1487yqCO5CdK0827Fl6EAivMTNous3dUJaj56v/eiFlWwLf3q4KLO?= =?us-ascii?Q?xZrT4Oydfem1H9ZUawv8HewRqa7Dg5DsHjoJ5MiUnEtJLu1YQOel11U6Sdbp?= =?us-ascii?Q?H6yC7cgZeqj1yclJCgLqdmo5WJRU4p5zdtop7xFqfywCbjPBMXw/m/pKAgpt?= =?us-ascii?Q?Z99LFi3i7XpQblKgceQMQqdffJociHoe3DPKP4X/is7yRnl2V8+VXE3oSW/v?= =?us-ascii?Q?pb/tUypuT2Ji2tH97oVn7cBQ9CX32VqfeZDtX/N03N3JT0hjgBy0kXUhnObp?= =?us-ascii?Q?HKjmxG+KC2jNdE9mMB+vTH2vR2C9aX2guo5PqpKFsK+ieRVr6C+qWneDKC1z?= =?us-ascii?Q?itfhCI8eNNpRXzATj5XE3J2fCIqP1KoJikdpy8Y7XN3UX5NPIa+2nA/TmrRy?= =?us-ascii?Q?9MdQHcaw4C0nLO1Mi47oJmgZVydevxKJLY+E8p54TsXOoFidz0gdpxtFWY2C?= =?us-ascii?Q?MbWfx6Q69GklWlbNvJycZCdmg/EQ5Mh0lVyU/Meu3p0xERXKvgzW71NL+I3q?= =?us-ascii?Q?ionh+97e7bDoYRUSkmX7s9EmxdZtJrVZsNODf7fRerGSYS5uoNWNRuOBYgZs?= =?us-ascii?Q?4br4url6cJIzeONM9QRlyPa9FIv/1F4OqsMWO6o7cpKzBGboPju0i3YnyETn?= =?us-ascii?Q?jJ2rURum/BGKXQLH5Vili/H+6l6VSKTyNKxlZiW9K5oY0hzuUgZsQdHR7TOm?= =?us-ascii?Q?FXui65Jn7yglMm8YbXnCuqvoodhraOjar+fd1viZVTaNfXd0AEn1gFwBsf90?= =?us-ascii?Q?k+7/CvgY1qQ0QnmOegav50oqGZbk7cVFGSTpsPSQwByXPZmQVMZ9Kc0DxLE4?= =?us-ascii?Q?zlQyzX3MrMMXLTeIuOzyqsdumbfL9+vIhTNt/pHzUDG8t++0cZh+WFWZ5WI2?= =?us-ascii?Q?ngy38lL3JoBidGGkTiRRY1G3ER4JXiIDLamRcw+heQH5Q4JhOp9N23H5tmPZ?= =?us-ascii?Q?HGL9fZmGFkNGKCjEiwU5gSyUD4Q5R1TpI2aVixG+19PYZ+u6xCVojXoJoFw1?= =?us-ascii?Q?ga+vPxn/XNt7sRTl2E+qGwR+RiuUUN4=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f05a26d5-08d7-42d1-5878-08da3f0d526d X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2022 11:46:07.6056 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: w+6yNz3Mh9lWkkGJluY+JNg+ElXd45KFPzYOtsNhyONVA/RJfRQTjsOQCHiYJwsyZvNF84AZ0GQ+Cb1wbIh9h2PW7r6lCPZxVcaZtjmKgMk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5606 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, May 26, 2022 1:34 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v2 08/14] cryptodev: add public key verify opti= on >=20 > > - Added key exchange public key verify option. > > For some elliptic curves public point in DH exchange needs to be > > checked, if it lays on the curve. > > Modular exponentiation needs certain checks as well, though > > mathematically much easier. > > This commit adds verify option to asym_op operations. > > > > Signed-off-by: Arek Kusztal > > --- > > lib/cryptodev/rte_crypto_asym.h | 9 ++++++--- > > lib/cryptodev/rte_cryptodev.c | 3 ++- > > 2 files changed, 8 insertions(+), 4 deletions(-) > > > > diff --git a/lib/cryptodev/rte_crypto_asym.h > > b/lib/cryptodev/rte_crypto_asym.h index 0dab7c0593..3eafaecbbe 100644 > > --- a/lib/cryptodev/rte_crypto_asym.h > > +++ b/lib/cryptodev/rte_crypto_asym.h > > @@ -141,8 +141,10 @@ enum rte_crypto_asym_ke_type { > > /**< Private Key generation operation */ > > RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE, > > /**< Public Key generation operation */ > > - RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE > > + RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE, > > /**< Shared Secret compute operation */ > > + RTE_CRYPTO_ASYM_KE_EC_PUBLIC_KEY_VERIFY, > > + /**< Public Key Verification */ >=20 > If this is not for DH and only for ECDH, then specify this in comments al= so. > But IMO, it will be OK to use RTE_CRYPTO_ASYM_KE_PUB_KEY_VERIFY. > If it is not valid to use it for DH, we can mention in comments. +1 >=20 > > }; > > > > /** > > @@ -434,8 +436,9 @@ struct rte_crypto_ecdh_op_param { > > * Output - generated public key, when xform type is > > * RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE. > > * > > - * Input - peer's public key, when xform type is > > - * RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE. > > + * Input - peer's public key, when xform type is one of: > > + * RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE, > > + * RTE_CRYPTO_ASYM_KE_EC_PUBLIC_KEY_VERIFY. > > */ > > struct rte_crypto_ec_point shared_secret; > > /**< > > diff --git a/lib/cryptodev/rte_cryptodev.c > > b/lib/cryptodev/rte_cryptodev.c index af58f49d07..57ee6b3f07 100644 > > --- a/lib/cryptodev/rte_cryptodev.c > > +++ b/lib/cryptodev/rte_cryptodev.c > > @@ -185,7 +185,8 @@ const char *rte_crypto_asym_op_strings[] =3D { > > const char *rte_crypto_asym_ke_strings[] =3D { > > [RTE_CRYPTO_ASYM_KE_PRIVATE_KEY_GENERATE] =3D > "priv_key_generate", > > [RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE] =3D > "pub_key_generate", > > - [RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE] =3D > > "sharedsecret_compute" > > + [RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE] =3D > > "sharedsecret_compute", > > + [RTE_CRYPTO_ASYM_KE_EC_PUBLIC_KEY_VERIFY] =3D > > "pub_ec_key_verify" > > }; > > > > /** > > -- > > 2.13.6