From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8F64A054A; Wed, 25 May 2022 08:36:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64DD1400EF; Wed, 25 May 2022 08:36:28 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 505B2400D6 for ; Wed, 25 May 2022 08:36:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653460586; x=1684996586; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=rPXgldoX9RpFEHMtgUOuKCu49hMmkJHHD41P2f1bZnE=; b=g+DVe4OQoVD3tyyO+YGNBcdSRCqQIh/tYubA72Cx9XLIabFv70iD5024 6EORJVJc9DYo7UafbTZbshzLJLakWldCoatauItm2Y703ydDRRCFJXlAx RApVWaBCCd+UlIcpr0tV4Zyj9ZnOSbkDb5/78/ri6E0p4ZCYwEBNSZbML afp+kfg11IN/PCOYPo4kwER1hxuO1bB7TchH1f67jRzsDF3im5EZQMdfH UwmFZ3xEpJ6Eb/swSkTlxyPwPcksC5RMorzsH0FOVROzMymAwi0uykjq/ eGtdGIGZ1249z5QtbCJIEEFE5laUQyzK6qPNeEObGMFkCaPNDfI9MC/Sn Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10357"; a="271306320" X-IronPort-AV: E=Sophos;i="5.91,250,1647327600"; d="scan'208";a="271306320" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 23:36:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,250,1647327600"; d="scan'208";a="578211257" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga007.fm.intel.com with ESMTP; 24 May 2022 23:36:24 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 24 May 2022 23:36:24 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 24 May 2022 23:36:24 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 24 May 2022 23:36:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YBf+jzYw/brBrMmVTVX8PADtqmh+OIVT7U2+RYjM+jIYvEoI3HmwTvbw29Kuykk8Qob4JovIKSrD2YS3YaGav+Glc9zUZb4OSEzCVEsxVmcZHCD0HA/hih7gzaxz+AXjm58s6Pee8vZGsuqQPDlS3B28Xq5GCS+7Eh2h3gw27tltxvkVdhkbXn6567ctW5mjbTbcSI9mUxj/gQe+7E4MPYYf2bm5vo4H8oLAqC/ertJqqBAn1l0eUGPGRudZDiYJ6VbsiwIYwmIP3Cnt5LKEEjd5yvR2A5Jjl3Q1menK+uLPjlMw6XWI5IYcWdNn4qT6V+rGewDHdhRhwOgf+Hb+wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cZ4pPfczx7QEKrn3u5URYEAv98GpvAfcVTcUYbLSiOc=; b=fCalalU0m/sG4xADeCIK7Mwd89Gf0lTKeJMpcwTyOf4ruQ8Khq04UzJ5z5GCDmDtS1iuLhlX/YukXVJo4JakilGaz/2ERcDBcBKnOgySMJQa305H8H8yygqxVnC5T1CwRuHNlgv+drHbrKOuKaqfnVyyBon4+m33BJ9TaKSqzANmKezoke8HQwiBhmDF5UuKTWZac68QM0DKK3xMIzeJdyH/eGi2gk+FkaP2DQ+gHFvB+9cVxTzQrEi/z2tjwL+LOUIZVDHLqBKuHjfs88zB8TRuYt7/4QeFrivpVnH6SIikIHpymwpEGWvwiJHyADTS6+2OPSoM/N0O7aHp5bCzMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by DM6PR11MB2908.namprd11.prod.outlook.com (2603:10b6:5:70::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Wed, 25 May 2022 06:36:22 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::fc0f:1644:98b5:be1]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::fc0f:1644:98b5:be1%5]) with mapi id 15.20.5273.023; Wed, 25 May 2022 06:36:22 +0000 From: "Kusztal, ArkadiuszX" To: Akhil Goyal , "dev@dpdk.org" , "Kiran Kumar Kokkilagadda" , Anoob Joseph CC: "Zhang, Roy Fan" Subject: RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next xform Thread-Topic: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next xform Thread-Index: AQHYbBe2UHM2F4o38UOTiTgBHrrEV60t5jIAgAA66bCAAQG9AIAAB+Nw Date: Wed, 25 May 2022 06:36:21 +0000 Message-ID: References: <20220520055445.40063-1-arkadiuszx.kusztal@intel.com> <20220520055445.40063-12-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 24479c06-d3f9-49cd-87f0-08da3e18e225 x-ms-traffictypediagnostic: DM6PR11MB2908:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ALwvchMR+zf40Uf4g2qYXlnFtpsQKXWQWXiwJvC91HFxmocZOCMM6bXBQwT3kywPIVWQtF+lR8mb1a6OgK2epT+gmPe+FJlmSM6ddmGDhYDzu/5cvpAXGYRt4orcFruorYLceIuXqa9MyMNQFI7kmdPL5ngOiUG+4Q3Bqnse6AVI3p+/1jS17oobp1jkPWXYz8PX+wHxxlJafDPtIGgi33ZweCWX8Oil5SpLYONgk2A59ZNHk6mHcGVHUuAkZl48FBCi+xZuSF+h/PbdvR/lKIuz3X/zxGvgA5VICs0CStVnpjSDy7WQmn/kF2df7XeERjwcqG4CMDKbBevNkJXobYMXqYJLcY36Mo+WvS8SNmlvY3lmt0LXD3tMMQZYD6KHRz1yUDxvRifOQAfLjOcpTJ+0iajh3k5o3BdQZay8+Fi83Unt2ZHZbrrFW7Q+6lO5ZyAK5rh40VRO5p5TDEiL2YTH26yza8ITnUNcCTSjjE8sM4WhylHHfiMbFptD7qTWPlYy9xPLxVaH32AFIkgdzFBjBFwtJOnc08tm5GSX6lb/Oi8i0kxGNMW0FTLIICrf+IAuqYqavAHB2HWkm1rYMcWMry+eY13RQdKMPwpZ9cY8o010VTrFO1dPy/R3yNlV2UFxsJqBZssjBkEAlq1kR2X0h+M+mo39G9zz/cfYBIbA0MHQiet8Rf+MLweG/Y1uqHTvmogQ6yaY0pH2bDDemg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66946007)(76116006)(8676002)(7696005)(4326008)(2906002)(6506007)(64756008)(53546011)(8936002)(38100700002)(33656002)(55016003)(508600001)(38070700005)(66556008)(122000001)(52536014)(82960400001)(5660300002)(316002)(66446008)(86362001)(107886003)(83380400001)(110136005)(186003)(9686003)(66476007)(26005)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Yhu8tyxgYO6GeyokLAW8gwffWn3qhYEmkkHD6OeDakKFq3lNMdxrAnd5QqzM?= =?us-ascii?Q?65vcV5iUosdgZmESpb93vCF1/HFaxGsKVem/hVO9KcmWsVvwqhZ3fdEPm5d7?= =?us-ascii?Q?ehGR9hW/nuXC/mo5WMlHJ9jibKx/k3BAz+HHGiNbpTbVP0fTgFilfSe6PqOZ?= =?us-ascii?Q?ZKMxJZqcduGB/sfgsAeY39axDNm8i5Z2gBjk4xOV4cmLzUnoj/p6h2B4hS/+?= =?us-ascii?Q?MHtOpKFrbQgE7iJH9mm9WSBvERN3SZfkxtgTYPLyw60JxYQqNq5S3BgSCYr+?= =?us-ascii?Q?YnjWmEZAdaDfFLgjL1NJ9U0AMQzH1ANcJE5VoeAihao5g8F1rxnNIUWvkN/Z?= =?us-ascii?Q?78wtD+w8sjltmnJZAp3hHBtRbL4vw+uIFSdeLoen3rt1GhDCAoaDbM9jfbKo?= =?us-ascii?Q?qdZfKfmv8phiMzHN5Y3mgRvri1sbguHzes4fMfeQe1LWlGWgsY7VUDJ7Smw3?= =?us-ascii?Q?njTS0o1i2AmKqkvHatAhqDtGBu+4wRnJXFgV76xx0pAxOgJRawWofoHNQnKj?= =?us-ascii?Q?fur2SAb4C5oFibze+h2fBvcDh8kem9OT0lSVMxfML9yHUFlaA2vGLcTOxfkz?= =?us-ascii?Q?w0/Gor6IMOHzsmWiT9Ix8PU46d/gxTjWdmNAd+xgzMgXUwJIhrhyFH3X5mTF?= =?us-ascii?Q?n1Xytymo2s5LOKi5/n48Y3p2rXHR3j/u156GyxoeNySz04CGSfTketFh5dkr?= =?us-ascii?Q?JUR22lZv0dYip7ZplQxbaT8TOaFUyDgkwr57HKfQ2uuarV0aMR+v6DUE0bur?= =?us-ascii?Q?4I+63X1JBjBdS28+YUUSjGCcr4gbuk66MakFvOdVQqbECYUrAFTLrax1ScDJ?= =?us-ascii?Q?tNVeDLvyfWfyr98G8zUVH5SlqyA0vNsxPSOe6Zfj4ArMwV2NhazONInP98tn?= =?us-ascii?Q?qRY3XD2RMHLhUHicIFRRXpMhIUwruxGj/0VfVUTCv1WfYzoK4AWvLmyIceXT?= =?us-ascii?Q?m+v0AddcF0GK5YfljJan2Vi3O+OrfusTiNPFCTf8zL2ylTiEbxL617jGiH1f?= =?us-ascii?Q?lmnkduE4fGZQuLLql/mgXtmblYzQs+3rvMa5vMB+Hlj6HvG//c1Ce3YxpbLY?= =?us-ascii?Q?G4mvDMbenvroqr0i/heSKdKdqmtj+thw23lWqHmQ7TDpwD0OMp4SK+2TOtNJ?= =?us-ascii?Q?usDiojNVGVJ5/GsBsOKbFI0r1kFLZ5We3YnLaPl1o0CnoWgqOlXqVHnUIX/V?= =?us-ascii?Q?KQg4OLP/iqKkQx0kvBjdwkOC7oH64qgr6iOcFvAW2Bsx3F/Wkf7J14peaWla?= =?us-ascii?Q?N/VT+W13Kgm3zr+vDTAQnQwMYS80YM3SHLqLhm9EliDGFNFZSOLQiES7X8l+?= =?us-ascii?Q?U4T0XuyGp/hZ8tiyEH64RXYV5F/J+839Yc7ZQz3CKI/u1Trx2EOFj4nVYs2C?= =?us-ascii?Q?J4mTejw4yVnEgji03wP64+BEiztv94J0H7q44+qrQSZd+xB+jtaSW59BWsgs?= =?us-ascii?Q?bt9EchRLlgbjT36SBwS22ITWvxvK+IZ7PBuJbTmwbKjT1MqcwtH0L/M1M3wc?= =?us-ascii?Q?Vm78qTNvd+Yr+GwMcRcBpbwx616rFuoWhswYVVGgGeZPG/VctcpIbiA9j1FU?= =?us-ascii?Q?E7He6i1XHriljJ0eGml1zTpFVDnrWW4UlSF8XNq3khqntEbTQ+6kgTVwSgfH?= =?us-ascii?Q?T1gZNty0cAy6fRfYv0a6gHPJISupovKjm0HtUWhksa9k7P7Ry75A4SuwGwYg?= =?us-ascii?Q?/AlvgqaU26NBceSqwk3dGpv4VpgoxiHgSPbtT6j6miM4xpvVLjKuF07XLkms?= =?us-ascii?Q?xIgQ2RyIcksZ52SSER4+40i1WHI+B+c=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24479c06-d3f9-49cd-87f0-08da3e18e225 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2022 06:36:21.9969 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: U/3gmQ1jXy2jBbftZx4InA8SG0OjRaabpjtLSeGNlb97kSWCJFCQF4MZZy267VuRA0PLa+zWlPZVbQJI9Eaj68Bly4ATPEtrg22U0ls6beY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2908 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Akhil Goyal > Sent: Wednesday, May 25, 2022 8:06 AM > To: Kusztal, ArkadiuszX ; dev@dpdk.org; Kir= an > Kumar Kokkilagadda ; Anoob Joseph > > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next xform >=20 > > > > - removed asymnetric crypto xform next field. > > > > Rationale behind having chaining in symmetric crypto was a fact > > > > that encryption and authentication are usually done on the same > > > > set of data independent of algorithm. > > > > HW usually will be able to handle it in one PCI call. > > > > In asymmetric there is no such relation between algorithms, > > > > therefore next field would be useless. > > > > > > > > Signed-off-by: Arek Kusztal > > > > > > Please check documentation "doc/guides/prog_guide/cryptodev_lib.rst" > > > Not all asymmetric crypto xforms are supported for chaining. > > > Currently supported asymmetric crypto chaining is Diffie-Hellman > > > private key generation followed by public generation. > > [Arek] And why do chaining when this can be done even with one bit flag= . > > > I believe it is OK to remove next. @Kiran Kumar Kokkilagadda/Anoob please > confirm. >=20 > If we are removing it, then documentation should be in sync. [Arek] - although, we may keep it for now, I am not dropping it in v2. DH p= riv + pub can be done with priv_key.len =3D 0 -> similar as 'k' in ecdsa wh= en k.data =3D NULL. But I do not see any situation for now it will be useful, it may be droppe= d later if not application found. >=20 > > Also, currently API does not support chaining of > > > symmetric and asymmetric crypto xforms. > > [Arek] - This is one unlikely scenario to combine symmetric and > > asymmetric. One I can think of was once proposed DH + DSA integration > > for random number. But not much else, although we can keep it around fo= r a > while. >=20 > Yes it is highly unlikely to use this combination. >=20 > > > > > > > --- > > > > lib/cryptodev/rte_crypto_asym.h | 2 -- > > > > 1 file changed, 2 deletions(-) > > > > > > > > diff --git a/lib/cryptodev/rte_crypto_asym.h > > > > b/lib/cryptodev/rte_crypto_asym.h index 1652a434a5..b355cbe5fa > > > > 100644 > > > > --- a/lib/cryptodev/rte_crypto_asym.h > > > > +++ b/lib/cryptodev/rte_crypto_asym.h > > > > @@ -492,8 +492,6 @@ struct rte_crypto_ecpm_op_param { > > > > * Structure describing asym xforms. > > > > */ > > > > struct rte_crypto_asym_xform { > > > > - struct rte_crypto_asym_xform *next; > > > > - /**< Pointer to next xform to set up xform chain.*/ > > > > enum rte_crypto_asym_xform_type xform_type; > > > > /**< Asymmetric crypto transform */ > > > > > > > > -- > > > > 2.13.6