From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5125A0545; Thu, 26 May 2022 13:45:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8503940151; Thu, 26 May 2022 13:45:03 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id CD6EB40150 for ; Thu, 26 May 2022 13:45:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653565502; x=1685101502; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=xjCPxKRpH8uF0y7c2Xz7fT1ePjyST1w0nS9Nw+cJi3A=; b=OnqXCkOg/ZZH45bS3ZZ2+8WnOo8kEBw5ryCQQsODdTP/ZdwzbW3gggMN IzhDYSaoie78vU0g+KN8yCVn1niyMHfLXv5ZLXPSJ99WVJbyjnhLKDaW6 wa6a4Da1uS9lqxqJMDZUGwQ4yESme1iwVMrWAd4tGXIgVMbaEexzJQPVH 1lwov7s+wnjU5H/pzqsVYt21KX9IZ3PF6Dc/GPZ7SM2OLKfJ+bxS7K+Wp Wzo4F05naSQeHOkwZnMHCLbpctqhpdF3r04QPtv6Lm9Z9ehterCG7FAzu e73pthBRiSMFzhxq2wP1bUjdF2IyBSVPyTo61Aa0Iw5ISWfovxwCHkmPf w==; X-IronPort-AV: E=McAfee;i="6400,9594,10358"; a="273854309" X-IronPort-AV: E=Sophos;i="5.91,252,1647327600"; d="scan'208";a="273854309" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 May 2022 04:45:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,252,1647327600"; d="scan'208";a="746291214" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga005.jf.intel.com with ESMTP; 26 May 2022 04:45:00 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 26 May 2022 04:45:00 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 26 May 2022 04:45:00 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 26 May 2022 04:45:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XQcQmORs7wTh+GqjUZtRo9MFxzJe6UpQnCB1wawWnotzSWRGS8LOViN+E5Jzg8Ha9xzlYAneq3Loa1l3KgD0EmW1gamLGfn3gkgfbsl8LpXLejdxJENNlIvW78c6grJdhJFnj0J9chHGMPvl6aok2uz4hC7y6GHXYRE/ewgK1FLIR8PJLVPO8e08C5aY4xbTx7E6o2fEeyJQX43wkb+Z4DC4JrSc0tHVlwte1q56YpgHnhcGv06JBb52mhd3bBrX4R49yE6dlSZT646G38SA5tSw6iE5CSrj+r5MvoebWaHlHVnueJcsHhYn6IfZfRJQ4FWbvAG5n4tnn2uA6r8/zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kQDnL5jQ4rgyBBZLAuPSLpqaAbceedCwSyoAABJKPKY=; b=mHDStdQCOFXkr9MrLr+TIBDj43a0h6VFUzoTkSCxVuLL8MSxVK8y5QRICW64Hxk/IgiyIXR77O3zjmhr18ouo4gdX9HATsk6RD7MfVbPWh2rDuKMTDwFy9b4p8tAMuQg7Pn5SWam3ev+a3xsBN4fj/Dz8pSGJad5SQNZtMyuVsHbLO1ZN8SWA2GceZTsxT0rBGFBFerEzDBoVB40dNTYYhEXrPFcc2Ra+Q/jZTql5apIBAUeyFYK2zmYFdETMbsIlExS58rLsPSwjIDI0kopobabyQXFZ+u69/3oEYwjc50qxUEDGnZzfx7byvpts1D+EpC+yRYZQKPqj5e3bkCXZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by PH7PR11MB5943.namprd11.prod.outlook.com (2603:10b6:510:13f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 11:44:53 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::c1de:722f:b4f3:91b5]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::c1de:722f:b4f3:91b5%3]) with mapi id 15.20.5293.013; Thu, 26 May 2022 11:44:53 +0000 From: "Kusztal, ArkadiuszX" To: Akhil Goyal , "dev@dpdk.org" CC: "Zhang, Roy Fan" Subject: RE: [EXT] [PATCH v2 07/14] cryptodev: add elliptic curve diffie hellman Thread-Topic: [EXT] [PATCH v2 07/14] cryptodev: add elliptic curve diffie hellman Thread-Index: AQHYcFkfQS+89UWFy0eCqP13Xv2blq0xBvAAgAACChA= Date: Thu, 26 May 2022 11:44:53 +0000 Message-ID: References: <20220525155324.9288-1-arkadiuszx.kusztal@intel.com> <20220525155324.9288-8-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b2e446fd-45a3-4414-7e4b-08da3f0d2651 x-ms-traffictypediagnostic: PH7PR11MB5943:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xZhDHQoJpiutLEUj+zdqIcwyFrgqrEGokc8btQLej/njnMUxTTQkq3d/rZKQWx2Vj32gP7ArMa00uRHbGCrfk+Ch6Llpejl/584qSRq3vN9rGl00qhXvzxLAj6fGDbR8B+diyJV+thK6hgALSUgTYWxHygzO9FsfSt8GMh1HIJmcMxweolvYch9er2nJz0SPGrxNh3IUy5fC6VqWDYtw0Ki96Q3KrTK/gclZxVW5bmnWf7lK74B+yLeZIHqUZ3a6F63LUNpnl9ZiifGtF5h9dDByOcEOnoDrrPOGF5TNg1CjGL88K/VlKLO/8ElHovxSTGBejA9w8wzZgb1YrNjrYyc/17AGb3HxzHsJI6U/VLmRv3iYvOloXgYOa9RuzNxeM9wYPdQbhgd5+oxJ4nY0m8rv45zIWgU8MiK/2Nfub6W6GasK392R6CIB8/eAxnm8FHD5XRjrMkGeg6HFOM2g60J4vaQhBnly7v0IWSeII+eBpLP7ly966dEovW6fjQSPioANFyfxpFVtuZc8ka1Ugi2aws3nQnjic0AA2wuH+yaOxX2V6PWHfQTcsZArjmYotkINDuCSaIY7oH1y1Ix5DjTTd13Eh8nF6QmZNTjgRNujejHtcnJtHKk3llKf3ByaTop6LOce3EAFnpxlH3LKdyAWvEY4S8NintBWP0/bQGTlbcZFlpcNwRSYCQIXLx9EgkHtVyF889TGHIiqXBcQ+w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(9686003)(64756008)(66476007)(66446008)(8676002)(66946007)(76116006)(55016003)(4326008)(5660300002)(83380400001)(8936002)(66556008)(52536014)(82960400001)(122000001)(508600001)(33656002)(6506007)(71200400001)(316002)(7696005)(53546011)(38100700002)(186003)(110136005)(86362001)(2906002)(26005)(107886003)(38070700005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Be0ZkHdOdnAb6ryn8Pnn/5MwMa0DaM5SidAKNvPV7Yo3KEdcSzwkFMpCYyDa?= =?us-ascii?Q?JfK+hciHR11lwa9rkV1V6gV4CEY9+3pbMDbctxnLInHxwOiI0E+Jf4XDuB/j?= =?us-ascii?Q?xBtbhDzR96pzvIpEYhevGA8toLpDIRh4n63m8BI8cxrb5Al7IFGuNgd+qIbL?= =?us-ascii?Q?+SzNsMjN99MiH81+KSJZ2no+J7Q3l0qU3nU+KXuiD8b8NbYDeN1GE+fmt1aW?= =?us-ascii?Q?XzQvtPYpgMCWIrq+c/480If8OBjjQ+Tel6nAt5i7S4Z0tQfOAN414MXcNst6?= =?us-ascii?Q?eFKCQrfj2SOykUFJ0F+yA+GohS31YsVxzgmZ8PT3xnqvubW88OWrzt63s4lV?= =?us-ascii?Q?G/oQAmplhE2LztNz0ZjeVTu9MX6o9a/smogEu3LgFfB9Gs9T5GUouG6gXfGf?= =?us-ascii?Q?CbtMaP/wqCUone+G2w2EG+DKxTDDzoA4+wFw0wctgpzQ9Fp6p0nBHeorcsvP?= =?us-ascii?Q?HMA0mrlkDOXj8xbvonpgYb1iZCrGcCuTJRuPcckBP/qePb3fjbc4m8AqVjdz?= =?us-ascii?Q?vs++J35iI2LmnN3MkI4wDU9RQ/YQhLe+cvY9Au+L30SDYzCNY/TAS8OBgFNI?= =?us-ascii?Q?l74IgE5NYTmThZj/B7HYCNaOKy5wwX81DQqp/a6Agm71OuphY60sowNqz1mg?= =?us-ascii?Q?VPHrWeI49oupvkzTq7e4pGouPUtA9ue1Quxs3HtFUkulL1Ao/t8MwvSFYhM4?= =?us-ascii?Q?iswGkQdVTxf77QI+ZwvnT9PfPc+coDDO0wXXU55Ub2To1yh5pb/2d7fd+49j?= =?us-ascii?Q?WKtehGQ9jsHobB6GFme15EuQS3CM6V3nuOWS21Qj73+2B4PpSJlCcIopLvax?= =?us-ascii?Q?wcaA/hrtxC//jp3dP6nOEaAquqP0YYAPq4l1onR2398D3xm/xObo8/0YfBHN?= =?us-ascii?Q?Z2CMhrLu82qQE3umJ7dFQ+TDMDIoUpcjTjSj4fxP6oPuglXpDOWtXbLV0IUl?= =?us-ascii?Q?qWNhYmiTyQgjdPpnSNL7ml3m/B61IVkw/4MgM8nz7ksUyfxhz7SjVJqsuzt3?= =?us-ascii?Q?E/ebWWrVqI6tqrpg29U0S37fXjaCR9JtGqKMxnsJz851da8ZVyx7heUhfTaG?= =?us-ascii?Q?JzSZUKxlJWcTw7QVlSM5JykiX+y5P11gtzY2mEJ9klRiu9UsnE0RzUpKJBcs?= =?us-ascii?Q?UJOxHViPyHqcLNHsvVtvHUlrSorHmWjj6uuJcg16geDmOm9RssldpPZO4cTi?= =?us-ascii?Q?DttRy9UxWdK5oAZd+ffrCKhWGEtJDvCJKhpAj1WZwPeVtIBxhHvKVHsd/+OU?= =?us-ascii?Q?reG3yzKSKz5Yh9+tlQ/IuPo8Mf+I70OmhVyR6Ef1aPfejsl+1i8ApEV63m1Y?= =?us-ascii?Q?VdxpBPqheeNHwMiYV8wUZ3RlUxuCXnAfGVvoCXgRFvtUecBQ36MU8j+NN+yH?= =?us-ascii?Q?Pn1efc+Vz4xX9HhRa8/Chfc6KP9mRA/LmuYOBAzH7sHMmAY5UPoEAw44nh7b?= =?us-ascii?Q?5i/L0yDRRBqiGfomhcPHGooBF9t1g8UMBBfkgAxT49sygAaUTZMDvbM+2m4Z?= =?us-ascii?Q?ORPeIgpDTzDvr6egNy/HcSF0Zxlh2fEms1N+/aPuaaqfbbxeBp7I6L1iHtrv?= =?us-ascii?Q?WauoUlCPNXDiWO45NOiumc3v6NAXVEIYauhdryquVnopNR5pbBOoWS+4uYPP?= =?us-ascii?Q?ax5H7PNcxzyMwTA240owQfn7NMi6boIufBd5NRTydxF2lT3JqcAuNeT+QAfb?= =?us-ascii?Q?Wkk8gBTY7A5ovRF1hH19/IKEMGHXEUk7dXrlyDcPNREKmNAf8xZ5v8ytQke1?= =?us-ascii?Q?ql3T5kNDlv2NfCx1l8Mv2oPrHbYOZ98=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b2e446fd-45a3-4414-7e4b-08da3f0d2651 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2022 11:44:53.5720 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6cxK3I4M9opQj0fc+LQ0JccYjtmspqqSV3B08F0Ni28/qW/D7zSzDvkSZ8wIQPQsZQlKASld2VOSk4bkhRyO2tU+VW4Nzow1+QsX0jF5QQQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5943 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, May 26, 2022 1:29 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v2 07/14] cryptodev: add elliptic curve diffie = hellman >=20 > > - Added elliptic curve Diffie-Hellman parameters. > > Point multiplication allows the user to process every phase of ECDH, > > but for phase 1, user should not really care about the generator. > > The user does not even need to know what the generator looks like, > > therefore setting ec xform would make this work. > > > > Signed-off-by: Arek Kusztal > > --- > > lib/cryptodev/rte_crypto_asym.h | 38 > > ++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 38 insertions(+) > > > > diff --git a/lib/cryptodev/rte_crypto_asym.h > > b/lib/cryptodev/rte_crypto_asym.h index ffb0e8ed17..0dab7c0593 100644 > > --- a/lib/cryptodev/rte_crypto_asym.h > > +++ b/lib/cryptodev/rte_crypto_asym.h > > @@ -112,6 +112,8 @@ enum rte_crypto_asym_xform_type { > > /**< Elliptic Curve Digital Signature Algorithm */ > > RTE_CRYPTO_ASYM_XFORM_ECPM, > > /**< Elliptic Curve Point Multiplication */ > > + RTE_CRYPTO_ASYM_XFORM_ECDH, > > + /**< Elliptic Curve Diffie Hellman */ > > RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END > > /**< End of list */ > > }; > > @@ -407,6 +409,42 @@ struct rte_crypto_dh_op_param { }; > > > > /** > > + * Elliptic Curve Diffie-Hellman Operations params. > > + * @note: >=20 > Note missing? I will remove note. >=20 > > + */ > > +struct rte_crypto_ecdh_op_param { > > + enum rte_crypto_asym_ke_type op_type; > > + /**< Key exchange operation type */ > > + rte_crypto_uint priv_key; > > + /**< > > + * Output - generated private key, when xform type is > > + * RTE_CRYPTO_ASYM_KE_PRIVATE_KEY_GENERATE. > > + * > > + * Input - private key, when xform type is one of: > > + * RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE, > > + * RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE. > > + * > > + * In case priv_key.length is 0 and xform type is set with > > + * RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE, CSRNG capable > > + * device will generate private key and use it for public > > + * key generation. > > + */ >=20 > You added the above CSRNG thing in pub key for DH and here in priv key? Should be under priv key.I will change. >=20 > > + struct rte_crypto_ec_point pub_key; > > + /**< > > + * Output - generated public key, when xform type is > > + * RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE. > > + * > > + * Input - peer's public key, when xform type is > > + * RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE. > Shouldn't this be for both RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE and > RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE For priv_key yes, not for public. >=20 > > + */ > > + struct rte_crypto_ec_point shared_secret; > > + /**< > > + * Output - calculated shared secret when xform type is > > + * RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE. > > + */ > > +}; > > + > > +/** > > * DSA Operations params > > * > > */ > > -- > > 2.13.6