From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93483A055F; Fri, 27 May 2022 08:30:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 351B340E5A; Fri, 27 May 2022 08:30:51 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 7195640E50 for ; Fri, 27 May 2022 08:30:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653633049; x=1685169049; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=20yretBptgZ6R0dSQblLuFAcCSQsfepuOxbo4UN1Xkw=; b=NFL0Q3vLkc8VsdZN2ha7vsAtqvUwTBq9+6bDRRdqNYCq+bQ9DjBxHT9f MJAvpbqVvO6Mj75pDUbzQuvK3BOETHprwbyova+SUKhsLZCY5cb9YcH0x N81x2iEZWUhYjgpqt+HTZhteBOebvVqtiWUOWVOoyRkVTMj7rctH4Qneh emcLiu80nr4XKLzSJBLHr715ML0bMypfoyZFdxbfUI2I3yMNm/FeKoZZ4 Bp7LinGf4cZi8QbdbNQQbYHmlfb65rO7F1/7cw9qeZsKgkY+v1UhSsDuO pZ5EHtzD4tgzAbXebEYyBZTrOrudGNzQE3eR8G9+elofcM7Cd/LwZ+L11 A==; X-IronPort-AV: E=McAfee;i="6400,9594,10359"; a="273207628" X-IronPort-AV: E=Sophos;i="5.91,254,1647327600"; d="scan'208";a="273207628" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 May 2022 23:30:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,254,1647327600"; d="scan'208";a="643244398" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga004.fm.intel.com with ESMTP; 26 May 2022 23:30:48 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 26 May 2022 23:30:48 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 26 May 2022 23:30:48 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.106) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 26 May 2022 23:30:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Aa9ZNjHrup6ZGdiv9MUtgwlUtPzwkqM2nEaP1PV5kim4EovBPcPFGhS1nChr8Re/8luC8jSEs8JsMZj8rgwUuhtRkLIEIE7j7HbTRNHzQjBe66QXYdi0xtleRRlwIlcjSsQ9FqaUZ0Y1o74rqKpDi8U6JU1QE5//BFHiJGiNewz5GBetl5xr9g48UHU79K62vyNAB1noaIFvo+g98T9tN953cnVWT9xxumVTrJBcfwBCZSi7n5QzHTD22G8hSJoiSsNfF/6HGA7A9yP/R7w6E+XfI3H9EpoEIkBaxNz1C464qzJFkt1V6GmQqqZcKpvtpiSp+Y4rMP6zYCkxNiSLAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c9svGMX3EDTbOBm4DLNIQXDAzel35amFg80eSSMIBUk=; b=kZteIi65zpTfAhzbepz7PV7AXOnAbCtcvm4/jHnGTY7uMzfVeDNlPBfJM8hh/Tk6VBDjnt2+dcSbUhfhgP68dkhOd+xfsrSP+mmR/somAeR11OcEq2OiqIZS5BBryCw3dUYySyj7sWwh+hXmbdI2lhbKPgkfETm5UEGM/hN59DF/1TRHn0Tpf100Uysdqo2baPJ7ykPFTQBquumRUh5Ix6frsss2oFYeL94ZIAys2bGIM5t1u2OVBAEoWLRxaIY5nhwXt5u5jlHm2nnsosY4MvIdaSxMhGjxyhr6Esi3i3I1FUKGWY9Ro3qzwUe39wcP11hHz2LO5Cb58BWpNOINjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by SA2PR11MB5164.namprd11.prod.outlook.com (2603:10b6:806:f9::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Fri, 27 May 2022 06:30:46 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::c1de:722f:b4f3:91b5]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::c1de:722f:b4f3:91b5%3]) with mapi id 15.20.5293.013; Fri, 27 May 2022 06:30:46 +0000 From: "Kusztal, ArkadiuszX" To: Anoob Joseph , Akhil Goyal , "dev@dpdk.org" , Kiran Kumar Kokkilagadda CC: "Zhang, Roy Fan" , Umesh Kartha , Ramkumar Balu Subject: RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next xform Thread-Topic: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next xform Thread-Index: AQHYbBe2UHM2F4o38UOTiTgBHrrEV60t5jIAgAA66bCAAQG9AIAAB+NwgAAI1ICAAxCQAA== Date: Fri, 27 May 2022 06:30:46 +0000 Message-ID: References: <20220520055445.40063-1-arkadiuszx.kusztal@intel.com> <20220520055445.40063-12-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 35d0b8ab-a208-4265-7a19-08da3faa6ed5 x-ms-traffictypediagnostic: SA2PR11MB5164:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MoGcF1r3wytoKSSQLGlShN3h82EFm8GtEm6B0fQaPiEU5Kl1VNWIhYhFOzUmE8yHqeJMH0erquQKMKjtrcLiOD0KPO2tI9KdVgNcUD16yJqFbKnix9f3jBL3+ogUTfV0KCx0U3uPDcFBd7c1TxrMN7M10tqqkLvfulnKRGRTH4t928rmFaHJcT1ea74TfrhZ2c1P4GH6s6QAEiTt+AHvo2f8x2DRNsGtgqFUtuDIc52LSUg6s7389Q/6AdzMedw+ObcLCVJI7R2IrNvfFsYkRbPeledOXQsMCw6qdPYixAXqtVGTYb+l+WpugLXsoTMd9/jciEE1zBIxGfvn7OM2pd7hcw5+oDny/xI0a67DCkbOIqhgk6xxpeuk4lRrbfnqNQg7HnKRK4aIVXDqEomJGCCZQHf8f5x6QtGErkzFAI6mmjqUdMpyLthshAonXjBe8JNT7yue70tJGaiHK5qMvIZsO34R9VRLGrK6L78wk9mMYVdwfpdGhVxoSwOWfrhxRjcMKq3vImxBopUQS8hhNtfrfa315Zhae3QxrXxwx6/2kt14MNkucEOVgBDfRg8xAQf34qBE/9ql8VwMVGwM16MbOO611HGVfpweG7O3LfIWeAZRwE6rIpXbg5hfTFrJIkKRMfErj6rbKfTsmMFrqHvRfqVIu27DSDYCfAMrhToAB48ZRgqz03GjKftI1zROf7LOF6QH2eVjutY5fZQUMTyyTkzob/id7Nuol+uEpbRhTI04U3lLuxxctHmVoo1VOty9H45mLaynvEG7mE1F53uuaJ/mQV7vEqe/YzWXK9g= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(508600001)(55016003)(52536014)(38100700002)(966005)(5660300002)(9686003)(26005)(86362001)(186003)(8936002)(2906002)(7696005)(53546011)(6506007)(33656002)(66556008)(64756008)(4326008)(83380400001)(66476007)(66946007)(66446008)(8676002)(71200400001)(76116006)(316002)(110136005)(54906003)(82960400001)(122000001)(38070700005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?txZUvFn37uWWgDdPJblr7s8mTmz/AdXLCbdMzvy2aPCIVsVw0pJ1JQ+WcEMg?= =?us-ascii?Q?cKxCDyENEXtevLYNHsA1dMM0OEYuFeIfPg4SnnOZnPYJMpwhqGQF/Q1HgTi5?= =?us-ascii?Q?lyCNgF2MXsQAmQINW1q3j1Z1TmqfbiEKC7s5PfMlUSOBkAsV8BCwsWdv0i6B?= =?us-ascii?Q?jZSGeTYtIs2JuQs09IRssDsPgLfwe5ZL41ErpLBPmVWYxy2B9hQIktZCEuBq?= =?us-ascii?Q?8/xLHd42LP1AnW7yjGJ/LmLTOcDR0WQBgDPnpe/8OxgEVQgGRMywDvjH9rPc?= =?us-ascii?Q?vfTirltIl2GJhSz3kMAkK2TFp7ED0fKHd/A85wZiQzdOQiTJpzT1kRVWEFRS?= =?us-ascii?Q?2jTOz7hN78Z/C01xWpdqL5+zb6ZAijLgJ3Fa0U2nTqjkza+maCpF0ew5sZtj?= =?us-ascii?Q?WnocTCczJsVGMXxjSeq6ZvayZ3B3f4k+jvcBDMp2GWX5R60RLyuovsXjXIhU?= =?us-ascii?Q?EOYeqJjBL9qD9CXL4CbevBZfG3HB+pWP0FYKseHIQNaEI8lnLpOWp1VEoiq6?= =?us-ascii?Q?YlfA+nxtNbWk0elOL3jTQZVh60+ToM79Rxu29pIEDQlEJX2BRBVsMEY6U9Cd?= =?us-ascii?Q?2WycyruslPdkB1ufKKjVztxMvYprRdJmijAbLba2cOffcwYvb8f6nKOR/yGr?= =?us-ascii?Q?4dip6S4VR713KXLWzN0Lr8fFBSQ87nzQSzg1At3JzZCrSp+eupxNaTmj9bes?= =?us-ascii?Q?J2f+H0N1RzwllVOcQDDRVbcKkp1fY0dJpk6IBjrYiXlO0k34m1lzivOfpzGo?= =?us-ascii?Q?Rhc+OBHPaiRjpAdhopQkpbsQw8F2Ddb4Lz5it73XX86TiXgrqz+NCWOjNzPk?= =?us-ascii?Q?9DgKCWfc0yaSQdRm3ZfVgaIhUNXG3SkifE7NwDYEVUlazHDHeBSg4UH1+yNR?= =?us-ascii?Q?Kqn4ByfAmebTBLsstcudyy1GW5eL9mXLiSytQRE4HElZNNK3Um0w5At75bGO?= =?us-ascii?Q?xsiMV5vYfE2YBTtoM+QR9rMm//tOdblqTtrisaOhV7DZId4cpiTgaBVPnTp0?= =?us-ascii?Q?400yNuzFwnTPgWxMRy/G+bugnfzbBY7NYl9ipmZwpEfMovNBH4xhUzKnM2uP?= =?us-ascii?Q?lUHFlWtwtGIvUjRtwpzeTmmwwk2GuM6Sk8RneaxQ5BhjO7N+XSFVlwJm0TCD?= =?us-ascii?Q?4bstd/jdt7TYj/hJvQHTlAY1UBVXr6edeDlawtxaVaQxBwQGbOXhrKvth50Z?= =?us-ascii?Q?S1gX/Z9cxpxMEjW/wmZJbkwEdxMoqJ+ypqWqCVTVGIeBQUYMfZNRxwZvtek9?= =?us-ascii?Q?4WNvxejmYv/T3aNmKJ3/hVi/3Bf5gIi0CowLiChpui0drog8LXyLVkQjlSlW?= =?us-ascii?Q?2yPU+0m++Mq64zKm8bIClF6e2fYlCBFi3jrT+NruTsO0WF561VpNS3pvHadg?= =?us-ascii?Q?SZbe6+tpYtSugXvqMaHQLXVux3P8RP9aoDXhaPvCnpwdGGxpGdRLV0nccRQX?= =?us-ascii?Q?B5gyjiM07TWO+hcLshDp0G+V0Wg9/inKDECN0rBotoStc/S8d3Ly0zYxjt6I?= =?us-ascii?Q?+g6DGpVHERMj9uGI/2Y5SjHIoVIiNoy9kiz/e8TacZEzlep5lT4j2KIbNN9e?= =?us-ascii?Q?veDxgcQSulhoUYZVuVNtPcGIseWk71d/hngHzlOWDgLP5QAFWwtqehqOs/Ag?= =?us-ascii?Q?HzelUtXKG+YBlDR1Z1wtkGVL2Gv8h7YNlMRbarYFUaEI3xwCaWLee/qlzQPM?= =?us-ascii?Q?W8hbQigz9sHK233K7LXwglrF0FRDYF6tOWiKxJK3kGSXvzj+tL5ggNJwRel0?= =?us-ascii?Q?gH2M48OP8iB3nIg7QYJUGZzyRPIWxDM=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 35d0b8ab-a208-4265-7a19-08da3faa6ed5 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 May 2022 06:30:46.2664 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hWUoO8VUEFk2dt4KBHs1lPSrDFsZKiTKdPAoxyAmb1zAgEIf1GemZnoor3stcdXJLty1xQADbcz5Ua1Fw5NTLK4BsOfryQK/wqMyd72AJwk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5164 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Anoob, Sorry, I don't know how I have missed this email! > -----Original Message----- > From: Anoob Joseph > Sent: Wednesday, May 25, 2022 9:06 AM > To: Kusztal, ArkadiuszX ; Akhil Goyal > ; dev@dpdk.org; Kiran Kumar Kokkilagadda > > Cc: Zhang, Roy Fan ; Umesh Kartha > ; Ramkumar Balu > Subject: RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next xform >=20 > Hi Arek, Akhil, >=20 > Please see inline. >=20 > Thanks, > Anoob >=20 > > -----Original Message----- > > From: Kusztal, ArkadiuszX > > Sent: Wednesday, May 25, 2022 12:06 PM > > To: Akhil Goyal ; dev@dpdk.org; Kiran Kumar > > Kokkilagadda ; Anoob Joseph > > > > Cc: Zhang, Roy Fan > > Subject: RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next > > xform > > > > > > > > > -----Original Message----- > > > From: Akhil Goyal > > > Sent: Wednesday, May 25, 2022 8:06 AM > > > To: Kusztal, ArkadiuszX ; > > > dev@dpdk.org; Kiran Kumar Kokkilagadda ; > > > Anoob Joseph > > > Cc: Zhang, Roy Fan > > > Subject: RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next > > > xform > > > > > > > > > - removed asymnetric crypto xform next field. > > > > > > Rationale behind having chaining in symmetric crypto was a > > > > > > fact that encryption and authentication are usually done on > > > > > > the same set of data independent of algorithm. > > > > > > HW usually will be able to handle it in one PCI call. > > > > > > In asymmetric there is no such relation between algorithms, > > > > > > therefore next field would be useless. > > > > > > > > > > > > Signed-off-by: Arek Kusztal > > > > > > > > > > Please check documentation "doc/guides/prog_guide/cryptodev_lib.r= st" > > > > > Not all asymmetric crypto xforms are supported for chaining. > > > > > Currently supported asymmetric crypto chaining is Diffie-Hellman > > > > > private key generation followed by public generation. > > > > [Arek] And why do chaining when this can be done even with one bit = flag. > > > > > > > I believe it is OK to remove next. @Kiran Kumar Kokkilagadda/Anoob > > > please confirm. > > > > > > If we are removing it, then documentation should be in sync. > > [Arek] - although, we may keep it for now, I am not dropping it in v2. > > DH priv + pub can be done with priv_key.len =3D 0 -> similar as 'k' in > > ecdsa when k.data =3D NULL. > > But I do not see any situation for now it will be useful, it may be > > dropped later if not application found. > > > > > > > Also, currently API does not support chaining of > > > > > symmetric and asymmetric crypto xforms. > > > > [Arek] - This is one unlikely scenario to combine symmetric and > > > > asymmetric. One I can think of was once proposed DH + DSA > > > > integration for random number. But not much else, although we can > > > > keep it around for a > > > while. > > > > > > Yes it is highly unlikely to use this combination. >=20 > [Anoob] We may need this support when we add EdDSA support. That would > involve a asymmetric operation after hash is generated (symmetric). > https://en.wikipedia.org/wiki/EdDSA#Ed25519 >=20 > And, asymmetric chaining may become useful when we have PMDs capable of > doing more operations together (like the case with EdDSA). So my preferen= ce > would be to retain the 'next' field in asym crypto xform. [Arek] - that is very good point, however to implement EdDSA as chaining wo= uld mean that: - we need to implement EdDSA internals in DPDK - and EdDSA (in hash option, where actually picking hash would have sense) = is not one hash but multiple hash operation, so we would have to had multip= le chaining with operations in between - and we would have to compute R and S separately. - If PMD does not support one-pass EdDSA - well this is something that shou= ld definitely discuss, but having any crypto internals in DPDK is not proba= bly an option? >=20 > > > > > > > > > > > > > > --- > > > > > > lib/cryptodev/rte_crypto_asym.h | 2 -- > > > > > > 1 file changed, 2 deletions(-) > > > > > > > > > > > > diff --git a/lib/cryptodev/rte_crypto_asym.h > > > > > > b/lib/cryptodev/rte_crypto_asym.h index 1652a434a5..b355cbe5fa > > > > > > 100644 > > > > > > --- a/lib/cryptodev/rte_crypto_asym.h > > > > > > +++ b/lib/cryptodev/rte_crypto_asym.h > > > > > > @@ -492,8 +492,6 @@ struct rte_crypto_ecpm_op_param { > > > > > > * Structure describing asym xforms. > > > > > > */ > > > > > > struct rte_crypto_asym_xform { > > > > > > - struct rte_crypto_asym_xform *next; > > > > > > - /**< Pointer to next xform to set up xform chain.*/ > > > > > > enum rte_crypto_asym_xform_type xform_type; > > > > > > /**< Asymmetric crypto transform */ > > > > > > > > > > > > -- > > > > > > 2.13.6