From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4219745ACD; Mon, 7 Oct 2024 09:20:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0FEE9402A5; Mon, 7 Oct 2024 09:20:05 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by mails.dpdk.org (Postfix) with ESMTP id 81D8F40151 for ; Mon, 7 Oct 2024 09:20:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728285604; x=1759821604; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=neYBVv66o2Tg8JwR0WSscu1opF7AOMsTqEKIQVTLEng=; b=Eab+slD21CMaqvrKOK1KJtfsAMC6MOZ+urcGEFffZDmOBd/l/Mo/kxTl 5u4yAxim79I4yCqaRgm6KmrUrv/I5fX+74C1elflSHYov7u31y1PUk0vM KhDIzRa1yTo4/T+HOuVvVUMhEMoaRI7buXCmEkK2jaRQFvMTaUFLtX4et 2GpuGbDyQ1AjCmMCmn0DfzMHUQihOo/AJU+BvjJoxTJ2/gW4jvo4suwVx mMT40Pgs5BS0k0TKANVtd6QIu6CIQ78DfclsuSi8CqxnViJ/VWERMMf4A uNIoi7C+WClNLw5w/XWN1NDLOvuugCHNfrAdFKJMZsKlbuHOqa7uXtMnu w==; X-CSE-ConnectionGUID: Vso79rw1SJux4S0aFdpu7g== X-CSE-MsgGUID: 1HQuj6lUTGmGVkyYQyfOmQ== X-IronPort-AV: E=McAfee;i="6700,10204,11217"; a="15039617" X-IronPort-AV: E=Sophos;i="6.11,183,1725346800"; d="scan'208";a="15039617" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2024 00:20:03 -0700 X-CSE-ConnectionGUID: TOhw8H41R62bwxzARXya4A== X-CSE-MsgGUID: 0Cre+o9RRsafvdaNxsM2HA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,183,1725346800"; d="scan'208";a="79789508" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 07 Oct 2024 00:20:02 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 7 Oct 2024 00:20:02 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 7 Oct 2024 00:20:01 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 7 Oct 2024 00:20:01 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 7 Oct 2024 00:20:01 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.46) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 7 Oct 2024 00:20:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YVRUgbm+Bx4718IwSOzX6dpwP8N8rCxvEkwgWmI8Tyd7FZh20UhrfQohAIzdIGH2i+5/ZRr76JCIFKhiA7NACoEh376NMCwjK2988Bf51BbuuzaaRmRRdPXVRhb1iPspQDXw6VaGc0Vo1v4QtRbOcjDwznCzsUVY+5ByDnNq6OVeV7hxlXy35G3H3okRms4sxC3ueb5anrxCBvu4gslELYtCRppbOnq1u2sHwRv0rsOVB35Krn24aV/vR5OPveYXFDMKhBvuKp9NuIFY7TuLaZCyA73tyC2G163s9gFxDydvbTVy3OnqXu8+VInPXQZPV5BKonaMGldClDAaVAmN3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DAJFDgU6DZE7/L5h0w3IBC/PeK7CZZEsTXRdRm0ka2s=; b=rSuMo+FMwhVDaXRuY0j2JdoynXins5wgvb8g6GY/niX8egFa7iaUY3MPsjrLgjOO3yPXWKw1VbDTvKsiRb4V88v/gcl0z2RaXFCg/rCAWWW551LsSKd8I5lAm1Wp+HIxnbQEf5KOk8eZQoy8HT7heZ6hxQyaqQPKe/ba9BcTrlKdKMMfg1nj22emNRAXflmZG13Xx9db6SnA/IuaFPqOZ4vw6wLJz3TZjhjW2A6b/XSBz7leaRBEU+7WFEyeb8MFzBvjGOTWLJy6qQT4K+6+k8EBv50X6bp1fi8Yp34vt0W/54G+1+5lReCoRwkg+cSoB53rCYuS0uBFAhtZ804aUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by IA1PR11MB7809.namprd11.prod.outlook.com (2603:10b6:208:3f2::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.22; Mon, 7 Oct 2024 07:19:58 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::1c54:1589:8882:d22b]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::1c54:1589:8882:d22b%3]) with mapi id 15.20.8026.020; Mon, 7 Oct 2024 07:19:58 +0000 From: "Kusztal, ArkadiuszX" To: Gowrishankar Muthukrishnan , "dev@dpdk.org" , Akhil Goyal , Fan Zhang CC: Anoob Joseph , "Richardson, Bruce" , "jerinj@marvell.com" , "Ji, Kai" , "jack.bond-preston@foss.arm.com" , "Marchand, David" , "hemant.agrawal@nxp.com" , "De Lara Guarch, Pablo" , "Trahe, Fiona" , "Doherty, Declan" , "matan@nvidia.com" , "ruifeng.wang@arm.com" , "Gujjar, Abhinandan S" , "maxime.coquelin@redhat.com" , "chenbox@nvidia.com" , "sunilprakashrao.uttarwar@amd.com" , "andrew.boyer@amd.com" , "ajit.khaparde@broadcom.com" , "raveendra.padasalagi@broadcom.com" , "vikas.gupta@broadcom.com" , "zhangfei.gao@linaro.org" , "g.singh@nxp.com" , "jianjay.zhou@huawei.com" , "Daly, Lee" , "Dooley, Brian" Subject: RE: [PATCH v2 1/2] cryptodev: fix RSA xform for ASN.1 syntax Thread-Topic: [PATCH v2 1/2] cryptodev: fix RSA xform for ASN.1 syntax Thread-Index: AQHbFiRXaZdlGX6C80O2Gl5Vm4E7SbJ65Y3Q Date: Mon, 7 Oct 2024 07:19:58 +0000 Message-ID: References: <20240905145612.1732-1-gmuthukrishn@marvell.com> <20241004061107.584-1-gmuthukrishn@marvell.com> <20241004061107.584-2-gmuthukrishn@marvell.com> In-Reply-To: <20241004061107.584-2-gmuthukrishn@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5013:EE_|IA1PR11MB7809:EE_ x-ms-office365-filtering-correlation-id: 8d59c16d-4559-4a57-00e4-08dce6a0734c x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|1800799024|7416014|366016|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?rozCHPP6aj1UUmjTc5nmN1bGCmy7rSJWrSzOZ3xa7TdEWEssU/Dqh3hO/2fx?= =?us-ascii?Q?bGCvE//Q977qY6C8efaHVc01koRbo9BXfA3qSbtj1u7l3d5hFBjCiRy269W1?= =?us-ascii?Q?4YhTAa7DHKiKCNmPt8ZU928KSTcoH9lK82tpI6S9ro0F2hwuVbh4TjRYRCOZ?= =?us-ascii?Q?fnVmolT2AEf8rpi1v996lGmqW4VJKrhpXyerP8bCK0sW/AJmWx/jv14z6fKK?= =?us-ascii?Q?MXfBdj94KOpVVEK6qrHiOsnl3QXYWraWp5CojkGrS1ty3N6398rtJoLQ9CGW?= =?us-ascii?Q?FmOSlZ+ZBImCAhP8tmtUZiS0j4elMgmwWS4G9ysWyWsNf9dMjeZOZVHXhZxU?= =?us-ascii?Q?Ifrd0fzVB5dwbSawH8ezWQxxEVstzwM7IlzZfxy5jM/aLq+XqeJV3m8Z1tEc?= =?us-ascii?Q?9VL1VrwRAyvGSfzQ0Ulp7XNyuhBJU4f+WMyYMFb6+IYZ9BR86zbY9npjvi4Y?= =?us-ascii?Q?Jb+78vx2ItSSI5HuxXO3eYa+oNvzmRZyyW73qE/fqCUI4+20JfFHeVnExD88?= =?us-ascii?Q?FfuiXzFc3h8oPw5U4Qqty92mR4CpjyzfCv8F7AAGO7Hf+WQ03RnhYR6I/C5z?= =?us-ascii?Q?8xrZQuTXSoLHye92ry8NphYze/5vbzE0B9nRBKf5CBfl3f6XJaw470efxFPT?= =?us-ascii?Q?6vewqKP5+q3wReA9ZkfMMkawV1JUfu97154xjR63jz1HIzQKqHUhiBME928G?= =?us-ascii?Q?3TycLdOtxEXFFB+ZvjgXF/tqsMTfZx7C00VF8C8X6RDAflbY12rxv9IhnwlS?= =?us-ascii?Q?O3VEu/nD7D/b2nJ0gloskpiN2DVnsfNNbMcbHFW7vdf53Z5kruJknVAJjTsC?= =?us-ascii?Q?FJGtpPryvEGLlTc6c4pMoJGJw9jjvN2f7HRGuGyBMcxgV6rX6IfQRSAxKB09?= =?us-ascii?Q?cYkmkW6h8PHU4gER5F8CT8ADtzqkwNxxaYjkk+zssGpI5Q8G6IdQBgGQPe1Y?= =?us-ascii?Q?GhYPAZmn5R4ed2YPgLXzpPIYan3jJP/UNbLRkL57zi3eOCzsaKm6U/GPFYu0?= =?us-ascii?Q?S5YLw8r2zfWll13kvsitoY2tXfRpeeQx9M8ZQSIeNu8WjTMVMgtMPwWr84uq?= =?us-ascii?Q?gvN1PTctrijroig+y1BkZQIBQ/SVVivtNbbYXCIQysB0qX6X979rCILX/Taf?= =?us-ascii?Q?7jS/EDOggNXHaQrhpR5K+dsyuofZubpZ8/9SEhPx6REW67cTl7ejM8XgvjgG?= =?us-ascii?Q?ictJ3lco6ykS0rWpZMFSp3JZ+I0Vn+dIIiHZm9CZNe/WnlRUpfuNRZEINIiB?= =?us-ascii?Q?0v+gP71NGyZkkwARQL3iACqeVsgKud3YE1gVSBSDc1R2X5O1qzRQ8KrfvoL5?= =?us-ascii?Q?EtOqGJKHXm8OLVOX/dL/n0Oxm0/+1Dk7r6Gq5f2YRjufRg=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(7416014)(366016)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XOVA6GeEqrDqqNw/2XaYofr89QPJyZpUv3ssb+xVw8iSiNunwVGt9HI40bAo?= =?us-ascii?Q?ZNrV+355wqCtFLtbuU70NBpGmg29T3eTETP+JGXXnG/0q8hXEsswnCKeYOZN?= =?us-ascii?Q?y4hnIDNra5VoLYueMt+HAeoZvqRGm7PDCQG4c7vSfBPy02tFwAW/0NZebJrn?= =?us-ascii?Q?ALRPVcxNx5yrqMTHgbiQctARzMQie8dmg7Adu0wHjVFF1kB8spmJDHAssP5I?= =?us-ascii?Q?Bj1Sj0svUSWTagvzcb8ELz0X8AiFV0guJZL8DZIAXv6PtksIfhKBnlVd0rao?= =?us-ascii?Q?EgKbTVHeyNwVWmhZueW93zGJePUBJNXoBOikOLemIMy7as8J/s6S82iizpUs?= =?us-ascii?Q?VtinEW3P+UgOND3s+3fBnw2WG+1UEnPfMP+YqkQ917V3O5NxniB/0Vdp5EbW?= =?us-ascii?Q?ekVGwdRE8Ssq6Ep1wtG+TyU8f3Org1Az7HE6VUD8WXAeqJQ57Jv0YBFDic4e?= =?us-ascii?Q?f/ZwbxehxY1q/UWe5A85Ek32+NdNMJDqk57Xusc1eLahMD4g02zKK9/ZdLZu?= =?us-ascii?Q?3DDbrdsakoGybJyhchDzc1S1RGjbZG0qXbRDRgEzB/CdQV2MRd2F+uJoiFTD?= =?us-ascii?Q?NWh0bWK8KsnKZIcTLRLG23MplsvEuKd4iwzoa8qWQpTllO1K1WMrIZ9Cl5xj?= =?us-ascii?Q?ZGOF+9A33BIFdG75g0NqINPWNI2enYCfNP99xQaLKxlLqlhddE9LQ0lxbAEM?= =?us-ascii?Q?xkAJUHP0kOqx1G8Pm7CfROMQ13bEsX5ZZtBe5f9MzgjaXS95e+88Q3N0yLcK?= =?us-ascii?Q?iqeI0Uco8FLT/XL0zo9LKJVjezwXKaenUIVNCWoajT/EXfKGVYohFyf7UH3F?= =?us-ascii?Q?HwU8JytRfPi0RUJM79NBvwoxx0xO37k/L4WOY3bcQk00T7sTvAdpLlLir/gU?= =?us-ascii?Q?KBETlj8BIvohuboyQRBjCLce4vGonvvgK6rl1IzDGJDzF3s6NSXokuRHyJWa?= =?us-ascii?Q?lHU7iy+ObbubjwecZk0g+AIpPD/6Llvpaa7sN/0b0GQ5KLt5KZ531r+4g7ft?= =?us-ascii?Q?lo0ypsGnXb4d0/2PaREMzNKiTsuYSPtru61l5XFkl2x2SpWGHr7mK+3mTaCu?= =?us-ascii?Q?uPW03NY9Q+G29hpMEahZ7FcKuLY356UyO0PZ6OSHc6uOzyugQ2LUqa1Z2qE8?= =?us-ascii?Q?7GsS+YR6YFkcUlOVpqEbs+MGoDjpiyBSeaz1NCSUzPoxL5euVYS6T+0Nkb8x?= =?us-ascii?Q?R5KYqTu126ycFRCLzk5ZYaXuzoY0zpbZCruj6ltJg9L27+crGzqSY4G/VmhN?= =?us-ascii?Q?SrETrpwL/MX6bIwTBK4ZwBNEawWM1rzZ5yPKdKkTQkYiVBXtoWb/GqqlwuAD?= =?us-ascii?Q?eL8e3VHW0zI7+Ua0EuuCFldxYWKTcUEnZoqUbFKbHfhbjQ9hDycOgNjkrj1m?= =?us-ascii?Q?Yhe87LvMzxf1eV6bESVyeb8frTt7UwhWAVvUFErstbrJoST9DZhvberfKNTG?= =?us-ascii?Q?YiSjdPAte30nGIPHtPe62ZXbMTw5uy8uSgp7zFTJeB0MSBw/CjtYhTmHPmQt?= =?us-ascii?Q?VraiAXnTJV5lXJh9CjZ4/T0aM9QE3U/6eoGzCWipNvNyjh2MI9ZMVaNfoc32?= =?us-ascii?Q?kxdy3YxXObCxk5LPuLzR+LRQI4uXpIhEAHDw8o+qn6N+ER865NZ4YCczFHo/?= =?us-ascii?Q?yQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d59c16d-4559-4a57-00e4-08dce6a0734c X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2024 07:19:58.2790 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oavymiGAhEGWa5QzN0qtuSWhLql4ybNQL8MFFmBdTzAio7md/b1LsLEI0Ogu8y/H2ivnMBfD39lkXhlm9yJYBLe7fFFidwT85wPxo+eLwRU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7809 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked with a small comment. > -----Original Message----- > From: Gowrishankar Muthukrishnan > Sent: Friday, October 4, 2024 8:11 AM > To: dev@dpdk.org; Akhil Goyal ; Fan Zhang > > Cc: Anoob Joseph ; Richardson, Bruce > ; jerinj@marvell.com; Kusztal, ArkadiuszX > ; Ji, Kai ; jack.bond- > preston@foss.arm.com; Marchand, David ; > hemant.agrawal@nxp.com; De Lara Guarch, Pablo > ; Trahe, Fiona ; > Doherty, Declan ; matan@nvidia.com; > ruifeng.wang@arm.com; Gujjar, Abhinandan S ; > maxime.coquelin@redhat.com; chenbox@nvidia.com; > sunilprakashrao.uttarwar@amd.com; andrew.boyer@amd.com; > ajit.khaparde@broadcom.com; raveendra.padasalagi@broadcom.com; > vikas.gupta@broadcom.com; zhangfei.gao@linaro.org; g.singh@nxp.com; > jianjay.zhou@huawei.com; Daly, Lee ; Dooley, Brian > ; Gowrishankar Muthukrishnan > > Subject: [PATCH v2 1/2] cryptodev: fix RSA xform for ASN.1 syntax >=20 > As per ASN.1 syntax (RFC 3447 Appendix A.1.2), RSA private key would need It could be RFC 8017 instead. > specification of quintuple along with private exponent. > It is up to the implementation to internally handle, but not at RTE itsel= f to make > them exclusive each other. Removing union on them allows asymmetric > implementation in VirtIO to benefit from the xform as per ASN.1 syntax. >=20 > Signed-off-by: Gowrishankar Muthukrishnan > --- > lib/cryptodev/rte_crypto_asym.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_a= sym.h > index 39d3da3952..c33be3b155 100644 > --- a/lib/cryptodev/rte_crypto_asym.h > +++ b/lib/cryptodev/rte_crypto_asym.h > @@ -306,7 +306,7 @@ struct rte_crypto_rsa_xform { >=20 > enum rte_crypto_rsa_priv_key_type key_type; >=20 > - union { > + struct { > rte_crypto_uint d; > /**< the RSA private exponent */ > struct rte_crypto_rsa_priv_key_qt qt; > -- > 2.21.0 Acked-by: Arkadiusz Kusztal