From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02A8FA0503; Fri, 20 May 2022 09:39:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E1A37427ED; Fri, 20 May 2022 09:39:07 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 8CBDC40222 for ; Fri, 20 May 2022 09:39:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653032345; x=1684568345; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=UQRYP1XL4VvxSPRaVMY+xH3GhPS93zyb+8tPJLNnPX8=; b=dnJwcq6t0XXBGpra97gvrZhqs2nh5eMDUjkaImmRIY0VBfARzPkj80/e BPdWBjrb6sNrBdbSvwwQT7Y6QC+LdINMvv/zAwh+PVFxNFkmTKFstjI+Y qYZ/pQwzvV8sXxmqE+FDeX3igyvbi+YPzfAHvch0iQyVFXy+7Wdvj0MA9 yQSNvfVTuLBH7e2YRalDAaWrT+vI5HVSK5qLeCsHd4yk2LeEUuvo4ov5U C4Soap+4k3gyuUnHCLwLzyC2t2yZ2Q1A5GYOercF4HmKeS3ue35iGhNiQ 3rf5q6cFrWmXuhuk+SBumrlLpmBIeYVaI3e32T1ojRuXe36amvAjgk6g/ A==; X-IronPort-AV: E=McAfee;i="6400,9594,10352"; a="358931787" X-IronPort-AV: E=Sophos;i="5.91,238,1647327600"; d="scan'208";a="358931787" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2022 00:37:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,238,1647327600"; d="scan'208";a="546556973" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP; 20 May 2022 00:37:47 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 20 May 2022 00:37:47 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 20 May 2022 00:37:47 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 20 May 2022 00:37:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T0tFwlztp0BLq8kIcc78hRqZavSoVcgZOUgfepN+V9Wr5QiOqS/beCsQOiX9XL7bDUZ8RuVrYul34lIouMZh4+ZtUZiBqGGWceQRvBaagzuYRVXNoaocGOddP7z4WBeBCG8zphWnI4eRIxnzo4OtMZ12rCYw3KTCQJsJzcTV+/ao+g5qtVBlczm/UERqoIzwA4HqOn6DR8aIkPDoqn/TWUT73rhBbrrdA9AFCynfZX8a/h6t8nZEdCZXVRPvd4yyaDnqdV7bJD28qHBh9PkJRBMz9TGQWdC/QmFJ6SoVKtEGgV0NNXdE4XTuUv3XDPId8pn1d86553hZt2o6piQlwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LFjHkO91l+A1ZRjKGN5g3wa2BGYa9Wqju/PaY1k9HhA=; b=RfVN3gTw39s1USrk+Jw0YaurScO7GC5Ab9yY1Hr9VObqMG2fLXufSnXHqeY37SWIuLUz7xEuQTjPjXo6Q0W1m13/gQs4daOuoNH8IOYvIsHFV99f4SiAyBZqN4GV3Iw3UaawYgVb67BBFzlOzldxtRMWgAEqAfSOYjiBM3UBR6GCkQseR8Nqs7DDfCqPb/0MBJDIW33953ZKtJO60qtifk+X6qZEs2SMaw8lqKauu57j9fpl6gXncKmtwqy5DFnSvatR9L/dGzLYgFdYsUezvq7V90j6QmI3P6pxiuAiM6Chw9xO8/Dd89V0GrxPhszlVPwl41xVkv+ps81qupyo3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by BYAPR11MB2552.namprd11.prod.outlook.com (2603:10b6:a02:c7::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Fri, 20 May 2022 07:37:44 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::fc0f:1644:98b5:be1]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::fc0f:1644:98b5:be1%5]) with mapi id 15.20.5273.017; Fri, 20 May 2022 07:37:44 +0000 From: "Kusztal, ArkadiuszX" To: Akhil Goyal , "dev@dpdk.org" CC: Anoob Joseph , "Zhang, Roy Fan" Subject: RE: [EXT] [PATCH 00/40] cryptodev: rsa, dh, ecdh changes Thread-Topic: [EXT] [PATCH 00/40] cryptodev: rsa, dh, ecdh changes Thread-Index: AQHYbBeXhbQDqRU/802AJ1St5I9+XK0nXrkAgAAAsuA= Date: Fri, 20 May 2022 07:37:44 +0000 Message-ID: References: <20220520055445.40063-1-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.401.20 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 62ea4ad1-a202-4ce0-93f0-08da3a33a0f3 x-ms-traffictypediagnostic: BYAPR11MB2552:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8PfZskqLuoUiUeodlWSAy32O/JQst0vWseZIeAgRLNgjsx3a7i4g0idrC01gCVszi598qDKqZrfvfG4nvqxr7Ry3jaO1hK16yE2uy5SzZwoMDAKG6oTVikA/EgnX8OqvuCVi1+n9eUgEChU6cqXnZnWxThNPo2CayUtGR70vclIVPzoMeAMRIBnn7M68yt/KfDHXd+Wsh2HAwTyJ6cWr4LLmwRtDxuXWbzpqj0UGYpv3qgceHcG6qs8zp9fTwZYK1zVnuBwEnioa8pLkjFNA6d8lHYlsO6YVIZXMAFjhC11a04pexuwUePKYmacEs7LE5CD82nyGm3RSw78mvhsXHMcEhy1dA2edxqAcvm31aG1NoKiXqe9i+Pdl1YWzCtBcS3UfJIg5sgEbBuUCtZW89u5QDZbuZilCxJwHFzqkZr4OMevjiTlUNY5cvLtQJF7mEijFJLXPYWET0cgXibJt25EuD2LwWMQH5oELdiUkKIgyJYvRBI7cUJELAth9KUZYDiEUkk3/nmtunSgHUv14QPT4Weznv3YNBKCkfBGyRMUPq98dUh8VIfKl5aTURgC0iBduzwijxc8U+ZH5gWVsNhJ3t26kmLHrLbZQ4Sq2/OeMVCQZWBcgtvY2fmupXQ8N9XzVsyGj2baleSrN4KSfrrI9MXCiMVZYy+R7WoXtVgiOxnY96cQmZzoHezSNA+t4WqjtJ21Y6Ucrao3JCElcpg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(83380400001)(53546011)(38100700002)(38070700005)(186003)(122000001)(82960400001)(107886003)(9686003)(26005)(86362001)(52536014)(4326008)(33656002)(316002)(66946007)(66446008)(76116006)(55016003)(64756008)(8676002)(66476007)(66556008)(5660300002)(2906002)(54906003)(6506007)(508600001)(71200400001)(8936002)(7696005)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2UPBMT08a2VyWupAx3loNOv/PoXG+ROf9sQYxcLgTVMNbh7zKUSg+YyqWvEM?= =?us-ascii?Q?pFBUgBMgmcFK6NVkkUsQ2VEdifcsYNREqqVgQHN1S/tlU1cLnB6ejV6u026P?= =?us-ascii?Q?W3C1aXrAuBOkcqJrOW9cuRpf3TdQWwD5iTnBbTX07lG6rezet7K8URFFN70L?= =?us-ascii?Q?jKX1Eyc7u5zgRouBKncwf9TtEYe6hCnx7R5S8y7FMmkw5hydAgd/DkCvXxgI?= =?us-ascii?Q?OQF7TbxJA1XCUrTWqEOS6zmGsve2jB9ntr6nOHM5e/rdL91dhIE2F0xPiUJY?= =?us-ascii?Q?ZKkavdYYhfkHjZZCJtoUltM1qc8HDFNPHx8JF+QF55IcoZNJIC2+ISadBYd6?= =?us-ascii?Q?RYn4vuaaAW2RnJLh2MDWVOv9Z/6KhHEO98pmvB7ERdlZeYhaS3aatpDw7py1?= =?us-ascii?Q?odW2RdHLEBeH9yRer8wbwe3TrpXaKpX14wvjdIg3gFOVXwz7MgU3t19R0H4C?= =?us-ascii?Q?J8lCOugK1+lWvK8WZwmAVERVI4rs0pY34iH8iwxNH+kNobinovxbt9/beNxV?= =?us-ascii?Q?85+qoZlVKGZyI9iBi+NbTZvnMoGJFb4mhuyAr0tO2xkFu2z7aD/5I62yaBBQ?= =?us-ascii?Q?IuGbLNO1EGQkEn8bEKIVjAxpQ3Wh8N3HdE6KZPH3qUH/+L7m2rfs0rIlc2mK?= =?us-ascii?Q?c4saKSwO3/sdXcGiiihGCKSiUf+X8bl0cv3twGRSAc9T4xGhn7qUqjb2fYYq?= =?us-ascii?Q?HiBVSgS+5eBX9hzkiGTFuHHy8TaqKTqClIq+YB9tZeOS2DRvBJTc4gN6nwIQ?= =?us-ascii?Q?Yx7S76BmskcbYS7L+/rQKHalHAjL3KJ0779IT3NM/JIUEKFAJoLykOno+J0g?= =?us-ascii?Q?NwPtBqG3Mr1uu3uYN1Xiwc7uokqO87FQ6CeAzLZ/L7sHz++4QD6mYjsfZIdI?= =?us-ascii?Q?O5dE2hY1oc7EyAB6j6n0Oxw2AvD73IPNmSDii7VEJAWJmPCaMu0onIvYaWdf?= =?us-ascii?Q?keaogWTEe951jSAdIKAlpKHx35NPTD3CLX0Ep7iu58JOJhdGyDpaZs3BlRYe?= =?us-ascii?Q?HppaK7Z2EMVgfxqiSfVwcU7LyvoPGzAteL/OuA5obFauBIf1cCKxepuyL3yu?= =?us-ascii?Q?siTGU8BGx+qUsFU8Rp95ovbVfdDYska1MtARd2rrU+pmYDKTNxHhP1QisNoj?= =?us-ascii?Q?a55X0LQC8Ny42cYMwIESCivgJ9hTteZWyM6B4VsjhrZqzBMyKL/1+S1cAvul?= =?us-ascii?Q?T2qzvnTtAJhF72e6omMdtJV/m8CGUhmuPK3vOW2MsdpurD8htiHcBi8LVjxJ?= =?us-ascii?Q?C2CP4zIN46RK/wvenFiNvzxM0bmzty/KYr9WiVAjXIXMrw9T5+M3ztsKsBSp?= =?us-ascii?Q?p1cs/NBoBGu4nwK+McBKVky9ICesAE1yyyUK2LhPtz+4Wl/cKu3Bi7OkJJZe?= =?us-ascii?Q?/igHdFrnFg4u94QM2iDir7L1pyb+HQUd/Dr/Itx0+UL4vidHXV5KrqWpXacS?= =?us-ascii?Q?0ZyHqcVzk7ztOU+ASBEq+mDdo02U0CqC+HXHLvstRXwgeyx1LfnMUOyjRsCx?= =?us-ascii?Q?0c9XDsG53fjl4K1XWET8OCw38EX9bBPloHEyISFfxRZkVbzCSlQLAGhD6MhX?= =?us-ascii?Q?xwGia3U7XOSg7MgjQLkdmO8U65GWNi2G0t0x0omKascYLlzAO46DkgCXrppX?= =?us-ascii?Q?N/2oBacl1uLnY/4wZDCqi/dEXHuzPGD70gBw/2SIcOYv8DHosFrsmMJrcaIX?= =?us-ascii?Q?yim+KeQ+t2FhER7xIr6erLcHXNErWOlmFfpvMe7SNb+CUS7gaVY87uzc3Dwm?= =?us-ascii?Q?cnp8rvrOIeE3TnfyEdDW/DSeXqISYEg=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 62ea4ad1-a202-4ce0-93f0-08da3a33a0f3 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2022 07:37:44.4094 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sVlqDorsqN3HT1EiXGrncEL+sYAI2kDqGk88Fqs1SAGAbkzoAl6uk5qheIzwZNI1syJUga/Iena+TG1Wn3MfOFbl42RdgaXnE6eDWaJ9fK4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2552 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Akhil Goyal > Sent: Friday, May 20, 2022 9:30 AM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Anoob Joseph ; Zhang, Roy Fan > > Subject: RE: [EXT] [PATCH 00/40] cryptodev: rsa, dh, ecdh changes >=20 > > This patchset introduces some of changes discussed on mailing list for > > 22.07 release in cryptodev asym. > > > > Key changes: > > > > - It fixes API for RSA (expescially signature paddings) > > - Adds Elliptic-Curve Diffie-Hellman > > - Removes LIST_END enumerators (ABI issue - supressed asym_xform) > > - Adds Eliiptic-Curve point verification (DH verification - but will > > be used only for > > EC) > > - Adds RSA missing padding fields. > > - Adds asym op flags > > - Fixes many API comments (like EC curves) > > > > Commits are grouped by functionality, and mostly independent. >=20 > Please ensure all commits compile individually. > Also mark previous versions in patchworks as superseded. [Arek] - I will send v2 then, and I will fix all technical issues. Please v= erify if you are fine with changes proposed,. Most of these changes were al= ready proposed in previous patches and in RFCs with no or minor problems fo= und. Second patchset I would like to send contains capability changes and m= ontgormery/Edwards curvers (would be good to have this in this release). >=20 > > > > Arek Kusztal (40): > > cryptodev: redefine ec group enum > > cryptodev: remove list end enumerators > > test/crypto: remove list end enumerators > > cryptodev: reduce number of comments in asym xform > > test/crypto: removed asym xform none > > cryptodev: separate key exchange operation enum > > crypto/openssl: separate key exchange operation enum > > test/crypto: separate key exchange operation enum > > cryptodev: remove unnecessary zero assignement > > cryptodev: remove comment about using ephemeral key in dsa > > cryptodev: remove asym crypto next xform > > crypto/openssl: remove asym crypto next xform > > test/crypto: remove asym crypto next xform > > app/test-crypto-perf: remove asym crypto next xform > > app/test-eventdev: remove asym crypto next xform > > cryptodev: move dh type from xform to dh op > > crypto/openssl: move dh type from xform to dh op > > test/crypto: move dh type from xform to dh op > > cryptodev: changed order of dh fields > > cryptodev: add elliptic curve diffie hellman > > cryptodev: add public key verify option > > cryptodev: move RSA padding into separate struct > > crypto/qat: move RSA padding into separate struct > > crypto/openssl: move RSA padding into separate struct > > crypto/octeontx: move RSA padding into separate struct > > crypto/cnxk: move RSA padding into separate struct > > common/cpt: move RSA padding into separate struct > > test/crypto: move RSA padding into separate struct > > cryptodev: add salt length and optional label > > cryptodev: reduce rsa struct to only necessary fields > > crypto/qat: reduce rsa struct to only necessary fields > > crypto/openssl: reduce rsa struct to only necessary fields > > crypto/octeontx: reduce rsa struct to only necessary fields > > crypto/cnxk: reduce rsa struct to only necessary fields > > common/cpt: reduce rsa struct to only necessary fields > > test/crypto: reduce rsa struct to only necessary fields > > cryptodev: add asym op flags > > cryptodev: clarify usage of private key in dh > > crypto/openssl: generate dh private key > > test/crypto: added test for dh priv key generation > > > > app/test-crypto-perf/cperf_ops.c | 1 - > > app/test-eventdev/test_perf_common.c | 1 - > > app/test/test_cryptodev_asym.c | 117 +++++---- > > app/test/test_cryptodev_dh_test_vectors.h | 1 - > > app/test/test_cryptodev_dsa_test_vectors.h | 1 - > > app/test/test_cryptodev_mod_test_vectors.h | 2 - > > app/test/test_cryptodev_rsa_test_vectors.h | 2 - > > app/test/test_event_crypto_adapter.c | 4 - > > devtools/libabigail.abignore | 2 + > > drivers/common/cpt/cpt_ucode_asym.h | 12 +- > > drivers/crypto/cnxk/cnxk_ae.h | 44 ++-- > > drivers/crypto/octeontx/otx_cryptodev_ops.c | 26 +- > > drivers/crypto/openssl/rte_openssl_pmd.c | 47 ++-- > > drivers/crypto/openssl/rte_openssl_pmd_ops.c | 33 +-- > > drivers/crypto/qat/qat_asym.c | 28 +-- > > lib/cryptodev/rte_crypto_asym.h | 342 ++++++++++++++++---= -------- > > lib/cryptodev/rte_cryptodev.c | 15 +- > > 17 files changed, 358 insertions(+), 320 deletions(-) > > > > -- > > 2.13.6