From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ADF0D456B3; Thu, 25 Jul 2024 11:49:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9884440DD7; Thu, 25 Jul 2024 11:49:07 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by mails.dpdk.org (Postfix) with ESMTP id 69C3840648 for ; Thu, 25 Jul 2024 11:49:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721900945; x=1753436945; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=u2GwKo4ekvXSdd/u5j19Qb4yEn+NvzH7BbhJaN3HBy8=; b=duuMfJrb8dAG62Kr0KZ369UUAzsRAMNXCDPuSsFvCN3clPSsrAnf1FB7 vBxbT3tcBRckEYFdfl9/tVrtrzg38mS5Sh1yhNyWcHPiaOCJ8+8+GYwgg pd+hqP10EmcPjIwNCgf3Icjfo7eohcvpolMc/TeY9VEpdSG6w2DF6EpVh I1xC9PKy9/nLV6oxvUgmPbvf1cDqc0vi0Ze4XTyZY8Q5g2qAnLHqQhb44 fqaXj6/8EKFesnRhMKNIL5Oiq6lq+TFR0OBnJ0pbnfrjuJRKADH6o2TKj B12mMPrfcmGO4rRyBm88Q6ARFwhXI9aXgba3qyOY5ib38jkmwhbfJjOm9 w==; X-CSE-ConnectionGUID: ZVpszKGyRgi6t0N37gzB+A== X-CSE-MsgGUID: s7xp0y0mS+mEjeKqIdNXfQ== X-IronPort-AV: E=McAfee;i="6700,10204,11143"; a="31016352" X-IronPort-AV: E=Sophos;i="6.09,235,1716274800"; d="scan'208";a="31016352" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jul 2024 02:49:04 -0700 X-CSE-ConnectionGUID: v5X4ag8mQ9K5S/XJEVU5Mw== X-CSE-MsgGUID: /MbjeTKZS/Ss9cYEulbEEw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,235,1716274800"; d="scan'208";a="52789833" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orviesa010.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 25 Jul 2024 02:49:04 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 25 Jul 2024 02:49:03 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 25 Jul 2024 02:49:03 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 25 Jul 2024 02:49:03 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 25 Jul 2024 02:49:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BIOBOn0sEvB5ddpmJKgZGoh8nJKvOhVbaAq18LaGAj66Aue+Z9CrJ7UhnLB/YuES3Tr2iDMO8TRFSJxFxfZL0pb1WhM7yyDUlUxFJhyysNPIMlzBsyDnySKEEgz2NntcCVbFwqQvUUrxCmsuKO8wnrwXvCASvZPpVI4RS9H96UdgzKN8eMPQXpisfrdzlwjp66Y/92FoYMUqzoqPQHfByMo1XQcaemCSL8eCyliRsVBqGnKG4ihAGyeFknduNeKsxvi88tlAqpFVHVc7zMVSC4/6IhAuSXiKDI9xX8a2xkSlfCfpnIHRlAOlLrMBW7nMQow31EBAYaaBiNLG6SbhZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YCvZ3xeY/SYqXD2egXraiykCzEP2m8LGuXxXGud2pXM=; b=XrWV3oT5cua3vKVRoWB4uX7adrZbmLaeseqwjsRcnSxE3XJAhP0wmRxYqh+JxaWnZp8c0zuP+N8ViIDqctero6ChtDLuyqKnQgqPydoc7VCUyNWAyi8HtMglWJ3wZ8xUW/d5wJk++ZQkNAp0OoHYekV9nXcPMUnqei65eIENorSPxRvflon6JaInsXfx0t65tqoOwSrYeeKmTAfbObUBg+OhrQunCZme83IdkhanfWXTU6oHK+YG2J66lipk0z4Sg9PKq45v3mmC+9n9JSC7jSRB55kY3v0QUptMQkFcL7a+6p6zzOBklTzsSlxHL4a+hMGNuxzN7kgWGk9lGA86Nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by SA1PR11MB6894.namprd11.prod.outlook.com (2603:10b6:806:2b1::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.14; Thu, 25 Jul 2024 09:48:59 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::1c54:1589:8882:d22b]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::1c54:1589:8882:d22b%5]) with mapi id 15.20.7784.020; Thu, 25 Jul 2024 09:48:59 +0000 From: "Kusztal, ArkadiuszX" To: Gowrishankar Muthukrishnan , "dev@dpdk.org" , Anoob Joseph , "Richardson, Bruce" , "ciara.power@intel.com" , "jerinj@marvell.com" , "fanzhang.oss@gmail.com" , "Ji, Kai" , "jack.bond-preston@foss.arm.com" , "Marchand, David" , "hemant.agrawal@nxp.com" , "De Lara Guarch, Pablo" , "Trahe, Fiona" , "Doherty, Declan" , "matan@nvidia.com" , "ruifeng.wang@arm.com" , "Gujjar, Abhinandan S" , "maxime.coquelin@redhat.com" , "chenbox@nvidia.com" , "sunilprakashrao.uttarwar@amd.com" , "andrew.boyer@amd.com" , "ajit.khaparde@broadcom.com" , "raveendra.padasalagi@broadcom.com" , "vikas.gupta@broadcom.com" , "zhangfei.gao@linaro.org" , "g.singh@nxp.com" , "jianjay.zhou@huawei.com" , "Daly, Lee" Subject: RE: [PATCH] doc: announce cryptodev changes to offload RSA in VirtIO Thread-Topic: [PATCH] doc: announce cryptodev changes to offload RSA in VirtIO Thread-Index: AQHa3EdY9nEqyeYJekeZ7gT+77+RRrIHNDJw Date: Thu, 25 Jul 2024 09:48:58 +0000 Message-ID: References: <20240722145551.1159-1-gmuthukrishn@marvell.com> In-Reply-To: <20240722145551.1159-1-gmuthukrishn@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5013:EE_|SA1PR11MB6894:EE_ x-ms-office365-filtering-correlation-id: df6914cb-42d6-4779-ab2c-08dcac8f01cc x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|376014|7416014|366016|921020|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?cn6xnrpuJJEh1E7Fo9VU6Yn9ahV2H/abLphYFZ9usQ8zqRtJHsCpB7h5mKmc?= =?us-ascii?Q?oNi+arlop/W3VuBUpIqwgviF5qc5nu2P4NehBbJHKgThYtvL20vNiyfbyfKb?= =?us-ascii?Q?G8eIf31qkPKblRaw1B+tzLB+eSk9meZBKBabDX7suU97s/YWafeY0II33oSy?= =?us-ascii?Q?6BxDvy9LV/xI0ixLM11/XhdHQgbhsKSp4C1iBazE5UjsUL0xsXpuoxQbCj/P?= =?us-ascii?Q?uSayj+Z07UwgD+oeYCQtMAo02OOhS433lch7bpLuKiE0yHMUO4d5N14nWtMn?= =?us-ascii?Q?taFs9VhoBwSxWk2t2QCDdK5faA4+2wWL+MbMU9Ja54fPHmCc1zgHPIpzHgR7?= =?us-ascii?Q?qXkq/ZZkZrjvUQBLalRC1ilK0LOk1vaDpr2DPLjHbanuD4yXhsuOCAJi2SL7?= =?us-ascii?Q?1lsVeZ+k+9JgTQ9jo/LdA5z0c/L19aP/ihy4OZfF2RUzSSNjyEgtGJjI/IhU?= =?us-ascii?Q?Bssw9URXIfIJYKi/gSG2H2exo86JS5nq6JkBOYeFJXwUB+IT2yAxJStuXUy/?= =?us-ascii?Q?s6JkkNvPOIOSglAhoC0TWDNvmf1cNcyZ4F6i+kZLiiWeSzCiVW3TXh7B7fEa?= =?us-ascii?Q?FFUlemolfSH1lMPRMfztyp8hEud6baW9mCxi8OSJtmhlkIAUO9APB+Zywp+d?= =?us-ascii?Q?4yOuS+4QN9RKtcsVIwY0synyd0YeOi5pYEiCLo7TqLxYzMmwbVIR0C+ddN07?= =?us-ascii?Q?4MIOauhiu/yAb8/FnIsZ98yI+ET0Dx8mvg9rEW5fsFfIRcVTPPfDs8LLyUoF?= =?us-ascii?Q?xdcMHP9d+67SCv724A9Iydd2Lf8VkGpXBw/838sa8Bls1JJd/cfezZTM1xzy?= =?us-ascii?Q?CNDGria4BSsOaFmLZ/1Gq/Zk4CwF7YPuNNSWHHD0kc62pi76/SiOwX56EvHA?= =?us-ascii?Q?HojRXQhlTUqlQVnGdb7VXkb35dICz1Sxf1bx9WIEJvmQlXxfP7vATvSGsa2v?= =?us-ascii?Q?SoIF/+ldUfWzTAToKAg2YKUN0VpMptRZtcn1NiyYl9JhAFdX6XobeRCPXz4p?= =?us-ascii?Q?TfAbBUvgLxhiqaiGIUmx9ULE7gzq/xHsp3xTfCXTuijIodbeJY1eyzvuKpXC?= =?us-ascii?Q?vfYgg3HdrzWZ+HtISuCg8RBjXp16ERrI6YsgUmbhdLEChNfiaT1IKwFEOZHj?= =?us-ascii?Q?shEg93KEY7cOR6B3NgurzJcOcZcZrvLh+uP/kM6Upeut5+c3ktlQP3RMv/Z2?= =?us-ascii?Q?1W3q5rDyiyPv4Ctk3Tp0IcwgpqcSffuR4Cp3Jpj7Rjeld/h6HnNHJsEhgKPT?= =?us-ascii?Q?ICg3t8BLiFY1D0w9OmX5DqbtBR2otAq60ftEKI7tYZ6q/Wa1/ij3Q3QUzvnb?= =?us-ascii?Q?VB+cDyhb+9bje/R3LR++6HVNHFCkvqsqouT+6wlabOMpTm/m2oMrn4TibSTt?= =?us-ascii?Q?41d9/IB6saSAVELYe+dYWoz0qaxk?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(7416014)(366016)(921020)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1erbnIVJNtzEVBikhZA7JpGMIpGz+8hoKUZ4AHQWXh3B0T5rDubvdqPjEpb9?= =?us-ascii?Q?YhnOWmp0oxze4owAsuP7lTJ/S4ORR5HZyGcotpP+ot+lCA2tRjKEFEwlusWf?= =?us-ascii?Q?1/VknwnUvHdo+50FRMXQsYftxf5Kru+n9zv3HmtMgRDa31Z5jVDBfYyRT3ao?= =?us-ascii?Q?xe2poLf7/wxDaQrMn8/63Kv+KT6Ow+R356h8p7Wt3YBVRlkK4fElKye6MvEv?= =?us-ascii?Q?o3sn31dZ8gv44WNMVGLkjhdu+NBfbZUQ6P1I3slTex7e3CfryZ4AbkDmly5X?= =?us-ascii?Q?bhQCfdWyTmnMkFk4KQVcFSF0tP06b/WTvCDssIPkCpe6w6wT6raukeLYvTj3?= =?us-ascii?Q?feLjasYLIAMaYMrBpaSa78DR8d/81WwAnoaCMJkNVTI7SBFvmGWSuwH9flw8?= =?us-ascii?Q?LSrhSJqlcAbyu0pcka0E8OkYuSVIfoNAuySVSj1z0KTPqoxYA8MZwCDL2erk?= =?us-ascii?Q?hQuF9Rhu+xkHsrv+ChV0+7oqPex7tnVm/MqmAQDZoXIcaf8nXYyTqhrBGctY?= =?us-ascii?Q?lodyMA21e+qKP597DyUf8ul7FlwZGV8EmY5JD6Tkz9FW2md4pFHvlPlSpHFi?= =?us-ascii?Q?aGcb5NayVcKNMrvqeXAQE+AmdQv92pLP2RH6mtvrEPcdFj155QX4K8nRg9W2?= =?us-ascii?Q?S5MwXeIR+FZ0gcvy4dZwKmf8zrG0CsZ/erU+motDlcE9U3O1c7Hduxt2krV8?= =?us-ascii?Q?/SOLA44aPY9KEzT554hs6AiFRxtWKW9+3n84lFxpNMkZBMbTb7ysRejQ+Hv4?= =?us-ascii?Q?lMo31o1BXnxFJxljry8tn0vv+fkTbzzmXzTHsOdTgMHbRTVqOc68+/Ld1IKr?= =?us-ascii?Q?zj4Ze1WUQfZm3OsRymBYbBpsTtt1zJBoQ81JShWQxE3yEJzyes12cf9jVgyM?= =?us-ascii?Q?skU0WwEgVxYXkYzn6JrFbAkR9yk//4rzrsiA+KW6qSzOGMMZmpqiooW2iKDu?= =?us-ascii?Q?o/oW4BTMmiuQfzPOi2VjyYDcuEHFsL11nWr3aL/1vyqNHubWfdwrg5aWxvGG?= =?us-ascii?Q?w8CU7kqE3lLS1kiDqKhopPzwREaYgsTnNDCOQNwKhuWUafN/y83Dm44M6Iug?= =?us-ascii?Q?4+x6Q3suA5UuEubsywVGOCW5KfcWQhnxxvVyV/4BFM35/imL2CJq6qtlsC3I?= =?us-ascii?Q?KzU0T6xjHdCoitJDaudHXYn9K3H6fST8wDZVq6neXFSMDsy3K5tZC0l6lfS9?= =?us-ascii?Q?IRCqVBa8mq4JR3Ca8S9uLxaJ8YwzWYD+ZIy0RQmQ2HnRgQhBjMBVdqmuD8S5?= =?us-ascii?Q?VIIZXECpbSwcQwEcpNPweYpVioS+J64meS/EMsedvomv+5+VlWg2wL9spjuj?= =?us-ascii?Q?8P2LELhm4YKAW0kbRBtP6ULrVGPzpESJElwyhYgXqTH22xvOdvdgJrqRsEHn?= =?us-ascii?Q?UwmLLKfEZFVRU/fh8xUyaWMabVnTV149+3gPw7UGqkHMHx4ETq6pKBjQNMZR?= =?us-ascii?Q?B5ZY15jBntkYRs/WGO7QLait/hFhfm7iMC4Y/6EjXrFD+N3IJk+f/uOvCAmX?= =?us-ascii?Q?4Y7ZlDW7p8WcOjQiNLg8E1fbxGK62tmO/iaeztAmSlqBRdSLcdG01Rqd+bs0?= =?us-ascii?Q?B/oXBME8R/dPIHFt90rl5yppsn2nkXTlPvhJNb8Doc5qF+yKBZQxpq7zYg9+?= =?us-ascii?Q?Kg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: df6914cb-42d6-4779-ab2c-08dcac8f01cc X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2024 09:48:58.9738 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Sopd+nE3JdCV0fcf5kmd6dAxqDdEHJyoBOxwQkhL9yraeDRkd48Yp+BvURH5XvSX3/vyS3hwNX5W0L+JyU/a6Nl95eIathlLWv7Goc52ESs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6894 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Gowrishankar, > -----Original Message----- > From: Gowrishankar Muthukrishnan > Sent: Monday, July 22, 2024 4:56 PM > To: dev@dpdk.org; Anoob Joseph ; Richardson, Bruce > ; ciara.power@intel.com; jerinj@marvell.com; > fanzhang.oss@gmail.com; Kusztal, ArkadiuszX ; > Ji, Kai ; jack.bond-preston@foss.arm.com; Marchand, Dav= id > ; hemant.agrawal@nxp.com; De Lara Guarch, > Pablo ; Trahe, Fiona > ; Doherty, Declan ; > matan@nvidia.com; ruifeng.wang@arm.com; Gujjar, Abhinandan S > ; maxime.coquelin@redhat.com; > chenbox@nvidia.com; sunilprakashrao.uttarwar@amd.com; > andrew.boyer@amd.com; ajit.khaparde@broadcom.com; > raveendra.padasalagi@broadcom.com; vikas.gupta@broadcom.com; > zhangfei.gao@linaro.org; g.singh@nxp.com; jianjay.zhou@huawei.com; Daly, > Lee > Cc: Gowrishankar Muthukrishnan > Subject: [PATCH] doc: announce cryptodev changes to offload RSA in VirtIO >=20 > Announce cryptodev changes to offload RSA asymmetric operation in VirtIO > PMD. >=20 > Signed-off-by: Gowrishankar Muthukrishnan > -- > RFC: > https://patches.dpdk.org/project/dpdk/patch/20230928095300.1353-2- > gmuthukrishn@marvell.com/ > https://patches.dpdk.org/project/dpdk/patch/20230928095300.1353-3- > gmuthukrishn@marvell.com/ > --- > doc/guides/rel_notes/deprecation.rst | 11 +++++++++++ > 1 file changed, 11 insertions(+) >=20 > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index 6948641ff6..26fec84aba 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -147,3 +147,14 @@ Deprecation Notices > will be deprecated and subsequently removed in DPDK 24.11 release. > Before this, the new port library API (functions rte_swx_port_*) > will gradually transition from experimental to stable status. > + > +* cryptodev: The struct rte_crypto_rsa_padding will be moved from > + rte_crypto_rsa_op_param struct to rte_crypto_rsa_xform struct, > + breaking ABI. The new location is recommended to comply with > + virtio-crypto specification. Applications and drivers using > + this struct will be updated. > + The problem here, I see is that there is one private key but multiple combi= nations of padding. Therefore, for every padding variation, we need to copy the same private ke= y anew, duplicating it in memory. The only reason for me to keep a session-like struct in asymmetric crypto w= as exactly this. > +* cryptodev: The rte_crypto_rsa_xform struct member to hold private key > + in either exponent or quintuple format is changed from union to > +struct > + data type. This change is to support ASN.1 syntax (RFC 3447 Appendix A= .1.2). > + This change will not break existing applications. This one I agree. RFC 8017 obsoletes RFC 3447. > -- > 2.21.0