From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A7F8A054D; Tue, 31 May 2022 15:50:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 514624067B; Tue, 31 May 2022 15:50:23 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 6140D40143 for ; Tue, 31 May 2022 15:50:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654005021; x=1685541021; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=G4j4gFKrT+QqbyBNDXCjh3sn0ByEiFJiIOzEUfGmzgo=; b=j6ZpsJO7Bm47pd8MN+a5G3D1teR33F9OGN+M7Zh55dBGS31CxVQFIlC9 9JRkFFyPknSPfI0c/UO4kax4C3W31U08fx3RvF28OX8GHV1rM7L6xNqWt ol6gacZqc4c5iNgo2oM6na3ksOdvfjl80MEDWViJrj/aM270pN2OJqVPu rp7t9WyZix3NMuh17YiAa5dCIckQxqak+wKQB7VRmVPcIKK3lbjzBBHbW 63mawnRL35J+g7EuwrMyNy5Eabf3WaajLPiEpDFIVVQWvTs/7CrWY+knu b+7nkRcjBy2dpv1846glRSH9uGliMwEAxcHwn2AiFisvrJeCC197ve9nR A==; X-IronPort-AV: E=McAfee;i="6400,9594,10364"; a="275262502" X-IronPort-AV: E=Sophos;i="5.91,265,1647327600"; d="scan'208";a="275262502" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2022 06:50:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,265,1647327600"; d="scan'208";a="581092762" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga007.fm.intel.com with ESMTP; 31 May 2022 06:50:19 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 31 May 2022 06:50:19 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 31 May 2022 06:50:19 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 31 May 2022 06:50:19 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 31 May 2022 06:50:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O1no+R3Ama4DGHC0bCSPdyd9RRNKpGUaJO55CV8lUZpCuLAvJZpynC5fN0oLdwyoY/5xZULbHWrxyESYirgaNK+l9zsZVEYHlYGRqnryxS9zXtB3g1ubb8pSCgU62wcUhin5kZxudGXRUQl0MsOLL+D7RxKYYXG/hhHifsembZCM4TWFzX22vObzZvAO+98VEwEWETg45aZ7CW3CtSxa22PAo43Ax+Bl9TnI2gUasSd3I3jqH/rfm8+OjuhRYeu0+6L1HoDP2UQbsxi9oRmWSFKK+zuDVb8CazZyaNLjqBQ/Fc2SiUB+6YqTGmID8kIA1af++ECr11Cqa83dARPMBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dyLREa65U1ACvCAmxiEDf7IQu+n1NmrS0lBL9obtBXk=; b=iU/NsTr911tl2CHI2sACOU0pORBIpbftWbolmxhpUH2qX9A/U+D4Hi5H9Xq+5u/bYK0lAgCCrDbwupXSh8nZjPEXznZBYTJdm9mShpJ8cW4ScU/1WPIhcanVgCyZ/4a7qDHVNN0u6xIXK0Sas0uvhzidZThHZRvg0sHvD+sCSaKqppzVW7MvKVcVyAu7XFBZWqfFOic0ALdu97O82EJuHmgy4dNVAcrGJ11vbnWO913UKD0qsY3FwXyuRYV1omFW6KUEGUsHFSfmuaYyufJ4I7sad+eQjKjvBvnLl1L93IwNJaJNRQLS+a5VdO0oOxcC9ipRNGoLEBRwJ8/4QKRZLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by IA1PR11MB6444.namprd11.prod.outlook.com (2603:10b6:208:3a7::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Tue, 31 May 2022 13:50:17 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::c1de:722f:b4f3:91b5]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::c1de:722f:b4f3:91b5%3]) with mapi id 15.20.5293.019; Tue, 31 May 2022 13:50:17 +0000 From: "Kusztal, ArkadiuszX" To: Akhil Goyal , "dev@dpdk.org" CC: "Zhang, Roy Fan" Subject: RE: [EXT] [PATCH v4 02/12] cryptodev: separate key exchange operation enum Thread-Topic: [EXT] [PATCH v4 02/12] cryptodev: separate key exchange operation enum Thread-Index: AQHYdK0Ohqlh7Udw5kqb33ma5u6cha043u+AgAAeQxA= Date: Tue, 31 May 2022 13:50:17 +0000 Message-ID: References: <20220531040439.15862-1-arkadiuszx.kusztal@intel.com> <20220531040439.15862-3-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d7055eb8-e60f-4016-2936-08da430c7efa x-ms-traffictypediagnostic: IA1PR11MB6444:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GdH76YcDXPYdgVCCuyv3/P9uudP4sYyGdozq7er5GGbVU/fDcYDaX8ZAcFjTd+aHW/rmqlywmJOnR5893b0KKwKFKiahTd78Li9QwfoIj8dkdIXX7l5H6vGd0cCzZnTFnPPZljJD+jy+grHOVfzziiag87dGoleXCp6tVbL5ZvVdITAqWxyP2fmV9M3/VePoM7ruQ5oFYvXA/Pv2uzt2S2L0c0LWt/mezBdCOjFNdAtk+6b28DONXEVp4IlDjUkLNfD/U1qnN7qFGQpzjiS/rjFqH6Hq6waIMbqOz1FFKNDxHA6m0OJM48OXGgbpO/1bXKVzI718D+71JAwIC6FdCRPKAlxoeH3FXAuDgi09keg7dmJUyAr7KIBoAradwrj459rVaZThGjGDmlZIXMKQO+AObRx/YR2XIx8C2bB39pVG6TJRFU0b1IIVxKhgGiDqr+QH35ZhQ0/1ckEU0/stKi9oF68Czbb6XNlprEZx5oHgjepj28fWixMUqaz8zTgp1hM1nSoKOD4rdH9uJQyGHQtJRtTSXwnl1TzlQXcbyy6703Y42dIM949I6woSjLaeE+BaDbUvQM56vQMMR4zBLE5+Sl8hK+r+z8TXtDtiqy4IeX1fjdLSCLbIupOTJuJobaqYxr5Tn3hyJbGeTcUM/0lwGw3R78kVyTu2D2UPb+3dVuV4J8U5rez/0+g5M2Ch3jAwd8mtwmP6myjLgYnLbg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(38100700002)(66946007)(9686003)(53546011)(8936002)(110136005)(316002)(66556008)(4326008)(66446008)(76116006)(7696005)(66476007)(64756008)(8676002)(6506007)(26005)(122000001)(38070700005)(33656002)(82960400001)(2906002)(71200400001)(508600001)(52536014)(186003)(5660300002)(107886003)(86362001)(55016003)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bSePa03YKxG6xdcEdT2wGkWJcF3XiwQVJXK0nPq+Fec4aU8W/qiOZIg/WrGU?= =?us-ascii?Q?C3ECJt9duRbnkyJfIyk1TEWLauOh5pWWEtsxhh3c0RadXO5UeYrtBTOLMAQS?= =?us-ascii?Q?qfxLedivVu1NTY3C7JrfAueSpikWFOL7B55t7CGueQu5bRFOGivkoJIkjeZ0?= =?us-ascii?Q?TCc+lb9qAnJxyAwYFc8sSdRhp8FGsNWSTE18fvXhTJ+8MKfIUiCBAfK/BSL5?= =?us-ascii?Q?fUD5d1zykMKywSOJVPIDm72yqqtDYEJG58cdY5lxy1Gr/rytm4wHGbfSnv0q?= =?us-ascii?Q?eXE6t+piL98r28iMWLyA1AP58tMhSvF2eYLq4h8PxwaZzQG5ovzHPxH7RoHa?= =?us-ascii?Q?0k3TNMT5yRCXYJ4z6pRfuCHO4HCdI0IjbgGGLc6i6KW3wd5UUbvngjw2/qag?= =?us-ascii?Q?RhGJhbEVhucz4DLTcMNSyAoV79TbLmAkbaduuxnkg1EX3vJ1w5WePghn1al7?= =?us-ascii?Q?VMwUeJQb+hflsnk2v1JCvHlnjgMGFGdQdAMeF9VamjwK4oI+OlOuRiIS3jhO?= =?us-ascii?Q?iQG5vMdOlsFr/7sGIpRZ8sEWN5FfIoRTOOTpXA6doSL0WDjMXr1kJznZlaJU?= =?us-ascii?Q?w1TH4xMPWDkbVHp2WO0QszMOxMQ9GAcK7ZqyqevF/L+VUfUtq1PUNVeTnJjP?= =?us-ascii?Q?PJeWNLQvwzxl+jzVv9E4XkDWXu3sHhKowA5YoL+nf9zxo/aYCGO/McR9o4KT?= =?us-ascii?Q?lZD+x/UhmZijotrjdWqnCxGgZSqh626538qZnlJfXehUNOAHOaUE70xkdneW?= =?us-ascii?Q?XKltDBJNRHCKUiPTTuAcyC0Mg1cIncJEym8Qck+hXFqe1jDicRM6xdmcN0SQ?= =?us-ascii?Q?yo25ec/McojIQ2f8/YmQRkkFuDD3SK8IMAVwQbMUMCCjjI9uTn5VPgKvhjOG?= =?us-ascii?Q?yXyWJa3OjRQOFVxt4AHBi73h3z98bToMe7LeBjoahX+wpMLqppYM7FdPdae1?= =?us-ascii?Q?mpYz3XuvHE9fj8pNzlTHhja4nPj7YqUkyW4aCXVGcuZ/mBHtP2ALMMX3GKPa?= =?us-ascii?Q?GD7PeuoOVNb50m13gEQzZQ+j8sSFOAs0C8YMCZzlWNuLDvJlqaFr4upj0Odf?= =?us-ascii?Q?3s2oD0JLepIjcZgjzEvuqTDTQ35Gl3RCEGOLxlRWx8pmaf0V2ZxiVXSa6NiR?= =?us-ascii?Q?bq0M5WQeOCih5FMRTBlAcRfiyeulNZyGVOFzhLRoCYAb9qZ4PtrK5AmaQivq?= =?us-ascii?Q?aqgluFmMCV+vzYIa8q+7Kp5SUclGakboYVy/AHuPAe6pQ6UF9Ow0fJjYqPSs?= =?us-ascii?Q?cYj1EiVT+2PWZwUK6cXImLcWmFJPhcVJ2AlS/3OACkQVNMZGrSKINo3MTotH?= =?us-ascii?Q?EzR7cwsipWPhR/gMq246YVxGOTQnAt6l2fZ0AmDQAGPRpSEvp3Sun0cN9QPX?= =?us-ascii?Q?G55ccm2lgRHyfqwiPg4eyRpeQ+HINw9USa/n7TZ8in7l2zbdszgjCG6zKcII?= =?us-ascii?Q?ryuEi0jqYqiE1tWm+Pjp/9r7qvE00nSPZ/otjtEO7FjwOCAOeFRE9ymY7MVc?= =?us-ascii?Q?A8HhBLvvgwVhWPTCmH+ZsGqn8VhD58GBFjwr+T0vlsRxOEQi67WDyi0Yat5G?= =?us-ascii?Q?e/s0pm/9Aqqk+Twp4Yfz6S3ynlRaD5cora/5t1X8yTkfKwU18Kbdh9dW+YtU?= =?us-ascii?Q?ZzVaYM3GCX0VdsyHMUCQKjJqBQboKUZF34lzubUqi7ExLcMO5t1FWh0VTN3u?= =?us-ascii?Q?eR4w+uZQn7jAO7Zp/yrjVytDhJz/j5iaVHLvH4yY8Gqv5G+MGlrqKn8zmthK?= =?us-ascii?Q?NUdumkQ0L2A79OG5xnkkYVgNqJ2+w/g=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d7055eb8-e60f-4016-2936-08da430c7efa X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2022 13:50:17.4713 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: N+O7c5tBNF/j0ix3021/wV+9sdZzgSyYpzWjRBagMp5lgArp81QYB7SBH71Tku2jrpKVkUzq+d/nM2DQxsxfWbQ3MOxSv+YhLLjyQEMvM/w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6444 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Akhil Goyal > Sent: Tuesday, May 31, 2022 1:47 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v4 02/12] cryptodev: separate key exchange > operation enum >=20 > > /** > > diff --git a/lib/cryptodev/rte_cryptodev.h > > b/lib/cryptodev/rte_cryptodev.h index 2c2c2edeb7..7d683fd728 100644 > > --- a/lib/cryptodev/rte_cryptodev.h > > +++ b/lib/cryptodev/rte_cryptodev.h > > @@ -168,7 +168,9 @@ struct rte_cryptodev_asymmetric_xform_capability { > > /**< Transform type: RSA/MODEXP/DH/DSA/MODINV */ > > > > uint32_t op_types; > > - /**< bitmask for supported rte_crypto_asym_op_type */ > > + /**< bitmask for supported rte_crypto_asym_op_type or > > + * rte_crypto_asym_ke_type > > + */ >=20 > How is this supposed to work? > Ke_type and op_type are 2 separate enums which can have same value. > How will the user identify which one to use? [Arek] - by algorithm - xform_type. > Shouldn't we split this too? [Arek] - for me both options are ok. For some SM2 may be bit challenging he= re, but in such situations we should have different op types for KE and OP.= This would spare this API from having one op with majority of fields unuse= d. Though it may be split too, not big problem. =20 >=20 > > > > __extension__ > > union { > > diff --git a/lib/cryptodev/version.map b/lib/cryptodev/version.map > > index f0abfaa47d..dbf1f62199 100644 > > --- a/lib/cryptodev/version.map > > +++ b/lib/cryptodev/version.map > > @@ -108,6 +108,7 @@ EXPERIMENTAL { > > > > #added in 22.07 > > rte_cryptodev_session_event_mdata_set; > > + rte_crypto_asym_ke_strings; > > }; > > > > INTERNAL { > > -- > > 2.13.6