From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2923745AD8; Mon, 7 Oct 2024 18:03:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B8DB427E8; Mon, 7 Oct 2024 18:03:58 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by mails.dpdk.org (Postfix) with ESMTP id CC7024026C for ; Mon, 7 Oct 2024 18:03:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728317036; x=1759853036; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=hEabPG01vg9wrYMmSZ6STPFFIw3umT3CMc2P2nRaOyE=; b=n0PRtCQm4S/GAEN8gP6doyu7GZoseCdV0ttIjam8PhsAakUsRKBXta2x Rsebf8xakKrKoiCtNtdn9t+k5w7wThIkJ4BTFCguhpsbcw+dQIHg9eGfh 75nUc7eyr8zWq6/EDV0x40Td4/rpKOvb1xcunDCzuY3IhgC+lxDggdriF b+KIEpRdOuwQtC8HfTHDVG1M19zIa3hP5xbFIXT/WU3PdXcLWpZvZopD4 YMGuBaP4lrOB3orikEoBfKh2844fiSvU1/0Z+2J4GSzPGObMs0zNhqqcs pJdFlanmcFx9x/D1tWf1VMenbpbYL+KiVE3/Zk9T+Y2psrq0KNJPq23O1 A==; X-CSE-ConnectionGUID: o37AY09DRUe+nnwvm3U+SQ== X-CSE-MsgGUID: EdSDapwASAWY3n0bj7Rljg== X-IronPort-AV: E=McAfee;i="6700,10204,11218"; a="38861618" X-IronPort-AV: E=Sophos;i="6.11,184,1725346800"; d="scan'208";a="38861618" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2024 09:03:55 -0700 X-CSE-ConnectionGUID: HX86LhNPS3ivGhRNjMe1yg== X-CSE-MsgGUID: DSx81Aw7SCSvwtyg0Zsxug== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,184,1725346800"; d="scan'208";a="112983709" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 07 Oct 2024 09:03:54 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 7 Oct 2024 09:03:54 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 7 Oct 2024 09:03:54 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.45) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 7 Oct 2024 09:03:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BuVIAUYqRw/oC6zWMZ13RN4R9RIWrypZ571aNDh2QbMqKe4wi1jnZs0KqvVH8pz9XW46jOjDzFAhJ4yeXGrwhy8h2l5+uLfcrEOSSVs9i1a2j8Ew6w2EjoxeK0pja8bGatvKml977PjOz6TWHohY6jkh8+eVIP57OHm+nVX/zeXGGQEoHdmuMZLroNxN9Skyhhi1p9shkadhAq2b1cySnwWmFJdcLn3ChB+evr1/rHLjLQJd40Avq6VBMsj368KOz68rLfr0/uqRbQYV6winm/zoch1GJ1AyCb8/BtgRGftpm9qfYN28tRFUQ0I8f8h3H0366x4PxjHHNIoqFyJAdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aBZcIgvF9cD9zaN66TGJ8EupmrWsFb0BimMyanxWBBc=; b=Hu9osvaA6cbtHN8h+qN32ul6rB4Gla7gQy7vVR9UExCWRHMgAvdZSs07J4FgL1W3YsGuRYEZdqwR42CnjaWkKek+pClITf78fw5MJuyja4XZI89ys9BGNU8Yq0+So3gEy1fakxR1yAkmeaD5cMuzI3iGjGYKwrzeYAWRqPDKzKUF+moZg74XwNYZ1npadBj7r6+6UjKL+LF9ZDnKIF5JY0vkRuT+6pgF6XULLGX+8PCCki6ZURPthIxOSszkk67XL4sbKepA9CaW7un+TNIB/KTcTxJPmbsfFwuU9bpTh/YZlyiClslIvARxo8vqrISc1Ux5zwQf4T2yHr9DZZWv0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by CH3PR11MB8442.namprd11.prod.outlook.com (2603:10b6:610:1ae::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.22; Mon, 7 Oct 2024 16:03:46 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::1c54:1589:8882:d22b]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::1c54:1589:8882:d22b%3]) with mapi id 15.20.8026.020; Mon, 7 Oct 2024 16:03:40 +0000 From: "Kusztal, ArkadiuszX" To: Gowrishankar Muthukrishnan , "dev@dpdk.org" , Akhil Goyal , Fan Zhang CC: Anoob Joseph , "Richardson, Bruce" , "jerinj@marvell.com" , "Ji, Kai" , "jack.bond-preston@foss.arm.com" , "Marchand, David" , "hemant.agrawal@nxp.com" , "De Lara Guarch, Pablo" , "Trahe, Fiona" , "Doherty, Declan" , "matan@nvidia.com" , "ruifeng.wang@arm.com" Subject: RE: [PATCH v6 1/6] cryptodev: add EDDSA asymmetric crypto algorithm Thread-Topic: [PATCH v6 1/6] cryptodev: add EDDSA asymmetric crypto algorithm Thread-Index: AQHbFjcq8F1uDYMpYk2Qxu5bMkfxpbJ7coyA Date: Mon, 7 Oct 2024 16:03:39 +0000 Message-ID: References: <20241004053059.319-1-gmuthukrishn@marvell.com> <20241004082623.714-1-gmuthukrishn@marvell.com> In-Reply-To: <20241004082623.714-1-gmuthukrishn@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5013:EE_|CH3PR11MB8442:EE_ x-ms-office365-filtering-correlation-id: b541b471-6faf-4847-ca1b-08dce6e99c1d x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|376014|7416014|1800799024|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?x4HY3bcgyIsalV5qDu96HF2RavoYdyyUEU7VJfr9eyTd9lrZ7B8zMQApmFdz?= =?us-ascii?Q?lQV83K3ZPMHE96LI92nCcio0rPHsBOgtivW0Cq9hTy7sGRj+5RBqS6nGKxBn?= =?us-ascii?Q?pugj1OChfh5huujZbORBwKJXceWVPij9nIdRMq50AvC7IQcoWqMYbqec8MrK?= =?us-ascii?Q?8wUR7Yzsg7FcfyIac/LPCeoier5QLSv4EoQ5O6R4nb7kppYDxmqbCGqnFN/4?= =?us-ascii?Q?z8sYFpwrQPU1hk8HrxyWNNCW5Vun1XfToBNzM6itjWqoolzg6m17zUmmV4iP?= =?us-ascii?Q?6MrbRNUv7pzmKCQv0YiU95YlQ+971ro/B4wKZEe9o7eVMHITfCkk0GfWxTd4?= =?us-ascii?Q?28Fqfcxh943KPdfwaZ6CZAlwRNGAJSDhwsBI89isTVLRX4BsDmZBeQoYylob?= =?us-ascii?Q?RB+2Xpzfk1ab+dXnPD7deM4ZTJW7cLRKA5tq7zaH+lxay/BhyECod31yQe6e?= =?us-ascii?Q?IuXnT0umqcCx86OG1nf4EILMccoN5qIirWod9sUtmInHn9VuG9/3RmUPcscz?= =?us-ascii?Q?gHFm1O8OBcioGdxH4UbEVVG8TDydYM63bAKuteP1DpGjV40Ase+0tuRjJv/S?= =?us-ascii?Q?Sbe/HeV8tZqph/ajor/fHHOwypgZAVyLge0viJHAkXjc6UfZXPeJNptNb96Y?= =?us-ascii?Q?uSfcmsM+gmqohBlAacsZl4jA1186i0hWxDZ1QrPjwms1ProG9W+A4aCLHWL5?= =?us-ascii?Q?doi0ar8r/5mzrENPqlOTsa0HIlKDqXqkN0IgbooiirLYXlyPryF4hHsjbGDD?= =?us-ascii?Q?TwSlrRc6qEpacmpi7wkayEpqjcecP6XtT57/63oZC3eo0o7wOpqI2Qz4q59R?= =?us-ascii?Q?cqAzog1h3yqDGKZOaPFkRJGy6ITxQkC2EGIicsJij/E2QTVqLpziN1M24rPB?= =?us-ascii?Q?nQw8LK35XhFp6kmrTyC9d+hQmadDU7//IWFNeQ2xalLkJyyaRp3R5A1MKqEl?= =?us-ascii?Q?FxUWJi7cdSX3jHUMM2jZulgr0k1a1hbWEN01ab0RAs9KZ4UA+E4Xaydt5l++?= =?us-ascii?Q?QScamv/kbG44jjYwIRgjP/Bv5EygDaV16jioMo+Ivc6OLtI22bKQioGeS6v1?= =?us-ascii?Q?wzg/Z+1x2SxPy0RV4/n+2QzItl03+Ul9QCZOcAF7Vj4Qw5am3LnzUrgOsnxX?= =?us-ascii?Q?rHPEyUUf9dI4MpPIQhgdzidzJKpzFkZ0YftRl7gjdcWzUeg574+h2Vkg13ye?= =?us-ascii?Q?O2wTRssMjugbpRIqwEXk7vFkatOLBf95CHKNXyZEPiRh0tblAyk4cnwJiNzM?= =?us-ascii?Q?ZoN32KVg97MPpftod/WLZdoieEhdPZX2mAjVmyoyrzfX7mmbp0CFe0qKIO/Q?= =?us-ascii?Q?1CPd+hYiG9eYvPcpAydbjxy1sM8+1PzU8anr6qBF40T7MQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(7416014)(1800799024)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?glusmN0AEHioiF8jbTH3VG2IrDZQYHkiErSZx666scUpUGa3vyodMWDG2l1u?= =?us-ascii?Q?ydA0BJbaRuizOInZZPfaICWWaYfXQDu9NT7s84Vro2Ngo4bFYriuzbtbO2CZ?= =?us-ascii?Q?aSDJE+Io4tChOFqVmIPzLHE/ymhe8y0prDsqfKHpDEGHKd/GUl26M6+613dw?= =?us-ascii?Q?DyuffkoE9wBq8Pq/bRdFVVXo+oJnw2MdKFC3dTr8TTdZzLa5sOObrIK3ta8b?= =?us-ascii?Q?2H4/u+9jiUPi1iYLa3WPm/RAklywStU1fQ1wVnd06pzF0XlQ4iXaL9mCfxZN?= =?us-ascii?Q?nVRRH+8MOsGHf7qRXVEM9aMNpR5A/Fq0zECKL4zumbJ9fTdFbPEbNNXqD+HG?= =?us-ascii?Q?nhEFjjXZ9Q3uKZkD9OQtSpgug2u3/eEEbJ8+p+cwHZRFuOk6NbaAPv1WpWKf?= =?us-ascii?Q?aQVWilNVZkcQnxcBbFz+vgS5qx2hEWxKo5qgG5w36HM3X0N0rr+j9xeRHur5?= =?us-ascii?Q?S0FIS4NaE6rjjQrRZZemUlBjMHT1+rLulIx+EFe0PhfTo6CAf0975zI/d+t/?= =?us-ascii?Q?8hX+43hH0I1f1yT9QzkAYZ40IBNreI7yZ4P7NyDQqvgKgg8sQohPm0rjGDZF?= =?us-ascii?Q?H4BLiBUjAfUXAt/2sNFgkNy7KZqP4iYAPRxGcR2LZNft0udWtmv9WH0LEZwC?= =?us-ascii?Q?g3ExT1F5czlDXyhMkGv4ejnT804i5spJvp7rh9ig8AL6LtdB2QTujDemfWP2?= =?us-ascii?Q?fYjH0/ihJYCLwd9i+TPVEf/Wrx6ovu70U+V+fu210zwfPFpQUJuc/2IfwfUK?= =?us-ascii?Q?0zqb3FS1z9tMd+reMRbxsA5QT3vvLXuqsVaeNYAEu7cyfGCKjoO7iFEk6g+6?= =?us-ascii?Q?b7vMJ+xVrUYwPzPRSI38/QVySWlAQsQNOZvWy3LpyB54w3mUD1OEI1zpUHbx?= =?us-ascii?Q?dnrCtbMMGdX7GvnQT/KDwAZhYxWktplsDeTXOoWz0SmV3W+3CgkgdPCE8g2s?= =?us-ascii?Q?wU763fNa/Sb6jqzgtcrncRu7IOxcAol/nbTd4shWEyB0LxFBUSip1sJZxhOd?= =?us-ascii?Q?J5nS95lOBcBPPCVjIZycLR8+MfrpdzGf/TMr1X0lWiMjDETXq70BwJ2zVAdy?= =?us-ascii?Q?stvswJxmD+E/x6Oj76JVIo7HjDWmagh27+4vT+1OYwkKiSXJV+qEU4hfnRKq?= =?us-ascii?Q?BsLJYbguFmRBEYQXuxXJ4r6dMlcI0FXIX6SRaPZ2CgOARrD5BNpamNL7iJAd?= =?us-ascii?Q?t4ISmNd2LbnVE1486WbdCY6eG4DTqEHH1Qu/JgdjdXCDNjhNJJYuKvlPOdMr?= =?us-ascii?Q?j2pM9Df6JTfHurp770eowFwJCWOMSMvmFT4zkm//edfBgBuVKkU/LwmGDiiA?= =?us-ascii?Q?X53oOuZRJcxWSHC9CYrgnCPepOcdLRugPfe37pTuEI1m/iSB/crHRMnYjgLX?= =?us-ascii?Q?ZC3yZJ4sjyz6s1gAAHgeQlo7iYuO1AkRlP/B2J4C77Ch5eWD3RrNjizsq4N5?= =?us-ascii?Q?2iDeeYlbTGrFcNb38dk+tRzrNEBTnCF7LKO/dVWaCow1gm1lGCYD2RuczdRv?= =?us-ascii?Q?9k3Rcu8jL2f1HQjS5sYDQWT9kb+BCBKCrBuZClkRrH656iE+nGKoc86NWB46?= =?us-ascii?Q?MJBcBYWkpUPZbqZ0BtwCzL6T7viL6JGpmNrOf1jg2W/RXbR+dFmzfuDClQNS?= =?us-ascii?Q?iQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b541b471-6faf-4847-ca1b-08dce6e99c1d X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2024 16:03:40.0363 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Z9wJuK6vV/U+uAbEf75HDkRyL1ObhGxr1WrUj2kQgPRQat8li+lih/ATLGrog9xd4tS+Uv0FWRAOF0/dTis+ouys/toDoMsjUagCObMFdyg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8442 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Gowrishankar, I like the idea of adding EdDSA, but I have several comments. > -----Original Message----- > From: Gowrishankar Muthukrishnan > Sent: Friday, October 4, 2024 10:26 AM > To: dev@dpdk.org; Akhil Goyal ; Fan Zhang > > Cc: Anoob Joseph ; Richardson, Bruce > ; jerinj@marvell.com; Kusztal, ArkadiuszX > ; Ji, Kai ; jack.bond- > preston@foss.arm.com; Marchand, David ; > hemant.agrawal@nxp.com; De Lara Guarch, Pablo > ; Trahe, Fiona ; > Doherty, Declan ; matan@nvidia.com; > ruifeng.wang@arm.com; Gowrishankar Muthukrishnan > > Subject: [PATCH v6 1/6] cryptodev: add EDDSA asymmetric crypto algorithm >=20 > Add support for asymmetric EDDSA in cryptodev, as referenced in RFC: > https://datatracker.ietf.org/doc/html/rfc8032 >=20 > Signed-off-by: Gowrishankar Muthukrishnan > --- > doc/guides/cryptodevs/features/default.ini | 1 + > doc/guides/prog_guide/cryptodev_lib.rst | 2 +- > lib/cryptodev/rte_crypto_asym.h | 47 ++++++++++++++++++++++ > 3 files changed, 49 insertions(+), 1 deletion(-) >=20 > diff --git a/doc/guides/cryptodevs/features/default.ini > b/doc/guides/cryptodevs/features/default.ini > index f411d4bab7..3073753911 100644 > --- a/doc/guides/cryptodevs/features/default.ini > +++ b/doc/guides/cryptodevs/features/default.ini > @@ -130,6 +130,7 @@ ECDSA =3D > ECPM =3D > ECDH =3D > SM2 =3D > +EDDSA =3D >=20 > ; > ; Supported Operating systems of a default crypto driver. > diff --git a/doc/guides/prog_guide/cryptodev_lib.rst > b/doc/guides/prog_guide/cryptodev_lib.rst > index 2b513bbf82..dd636ba5ef 100644 > --- a/doc/guides/prog_guide/cryptodev_lib.rst > +++ b/doc/guides/prog_guide/cryptodev_lib.rst > @@ -927,7 +927,7 @@ Asymmetric Cryptography The cryptodev library > currently provides support for the following asymmetric Crypto operation= s; > RSA, Modular exponentiation and inversion, Diffie-Hellman and Elliptic C= urve > Diffie-Hellman public and/or private key generation and shared -secret co= mpute, > DSA Signature generation and verification. > +secret compute, DSA and EdDSA Signature generation and verification. >=20 > Session and Session Management > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_a= sym.h > index 39d3da3952..fe4194c184 100644 > --- a/lib/cryptodev/rte_crypto_asym.h > +++ b/lib/cryptodev/rte_crypto_asym.h > @@ -49,6 +49,10 @@ rte_crypto_asym_op_strings[]; > * and if the flag is not set, shared secret will be padded to the left = with > * zeros to the size of the underlying algorithm (default) > */ > +#define RTE_CRYPTO_ASYM_FLAG_PUB_KEY_COMPRESSED > RTE_BIT32(2) > +/**< > + * Flag to denote public key will be returned in compressed form */ >=20 > /** > * List of elliptic curves. This enum aligns with @@ -65,9 +69,22 @@ enu= m > rte_crypto_curve_id { > RTE_CRYPTO_EC_GROUP_SECP256R1 =3D 23, > RTE_CRYPTO_EC_GROUP_SECP384R1 =3D 24, > RTE_CRYPTO_EC_GROUP_SECP521R1 =3D 25, > + RTE_CRYPTO_EC_GROUP_ED25519 =3D 29, > + RTE_CRYPTO_EC_GROUP_ED448 =3D 30, > RTE_CRYPTO_EC_GROUP_SM2 =3D 41, > }; >=20 > +/** > + * List of Edwards curve instances as per RFC 8032 (Section 5). > + */ > +enum rte_crypto_edward_instance { > + RTE_CRYPTO_EDCURVE_25519, > + RTE_CRYPTO_EDCURVE_25519CTX, > + RTE_CRYPTO_EDCURVE_25519PH, > + RTE_CRYPTO_EDCURVE_448, > + RTE_CRYPTO_EDCURVE_448PH > +}; > + > /** > * Asymmetric crypto transformation types. > * Each xform type maps to one asymmetric algorithm @@ -119,6 +136,10 @@ > enum rte_crypto_asym_xform_type { > * Performs Encrypt, Decrypt, Sign and Verify. > * Refer to rte_crypto_asym_op_type. > */ > + RTE_CRYPTO_ASYM_XFORM_EDDSA, > + /**< Edwards Curve Digital Signature Algorithm > + * Perform Signature Generation and Verification. > + */ > RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END > /**< End of list */ > }; > @@ -585,6 +606,31 @@ struct rte_crypto_ecdsa_op_param { > */ > }; >=20 > +/** > + * EdDSA operation params > + */ > +struct rte_crypto_eddsa_op_param { > + enum rte_crypto_asym_op_type op_type; > + /**< Signature generation or verification */ > + > + rte_crypto_param message; > + /**< Input message digest to be signed or verified */ HashEdDSA will require a message digest; pure EdDSA will require the messag= e itself. For HW it will be more complicated. > + > + rte_crypto_param context; > + /**< Context value for the sign op. > + * Must not be empty for Ed25519ctx instance. > + */ > + > + enum rte_crypto_edward_instance instance; > + /**< Type of Edwards curve. */ All instances are using the same curve, where they differ is the way of han= dling input message. And I think this should be a session variable -> new xform for the EdDSA. > + > + rte_crypto_uint sign; > + /**< Edward curve signature > + * output : for signature generation > + * input : for signature verification > + */ > +}; > + > /** > * Structure for EC point multiplication operation param > */ > @@ -720,6 +766,7 @@ struct rte_crypto_asym_op { > struct rte_crypto_ecdsa_op_param ecdsa; > struct rte_crypto_ecpm_op_param ecpm; > struct rte_crypto_sm2_op_param sm2; > + struct rte_crypto_eddsa_op_param eddsa; > }; > uint16_t flags; > /**< > -- > 2.21.0