From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 765CBA00C2; Thu, 7 Apr 2022 16:05:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6561F4068B; Thu, 7 Apr 2022 16:05:48 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id A1DBA40689 for ; Thu, 7 Apr 2022 16:05:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649340346; x=1680876346; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=tuvTXCFD977FW9fB7bc5MrhWjksBIDMxZqXR6dC1FNQ=; b=Nd2LLpnacv+ICk1Cp0VZWDdGr//7XtHJ1f2RdM+WF6+fZQbfWP8LhlFu mWlc6xR0oCTxPgu+umtvhdsAzfaK0WntGFq+hYRWYUGukihRxuNzTgEQp dzBxl7weFFtsw6PWxkI90xfV+b4PrBCHdQaFUkfmoRa8FEtqAKevL3STX zvsVSKZlomsqgO/T8G+ypHiK3pjw4EfOvTqISKE2uzZ6AYRNsqlFxGDWI aRPlzGgfRD88163MMdDpViMYLKCDYgHuAx5ek3wtpFP8DXlJucXxFj3ul 4kfmoXHi/gbMlBedLQ7uJCv7u8M6a9XtbMt3A5URzwu3tCRN3sSWuhwAL g==; X-IronPort-AV: E=McAfee;i="6400,9594,10309"; a="261323023" X-IronPort-AV: E=Sophos;i="5.90,242,1643702400"; d="scan'208";a="261323023" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2022 07:05:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,242,1643702400"; d="scan'208";a="557380237" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga007.fm.intel.com with ESMTP; 07 Apr 2022 07:05:41 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 7 Apr 2022 07:05:40 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 7 Apr 2022 07:05:40 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 7 Apr 2022 07:05:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UyrjA5F076X6pOtLINpoUu77xq5TzK8v3DLIZiUpbKvXO85bVPhSihSi5kAGihipd3KMSJATkkPkiObJSwXkyx/T9s/szjQuNcrvjL8mCnZUeiGKGyB0q65sMANp83+7Idx7MN6lHTvL6wN5DI1XRvK2kjUtHHYVk2FrOyuKI3lDd1P3dv8FaSxQrkBdJI5Z0TmBfPbI/Zial8D+4ojfzFcs+AQPrPzr6qnnF4ROJapQQG/M4okxi2xhCIQrIyf26J52PDbtkqDfTdZNZPUBfaBpf9sqqcwqFBaqvjxOqsW+1aWfL4Bkhg6im+iSCyDWq06PwLekkyKI8qRkG9Nz7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k9b6DXzMm7ykIPOjBuV66z516yQJmd1CSMMWxHgVocM=; b=jrMxMc50+t5Rmy3QDOE+GwuGSzg2KMg9sjr2UB434mTa+CF1YVieTSNCEnkCNKj4ubu8j7HnTyvttw2LPq07S9I1gcwTe96IRaj18+zyOA+JqJ3ZWMcYM/rbnm/9XucXMfQmfYH28HAyNZWfqAroedjMiEYlwwZGpXAIc4tyWog0Tzj7V+3CmKoFCYjUjaND1s8KgDbuAT0H8fqKVgt59wB4nn5kgMal2SyFxHX1Aj0h7ruAUkfLlCn6LtWkznhVevFF7QYIxI1m4e+RO5jgEZHhCujY+xpW5cI0giJrj2PauqjXYrp6dniPuwhJZ7qMbuCcF5D4gjVGjSUdLMx8Lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by MWHPR11MB2048.namprd11.prod.outlook.com (2603:10b6:300:27::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr 2022 14:05:37 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::8189:36b8:ed0e:2501]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::8189:36b8:ed0e:2501%7]) with mapi id 15.20.5144.021; Thu, 7 Apr 2022 14:05:37 +0000 From: "Kusztal, ArkadiuszX" To: "dev@dpdk.org" CC: "gakhil@marvell.com" , "Zhang, Roy Fan" Subject: RE: [RFC PATCH] cryptodev: add diffie hellman verify, change ec enum Thread-Topic: [RFC PATCH] cryptodev: add diffie hellman verify, change ec enum Thread-Index: AQHYSoVs4+H4HJdZRkSTr9tJwf6za6zkdhWg Date: Thu, 7 Apr 2022 14:05:37 +0000 Message-ID: References: <20220407134248.20178-1-arkadiuszx.kusztal@intel.com> In-Reply-To: <20220407134248.20178-1-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.401.20 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b8249571-c86b-42fd-b5d4-08da189fb139 x-ms-traffictypediagnostic: MWHPR11MB2048:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: B3tvDHfMmZgSoZvNw1LFAFJGqTp5G1XdVm9xQQ2yVDW/gAB/wWNXLauOXcbUsVpjjvEEWk/Y+bOqiZoJ7w4POHtiNYxKgriE/JdDpam6V2Iziirx9lTJWA2ZV5ohdDMeUbEhI8O89GXnnaO83cdKdhpYacsU2cw7z/1vIhpf+i3t4AgI45OOGxnl+OohLCiNIIPkWT78DNLYMg+vtuteyL5QcT0pvr8cbET0uWtzblNzFZGZOMd9Z0WjzCWBfcZ+XFzRDN4PN1VOXFO4PMZZwAblrNhXq5622bvgT6GbPQnX+0VNQwUltJX6upWZPq6LsAMyeQVsrHNypjgxnDxQw4fF9q+VjJO46uSvtfIu5m2fOJ1s4XiMf/BBz2wy7p8k+x0FHEPvSe7A1v0J5I31zwZUtK8BIfjX26qi9F2BvSsASVlJ7e8rDlVmudt8J8JXvHezMKtNDmdsAkqVAzNWvUX0j/Rz8lD3w5JrHqQB7SCsZaak4+mzJQN0uoKeJdmU/WHzGxX5tzBsglLSxTmU2XUqJpCwKwg0OpSUiRODKRcegrpS1zAGCMNimlp/umKFFWcmVBvblNz0Kvsoz8cX973aLFsdHrh/O/Nv62TXl5jffXtKZ9NaOc4QjsrxCbGHOere1jbsSYSOBz5olCxr4SwUoKKvHxX2eWtB75IxFkCkb/tRgAxYRnNvuHXfV5qoPvaZLYEe2pMEgWLWWCMq3w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66476007)(53546011)(66556008)(6506007)(7696005)(9686003)(4326008)(64756008)(66446008)(8676002)(6916009)(33656002)(316002)(54906003)(107886003)(15650500001)(26005)(82960400001)(122000001)(86362001)(5660300002)(186003)(2906002)(508600001)(83380400001)(38100700002)(52536014)(8936002)(76116006)(38070700005)(66946007)(55016003)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Hd1LbWQUVDniUNU70HFUtSxqa1WW7eUJlat0KFNezJQSjx/nH9rr7WS5/E6k?= =?us-ascii?Q?TokkZQwgsRrN7eXak8w5UYLRdgq9ejR7CBRIaR+Ou1xcaQrJQQTnnl9SMAgc?= =?us-ascii?Q?34rFzTGkpsIv78TQl05JMoCMzuA7DvLwdniVEHQfuNOQFEWI39L84CiLiOde?= =?us-ascii?Q?xEOu+pXx5Gq3w3X2aijJXsE+rcRWc2h5AO1Atc6gL/vV8AKhGd43IjqFUHLT?= =?us-ascii?Q?IRzAhVAFTj8Akx2qxm5iqG+pEfm6IMllqKjRGwZT8rnWu3qrmRaFRAZYhmnw?= =?us-ascii?Q?UMMfQixq8d3jCQ3sDMTbb6dztv9eNNRRth40yZJmUyHDUncHDpQsKLJyexjh?= =?us-ascii?Q?yEuiCwkvjcor/zXHQ6Hmk/C8mP0PeBv/dhop5EjTsDWD/mfEtmrB7IFmWwN3?= =?us-ascii?Q?D0+0VMJE+nmldbngdiqr5p95aDOHRwSLJ6SuomK3xgCvYlgIXuMs848aGYtJ?= =?us-ascii?Q?RJsO1Q4CZmNLhM/EWov4aJ+FZEeRCZ1Pxrz4Fupw2AbcNbSCSBZW2K3XI46r?= =?us-ascii?Q?BgWarjU0tsD1rm4nlSR8EhJkPC/IR25gKjvBURQgpO6VlQgzBspu4t7NJ5Dy?= =?us-ascii?Q?b/PYGDpJumD2XK8Vg/2+X6KCZqdLg9FgQlMsz9GgxfbffXRiBb+gU8DWoHhR?= =?us-ascii?Q?EOOUzB41DaCGhCXY4KZJvxm48fPRvRMu0YygyozTNee/2lUow13G9XvlwZkK?= =?us-ascii?Q?5x2Zh1RQuf5gZPK+cz4fnZnhtKryvA4Hi+7QpQifdzICR+1Roul9WDomfgdq?= =?us-ascii?Q?ssRHwcWVXIzFS5VNd3Sc3b+a/SETbAArOLR01RyMf/s8j2Stx5HFpqjlZaM/?= =?us-ascii?Q?tty1gJDSCr5eG4BXlWUCIThPqNEb30ttrXDowTQNyEbHzgq/7Eyx4zfoCPpw?= =?us-ascii?Q?Fy5kiTDonY8f/e5yKWD0YsePzRphnQuHeyY2BFhg+8MucuKfZZm3pEyMFI8M?= =?us-ascii?Q?n13LG4V5r2yQ01FIdDhOTE4O08R81sNbS8xGOBs3FX8U0lAqxFwXMo1eR4oI?= =?us-ascii?Q?HmDjVVR17//O2N1rZyaJ1vxq7hWPbfIlqCsKRjQUmYKvbEvALhmvXqLMLwXD?= =?us-ascii?Q?rX69lXn5wgrzJ1Jk4KhFqxqQOiyt7ii9PPI4eE3aYB4W95lKF22Mi+eNQavC?= =?us-ascii?Q?qhjVHARmT762fIPyUPqfV+Llnt10DMX06mNwjiQG/ez9k/H+FYLnSM7F3UEc?= =?us-ascii?Q?KwKjo3Yh0l9+gT3ZvT9P2qZyOt2r7pArVXxa+cRJuR2wIgOYoEXfca5WMjnM?= =?us-ascii?Q?skDN6BCt7+3jjMDtqG6D8OBv5qB8JkIPshqPr+M2JNG/xqws9C5ZNwALKcHD?= =?us-ascii?Q?THE6zhwrdJl/AQUfjHLcvMu3D9o7KYLycjYPx2YhMcB2V+IMzUls+vKeUktr?= =?us-ascii?Q?K3jIGlQW4nEQuGSLH3JSaw3O6MAk9I7oLeePyYKcAe4pf+R/VpMHx5UZ9qnU?= =?us-ascii?Q?Y9emLBUg4NTF98ApIfGXl/bxR0olVS7iiddF+eWN+2MBjOScwgDWMyBMp81X?= =?us-ascii?Q?iCFhbjPcOR4Z3UC4BV3WEXmx43y0wV9uGbQ6TuHM6Mv4eVTPJvLh737NPZly?= =?us-ascii?Q?kG8CQsiBUN33BckNKMJ4Tzqn8qqPb1NFcVdllq7MG72vVHswZE3yqDc/j4AK?= =?us-ascii?Q?E2yK98e+4usaXWAoHDYM8eAcLEwf5mwKS2MhsNI4Cp/1CrxJt47pKg6uz+pt?= =?us-ascii?Q?w0ducBKRHl46EjX6UyQ6TE3fJO7DNHdvSvQMK47U7konvSxqFh34WQMYZosW?= =?us-ascii?Q?AZlXxgQRF+VBLDvNtFFykdxNtx3jRuU=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8249571-c86b-42fd-b5d4-08da189fb139 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2022 14:05:37.7468 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MMI0eZsVOTzySGaOBUV2Gv3LOaKPpJE4iiQpA6WTWsBroL/K7JtrQfO2xRoXMOHvD7zjfz3T9cy/Fkpe+4KjgZb7fqi0zXnGvARkMUEGiCo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB2048 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Some explanations below. > -----Original Message----- > From: Kusztal, ArkadiuszX > Sent: Thursday, April 7, 2022 3:43 PM > To: dev@dpdk.org > Cc: gakhil@marvell.com; Zhang, Roy Fan ; Kusztal= , > ArkadiuszX > Subject: [RFC PATCH] cryptodev: add diffie hellman verify, change ec enum >=20 > This commit: > 1) adds Diffie-Hellman verify operation. > 2) splits asym_op_type with dh op_type > 3) removes next pointer from asym_xform > 4) changes enumeration of elliptic curves >=20 > Signed-off-by: Arek Kusztal > --- > lib/cryptodev/rte_crypto_asym.h | 36 +++++++++++++++++------------------= - > 1 file changed, 17 insertions(+), 19 deletions(-) >=20 > diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_a= sym.h > index cd24d4b07b..6fbc7b7708 100644 > --- a/lib/cryptodev/rte_crypto_asym.h > +++ b/lib/cryptodev/rte_crypto_asym.h > @@ -43,11 +43,11 @@ rte_crypto_asym_op_strings[]; > */ > enum rte_crypto_ec_group { > RTE_CRYPTO_EC_GROUP_UNKNOWN =3D 0, > - RTE_CRYPTO_EC_GROUP_SECP192R1 =3D 19, > - RTE_CRYPTO_EC_GROUP_SECP224R1 =3D 21, > - RTE_CRYPTO_EC_GROUP_SECP256R1 =3D 23, > - RTE_CRYPTO_EC_GROUP_SECP384R1 =3D 24, > - RTE_CRYPTO_EC_GROUP_SECP521R1 =3D 25, > + RTE_CRYPTO_EC_GROUP_SECP192R1 =3D 1, > + RTE_CRYPTO_EC_GROUP_SECP224R1 =3D 2, > + RTE_CRYPTO_EC_GROUP_SECP256R1 =3D 3, > + RTE_CRYPTO_EC_GROUP_SECP384R1 =3D 4, > + RTE_CRYPTO_EC_GROUP_SECP521R1 =3D 5, > }; [Arek] - this one we could change for the following reasons: - this is TLS specific registry, this values does not need to correspond wi= th other protocols like Ikev2 - we cannot set deprecated values < 19 - TLS registry to some extent is incorrectly named to. It contains mod exp = groups as well, and we do not even support that. But if we would, it probab= ly be not "crypto_ec_group" =20 >=20 > /** > @@ -109,13 +109,19 @@ enum rte_crypto_asym_op_type { > /**< Signature Generation operation */ > RTE_CRYPTO_ASYM_OP_VERIFY, > /**< Signature Verification operation */ > - RTE_CRYPTO_ASYM_OP_PRIVATE_KEY_GENERATE, > + RTE_CRYPTO_ASYM_OP_LIST_END > +}; > + > +enum rte_crypto_dh_op_type { > + RTE_CRYPTO_DH_OP_INVALID, > + RTE_CRYPTO_DH_OP_PRIVATE_KEY_GENERATE, > /**< DH Private Key generation operation */ > - RTE_CRYPTO_ASYM_OP_PUBLIC_KEY_GENERATE, > + RTE_CRYPTO_DH_OP_PUBLIC_KEY_GENERATE, > /**< DH Public Key generation operation */ > - RTE_CRYPTO_ASYM_OP_SHARED_SECRET_COMPUTE, > + RTE_CRYPTO_DH_OP_SHARED_SECRET_COMPUTE, > /**< DH Shared Secret compute operation */ > - RTE_CRYPTO_ASYM_OP_LIST_END > + RTE_CRYPTO_DH_OP_PUBLIC_KEY_VERIFY, > + /**< DH verify correctness of public key */ > }; [Arek] - DH Verify need to be added anyway, but rfc here is because I have = split asym_op_type into dh_op_type and asym_op_type. This leaves asym_op_ty= pe like that: { ENCRYPT, DECRYPT, AUTHENTICATE =3D SIGN, VERIFY =3D VERIFY_SIGNATURE, } I know it is too late to create one generic op_type for symmetric and asymm= etric but still it is better to group crypto and key exchange operations. >=20 > /** > @@ -256,7 +262,7 @@ struct rte_crypto_modinv_xform { > * > */ > struct rte_crypto_dh_xform { > - enum rte_crypto_asym_op_type type; > + enum rte_crypto_dh_op_type type; > /**< Setup xform for key generate or shared secret compute */ > rte_crypto_uint p; > /**< Prime modulus data */ > @@ -278,13 +284,7 @@ struct rte_crypto_dsa_xform { > rte_crypto_uint g; > /**< Generator of the subgroup */ > rte_crypto_uint x; > - /**< x: Private key of the signer in octet-string network > - * byte order format. > - * Used when app has pre-defined private key. > - * Valid only when xform chain is DSA ONLY. > - * if xform chain is DH private key generate + DSA, then DSA sign > - * compute will use internally generated key. > - */ > + /**< x: Private key */ [Arek] - unless someone can show how it works we should drop it. > }; >=20 > /** > @@ -504,8 +504,6 @@ struct rte_crypto_ecpm_op_param { > * Structure describing asym xforms. > */ > struct rte_crypto_asym_xform { > - struct rte_crypto_asym_xform *next; > - /**< Pointer to next xform to set up xform chain.*/ [Arek] - same as above, unless there is any application for it we should dr= op it. > enum rte_crypto_asym_xform_type xform_type; > /**< Asymmetric crypto transform */ >=20 > -- > 2.13.6