From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8372A0503; Fri, 6 May 2022 14:05:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 767344068A; Fri, 6 May 2022 14:05:25 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id BDF3B40395 for ; Fri, 6 May 2022 14:05:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651838723; x=1683374723; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=FTxLPyDgt6wRD4RvDCgbrgZYwM4kgUF9GUUWi8lnU8I=; b=Wl3hgayQGsP1wIAXpZGnLZars+ZbZ7NOF0JOHxUSTZHiCoE9PuWwbEHK /x1RSdv6V3e2gklfBXrE415X7PJX23VqZAIkaw9Z3Yt9DYkQSxNuuDJS0 QvnU1ZkmQ1Cot2kbzoD0odjdf9aM8DXmVTHy0/Agv3GxVGuq1yRh6E3ig rLLaeYebIWX0e4rCoh50wPyNQcu2MRCOCEYUNSeq2tHDk8ckrDXj+C+fv 3vIwJKUlIG6/cgfjkqbCE1+uv/rek32NpP/ynIF4/u9lcJ7hctNawAX5M IHeP0xLhzkTHe39/CmxRx7l1Im6RxNZRY4WOejJRyiMyEIZvxOeupEpNx Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10338"; a="266041300" X-IronPort-AV: E=Sophos;i="5.91,203,1647327600"; d="scan'208";a="266041300" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2022 05:05:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,203,1647327600"; d="scan'208";a="549833306" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga002.jf.intel.com with ESMTP; 06 May 2022 05:05:14 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 6 May 2022 05:05:13 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 6 May 2022 05:05:13 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 6 May 2022 05:05:13 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 6 May 2022 05:05:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nH7IwAWsseboSAcKdtu8llrYqnqCSrlyPXvuEUNSriGtXpkXCJRiJq4WkA3hzAs0aD+56oRzauNEgRv5Cf23rclrM/Ff5bIqqLGS6rfbYcc7h47X6+Sma1uIbRgl520OUD5m7Fc5EDNWxfZGfW+R76UvPiqi7jQynpllh+ibb4Bp2VwH8xjtXm4JRHLt+ws230gxyLHF8qcW77AzzQtCja6PdwmKFHsnigf82/zLjjcCRsrPGRnsrkjabmpt4Rg4M4UdKi3g2qvWbXCCPyxzj4f0TAMSo3rzRFqzErolEdBRDFxwEBzEjXthq3v0LQyuA7/e37xBLRsHhJoZAB4hFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=amFB7MYBdoRuonv/15ovtF9+vWfH413r3s5kG9QkqAk=; b=JpScwHMVn1CAd6jONBi6xae5nS2WChUjkbIGlutP6430Q1xmpQz22aBFh2Ha4ev+0VfaO8vXX20+nRz/XRRqkcfdBtxjznQ/abCEZRPrWze+7ax/Js0r872sXZ3J29A1V0G+S+f4IzicizmOl4KuYis0NN0dLbFkZlUf09rTnXNzv723LhREGnFaPO49G/ON9AdHgjQHj8nqUENaC+bSkDML42gBqOHpIeFVVo9Wo0XYjHL0Xw6ED0wLAv31b5rkYG6Z368O6EQSP4gEm9scql96xIty3HnZ4jXj1jhZkapkQxAmSN/8t4SnmHlDGsx155vxl2lo6oMJVjXI0ZoXOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by DM4PR11MB6067.namprd11.prod.outlook.com (2603:10b6:8:63::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Fri, 6 May 2022 12:05:11 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::fc0f:1644:98b5:be1]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::fc0f:1644:98b5:be1%5]) with mapi id 15.20.5206.027; Fri, 6 May 2022 12:05:11 +0000 From: "Kusztal, ArkadiuszX" To: Akhil Goyal , "dev@dpdk.org" CC: "Zhang, Roy Fan" Subject: RE: [EXT] [PATCH v4 0/3] cryptodev: move dh type from xform to dh op Thread-Topic: [EXT] [PATCH v4 0/3] cryptodev: move dh type from xform to dh op Thread-Index: AQHYWgqZw0b+PZ1W/0yjhl483f3Ty60D6uoAgAKB3yCAC2AtgA== Date: Fri, 6 May 2022 12:05:11 +0000 Message-ID: References: <20220427074400.2091-1-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.401.20 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3d11db9b-c251-4d20-ed28-08da2f58abe9 x-ms-traffictypediagnostic: DM4PR11MB6067:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: enqanhPoGPLR0Jp3I27UTlwjfX+zMROWCNYKDRg2nE2ifUllasFXjB3dxh8yP+RyJeCfxNWrBYxzzh37Shca5FnhNfyC2WCPtGQjuUzwJFnBUnLAI5CRSpTo97ggmRhFKcTENjlRz96v91dXWOT4dG/XERgBy6Gurizd0BWiyANFPHfExp+1q9TCMNaUvXlmYTi1l/zI43KPUD4aKGqqhEx+xfhXKTFbRkvy/mzgqvL7Rr6I3hKAH2egGyjmKvllHMgPc1uiCVlP8mJT7Ie1GYk4Nh55Hsrt+b7S878VlUabLv4ZyR4GaezMX+GkwdS6U8+qc6yWoJ1zZpx4VGHRN2aHI9PfaSGAAFV942KoQ98h/xlo1ckENJvidzJojS/iK0YZ6f27PFQO+9gHWO2TgKO0U7EYR3O1IJC1MxY2wud5IxWbER0V+LOdXVWEn5yIyDR7DAIJxdBJ0T4IMVSihLIJ3xst/qJWrsOe4+GbD5wz3FIQsKBTTFV5vbP/OPuTgVM/7pXhRKnWukF+0zYWzFw1E4nzQQMZ8mec/GdjFKFwx5MUuBzpGWPQhJ04I1CS+3012Ijyv0qEPkPnluXLo/hx7XiwhOkfsMw7Lhj7BpbVn2YdpDffObu434YZoXV9yuVW3CjFUYiad/PtUxsdMGOYVpxhU/3YvbfijC0awHOia9d2jrcGKUf1ZytgphJpEqChn9zDnN2wrtiNS/PjzfLVGrYPKGcGcKUCFgOnMImltHeGcvmet5HNnWSaVF7PouoXfiBf3gW71XSPECYkYMVc94zcwn7bmXJPp20wUOw= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66946007)(66556008)(2906002)(316002)(66476007)(7696005)(186003)(5660300002)(55016003)(33656002)(76116006)(64756008)(52536014)(66446008)(83380400001)(4326008)(8936002)(110136005)(71200400001)(86362001)(107886003)(966005)(508600001)(82960400001)(38070700005)(38100700002)(53546011)(26005)(9686003)(122000001)(6506007)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9LXnrLzmsggySPAWzpYmvYl79SjvRtpV0l0x3Wrm8c07/yOxc+/XGAAu3Yjd?= =?us-ascii?Q?nriXm9PVLAU2ofeJMS0NAjxodqQPIEOIKC+oCaaI8xmJvH2a8Dukqv9Pvug8?= =?us-ascii?Q?LnOgV5p/+l7xgkKLSDLagH/UvHwgT+RnB0vEm91K4bqAY/jCa++XlUmyTjyp?= =?us-ascii?Q?Y8+PpWOUdvPrKDgCdspXQ+hFiyFTV1OfQGx5u7cFABYrPql+b7kvZXaEWPlb?= =?us-ascii?Q?XK0E+5h2E7UdZY+EaLiTHKj3V6F0apcU3QQaexEAli+hbkN98fyZbKYPQMhf?= =?us-ascii?Q?xkemIfJkYPXsq1rF9S0rjoksnx6wUXNE0Tte8R9i1H91JIgE2GMBLTDiiX3L?= =?us-ascii?Q?mR+FDaiZSuMnZ6xWnyGqLByIDFewRisZPxNkhGZmhbH3WeUpOnEiSUsYxxPt?= =?us-ascii?Q?EZXoqW5w/IF36Rxyn9x0qPBizHwUyFKaXCG8hr1GBvjbv2eJgGKEDPWPIfAY?= =?us-ascii?Q?NbMS9m9Fcxnh49NnKUAwyegeobIiH3WD1qGMOBwlUZACGQ0A8PbK0KqJ5xJe?= =?us-ascii?Q?yLnSHkCDhZ9r3Z2fDmZHX01j2COUdFlFjiaBkA7hLr7bE8geC9FjB3qTWSfo?= =?us-ascii?Q?zUjT1CX20tsDThVajmsyt4bO2fS2b3xYL4mIE8TZOL+mbGkpaF0SDmESRtjF?= =?us-ascii?Q?wXj8QBYpyqGFz0iSY226WtP2h6kBrOwgtAXfKAbnRk4E8zQ1nD4OY0r/xm12?= =?us-ascii?Q?33BIOBqgT7fB0NN7fWCaC8Rdb48wiWI7KsjbTMIWpNLL0eHCUwQqBOEERqDa?= =?us-ascii?Q?h5mMmA9IeA8Okr88INsErUIW9u5IkLAfYd6o80sWv1+bAi3ee9Z8XbmO5XQA?= =?us-ascii?Q?bRL1v+OMiwsXpwOtTaHxHr28Gg0wehs2HVIRp+mBY8UJsareM5Ct4wI0wOaP?= =?us-ascii?Q?WJJVuEj6Hct2ktIJC+QIvR/HUtjcg+9SNxInOI0v3rneb2WAPyAVCfx8oL3H?= =?us-ascii?Q?2aTD7/rkNHyyWrkvGilQrWiiU/dhwur2S3KWd4tKNXZKjeKsP4A4GwZzNfGT?= =?us-ascii?Q?tnxZwDGFvXehuKrfsCr0O1KfPmjAgbioqbcaV6TLlL6xSS9LJEglwN3BVyf/?= =?us-ascii?Q?EG28AMCAch8nYljwHAl1HOfGQEdtgnDoleAUpeKqPRJWyqvmX0JVRG0DaHfz?= =?us-ascii?Q?e53XHaB+rBTH94sEY467yaIu2X7VZRJVwJq0SZyAImIZrlzi9oPKidJyYuQK?= =?us-ascii?Q?cvm5gvje/Lf9NeBnBScFxkEcxEIWJHqm4o4dIR8RKAX8loUkTgIRKRVz4f6A?= =?us-ascii?Q?nFXhV6Ob2knPBLCIMZPDiaUoXFy0zcOkTpEGBCiubkcgeuZjW/vPUBLIhbFG?= =?us-ascii?Q?xW4qWBUQIb2ga7pYncQuTOpm+pQ9sPfb3QVIfhDTt4vDLvjMWhHZ9YI3UM2+?= =?us-ascii?Q?5YW2nCLjsQ/1ZqYdTeE65H4iY6qLWuXDs86C6vHoYkYkjPtkKzDpSZBTfTOZ?= =?us-ascii?Q?YxXXxNbiP5/jrzANVzzgahwVsQtAU/8oOrK1rVK6sRjB/kZT0zmyq9oIgD9y?= =?us-ascii?Q?9/imGO3oat48vIDRAPIcZWGQYh2HMNfcSdZ4hBZ7OhxrCFRwVxso8Ct7Erdv?= =?us-ascii?Q?fRQTS0eUtgmu5kNnLXmewSPxAbjPZkrURBNoegWgabpFwg+mu3QgIimTV5IT?= =?us-ascii?Q?G44OUzMqUO+smv94FbdOOCZds5ZRRQXSB9hderZs7OtLXuVjBHJmHxprU4ZP?= =?us-ascii?Q?CNSt+QIzu05xrg3mzVXgGXnxTaVdiwcDmuGR96LzbSmj+NBBu+APb/aJ15di?= =?us-ascii?Q?QSinMJHi1jKiW/5F3WWmUHuqfSyxG8M=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d11db9b-c251-4d20-ed28-08da2f58abe9 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2022 12:05:11.3739 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hnfJXmfUinBE2ZvYzImTP/6khzV01q8/2dMHhvd/reFbSunE6mZ9TeJhxYjRs5pYr/FlNoFj/6HjPKLfGHYVN7tfLpT/uUKNYfCveiVrBD0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6067 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Akhil, > -----Original Message----- > From: Kusztal, ArkadiuszX > Sent: Friday, April 29, 2022 8:26 AM > To: Akhil Goyal ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v4 0/3] cryptodev: move dh type from xform to d= h op >=20 >=20 >=20 > > -----Original Message----- > > From: Akhil Goyal > > Sent: Wednesday, April 27, 2022 5:58 PM > > To: Kusztal, ArkadiuszX ; dev@dpdk.org > > Cc: Zhang, Roy Fan > > Subject: RE: [EXT] [PATCH v4 0/3] cryptodev: move dh type from xform > > to dh op > > > > Hi Arek, > > > Operation type (PUBLIC_KEY_GENERATION, SHARED_SECRET) should be free > > > to choose for any operation. One xform/session should be enough to > > > perform both DH operations, if op_type would be xform member, > > > session would have to be to be created twice for the same group. > > > Similar problem would be observed in sessionless case. > > > Additionally, it will help extend DH to support Elliptic Curves. > > > > > rte_crypto_asym_op_type is moved to rte_crypto_dh_op_param. > > But why not move to rte_crypto_asym_op? I see that in other ops also, > > Op_type is there, we can move that out. Right? > > > Yes, we could. Although some of the operations do not use op type > (POINT_MULT, MODEX) so we would have to extend asym_op_type to contain > RTE_CRYPTO_ASYM_OP_DEFAULT /**< Default operation */. > Another proposal was to split op type to: > CRYPTO and KEY_EXCHANGE_OP > like I described in here: > https://patchwork.dpdk.org/project/dpdk/patch/20220407134248.20178-1- > arkadiuszx.kusztal@intel.com/ > then op stays in algorithm_op. If op_type will eventually be placed in op_param or in asym_op can be chang= ed later, as it is of less importance. I would say first we need to decide if we are going to extend this Diffie H= ellman struct to support Elliptic Curves (for Montgomery/Edwards there will= be another extension, but it is fine, would be in union). So in this case op_type should not be in xform as: - DH op will be used with EC xform. - We would have to create separate sessions for single group. Then we can add 'point verification' to this or, have separate API structs = for all these but then DH would be redundant. >=20 > > Also, I see one more potential issue. > > There is a union of various ops in rte_crypto_asym_op, but how will > > User identify which one to use. There should be a union to identify > > which Struct to choose from. > Could you show how this union would look like? > Normally PMD will reject operations that are incorrectly setup, for examp= le > DH_op + ECDSA_xform or incorrect op type like ENCRYPT. >=20 > > > > > > > v4: > > > - changed op_type coment > > > - added openssl fix > > > > > > Arek Kusztal (3): > > > cryptodev: move dh type from xform to dh op > > > crypto/openssl: move dh type from xform to dh op > > > test/crypto: move dh type from xform to dh op > > > > > > app/test/test_cryptodev_asym.c | 11 +++--- > > > drivers/crypto/openssl/rte_openssl_pmd.c | 54 ++----------------= ---------- > > > drivers/crypto/openssl/rte_openssl_pmd_ops.c | 26 -------------- > > > lib/cryptodev/rte_crypto_asym.h | 14 ++++---- > > > 4 files changed, 16 insertions(+), 89 deletions(-) > > > > > > -- > > > 2.13.6