From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59766A055F; Fri, 27 May 2022 08:40:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EDCC340E5A; Fri, 27 May 2022 08:40:43 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 1429940E50 for ; Fri, 27 May 2022 08:40:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653633642; x=1685169642; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ENn+32ZwSJRXPKub1IjXfwZ6JGwcWjAFqxziVoOjibY=; b=X4mcFAaUreo8LjZTSHQ2CkbIXF6PJNC097NUdniarS0AJLu74rcl2Mqf jnHrkJkoY1C4nT/Mh6xAhQ7OkFoEj3GINS80HiB1yeVKs6vInETcJq76+ 5SascxA1aeYsbX8bKfhe0g16f4lrkJWxuMcxjcCRzBu41fIuFFwXCAUb/ HSHJ6KX9ddTRZViBxCyaYpYIM/YigiziT8NKisCbiiMe07TlX9yf+e6lJ xiyKC8b4Vtcrvaz9+mNkVoU2emY6fbhlqkk4yrj8FvN99e8OXVNG8BOnR Em0b2KyEeeEHrbq73uBpVWRRj5fI7WbJI0gQuX7QGL0YaDxJu4vVnebeI g==; X-IronPort-AV: E=McAfee;i="6400,9594,10359"; a="271970091" X-IronPort-AV: E=Sophos;i="5.91,254,1647327600"; d="scan'208";a="271970091" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 May 2022 23:40:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,254,1647327600"; d="scan'208";a="603706082" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga008.jf.intel.com with ESMTP; 26 May 2022 23:40:30 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 26 May 2022 23:40:30 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 26 May 2022 23:40:29 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 26 May 2022 23:40:29 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 26 May 2022 23:40:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OcIbUGIqSW2NmSQUFkQkZP+sXUCSXsLk4kv4Q/ZZPUi1J5GPkeugTGMaQUHFtfaPrVHlbFzVGNtcq2tLtjqp5RNLe34/Xkys1GW8sl8nTiSChTpxT3aoSn3tmSfL4mTSPxGHmTBSz0U5NfmVk7g4KuwqCUl4Tixsw8XjDTNZ/97Fqgx/a63gVibJXuAhhv/13r4HslVS17lCglmQW3K21y6Xjk+74/+14rZZKbVZJMTZ3OBuk/KKJKupM22gLah1M06CeyXnHkgB/BhFpnKLm74P84dhJeoqup1I1gOGwelagO0ZeHK9HnwZMJfU3e/qCth1AzUQ1Cu0jCVd1xRn9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7H6bykLNCjqEbc8VWrWq5mX4GDfbfJGP9WkRB3rP+Lw=; b=WyOfnAC964MYvLFRS3bMiWbf/xNQzBlFyhUX2ky7NxRuv0nYn1rurcQR4XP8IVP3ph8KdrWvQSeYTROg+Xpv7gGwLtRIex1jC/wa05gG5OWXAK4UA06b1s6UVhQbWOCi/TL4ertnRZ5yViljAw7aQV5INnIB6+VLaBHmziDle92BmzpKoVq9Q7jDZPj3N7HJ8wUIK6CVTtXXVC2wxXm/VkQQQ3OwEJwKa+wE1vvYcJCd4Stj0RWhNZEAOdMWYY8ANW6pN5DEpQ5MKk000D0/0bAeJcNIx+6a74kG93HkzNT92uCF9aLBVAYuPukhf4uLrVbFRyuRJmRduGPjF8gZ0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by SN6PR11MB2814.namprd11.prod.outlook.com (2603:10b6:805:55::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.21; Fri, 27 May 2022 06:40:22 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::c1de:722f:b4f3:91b5]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::c1de:722f:b4f3:91b5%3]) with mapi id 15.20.5293.013; Fri, 27 May 2022 06:40:22 +0000 From: "Kusztal, ArkadiuszX" To: Anoob Joseph , Akhil Goyal , "dev@dpdk.org" , Kiran Kumar Kokkilagadda CC: "Zhang, Roy Fan" , Umesh Kartha , Ramkumar Balu Subject: RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next xform Thread-Topic: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next xform Thread-Index: AQHYbBe2UHM2F4o38UOTiTgBHrrEV60t5jIAgAA66bCAAQG9AIAAB+NwgAAI1ICAAxCQAIAAC5pg Date: Fri, 27 May 2022 06:40:22 +0000 Message-ID: References: <20220520055445.40063-1-arkadiuszx.kusztal@intel.com> <20220520055445.40063-12-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f0f54e26-c224-48e7-a794-08da3fabc637 x-ms-traffictypediagnostic: SN6PR11MB2814:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1tu06cDcLsAHniVi1a1czXqZV+BfE0EjuQYe/mbXVa3sFaXx/VAiWMNoBdxwUQ8njcB5mkQUkk1fjk5iW0DYDgqGW6ybB0Z3QAkwtFU1FrUN8eakZWU165WT4cnM1gsYwb7Uh/6HYsBaYnG+Xf5jVZZT/1aIKV2x2T7iHx5Pk6BMPeof2kcc/Yss+ih5DhvxO+wPZwaQ/elVD+vVM4Yb5m6QC6XVWBkYC2ebzrDk0Uhq7BcptX1FtaBDJAL8qyJzqgqUVfITvzzidh566EZKQqSOqM4JXJMJRj9HuvuICbdmeajbjIZd7HWd1BLvpL9yuKiUXPFUXUmZYmFJgHEjoWOhml+D11tj08J2IvQvPrBQXdYUFZTxi017rUMyYrmTZpe/gXg0SNXgKAMmgNSDZU5ARADhGOUUqqWqiahIP3PdZhmlKyj/4NCk8jqOZZLU+lkrSkYnfVfyTPzZRYpi114d0x8DXvaRjob3VXlRnCViiFZsFx5MwSnHt+1bS48ee91Tw5tdF4Jnj++6fSmtMg56sx01q04lcZy5Mx7RtTlGiXjxqKKj1Ek4iovVyKXhqeS1BxvmXJT70GpqcjDuWJFasqhZ2PqCcqBxeI3zhEPAC6wQdJhfI7oZ92eTonTiH8jF2rZX4o2MINaDia155FI1zXpD9Z/MudK/T2rlbBrRtMFrY/J0Yc6hRMG75PXBwqiLGRZb7LBYLyxC6KB5U0YPzqloeCc18F7GESCyfqKXeDcl4MtBjbNfT21snn8rmrCAXL54XQgl+tY74LVeiKVP25nBNL9lyQgyjTJ7E4o= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(2940100002)(8676002)(4326008)(55016003)(71200400001)(83380400001)(64756008)(76116006)(66946007)(66476007)(66446008)(186003)(66556008)(7696005)(8936002)(38100700002)(52536014)(508600001)(122000001)(966005)(5660300002)(26005)(316002)(38070700005)(33656002)(53546011)(6506007)(82960400001)(9686003)(54906003)(2906002)(110136005)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?V18BZxW2cdWareG0JePacjfTK1I9LKdIiDCCyq61xneIwlLVFba3qAZFcDn0?= =?us-ascii?Q?X4T/RNqqE93pVLfx9AhMbx/D13J40y/q/akzw6fhN/Mc3UuWRNE2udOoUF1U?= =?us-ascii?Q?ta5Z5nPi2tax+sFclytFG1HVy1R2SUDe06B0UcYEIdq2l3c7eu/YE11IAn6T?= =?us-ascii?Q?9xFy2wOZEcZP/UwQlj1paS0lBWmySzjq0xsYiSf5WUiga57H9HKh+zWvbbxY?= =?us-ascii?Q?y7llMWceGULHuGM7O+ye946qIClBvFvm9CPXkH5O6vYsuuXT5Llh8/U+RxSk?= =?us-ascii?Q?A/vl0Y6JvpMbdzqoBG71M7IxOJL61Jl6L1sdgaBdUy9smyFpTp7DhHt5Iyc3?= =?us-ascii?Q?jXZNl+e+4m0wC+GKfXfOiGPxGKg1YC5ShNXTL3ktK9CYtFb3tPJe77oPa2NT?= =?us-ascii?Q?+xP6TdxzJEYn4W5/BIAoI0aYksgmIvDDkzcK5gmbMOJvArQOBxArk3f9hPQg?= =?us-ascii?Q?jIZYwQukBT12P23m9zERTBvrRAC5TFuQqB8Ex3Km34G/iKUQnCpLV2qb/iwJ?= =?us-ascii?Q?CnlNWisFs2yT4w8SqAeTcWCGf0zK/7kR8CVlNGp4cPGpEqcEkF8AnNLRgVp2?= =?us-ascii?Q?M2kee3hq65U/rfZ5Bnlfu2PjEJBEEPDT8qdQqfB5jk3aTo6vgB4lDdgV5Ckh?= =?us-ascii?Q?Nd/ODoERXEf/UNSKTtTMoVy0LzEMDYnnB58TUG+b8FuWt8DuJaauKmAtmdK3?= =?us-ascii?Q?cmyD2IwM0+HnpHVA7JTkRTgzCgJikldhNzqzDyz/YaGUlwkFtNsK2CWF1krc?= =?us-ascii?Q?o49j3ruBZYHYTWGsdz1habVrGnn8Qvs8vN1Vrg5Y+csOSFvixg4VlPz2iPrd?= =?us-ascii?Q?Hp1v3LlZqBYp9/R5NZIttwDsvbjYJeFbM3ndEH5Etplw3QSzX9mpgh7I9s4Z?= =?us-ascii?Q?ZaBY2F/4+ovdEilQ2nOIzyXZHHjziaVsvC/cQgTdnu54C1GTJZPYcVHllfDt?= =?us-ascii?Q?trtGIqjGZT4ZTJMMck5yBR0stnVEhEIABxNnU3fOf2mGtPmi0X273sjBdbzi?= =?us-ascii?Q?mDqXh9cUxKN+D7+Lj6xyeQ3QzAeKmQw9fdD6CK87m97NkouJI/7nLkJDlwTo?= =?us-ascii?Q?q/ZdlWWbdf38vx1nwZFrDkBylnKQEBF69iJk5w3xwemh0SLi9IxDKN6S7BIp?= =?us-ascii?Q?RBQe4HKZn4gLwpjpGwcnWtqov9GORYhBynyqB1pGz/TsqV1iCbG7vUg7WXS3?= =?us-ascii?Q?uBZTOPy0GEdcL1KDgARAz3OMQLoE4Yzbg8EbIO1+6MK8A5v8O0gvQgM3QHtT?= =?us-ascii?Q?XvnBgtwf8cOlni+2ilb98yTWVj8x4HGClmY2IFZYdwlrjw3Bd91voh4Yxd/K?= =?us-ascii?Q?t00oH4SGthSZ+NsUrCgSWq1hUqeWwM9nSjetd4XUPMtEMinlmE6DOjZ90GOd?= =?us-ascii?Q?vTVwQQPBRLF8zeg3u8S/HClXTHOzooUwv6E7YftN/fa8DAvqmEO/SSiaxirs?= =?us-ascii?Q?4FnuneegDIuUrIFYhlD03lyG0u7hgWsWByGkoWaQKZYm4rpVaX1hO8KeQX1H?= =?us-ascii?Q?JcjFmT0wGDlUlS8RWmWenCuni9RycIOLC9uR4rJD25rHEOTsNVJjSouRhg5E?= =?us-ascii?Q?bze3HmKBcLQNo9V3u8+8AtzSo7dR2KKJpLJDegPbqX3QH6NbydM05dIp2z3Q?= =?us-ascii?Q?mYOdwjLgjgOa3/6QVSJblTKryXU+VMz0T0f5KA9J3sc+txPx7FuN1q5/bn1w?= =?us-ascii?Q?SaFBpHZg6LYF9IfFQ0nlmK67o9MM2tZFOBcLo5jMUPQyU/SKDESHLelquYTL?= =?us-ascii?Q?2j7P4rd6YEUq5mwAq6Ze+MWKoPP/eb0=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0f54e26-c224-48e7-a794-08da3fabc637 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 May 2022 06:40:22.3523 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rNYx1GK2OZSLY8RR39SCSTErXR6AYtXwEs0foCKcN8qUGjxx6pH9zhfUOEI9kkPP+l9bmc3vylet+V5allgqGLYSKbv1iJNBhwwfg98oWB8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2814 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Kusztal, ArkadiuszX > Sent: Friday, May 27, 2022 8:31 AM > To: Anoob Joseph ; Akhil Goyal ; > dev@dpdk.org; Kiran Kumar Kokkilagadda > Cc: Zhang, Roy Fan ; Umesh Kartha > ; Ramkumar Balu > Subject: RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next xform >=20 > Hi Anoob, >=20 > Sorry, I don't know how I have missed this email! >=20 > > -----Original Message----- > > From: Anoob Joseph > > Sent: Wednesday, May 25, 2022 9:06 AM > > To: Kusztal, ArkadiuszX ; Akhil Goyal > > ; dev@dpdk.org; Kiran Kumar Kokkilagadda > > > > Cc: Zhang, Roy Fan ; Umesh Kartha > > ; Ramkumar Balu > > Subject: RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next > > xform > > > > Hi Arek, Akhil, > > > > Please see inline. > > > > Thanks, > > Anoob > > > > > -----Original Message----- > > > From: Kusztal, ArkadiuszX > > > Sent: Wednesday, May 25, 2022 12:06 PM > > > To: Akhil Goyal ; dev@dpdk.org; Kiran Kumar > > > Kokkilagadda ; Anoob Joseph > > > > > > Cc: Zhang, Roy Fan > > > Subject: RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next > > > xform > > > > > > > > > > > > > -----Original Message----- > > > > From: Akhil Goyal > > > > Sent: Wednesday, May 25, 2022 8:06 AM > > > > To: Kusztal, ArkadiuszX ; > > > > dev@dpdk.org; Kiran Kumar Kokkilagadda ; > > > > Anoob Joseph > > > > Cc: Zhang, Roy Fan > > > > Subject: RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto > > > > next xform > > > > > > > > > > > - removed asymnetric crypto xform next field. > > > > > > > Rationale behind having chaining in symmetric crypto was a > > > > > > > fact that encryption and authentication are usually done on > > > > > > > the same set of data independent of algorithm. > > > > > > > HW usually will be able to handle it in one PCI call. > > > > > > > In asymmetric there is no such relation between algorithms, > > > > > > > therefore next field would be useless. > > > > > > > > > > > > > > Signed-off-by: Arek Kusztal > > > > > > > > > > > > Please check documentation > "doc/guides/prog_guide/cryptodev_lib.rst" > > > > > > Not all asymmetric crypto xforms are supported for chaining. > > > > > > Currently supported asymmetric crypto chaining is > > > > > > Diffie-Hellman private key generation followed by public genera= tion. > > > > > [Arek] And why do chaining when this can be done even with one bi= t flag. > > > > > > > > > I believe it is OK to remove next. @Kiran Kumar Kokkilagadda/Anoob > > > > please confirm. > > > > > > > > If we are removing it, then documentation should be in sync. > > > [Arek] - although, we may keep it for now, I am not dropping it in v2= . > > > DH priv + pub can be done with priv_key.len =3D 0 -> similar as 'k' i= n > > > ecdsa when k.data =3D NULL. > > > But I do not see any situation for now it will be useful, it may be > > > dropped later if not application found. > > > > > > > > > Also, currently API does not support chaining of > > > > > > symmetric and asymmetric crypto xforms. > > > > > [Arek] - This is one unlikely scenario to combine symmetric and > > > > > asymmetric. One I can think of was once proposed DH + DSA > > > > > integration for random number. But not much else, although we > > > > > can keep it around for a > > > > while. > > > > > > > > Yes it is highly unlikely to use this combination. > > > > [Anoob] We may need this support when we add EdDSA support. That would > > involve a asymmetric operation after hash is generated (symmetric). > > https://en.wikipedia.org/wiki/EdDSA#Ed25519 > > > > And, asymmetric chaining may become useful when we have PMDs capable > > of doing more operations together (like the case with EdDSA). So my > > preference would be to retain the 'next' field in asym crypto xform. > [Arek] - that is very good point, however to implement EdDSA as chaining = would > mean that: > - we need to implement EdDSA internals in DPDK > - and EdDSA (in hash option, where actually picking hash would have sense= ) is > not one hash but multiple hash operation, so we would have to had multipl= e > chaining with operations in between > - and we would have to compute R and S separately. > - If PMD does not support one-pass EdDSA - well this is something that sh= ould > definitely discuss, but having any crypto internals in DPDK is not probab= ly an > option? [Arek] - but, I have kept 'next' in later changes. >=20 > > > > > > > > > > > > > > > > > > > --- > > > > > > > lib/cryptodev/rte_crypto_asym.h | 2 -- > > > > > > > 1 file changed, 2 deletions(-) > > > > > > > > > > > > > > diff --git a/lib/cryptodev/rte_crypto_asym.h > > > > > > > b/lib/cryptodev/rte_crypto_asym.h index > > > > > > > 1652a434a5..b355cbe5fa > > > > > > > 100644 > > > > > > > --- a/lib/cryptodev/rte_crypto_asym.h > > > > > > > +++ b/lib/cryptodev/rte_crypto_asym.h > > > > > > > @@ -492,8 +492,6 @@ struct rte_crypto_ecpm_op_param { > > > > > > > * Structure describing asym xforms. > > > > > > > */ > > > > > > > struct rte_crypto_asym_xform { > > > > > > > - struct rte_crypto_asym_xform *next; > > > > > > > - /**< Pointer to next xform to set up xform chain.*/ > > > > > > > enum rte_crypto_asym_xform_type xform_type; > > > > > > > /**< Asymmetric crypto transform */ > > > > > > > > > > > > > > -- > > > > > > > 2.13.6