From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51DF745C25; Thu, 31 Oct 2024 18:25:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D32A640265; Thu, 31 Oct 2024 18:24:59 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by mails.dpdk.org (Postfix) with ESMTP id 7466C4025A for ; Thu, 31 Oct 2024 18:24:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1730395498; x=1761931498; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=JvCkbrurdz+qd5rIijgYSjXo/TaR/YI3je58poy5RyE=; b=IehwsKqeqcPrPdio6cnwlnIUMxpKq7+0TQY2sJDwNG2FZQyOAPy9DaIQ zK9S4qMbhC2PzNUbBzst8zHcSpUCe7A0lzdH32hVTgghE/MRpZ+h83KXQ 605F2CBMYrC5xtRW83PFW6w64/wEUgmp+xRMsWYSLL54avHjLujNZIotQ V174l5YYdU0FeOvQleBweCxzhKqJXsUomGBt4IlKsejnINk6pn989GaVR jSkAfTDtesPlGirJ0TcWP2uPSrt15NxagMRA3LhQPUu77xMg6W5co7uFj Aqb7qEr76lZZIaqUxmxmIIW9QV07AdTeIBZiTksNTEiE6kvYsfYMuwleM g==; X-CSE-ConnectionGUID: /rAvhL+eSau6u07QaSvBSg== X-CSE-MsgGUID: gH63UuLOR1+WIHnozp7OvQ== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="30008158" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="30008158" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2024 10:24:57 -0700 X-CSE-ConnectionGUID: K5UWXcB2QY+5wJ+/N9BGqw== X-CSE-MsgGUID: CfvmfKl3QWmEpmF7ZcnVOw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,247,1725346800"; d="scan'208";a="87247992" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 31 Oct 2024 10:24:57 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 31 Oct 2024 10:24:56 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 31 Oct 2024 10:24:56 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 31 Oct 2024 10:24:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AyplF6e6Ys2VbMVj4fx7ZvNr4siGK6oSA+F0rIuvvBC+dva/BEnk97JjsI9kq7EjCnwH8faSHfIkQq8wi8XuIwGfmSuT61KPGudYIaDdDHsxpLRRt/f98t+nMCRO5A4+gOaVgP+CcTPsXtiBFYR8avb0tE9DFJPifNELqzSm9pyBPFgKNOddYwek2zd4Euge7sohXMA+K9xXdZiGAL2YU5ZIAcqZi4xZhjNdmlWw5wgrIoPDAOMPI0cOpaJukF8GiPTp5H4aWxjye1f6Ie82eJK4cqmBhmvx8iHW924KWeSGcY9SXBK/WSpZ6O5SwnJ5wMqhrmZUNmOXBWGO6Oy4Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UlO7REdLfxEdNYUAfesQP34+XwAMbZz8J2DzUtvV39c=; b=oEpYvRF7jQLFAwq0m43WKN4lG25hC26VbuJ7vkX1nwlnJo5/VUOfavYP7IQasrWVBV/v06jryf1EciFIL5IBPy+EqE+nTL9UcUHtqaf+wSekf9IHpFmje+m0BpAiABt6SLPJOUSC94ewtMRW3ZJDgl5cdzSPxiymGDhdt2dJOzrTPMYHmKGRuGod7HbxXKEr1HYBrJDefFrqCYyIV+YFrZEiKSAPvbIpMVBTUL+RrldCNsUDq+RQ+LoX4g08g7vCu9NnW505BOgSQckWplFllV1ImVFSqlIF8bsPqqPgZd/KSo3gyihmsGgJ2YqOR/e4aE4SjQQ5ipnY61w8dA4Ylw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by CY5PR11MB6368.namprd11.prod.outlook.com (2603:10b6:930:38::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.20; Thu, 31 Oct 2024 17:24:52 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::1c54:1589:8882:d22b]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::1c54:1589:8882:d22b%3]) with mapi id 15.20.8114.015; Thu, 31 Oct 2024 17:24:52 +0000 From: "Kusztal, ArkadiuszX" To: Stephen Hemminger CC: "dev@dpdk.org" , "gakhil@marvell.com" , "Dooley, Brian" Subject: RE: [PATCH v6 2/3] crypto/qat: add sm2 encryption/decryption function Thread-Topic: [PATCH v6 2/3] crypto/qat: add sm2 encryption/decryption function Thread-Index: AQHbJL/sXw+g8LaX10KbHhGgrszCybKTgJiAgA2olyA= Date: Thu, 31 Oct 2024 17:24:52 +0000 Message-ID: References: <20241022190600.81169-1-arkadiuszx.kusztal@intel.com> <20241022190600.81169-3-arkadiuszx.kusztal@intel.com> <20241022174651.7cc003ff@hermes.local> In-Reply-To: <20241022174651.7cc003ff@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5013:EE_|CY5PR11MB6368:EE_ x-ms-office365-filtering-correlation-id: f5e03e5e-3278-4156-1734-08dcf9d0ee12 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?W+z0mRKCadCrqMVEprFbiixA1GUFzQAjdw95Y90/PCQtjcvRH8P5Ig4Lihs+?= =?us-ascii?Q?/ppaj4j0wuO8HUNXudGmgpU/4eEmu1JPlK73egInp0vvKvxY7wPdUOo4qeI9?= =?us-ascii?Q?az4dDHM9foMvu9m/Kfv0iclBiL8ZMXwXPsF3vzZ+WQcIbI+oHPpRBdzaoL3s?= =?us-ascii?Q?qwUkQ+iKjuDbJPM/Ae6sZ74N3/4B7lojBJR5CA82cF9UP05Kr77xOEtzw03S?= =?us-ascii?Q?8ZEN/iFVLUjNeH/Upk2eEF+LVqxHrq3RQ8GDiFenCFvTMHJ1flcN+WmUunMr?= =?us-ascii?Q?3SPUkl/8iH9S/jQSoyg+gV+XK1A34ve9wNKPz6KndTVkYQNFYTkURRec3VEY?= =?us-ascii?Q?yhVr0W4sEkn34XNKw8r/XcN0FnDnAaDzo+CcBa9OkDYSrSQw7Edx2qS0XVq+?= =?us-ascii?Q?WGD/tBo9yknO2du2x9MrbBLeLAbPq8ooKZPdgZSKqFPejmAA7PNvu5dpHx8g?= =?us-ascii?Q?Md8rQ/pgh0Gn46AH7yabuYbsKdpUcquqHbcUmoN4FmOMEr6ROHmKRf6E57H0?= =?us-ascii?Q?syXD9x3DFB7wbupP/kz2HFO3mF3cJNoRDiL9mdqIBidUaIIzKWINmwk27BYM?= =?us-ascii?Q?kbAidUSpjXxq3aiqtfqvIKyORW9owq1m9VZs86oTxNamhEd8BoKuDkGlF0e+?= =?us-ascii?Q?onJuV8qP58+OZoP2f2L7ypdEXjSOJJKIRnZ6nFa2AWlGt4hD51Wn3TdeH41E?= =?us-ascii?Q?DiKFNgmBxSchuNrhTJxo+c+Qo9kAOvEyt/K9HYX82HKvF1r9GRAP25fp3LPj?= =?us-ascii?Q?Sc8asSp/8YuC45zV0Jwpv7ZYrFLL2UnABgWSWi4HpT+Py1AIpUyjBX0rHON9?= =?us-ascii?Q?e0mn5qVeFcgE28H8OCrbfn+XzN/SnMtQ8xA41JvofiIQ1HctjA8UHe0+EjxQ?= =?us-ascii?Q?SCiqgfjp5JXbHgLHmEsNK4a0TC75LItnh7tGgFs9TKJP6AKPa+d7wxRfen6R?= =?us-ascii?Q?JCYLEIXo+MbpUtU7gzyRz9x5vrSIW6U/aO8shyTyqhrW1ZX9+39IhZj87h/V?= =?us-ascii?Q?KTy4Hma1gn9oX6rA34uQ18VnnC9ncHDWo2d9Av/p+nS5Frn3J7ciBFaPnBQF?= =?us-ascii?Q?uyQQejPQyWguHieOoGNzFj6vJ2NyTPpa7d6I8//2ulo6YH72bfuMiUOgw9n/?= =?us-ascii?Q?mtQDJiKfNMkzEH7pRRg9gJFaiF0ZShvAgmuof4PT31OJ/8l4oGN0D3FspFjB?= =?us-ascii?Q?IO3Z5HBgrV5CvIqEfGZr49XsXIj0z1hnorXQoLJlL+8NqAIlJcz9cbraPrh5?= =?us-ascii?Q?h+POaOWp1OB4Nr5fl/g1EoaY8P4ndCq5AKa1pWm3Hto5/cIdPkA7aBKMYlFG?= =?us-ascii?Q?noa1sKL5crJm25vIZJcFayq0rMhP4ksGr5SZOufyCFCHKpICQXEuUpxRSs8z?= =?us-ascii?Q?GUITXAI=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zFOQblosdxStM10pmUPzZDTczeStl9PEtmYV2bAGau0QhMCSzNaiB0ThqHeq?= =?us-ascii?Q?hSuTh3jjxbwN5TPsnA88NzYHYWgwivtk+KufDPZJp7uiQrLZ6r8oK1qGjGpe?= =?us-ascii?Q?vtwDFv+YUinWYMzIcyBTZ9qHxnmU1avG2JztuPyC8SBZ4XqDqoN+bUF7rS5+?= =?us-ascii?Q?HGbafDR+E2OXusG/ZHchTnQEBy1S1rG69yEI2o0SJJOrpiPymC81DQKUPPi7?= =?us-ascii?Q?9zNJcECtOcIWcC2N2Opa+gawSrbjTfeVaJxP2n4Y2X8RiYNLDjhJPxzeVzsx?= =?us-ascii?Q?Uy4yhtBO0VWEISEIqKTX2xQSTfghxHGPmLfp/LW8pZwmDjE7B5bz6PwTsbPt?= =?us-ascii?Q?USTn8gC+6qM86zrKx7+FNf6sQb49ak94TWyswHfmkO9p4scg1e7WwrbHGNwF?= =?us-ascii?Q?bJ55HIaZOefIkkE4qNqMaaMZ53PTZuoTlpIscF14AshV1xMVoZ5wy+NWCEoU?= =?us-ascii?Q?ULJm2K8K+s4OkoJKu5/eeJBG2I4PyMCd3iLegPs3Ex31RB/PwVZHxwnNVI3Q?= =?us-ascii?Q?8bLJsya+wVxV7vCPXtRMcxj44sdZNeilHB9yirxmTiq6L+Qj2e5Yhv+7on5k?= =?us-ascii?Q?EnnuyPFqIQGhv8W3v9Bd6GbnhorPyHkldZ8SiP5AGDtwIB1djrK/oeVDjEEb?= =?us-ascii?Q?LakJgRVAZwNmVgVJAHOtaSVzXT9I1lb6gZQAmwGL1XfTJiTMW4vqIJWUwsec?= =?us-ascii?Q?9arybWaV0ujCCj+llj3gkWOpVwdY+5Qzf8MqYa/9rCAgBv0bRjTaUF157OZ9?= =?us-ascii?Q?33Uw6fNzAzZinw/jAlgc0Hu09KaZFKzv5j+SA78LP9LnyuXPDm/G9m4Qet8/?= =?us-ascii?Q?AUgiqpkg6HU+4d2wJ1t7HiSpnqbO4aWIbQ8bZ1dxYNZUKl9tpMr+rjRM0iT5?= =?us-ascii?Q?d4t8oiug0z+/y3YmMhs/t1OyF3w//pzijeJDg43It4HjhF84qTXy/0K5Gw/7?= =?us-ascii?Q?3ojAfKPg5+gaLdC/uS/40qLnR/4BfFfift2N9xE4fdrSeUByRJxQ4AKNgVqY?= =?us-ascii?Q?zcmnwJYwFhw9mMPlMfgrpYhIQOi58E/0CebZvlUlY9WRhnOYIGfdfMw6Sqhk?= =?us-ascii?Q?G2Z4q+Y7eEGF4xCAeKclYky2ku3WkDmLFxuT2GH3zkGGZ0ls+52w2Gk2EhX/?= =?us-ascii?Q?c6u92Egz29HJ8S3sGPr7k/iIXnFv2fzWHT4SU2c1V8dRpRhTVAIqRTsaMR0Q?= =?us-ascii?Q?bDfBGgMONQGQqxKc7frlRhDjRBHxixrilNEi5j/QHDWjL0JhqmAvLKmyYXZ0?= =?us-ascii?Q?TOGu7W34oRc7kJ/b9jwpk6pTuHgJGrLcTBAOJ7TnxpMJo54h1/cfxrah0WeG?= =?us-ascii?Q?iYuDHoyfIajns4W/K5BKDXOf3GhgHFmomsaSwFhZbDqw9Csk/xTy7azE5pJd?= =?us-ascii?Q?Ao1bKV3fv+A0hh7td6rWlDGywWDFZZzjCe1Qw9ty6HGfPmbaU36D01XzH5rn?= =?us-ascii?Q?uPg9CmIwzwCMoXhrlghmPlv8Mt5cIuVkKkZ3XuatI63/Y5r+Dn5vv7FNQftR?= =?us-ascii?Q?LHZXh6sMmBrvHKMT/xAdVKFk6YNmoKv/ixfxizwkqxKg3i/rycO1UEBKFncu?= =?us-ascii?Q?5INNjEeVVCKufKqzj44xxQVFj1yZuwHGfGPNB5AKepb5xomFY3YK94XpR/IX?= =?us-ascii?Q?2Q=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f5e03e5e-3278-4156-1734-08dcf9d0ee12 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2024 17:24:52.2075 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ilh081sOn/Jzwf3+/p73vtgGdxhb3+YKcwtCxvPRrmrl6DUqyO9if2yHW9brHzYC98aAeuKZmIktLEWN1owRrmv8WGvFuko04r6vcPxRAUU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6368 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: Wednesday, October 23, 2024 2:47 AM > To: Kusztal, ArkadiuszX > Cc: dev@dpdk.org; gakhil@marvell.com; Dooley, Brian > > Subject: Re: [PATCH v6 2/3] crypto/qat: add sm2 encryption/decryption fun= ction >=20 > On Tue, 22 Oct 2024 20:05:59 +0100 > Arkadiusz Kusztal wrote: >=20 > > + uint32_t alg_bytesize =3D cookie->alg_bytesize; > > + > > + rte_memcpy(asym_op->sm2.c1.x.data, cookie->output_array[0], > alg_bytesize); > > + rte_memcpy(asym_op->sm2.c1.y.data, cookie->output_array[1], > alg_bytesize); > > + rte_memcpy(asym_op->sm2.kp.x.data, cookie->output_array[2], > alg_bytesize); > > + rte_memcpy(asym_op->sm2.kp.y.data, cookie->output_array[3], > > +alg_bytesize); >=20 > Since the copy is small and not in the fast path, there is no reason to u= se > rte_memcpy(). > The memcpy() function is as fast inlines and has more checking from gcc, > coverity, ASAN so it is preferred. This function is called by the crypto_dequeue_op_burst function and in some= other cases (like RSA) there may be a 1024 bytes per copy operation. If you think that a regular memcpy will do no worse there, I may change it.