From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D54D6A0553; Thu, 26 May 2022 14:14:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7A18F40151; Thu, 26 May 2022 14:14:32 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 001F040150 for ; Thu, 26 May 2022 14:14:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653567271; x=1685103271; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=+jPfA++qLtC+CyUhkWTV2XATwKZwSV4Vqkwi6UHJm9A=; b=f2v5EGbYzf9bYcdRuoQRet7QMHWnHOzdb6aHYl3wgFlX1DugOPVuaC39 XEuW2DWPoMeTT7d5FnpHVb8lx9GYP2TVBQt0osARNpIwpmX5BYJIf1pue wsweR0JXj0A2iRJXvrMixILSpthZzEmOnl3kfkqszqQSoSC2FSpDrs0J5 RGCvW5iaCiTQLrp/UNuc9TTka8segvUxyRP3rzoi3bQRxFEfF3+pt03uE BTLqBDB0QeSSg2kN72vzO8EL++uiYuIEIIBtdaeMNQQGH3T+3fGVDbSBZ MbbBuZvjc1OwydkecF6Oyr1GQi8vuXE8ykCBx8C7SYQBG9F4eG7X73fjh g==; X-IronPort-AV: E=McAfee;i="6400,9594,10358"; a="261752092" X-IronPort-AV: E=Sophos;i="5.91,252,1647327600"; d="scan'208";a="261752092" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 May 2022 05:14:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,252,1647327600"; d="scan'208";a="609667567" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga001.jf.intel.com with ESMTP; 26 May 2022 05:14:28 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 26 May 2022 05:14:28 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 26 May 2022 05:14:28 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 26 May 2022 05:14:28 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 26 May 2022 05:14:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PIXsj8piNVE+2E+warka59t64MQBqB2p7oaC4eGujUKTqwzrNkp9n1NRaQiqhqYhbFgM8JqJYTqhXgfwUGjeRBsYHAzebdRFcuOBIidY/Afn22Gu2E6yfgON8frYwgSjdyzcfJ1KeOkapVu+sKTJrcmcGT+RZiyZ7l0ZVr3NNC51MKquQ7FjiBSQQXgF8L67t2uWftZlM4DkX8XyeexPBo+IcjcSNnqSZw6d80q77a0ZUC2mH8pYkTvYis6y6GgQZraaflFVj7uKFUSQcnpSG8SFTuSrzCb9fqg+djHUcv2O0FsZx2O7aJjad+8o2AbZDTvdQB8OMaK9lVNoLRSloA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vgcpgBkkRqJ4xBVVFfJ9uo3J5kwvgYg/E8Re5Vp0Gq8=; b=JFdCoNd/ySDLBn26exBR7jwNqUOFa+dScrYnQcD6OB6+8wHNjZq8WPf7UuF7Gp6ej/fotEQ2sIAntpSAIZf/pIk2i+N+raQ6rUaVqLfx3O0X+wxxfHTHxk3LcYIqitu9CQm/ciMZh5/TwHuapCKfDAy0JR4/RhuMXpA8Z9n/2xjY/rlB3NLI1Q/D0EgoolGt3M6pF0cNXEByEnkEKXSg9MfUZWf1aJ/NHdBQ33rc1SKRX9Pxh6v8CpEPjYdHJ2sCSeSJBfv2s0eULFCE6PiqWjfbVvjKD7v5v0g38jxDnNcWwc9C1wJ8N2vI4XiyUFq69o9b+xJdOSCpuXZh4SfE8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by BYAPR11MB2789.namprd11.prod.outlook.com (2603:10b6:a02:cc::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 12:14:26 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::c1de:722f:b4f3:91b5]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::c1de:722f:b4f3:91b5%3]) with mapi id 15.20.5293.013; Thu, 26 May 2022 12:14:26 +0000 From: "Kusztal, ArkadiuszX" To: Akhil Goyal , "dev@dpdk.org" CC: "Zhang, Roy Fan" Subject: RE: [EXT] [PATCH v2 11/14] cryptodev: move RSA padding into separate struct Thread-Topic: [EXT] [PATCH v2 11/14] cryptodev: move RSA padding into separate struct Thread-Index: AQHYcFkacP641dZ6KEq9ne1qam1Qaq0xEOUAgAAAzTA= Date: Thu, 26 May 2022 12:14:25 +0000 Message-ID: References: <20220525155324.9288-1-arkadiuszx.kusztal@intel.com> <20220525155324.9288-12-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7fadc8e8-3105-44e7-2e6c-08da3f1146c4 x-ms-traffictypediagnostic: BYAPR11MB2789:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DaajvyFehd7hBBbyTI9h/p6+zxu5dBd+ZwJGpSGTYMchARlr/4+p6y+JWj6L1JTsLid8DACfm61uTx2iDH5T1O7dVPwltueiReEsjh4hqQ2T7xgFouEtvk4+saNyfjEDGDASEM5Byfu64RK362CsQQbWd7R7beCRxK4hVJ+YD1lgzQ4eoX7GHrOl1K/2s9hLlAypVZPJEXw0BGk0m5VQKs9ANuSh0olr8Zy590zXtYDqwioEavUx17wfga1Jh6q5SZP1B7TVF3CCW+6EOPEftROb2sHvq5DzOCfNQVxrvCrr/jbmfvX3iiE+SLwQQltESeJbUGZHFPRryaMafKgoT2JSoP8tHVCi8G1PLSOXsX5iV5wARR5oqQRXzoFkL+9WfTOk0O7HAaVlscYgoTvdzD/apWw7RajTn4iuxTwm7jTPmOxVdcNis3EzgOvQP4pgImSalkp53nq3H5rmRcxFLEiJoCBOfQxUnuhiNBjIdf4690e6mWfA/iL/9cPjH6i8FgLKvDPRK0fpY0MXeRfLUZRyCLlY/6H5YEzyJcqPNVa30elDXJ1FfRp+HJLtml90Y1cS1PRDhu2ki5QkrbQ3CE+xKpGIZ0TqGXD9lOA0ZRW9xyjp1jAKlg7vwBGl9Xvcyiv+MMYtq36fbUT3VwRtVthFPu+T07Btd+GmDC9T5uGT2p661Ftxg4SK+1ttlyIx4vwWiR79bNx+Koj15epokg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(2906002)(6506007)(86362001)(7696005)(53546011)(9686003)(26005)(38070700005)(8936002)(52536014)(107886003)(5660300002)(122000001)(186003)(82960400001)(508600001)(83380400001)(33656002)(76116006)(71200400001)(38100700002)(66946007)(64756008)(8676002)(66556008)(4326008)(66476007)(66446008)(110136005)(316002)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ASOI21VssniS8lEIa/dORPpSQu+wCJrPkvV3ozkZ6h7fEySBoSURKqRXhPZ1?= =?us-ascii?Q?HEuIe3UKmg3guCgldDPynmDnPehdDAZnWsg7bh3o6/io1yMHO7RnMT5DwyZY?= =?us-ascii?Q?mvhfqd67+QdaBcywYM/LC8o6d+CW2T9HoYSciEv0VthdoSblLnhVj+4hGspv?= =?us-ascii?Q?GTe+QV4+XzDVU1Wuy8stlpLzIe9AvKD2oTS6x3mXIbj9gTr0cm8EMwjZ1Pol?= =?us-ascii?Q?L13RDYXS8qGpu4aSamKm3fZnRN7q0Y/NjLHawYQLXvFmBsqt4AQXL2p5Je0j?= =?us-ascii?Q?u2A4QWsw6iO9HOKlPIB7MbTJquHsQVtKf1Ksn+tNjJfx/amfrPIPUlKor1g4?= =?us-ascii?Q?r0sLJzRVkWS8q9wQufvD8ynGmoLpVEJwyAvAb0ImzlNkzUG8GFWP5GTxDKcI?= =?us-ascii?Q?gI4ny5qe4VAN/fZPQlD4o6EIRsVnmC2C4TS7Dp2ozKQysUz3tBG/SJf3iUqf?= =?us-ascii?Q?SR2zaPFUhFA8BtAWhrKNXaH0rgYJ6Fbz15mNSHxjcM1GT6lufR6WwVe8S2bT?= =?us-ascii?Q?Xhgc/GomDBiVu66ahX62fXwINSuTLJEsMyIMdok/QCbyDJgw8M9dfBdbhbHj?= =?us-ascii?Q?zpB0TsV3un41Q1jAH1yWvqRRtPWLusPd68z8OZVMgea+YbATRfTfE20QHQhZ?= =?us-ascii?Q?CpyhhJ19kQOB8ROQSQxTodSDnLACshZ4VsPkLBYeonMt6ZJdvP8P3n3jnyUf?= =?us-ascii?Q?E+Rsd32/78mHs5GiDU0V+Kup328HRw7K2OKAZTFSYrRnaj8IZpcdXQEgiEl2?= =?us-ascii?Q?3HgcBNTGXqkXQ/zjAZpzQROCyaT+pMi6X2rC1IUfe/9TKgH1EH/iFpYuJ3Z1?= =?us-ascii?Q?y8Kt+iJz/fZC1x5q8lF00qogHsC+8SmQyEYLBj1KCwe9l6aZhVsnkcvJa3JN?= =?us-ascii?Q?24tzf3tDuSNPgRcxlyP2jOHvraCwr/XgH8rOgvY+ex/bJOws+rW8BP+LW050?= =?us-ascii?Q?IJeIAgJ/jOeHiilcvmXq4CNGY9PwaCrtqJmjyrEoMe3/9hTseMP7fmomMOJV?= =?us-ascii?Q?kYViWRGarKLzS2Ntz7Ld7H8GIiBHCSQO7SZcYXVGgPa/r5Xl5IgFMhr0UXcc?= =?us-ascii?Q?kDwCekFu2G+0Kn605To01y2ZtUWmvKDoBTS6/IIJs4XspnZq7/D3Sd2e49fJ?= =?us-ascii?Q?6c5D82QRAIzwUbwzhb7PCVBoKlT3bEgW4Yr9DZ/8wg8cH5NQx2HNhviCAxb4?= =?us-ascii?Q?Q1vQ4GPae23ONqmLq4QIowGYty2jJNUy6UfBEk6Jcux+/xN2eJ2YOVFDbX06?= =?us-ascii?Q?PdNBmWQgSss1uE3W6l8L9MxYKns2zOD0EiVh4tF0BCICpaZlv6kptkxL2n/C?= =?us-ascii?Q?Jg0RrL/CM4Q4/MGvZFNzO3ylslHklzJvJjj8db1TVyFPmL8QncQSH+eDuojL?= =?us-ascii?Q?NU3+1+ptxAbZAwAcWwvujhtIwU85ZhYzMoaNdePmsiHojCmlsVlZfLJ3giaz?= =?us-ascii?Q?g9oD4wTJDXX15SLyuI10MhpgrzjxCPTe9aa+0ytEBGpmMdiMZWNVH5Elfuaw?= =?us-ascii?Q?9+//FVOiqDlYd7AyuonrCuSQvgKMRQ1V/BZTDahI2w19fBgXLOUHYWuw/h/E?= =?us-ascii?Q?vctn3cYwxq/AiPJ6N0ebXjoIcfnVRpYTpsvVlxgiJ8HlxxxocDVWDJuS0gM7?= =?us-ascii?Q?lCbvrIB3RhIhbB8vKO9AlwxD4HC6RFJxm8PwT3wqJtLximEHRSQecvN39tt+?= =?us-ascii?Q?RHZNwDUCx0tzazv362UfN8GvtKgEM+HSwXO9nsVu0UR25k9VGOyegP6bLuu4?= =?us-ascii?Q?7Ig5hOPPYpJm6axdploQpprEDx59xos=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7fadc8e8-3105-44e7-2e6c-08da3f1146c4 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2022 12:14:25.9977 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: S+eNRgtujSFvgClkx3+ILHLLZb8XpsgAeyrOobFGhLNupriIA9U3eAqEPWkZ/LScxFPMKS9/O9HtZnb32QUMsXSsqEsBUhrsK2VwJEsGnuw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2789 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, May 26, 2022 2:05 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v2 11/14] cryptodev: move RSA padding into sepa= rate > struct >=20 > > /** > > + * RSA padding type > > + */ > > +struct rte_crypto_rsa_padding { > > + enum rte_crypto_rsa_padding_type type; > > + /**< RSA padding scheme to be used for transform */ > > + enum rte_crypto_auth_algorithm md; > > + /**< > > + * RSA padding hash function > > + * > > + * When a specific padding type is selected, the following rule apply= : > > + * - RTE_CRYPTO_RSA_PADDING_NONE: > > + * This field is ignored by the PMD > > + * > > + * - RTE_CRYPTO_RSA_PADDING_PKCS1_5: > > + * When signing operation this field is used to determine value > > + * of the DigestInfo structure, therefore specifying which algorithm > > + * was used to create the message digest. > > + * When doing encryption/decryption this field is ignored for this > > + * padding type. > > + * > > + * - RTE_CRYPTO_RSA_PADDING_OAEP > > + * This field shall be set with the hash algorithm used > > + * in the padding scheme > > + * > > + * - RTE_CRYPTO_RSA_PADDING_PSS > > + * This field shall be set with the hash algorithm used > > + * in the padding scheme (and to create the input message digest) > > + */ > Forgot to comment on previous patch about the valid algos for this. > They are removed in previous patch, but it should not be removed. Right? Which hash functions are supported by RSA can be found in RSA standard, add= itionally our list was incomplete. There is no Hash functions enum in Cryptodev -> we keep Hash functions toge= ther with mac aglorithms, so that's why it was probably included in the fir= st place. But I would say we should not specify valid algs here. >=20