From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0785745ADF; Tue, 8 Oct 2024 09:40:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DC36E4042E; Tue, 8 Oct 2024 09:40:56 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by mails.dpdk.org (Postfix) with ESMTP id 04515402D4 for ; Tue, 8 Oct 2024 09:40:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728373256; x=1759909256; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=jgBFI9qQEXPqIR7+Rc7GSmwWu8ZYom91QJWUT4ysQnc=; b=QZJY38isCsS3jxt+9PLzXUpKFDCsWPrdcKAzhqJWWQcA1rYu7bAj9Y1m Q1vU88hsdA7mXN05JzQTKr/CC+IjJ8z3WUdURbBiWsI5qPFdFWE0YUjAR ZhwHhvQcD7xb6eYI6ViMqiIcj/D1A53M3dMRYVD/kBGR/IWe4KpSS6Ugb TLxoVvzfMM/9H3m4O1ro9lo/HY4ctpC7on5ODCFY8tM8Uuc/CO12j8f1h /jlNptiHp1DbCCzrrfSRAKuCN5Q/szyyQDDEUW7kG7IUHbZb1iqrels2j ZHApjDp9KQeC/looHKZGsU6YwgozN5U6we1bK0yHDgrMh9dC6wmFRmiIr g==; X-CSE-ConnectionGUID: isy26YS4TMikK6Qr3FUk3g== X-CSE-MsgGUID: zzdiHNsjTQGX2IiocgEB8g== X-IronPort-AV: E=McAfee;i="6700,10204,11218"; a="38939121" X-IronPort-AV: E=Sophos;i="6.11,186,1725346800"; d="scan'208";a="38939121" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2024 00:40:54 -0700 X-CSE-ConnectionGUID: SuL7KV05TQiPbsAWHDdeeA== X-CSE-MsgGUID: k8X0t6VBQkKidKOrd/MvXg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,186,1725346800"; d="scan'208";a="80165320" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Oct 2024 00:40:52 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 8 Oct 2024 00:40:52 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 8 Oct 2024 00:40:52 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 8 Oct 2024 00:40:52 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.47) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 8 Oct 2024 00:40:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IZxxaweyvbHXJZR09m7dBpR4fVwaDmsM+W/WKLuz11Itba7P2z23GyRYZt3ivNb7JmTPRAS48rKuwdi1kIjnBw8a0KX05w2gc6edyaFWn2AEejikqneqY2kj+Fio8XYkkEPSBwIfLl5z6kx3DhrVawWnQkUtID+AeB6fFGbgsPcphSuPCu/38o7pjE1aqLTG4ulR3lNLnDFp7hpmW0hkcgzh5jtEaEk5py0iXeAdSWXbiwfSWiG2EHcxc/V8nLSAVYXB2dC2e3WxuQ5VDmKauAb8ZL8i3r9X1XTBWEN0LKkkO+KAGe2Akcz2kjeAHKPiZV/tCKAQZSWRywa7yE5hXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C2khAEjVP8hoMe0v/Q+Mx3+bbEZRCvbEOB8dmTVAoJY=; b=dmLcTDN3/4sjkKrzEcGsa2nV+M3sDiX6FR0pT15Veu7FbfDp38Su+ha2vkogJOc44Vpaprw7WlGtVjkhibipll22ECfJcK5nmcKgbFI4FIPVdNfY86Y5mRPKqWzsNNSvCUBNF/K7gHOZ3h3GspQLys0t7m6GW65DgDfBCKLZmAsHyqBRmqFXKo2gK03cMz9w0z0JXt6gMklXECcElwD5Bbiy7MxOytkQWVVIKpM1hRFT8Ag0igIZLC/On+lj1HeUi+0rZ2c5VX1JTfPtUY7AFUc9Y1XIZH2RJ+hqBj06mTHXcNlYV4oTpEvjPicthhaNYMZpQH7LkSm981qo+2TZPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by DS7PR11MB8853.namprd11.prod.outlook.com (2603:10b6:8:255::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.23; Tue, 8 Oct 2024 07:40:49 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::1c54:1589:8882:d22b]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::1c54:1589:8882:d22b%3]) with mapi id 15.20.8026.020; Tue, 8 Oct 2024 07:40:49 +0000 From: "Kusztal, ArkadiuszX" To: "Kusztal, ArkadiuszX" , "Gowrishankar Muthukrishnan" , "dev@dpdk.org" , Akhil Goyal , Fan Zhang CC: Anoob Joseph , "Richardson, Bruce" , "jerinj@marvell.com" , "Ji, Kai" , "jack.bond-preston@foss.arm.com" , "Marchand, David" , "hemant.agrawal@nxp.com" , "De Lara Guarch, Pablo" , "Trahe, Fiona" , "Doherty, Declan" , "matan@nvidia.com" , "ruifeng.wang@arm.com" Subject: RE: [PATCH v6 1/6] cryptodev: add EDDSA asymmetric crypto algorithm Thread-Topic: [PATCH v6 1/6] cryptodev: add EDDSA asymmetric crypto algorithm Thread-Index: AQHbFjcq8F1uDYMpYk2Qxu5bMkfxpbJ7coyAgAELeFA= Date: Tue, 8 Oct 2024 07:40:48 +0000 Message-ID: References: <20241004053059.319-1-gmuthukrishn@marvell.com> <20241004082623.714-1-gmuthukrishn@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5013:EE_|DS7PR11MB8853:EE_ x-ms-office365-filtering-correlation-id: bbab3cdc-bcd4-46c5-32df-08dce76c8739 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|7416014|366016|1800799024|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?1VsRxllvGcJHe47lPsvNsCOcXooa3dEDWGRj0885SnkUVdrWlxdfKGBwK3sa?= =?us-ascii?Q?cRAA0Je5rnIGxXoVMA+3Bl+4Sa0H7DjP1diNyYWLkbyAVeSj9+5HAVdERuMY?= =?us-ascii?Q?A+O9D3nglwZCXxwH/V7vjAtSKOZsmt0MZPafcHOlhv0qTY5FvTj6gnFEmaww?= =?us-ascii?Q?u2jdIxfLsT4sTmjUgnqFE5nUz6/vTGrAuEkre41dBSeOM0RUtgyaCwBAhX5c?= =?us-ascii?Q?iyu8AsE7Iv/xi5omFuNrSSk67CK1/+i9SH3ucRfgssKMao6qcLfjY5u+GZZ0?= =?us-ascii?Q?ZYXKBofv1ymbmnbvlcaIY+ejVDb7h3Az5ye/tq4vpL8rzzyNhs3MesGirdY/?= =?us-ascii?Q?vLEi5kcltIkaET8o+aCU3u2pb9+QflUVekEOt1InnU6g1oc23rCMuCk5metb?= =?us-ascii?Q?dlVVIbyjuWuIufeAVkXwLaX8UoB5z7qbpKsZlTkipt65RjDoVyd9a6BTtMyK?= =?us-ascii?Q?wXLb65ztvErVBGChKiaMJHSyrWO+NSWG9FfkgCfIDCRlgYzBH3nyHd/hPO0o?= =?us-ascii?Q?P/GqxDrpfBFzzX+LuqzTG2KDQCNiWDGtfoJX6fdaqEXKSvfRWwyzXNzlCEP6?= =?us-ascii?Q?7OgtIvIi8k7C7i0d4pPlz7bc1tUf+13v+2dT0VGlA/DK6pUx4nZYoOSETj/4?= =?us-ascii?Q?BCDKu5w5afyvPBne2wRuThD6Yw6Ol8EyUzfxJwsDdy3A6MCd+gjruG4rbVpe?= =?us-ascii?Q?HO/ei6WqyX4lzvas+hou+mMRXsI0xfpkgtNj8MxXjE2Aa1wwFbdP1lkmBzHY?= =?us-ascii?Q?baTHmkm6S/W+/4bEXuPQh72OcI4ykiZVDCoY+UHFjs3S0jRmQ5WA0sCwgvv4?= =?us-ascii?Q?7sAimyJSsnKelil83Ic+Aj9GibBqT+hJS4xetLUX1GMHZWycfzkem+gJal86?= =?us-ascii?Q?r0X+96h639PVHao4LMl3bdMpHE9XWGJmqVC/M3az4+uR0kOqcO5Omcj/NmWh?= =?us-ascii?Q?HdMJvI0CIxxoXj2+OrJXD6QMm45lg4VPo3E94XvzytuqetRkH1DMK+wYQUnK?= =?us-ascii?Q?C17AkQyopjmCIznz8Xfglh9GBWi26exccv+/4xcJ972vQ+fFKsioYUZN/8jY?= =?us-ascii?Q?6HIeEdTwVZ4XKeyHXU/aEBlz58SPeYgI1ppCViaFktwneFzPWi4PhQrow6Wz?= =?us-ascii?Q?YU0GpEK9+D4vlzOgdelHeZVTEIUx8N902SMMstAsEgcKy3MABGRgCoGZnV6d?= =?us-ascii?Q?PluihNs8SlD3BM+9lv9NzjLFV+7uBGjnfD4/QVkJQhbICN8qzxzWItG3Vs72?= =?us-ascii?Q?ZkzFAS9+PJYuojJvvfxKEf/OQCUr+QF2iljQjXficQnRFQg7w7qAbeqDNR84?= =?us-ascii?Q?G4PfJd8KDGD12xg/DsS10JCCUGlTPsFJ0nSkoZb7IZDl+Q=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(7416014)(366016)(1800799024)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?158iikJKa6Of1L4+fR6R1MtoehL+cdhLWhsJ41tQlafiClnvQ+M6QKdAAx7n?= =?us-ascii?Q?Xan++oXg9u7ZaWzqDQ+pkcrVYAIV9l9ShJ+IMsfZytIXdEIOynP0qEbXSZ8G?= =?us-ascii?Q?IfGnJDsXrXySeeL6r7QKNB0eFGPt4XJAyPcFmSSrSLJvYzydqwqCrNLTBBF0?= =?us-ascii?Q?CISle5St2Apzz9WFjtpQKMenKu0JoLOWpCbcSGFM3kFXLGfdrGCGDa1B0lxC?= =?us-ascii?Q?OLumm9uXtSc+4O5CQfvNSCpdJLfze1K/se0gjg6PHPqzUvUoe4ItH8l+MGR4?= =?us-ascii?Q?qEOF4f33J5CysRZL1qu7OFYoaK6YJAFQSghtba+MNhTX3rL7cg+TgBlNcY00?= =?us-ascii?Q?xKvIaO36U9JZ/hFfQDuldpcj+oPUUUximdBwP+Ziv4E986vG0y17WSRkTwqD?= =?us-ascii?Q?6TkO1Uy2Mo/HsdnWCETtgRg9tYtP/0epQYYlFH2qLwhmgIqU00VhIiTIj3Ou?= =?us-ascii?Q?C2oXHbi9pyPEAF7wCzDnsqPKxCMY5UU0X98Mj7y7XLx3XGIwzsfaI5n2vkF1?= =?us-ascii?Q?6FmflRyo6FswsHW0d25c7XBLhwS2IUlo4iZVi4YcgvK1fUUzkTCD+AEznoSv?= =?us-ascii?Q?mLI7DOXEeD9ddnSk692O9H9bRkh5G4DPHFE0FoLITNOWy9IlL8BJCXESmfQi?= =?us-ascii?Q?4/J0awvEIJuo/W61IfYRu48GEr59ZrxjX9AanwOOESXXZyDrOiUX8B5xL2pt?= =?us-ascii?Q?1GxozAwUw1iZo33+5TlfcxzimBQpYXOtA5dHgSb7CQ0UZPvcbE0dlBnHXf/F?= =?us-ascii?Q?IbTT88i90GHB6NFawJ/RJPVOKQjJc4pxE4DRCKMa2dWkkkljbyQqjPTaQ3cz?= =?us-ascii?Q?x6tjzwC5QYU191kx0WsqzDpNdtzaZFtrsQ6YfHeWcwS22hvgNMBM4bXbk4Te?= =?us-ascii?Q?nyWR4TuBg8jZQlvVcfJCWalvnGy/8HTNaZM+dOp5l2jNEmQDlaJrDb0yFPoe?= =?us-ascii?Q?47Oa+gVzYXddzJHSYI7nw4WypGs96JCo1+0POI/6t8Ys9F+/wYvyIXA3yrrP?= =?us-ascii?Q?jWcJmjbZxQM5aQMmsiwnB0o3Mw4uE7WU05VexPXXV+4nt6uo4STB4Ml+OoK+?= =?us-ascii?Q?N17o0euS3u8+itbb/rBD14cX0ju4yuKIPiTjLjXWYxnmyrh/Xh7HX5GxtPP6?= =?us-ascii?Q?XSbMC5gfoMWmlR4ljlhllv2J1iFkNNvLEbyCml76dQsNZ1DWzVaibJnsER3U?= =?us-ascii?Q?hgbKJZ4lDb3tHET+wpUCGN7pgM/jM5YVCGnmu0IYZqtfRDsfpk1Bq1d0viX+?= =?us-ascii?Q?9jI+YEMnKcJIT11jgz8gj906Z1pWGnoF6W6AeN9SENnLrdC4rhvb9xi4SBFh?= =?us-ascii?Q?iY9uJQbjGCYr2TL2JfsJ83pAZVWuXwofgWBqjNN7qaAPUtv4cbDenFTuzpeR?= =?us-ascii?Q?0XW0PpId6rqXmmwP/3qZztOWe1zZSFopo6edRHYu5xgx3SNdK9/lWENjVKEt?= =?us-ascii?Q?avP6OSPIzegL4wJggvXaTmN5h8NjZYWAzazbZjjqa1Fkx8oW/uM3hNb/AM5X?= =?us-ascii?Q?SnvuhOQRIExOYVtXzGZayfAnsc0zm5kWRe/2YHxK/xFJsuwMCT+72l0zq+m9?= =?us-ascii?Q?X2a0gU0JmH/+Van1FZ2XJ1dm84xDDH8uduDYAE7jJkbv47LC1OAr4wgcTbE2?= =?us-ascii?Q?tA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bbab3cdc-bcd4-46c5-32df-08dce76c8739 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2024 07:40:49.0741 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qRookTKdZW76mC12FGxt2P1JDNcb+d3gtmXHsuiZClackmvXTXkAwHZQstRjW2hxWB4UQkLDR31IRn8TdMqhUIjpGAChbr+4JDmwdaKkBqQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB8853 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Arkadiusz Kusztal > -----Original Message----- > From: Kusztal, ArkadiuszX > Sent: Monday, October 7, 2024 6:04 PM > To: Gowrishankar Muthukrishnan ; > dev@dpdk.org; Akhil Goyal ; Fan Zhang > > Cc: Anoob Joseph ; Richardson, Bruce > ; jerinj@marvell.com; Ji, Kai ; > jack.bond-preston@foss.arm.com; Marchand, David > ; hemant.agrawal@nxp.com; De Lara Guarch, > Pablo ; Trahe, Fiona > ; Doherty, Declan ; > matan@nvidia.com; ruifeng.wang@arm.com > Subject: RE: [PATCH v6 1/6] cryptodev: add EDDSA asymmetric crypto algori= thm >=20 > Hi Gowrishankar, >=20 > I like the idea of adding EdDSA, but I have several comments. >=20 > > -----Original Message----- > > From: Gowrishankar Muthukrishnan > > Sent: Friday, October 4, 2024 10:26 AM > > To: dev@dpdk.org; Akhil Goyal ; Fan Zhang > > > > Cc: Anoob Joseph ; Richardson, Bruce > > ; jerinj@marvell.com; Kusztal, ArkadiuszX > > ; Ji, Kai ; jack.bond- > > preston@foss.arm.com; Marchand, David ; > > hemant.agrawal@nxp.com; De Lara Guarch, Pablo > > ; Trahe, Fiona > > ; Doherty, Declan ; > > matan@nvidia.com; ruifeng.wang@arm.com; Gowrishankar Muthukrishnan > > > > Subject: [PATCH v6 1/6] cryptodev: add EDDSA asymmetric crypto > > algorithm > > > > Add support for asymmetric EDDSA in cryptodev, as referenced in RFC: > > https://datatracker.ietf.org/doc/html/rfc8032 > > > > Signed-off-by: Gowrishankar Muthukrishnan > > --- > > doc/guides/cryptodevs/features/default.ini | 1 + > > doc/guides/prog_guide/cryptodev_lib.rst | 2 +- > > lib/cryptodev/rte_crypto_asym.h | 47 ++++++++++++++++++++++ > > 3 files changed, 49 insertions(+), 1 deletion(-) > > > > diff --git a/doc/guides/cryptodevs/features/default.ini > > b/doc/guides/cryptodevs/features/default.ini > > index f411d4bab7..3073753911 100644 > > --- a/doc/guides/cryptodevs/features/default.ini > > +++ b/doc/guides/cryptodevs/features/default.ini > > @@ -130,6 +130,7 @@ ECDSA =3D > > ECPM =3D > > ECDH =3D > > SM2 =3D > > +EDDSA =3D > > > > ; > > ; Supported Operating systems of a default crypto driver. > > diff --git a/doc/guides/prog_guide/cryptodev_lib.rst > > b/doc/guides/prog_guide/cryptodev_lib.rst > > index 2b513bbf82..dd636ba5ef 100644 > > --- a/doc/guides/prog_guide/cryptodev_lib.rst > > +++ b/doc/guides/prog_guide/cryptodev_lib.rst > > @@ -927,7 +927,7 @@ Asymmetric Cryptography The cryptodev library > > currently provides support for the following asymmetric Crypto > > operations; RSA, Modular exponentiation and inversion, Diffie-Hellman > > and Elliptic Curve Diffie-Hellman public and/or private key > > generation and shared -secret compute, DSA Signature generation and > verification. > > +secret compute, DSA and EdDSA Signature generation and verification. > > > > Session and Session Management > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > diff --git a/lib/cryptodev/rte_crypto_asym.h > > b/lib/cryptodev/rte_crypto_asym.h index 39d3da3952..fe4194c184 100644 > > --- a/lib/cryptodev/rte_crypto_asym.h > > +++ b/lib/cryptodev/rte_crypto_asym.h > > @@ -49,6 +49,10 @@ rte_crypto_asym_op_strings[]; > > * and if the flag is not set, shared secret will be padded to the lef= t with > > * zeros to the size of the underlying algorithm (default) > > */ > > +#define RTE_CRYPTO_ASYM_FLAG_PUB_KEY_COMPRESSED > > RTE_BIT32(2) > > +/**< > > + * Flag to denote public key will be returned in compressed form */ > > > > /** > > * List of elliptic curves. This enum aligns with @@ -65,9 +69,22 @@ > > enum rte_crypto_curve_id { > > RTE_CRYPTO_EC_GROUP_SECP256R1 =3D 23, > > RTE_CRYPTO_EC_GROUP_SECP384R1 =3D 24, > > RTE_CRYPTO_EC_GROUP_SECP521R1 =3D 25, > > + RTE_CRYPTO_EC_GROUP_ED25519 =3D 29, > > + RTE_CRYPTO_EC_GROUP_ED448 =3D 30, > > RTE_CRYPTO_EC_GROUP_SM2 =3D 41, > > }; > > > > +/** > > + * List of Edwards curve instances as per RFC 8032 (Section 5). > > + */ > > +enum rte_crypto_edward_instance { > > + RTE_CRYPTO_EDCURVE_25519, > > + RTE_CRYPTO_EDCURVE_25519CTX, > > + RTE_CRYPTO_EDCURVE_25519PH, > > + RTE_CRYPTO_EDCURVE_448, > > + RTE_CRYPTO_EDCURVE_448PH > > +}; > > + > > /** > > * Asymmetric crypto transformation types. > > * Each xform type maps to one asymmetric algorithm @@ -119,6 +136,10 > > @@ enum rte_crypto_asym_xform_type { > > * Performs Encrypt, Decrypt, Sign and Verify. > > * Refer to rte_crypto_asym_op_type. > > */ > > + RTE_CRYPTO_ASYM_XFORM_EDDSA, > > + /**< Edwards Curve Digital Signature Algorithm > > + * Perform Signature Generation and Verification. > > + */ > > RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END > > /**< End of list */ > > }; > > @@ -585,6 +606,31 @@ struct rte_crypto_ecdsa_op_param { > > */ > > }; > > > > +/** > > + * EdDSA operation params > > + */ > > +struct rte_crypto_eddsa_op_param { > > + enum rte_crypto_asym_op_type op_type; > > + /**< Signature generation or verification */ > > + > > + rte_crypto_param message; > > + /**< Input message digest to be signed or verified */ > HashEdDSA will require a message digest; pure EdDSA will require the mess= age > itself. For HW it will be more complicated. > > + > > + rte_crypto_param context; > > + /**< Context value for the sign op. > > + * Must not be empty for Ed25519ctx instance. > > + */ > > + > > + enum rte_crypto_edward_instance instance; > > + /**< Type of Edwards curve. */ > All instances are using the same curve, where they differ is the way of h= andling > input message. > And I think this should be a session variable -> new xform for the EdDSA. > > + > > + rte_crypto_uint sign; > > + /**< Edward curve signature > > + * output : for signature generation > > + * input : for signature verification > > + */ > > +}; > > + > > /** > > * Structure for EC point multiplication operation param > > */ > > @@ -720,6 +766,7 @@ struct rte_crypto_asym_op { > > struct rte_crypto_ecdsa_op_param ecdsa; > > struct rte_crypto_ecpm_op_param ecpm; > > struct rte_crypto_sm2_op_param sm2; > > + struct rte_crypto_eddsa_op_param eddsa; > > }; > > uint16_t flags; > > /**< > > -- > > 2.21.0