From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96B04A0553; Thu, 26 May 2022 14:35:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 823F540151; Thu, 26 May 2022 14:35:54 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 4EF3D40150 for ; Thu, 26 May 2022 14:35:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653568552; x=1685104552; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=YVhvWgQzo/dn8bFzFDJva3rfN1ZOhFtlExPx7dWYx7U=; b=IKi633zLajqwgh0DiukMeo5bwvUA0wME3A3p7FLo/Gvf/OKWwiBe77eq q+0iPUWTL0ozy7TOd/g7BDnvNLpaHlfMvMn9yimF7CAn9E/KG5dMAVbYJ Xy74ciYd7ofO/jO1vV26QySY64L1rBmVn8hNhMPjhoVJzmVGmsbunn9fX b77FuEDidSe1HO/lLLilpJsCCiwWhkhLxAuCYkYiHb8qoVgICt5Cvc8U5 0sRqCDNkzKhaRCMEYGCKGgNxnNpVi6SCjWJmXzSXQsKpL7yoYEAweO0cg b856kZSvDNC5AyXW/b6mt9O6YthjKed9nJnKq9REiK7thCtBSOtn61XEr Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10358"; a="271714661" X-IronPort-AV: E=Sophos;i="5.91,252,1647327600"; d="scan'208";a="271714661" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 May 2022 05:35:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,252,1647327600"; d="scan'208";a="630885703" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga008.fm.intel.com with ESMTP; 26 May 2022 05:35:51 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 26 May 2022 05:35:50 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 26 May 2022 05:35:50 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.47) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 26 May 2022 05:35:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nk/fiFc8+Ic7OwQaXjw7fM+zVB14bWH2OBquW+qGwfu/CS8H9O9OV8FDW6e4jpCihh1Nok/kjl+AxHo7xanYJDDju0lUzTEnxSNlLHOsVwwWYegFJpoJIB0ZyWju/ab/e6UxYHdIwi4qKSqNbEBmKJ6ZV1459zZK36CgAZIaLwWJmy2hKVIa3LgcjbiIe4bfMIdb4n52biKHeaGRHbejvrSpZRpl7NAHhzBv+5L6I/9Kw6PExUOVCxvNaJQf9GwSR4UqLtzP5TxfsS123Nc6iQEQUlN4qvq7Sem+8BbeFiOFn4S2/DkCjVkUQN56/TNxP2vQ06unyU1yU7NkUaINmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pS1FXCPnQnsF35SuUMeOTE3xMuUdzTEKeX+cW+vdZJQ=; b=U1zJ3AH2nithabI71cFOFl4t+1mIUaWqH3o19rSmkiuH2Kgo3Vc2vN6mptUJKnhT8Ic0hmBYcynf3a/q0V962cQeY2m9P4Po0QKRJsFHO5wNsk6c6ENuHS2SsKOHBELfvNjKKODp88tskrC/1NZJJzoPuy2DNY+huEvgqOQ8f8xWfztMwybOYrthhRRW4EVc+yjmqmOKEhE3wJetW2uHpOAys1vsYh+x4D0kMC6KbRc4nwU1UsAVLtuDggmzNxKyB7EdnN5E/CLCRgeFd1nyrCRLHCbd3mhfd2xaxz6prg4LlbI3nFo1MdhR6twYz9ocxJNMskx4Cobgw3bwoaLTsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by DM6PR11MB4233.namprd11.prod.outlook.com (2603:10b6:5:14f::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 12:35:48 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::c1de:722f:b4f3:91b5]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::c1de:722f:b4f3:91b5%3]) with mapi id 15.20.5293.013; Thu, 26 May 2022 12:35:48 +0000 From: "Kusztal, ArkadiuszX" To: Akhil Goyal , "dev@dpdk.org" CC: "Zhang, Roy Fan" Subject: RE: [EXT] [PATCH v2 11/14] cryptodev: move RSA padding into separate struct Thread-Topic: [EXT] [PATCH v2 11/14] cryptodev: move RSA padding into separate struct Thread-Index: AQHYcFkacP641dZ6KEq9ne1qam1Qaq0xEOUAgAAAzTCAAANOAIAAAuQA Date: Thu, 26 May 2022 12:35:48 +0000 Message-ID: References: <20220525155324.9288-1-arkadiuszx.kusztal@intel.com> <20220525155324.9288-12-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bc7598cd-aeab-4ace-90c3-08da3f144356 x-ms-traffictypediagnostic: DM6PR11MB4233:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Q3gZTIx6XRxADdk7KlguSWDka7uihfgjhvY9fqG489SE5O4oXZpIbxiuSj84uqZHH//z5z/pCwjEpK1tPRJvDgiFoxwIlIo846hW2SLAYg4PjNOJv3VgyVyPeJFsz3P984LaHvYpZ17KksHFWIHTI4A1ghuhXLmf2RXajWEBOO+WM1IirgJ49zHSik0+WAXhQcipiAZefovsb8VyRqHD4GjpAYJ3LZAszDWZBmvsTqOpVIT3iIutDMmga0SPDy77aP+/ZFixCplLRTEHFqDmO2U5iOgKP8uQ62XTOWITsp57CXqPpWFKdIx2pBAi4duKjFHLQZfL7liHVULySST/W7xc9Dq2WkOocdrCxpluuL5OJdIhAkq3uXKqBVucfto7XZ02Y5ddSvuCTPvGo8YX54eCgntV1ZJzUH44wllHO/NmDRpa1yNSqp2LSn46rho2rvciHCe0YonlmCHy+aORIP0MsMiQE7K6Sa7XjONXdP2iQcK/4y7rwxZX6rxxFvhN+qqKb1GY+2HYWtX67vNthufVwYoEZ8noxLuBCWTXGY90r5+M9e0zmDr9NUPxPJGdyBk6Tjt2ajcEPoNn5aLxSrAS2ncIyD8LBYX6A+czhM+3inHAxjt/VW+Kgc+fL6sci82CTzzO5aNShg14cCrFef2HNPENJvOiuVrNmJwWg6NqMCH+ghiLwivAxgPceuLNiEKYG8H5pGoL8HUy53yn7u1q4BlXs1WDCWRsnnYJ8Rs= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(107886003)(186003)(9686003)(86362001)(26005)(52536014)(5660300002)(8936002)(122000001)(38070700005)(38100700002)(82960400001)(2906002)(4326008)(66446008)(66556008)(8676002)(64756008)(76116006)(83380400001)(66476007)(66946007)(53546011)(6506007)(71200400001)(55016003)(7696005)(33656002)(110136005)(316002)(508600001)(473944003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GdhRuymuavKY09XDme6b0MTeM2eIkkrRujhOvogdZPPlbuZOUzeL2CLtmgxD?= =?us-ascii?Q?jI46zwckkFignEZRK2pW4OS9M25jgHGE/U8gurZRJI+RFaLWvLWJS2OrRelJ?= =?us-ascii?Q?sOUBm0wDH4mvZAVxvrMjaISh/LpMwcyBeYklU6kfWvnwKPBlSkakeY7sdv1p?= =?us-ascii?Q?sp9mwZv4v3KKBFqnQRFgWNABGQw6AtOLxvCga9+uFfJlEl6fQP9uHVwZJH1y?= =?us-ascii?Q?gEGaYmVDHndashdSWjxcYGeZldw5Y/SBU24rA8WtmPTBpM+K4JZK4tWKauSP?= =?us-ascii?Q?nDu4RT57INz6yRs+F8fr3dJSA8WUbiF8ap4nMvXAFgq4K/7dcfyiOTjflauc?= =?us-ascii?Q?9BAb0vXnC8DTKftZ3lA0ghlSnl0uD0aNt1/syotXlw64qIv2ww4WwoAGuBUA?= =?us-ascii?Q?SQ/FlTbcAfChY8F0iQ4DFrNg4S4rN4e3LJrt1qSz0t+wpD38+25SV0g9WhRq?= =?us-ascii?Q?Ll6atm/z5TKdUJqdmYazIyHGsblo5NqWsVbD2RDBaLtWO6OOY2eDt7R0nNwj?= =?us-ascii?Q?M0qakJvTgtT1vIYvTeM9udGuyq+zlLB4fsz5GkS40dHtCoReqSgokfhSOuKG?= =?us-ascii?Q?DrmAbqdzcV2baEKgORoY7VYH66umK/bOxeSme6IABxfK26WAt7Znv9PJN3qE?= =?us-ascii?Q?wV4OVz/d9pzwqUEUa5cK1sJk2LOCgcTpatfnRdpEeS/tzwexkRyZwwej4GBR?= =?us-ascii?Q?Dv2J9hV6ylNXS7NaGuNki7NA3LbwudK3ZpZHv5WC/xPOGJlkF2HUqSCZGdRC?= =?us-ascii?Q?a06BF8qTANmlXeY6jptxtg6lwBD0kqk/Pht3Dc/rDbLZDIRH0WHpBivlfVWy?= =?us-ascii?Q?WWcdyCvVoJPmhQlUmjJgoU1pNlUCkb7f3T0njSNhpYexUTuAxIiv9+hHOszY?= =?us-ascii?Q?KlbnIT1P53HQISHplRSMizfXysTuvEZEVlHCH1W2gdc+by5BNcn5deUNfjMi?= =?us-ascii?Q?371+k0PwtDATiq7b8/KaUq2RQqYqFhjG/EFQfe22CBJAdgFjm7l9S8GsB0Aq?= =?us-ascii?Q?xD0BgJLYdKttH+4tY9DSBqENJeW4jG4wuSSRGWvRBEpEZeG455tfaoUoLVaO?= =?us-ascii?Q?YUeGsWGKmvrO64N+IEL3UY4Z6okVI2oXijGrZNNujQdlJCn/uGKEk2y45uwc?= =?us-ascii?Q?n8LE31sN+njaDgZlUbfpFAJhwW63BYWYJINQp0z1q0g8Yl4EeNsSrV8XsjOT?= =?us-ascii?Q?l6iiTk1TClBCGwaNGvreIGtjgWWixmTTwko7lE2JmdkkKdu5uzn+0fzXv1fd?= =?us-ascii?Q?KF8OU0nAbEa0Ijb8HIrFGgjICYn12tOctGedLMNe1x3+gKy94VICwr52MUGM?= =?us-ascii?Q?+NK9CLTMXjwhphEKP1WTkmKD0zH5jioHnhar+XG5bGkBJYRn69zBrNApDrkI?= =?us-ascii?Q?Ld0iM6KE/t5h3Z6nkwwzLfCG5slqdOwl6eVH0ZeN1mXx5E24bYFgHqHOXLeZ?= =?us-ascii?Q?MaWLyjrgzM1aBvcmkpUt5XmbroLv1wIFe6iq8+CyQWtcgkxRbQoZcVJ9HOHE?= =?us-ascii?Q?zn8ind5+JbccnGYel3UbJjQzcgJjgElQoQlOjMxAKMkBQfYU+GVlH+LmlHQI?= =?us-ascii?Q?DVcz2EX4MSkrmp0GeofUphJlc9eEN1pd3r6OrD2OipcNukdC3dKYYgiefB6t?= =?us-ascii?Q?pwJ9owpXAq6XoEzW2LTLrO4kFW1NFUWgVCmBumFL1W7M1HuGP5Q5/wtTXaL+?= =?us-ascii?Q?ve0UsdwMQ45Ie0AmmRBlf+VfM3d6lrmV5lPj11qBtak+t3ky3kqot1/SYHQ5?= =?us-ascii?Q?3Wwf8bJTkcXIx1MWgWwhwmpXW2Ya9pE=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bc7598cd-aeab-4ace-90c3-08da3f144356 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2022 12:35:48.7833 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: P6UwPCWoZFzkU99lBWY6POYt12RoHOIZYvGdTBj0Kt/NzePoQgxnnanwuxtvkoNhNARIOO3/IFRhXJBEbdY/jDMdknfensIZu+aP+B3gHnM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4233 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, May 26, 2022 2:20 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v2 11/14] cryptodev: move RSA padding into sepa= rate > struct >=20 > > > > /** > > > > + * RSA padding type > > > > + */ > > > > +struct rte_crypto_rsa_padding { > > > > + enum rte_crypto_rsa_padding_type type; > > > > + /**< RSA padding scheme to be used for transform */ > > > > + enum rte_crypto_auth_algorithm md; > > > > + /**< > > > > + * RSA padding hash function > > > > + * > > > > + * When a specific padding type is selected, the following rule a= pply: > > > > + * - RTE_CRYPTO_RSA_PADDING_NONE: > > > > + * This field is ignored by the PMD > > > > + * > > > > + * - RTE_CRYPTO_RSA_PADDING_PKCS1_5: > > > > + * When signing operation this field is used to determine value > > > > + * of the DigestInfo structure, therefore specifying which algori= thm > > > > + * was used to create the message digest. > > > > + * When doing encryption/decryption this field is ignored for thi= s > > > > + * padding type. > > > > + * > > > > + * - RTE_CRYPTO_RSA_PADDING_OAEP > > > > + * This field shall be set with the hash algorithm used > > > > + * in the padding scheme > > > > + * > > > > + * - RTE_CRYPTO_RSA_PADDING_PSS > > > > + * This field shall be set with the hash algorithm used > > > > + * in the padding scheme (and to create the input message digest) > > > > + */ > > > Forgot to comment on previous patch about the valid algos for this. > > > They are removed in previous patch, but it should not be removed. Rig= ht? > > Which hash functions are supported by RSA can be found in RSA > > standard, additionally our list was incomplete. > > There is no Hash functions enum in Cryptodev -> we keep Hash functions > > together with mac aglorithms, so that's why it was probably included > > in the first place. But I would say we should not specify valid algs he= re. >=20 > In that case, mgf1md comment should also be updated. > But again, if we are combining with mac algos, we should specify it. Righ= t? This > is not RFC, it is our implementation of the RFC. If we are combining with= mac > algos, it makes more sense to specify the valid algos. Its actually not that big problem, though I thought it is stating the obvio= us. So we can add it back again but with full RSA hash list (including 512/224 = 256), or we will add it when this will be added to rte_crypto_auth_algorith= m?