From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6566B43CAC; Wed, 13 Mar 2024 23:16:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2BF754025D; Wed, 13 Mar 2024 23:16:28 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by mails.dpdk.org (Postfix) with ESMTP id 156DD40151 for ; Wed, 13 Mar 2024 23:16:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710368187; x=1741904187; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=h7Zp0c9mFsu1q+LLBCSvPoYZpqe2Wi5jukzqLsp1b/M=; b=XhQ5rAH8Grp7kaoi4SI1Vy5UIayXj3pnR2YLatTu82vLK+/sjKLuP4bv wiK1ISh0BFeNLPy4IAtyvQWzcJIUIFrxCXtEOlWb2ZErEjp7NSkC1IfTf 1HdQkN6Xc0E0FbIFEtb/pX1t/GV6tgdQ9scmYHpn3EN94HXwJwGZ29cJS O9BsEFk9+BV0MSvP5MTL8+jSltf/Ka0C9JP81zjHQs03sUvz3fDLILXYz /XZkl5etBxFIDs/XgOnfwgdz9xpJR1jw3H0F3j4gupTjWb2JRjoSiB7VF R7MLcRR/Yz/tI58+j3K+9cxfO9V2iI6resZgPlF7TPyHaLrZK/SIAJlXw w==; X-IronPort-AV: E=McAfee;i="6600,9927,11012"; a="8983111" X-IronPort-AV: E=Sophos;i="6.07,123,1708416000"; d="scan'208";a="8983111" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2024 15:15:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,123,1708416000"; d="scan'208";a="43114796" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 13 Mar 2024 15:15:58 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 13 Mar 2024 15:15:57 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 13 Mar 2024 15:15:57 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 13 Mar 2024 15:15:57 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 13 Mar 2024 15:15:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fpIuaq63qutd7FXEWg1ZmHeZHtyzxGo07uhdvTzFa6UMHxSl4vSsyAOlrbM5X15oKRU/tzN6XtddPxS7deXZ5tp7mfsABlL4JY5ZnItm7OM3Ze8lJe9uNVGXcpoH7LOH3qPJuuMAYLl4LwHCO12u/rQLWcrANbcx2ivu1RDwX1HL3qvnlC7UFxmt246hdGsC7+XvgLLbsSzVnRLsxodtfiR7eWB9EWA/Ee1PtyrD3yLb8Y0QDYabMnUZPHxUW4fvaUcdS9SaNJkvSTxVwZhPljJ+jVLlTTNntdoVrhs4KEEefmsROSAb0WAGdj3U7leoFIKRLfiyB3lVY5fPuXgnMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iYpn+B1AY5vQWah5ZU5atR+vvqADVj3n6XnbRyEOhbw=; b=mEfjVi8naAKVUGYAeeXRoAxQV5t31Qr3H8R5reg73FerUyH0pY/kNIwwsZ1beRqmjvVCqRbsA2Aao9j+mz7iIhc1K8DChT1bgSWqatniAAes+eYX/4WinKt26CdN8o+wMx3FgxbQcdRqYM0B8wemJe4FzvtTDAp+IPpJOx2L5PaP+vkSEoXdx2kPswqVMMTegvJqsj79ImvYQqZwGPMqoVI9JKdx5Xw/uMxa3Z2c0wrdMGMU7xcZ1a1L48aa//NBQDEHdgTu4He0VVZ93WzhgdGKDJr90vtSc+XMjppqB08ez3SDAYmQCjRakbMDZlhsAKJVdijYCMmEwn+37n/axQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by SA0PR11MB4639.namprd11.prod.outlook.com (2603:10b6:806:70::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.14; Wed, 13 Mar 2024 22:15:55 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::66c9:72ce:62ab:73c2]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::66c9:72ce:62ab:73c2%6]) with mapi id 15.20.7386.017; Wed, 13 Mar 2024 22:15:55 +0000 From: "Kusztal, ArkadiuszX" To: Akhil Goyal , "dev@dpdk.org" CC: "Power, Ciara" Subject: RE: [EXTERNAL] [PATCH] app/crypto-perf-test: fix unset crc algorithm Thread-Topic: [EXTERNAL] [PATCH] app/crypto-perf-test: fix unset crc algorithm Thread-Index: AQHadVZunhhE5o7NF060uAMSyV4PTLE1/BgAgAA7/MA= Date: Wed, 13 Mar 2024 22:15:55 +0000 Message-ID: References: <20240313145448.26264-1-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5013:EE_|SA0PR11MB4639:EE_ x-ms-office365-filtering-correlation-id: 2a99f2da-0f4e-4f6c-c021-08dc43ab2709 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: a2oybb8/oJaBz0uzsazGaT4Eea7a7RL8Dyqr0NwILjk3u6vNNPU2hkpOB9RZrsTKX+ITCqsTrrVXk+bC/21i9lnnKoZAsPMn+NqEkN7wUSnpQ4nbW/XtrNYKf5rxuojb8CyFMDh7FOMINHdeoQvu7+hVjQhAjjTQV0CsY0Qy28FiPFE2JR8RVCgNvKovXMBuf4pAGV7ke4ij+hE19TwKI/IfvQ1hffdatikX8wGkbwMYq4eRxXI2hLGjAQYckXXFKGNNHnSzFFMQE2AREyL99Gw4uTMzfYKigjpfpjWT/azUUAe8i2xFvceLBnttKho00x4W+DB1w9vfAnHfocFCLd/4RRqAb6nUBSshM8ibk49XIC0uk5Vrof1WDx3Sd2qfJ9mXPfQSlu1Pih4i2TXojQYZx21dDamUfdjWZo2qOzc8R8b5LPkBLF/t9Jsy9WVGKuiePQh6ARM9bKEytnJ8MaSnzfvMutRinH4N+0VK2jPa9unAkBbI3hZvQIaXVH3ugUgP+XWRvWrH/AKR2zezFZePWXD3eDETcd+aYyVQ9vKDo42Mzp7lX8/8MUIvd31y21yw2iNegqXAB6XHMtWoubiA+QmaHG2Jm5oa4gLJ5zSZKs7NEy5O9UXJX7CP8KQFOBC3U9vu85WRg9JR2/d5cMXdZf5YAp+Na+NANosjv8oPR9kXHmrZfDOk5vB48r0ZQuSA404RdlvTRd4/BJPoxXcYsKtDwtfH/sEYrPo/H4s= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?07odxY2xzz4m7HdTdQ+0BOw8NftvSHcimZPDKVkbA6ApzS6B/utOHpTAE5dH?= =?us-ascii?Q?PyZeIUkse0MeNiUBpQNUaJU/yk2IYgEQO6RUmOO5/5+SsTmyXRlYqoizfSPr?= =?us-ascii?Q?a5spqXTkq53GfWRypatcafpiOdnUkJsRjnNj6YBrfbalB6k8VV/P/jmu1qh8?= =?us-ascii?Q?pcCK1brp5MHZmm2imE6ME8FLwxr4hhKE88X+5mxtitkXNNaNFEVnQdqvzZP5?= =?us-ascii?Q?9+EFeRBdzTGMND1/QfP8juzCZ/dIbKqjS2gBfQSy8fNWe36VVkXCOPRV8iHV?= =?us-ascii?Q?4bZVx4nCm6FhKu9z0tm1BvbkFt++P2KGUxPQgLh7XrnjZK/siNnhl9PZVHw3?= =?us-ascii?Q?PdcvnCd2Y8QH42SFI0vWTpXvqNLSMTSA0NzIBYZ5oaKv0rlH67PckMbfJfGs?= =?us-ascii?Q?NWjnhI1KYQlAvQ9M6Ws2v3BcyLZeISi+1qLC+7UrBwQehTjj93YHjwpkeJ+0?= =?us-ascii?Q?s9TJNp6oiHjJpwhteT4E+8fuM84+RaSS3u9MNrvchiMkcehhjwkUOkiASZ/m?= =?us-ascii?Q?He8Tm1Q6yQTyPyoT6Lw3YzMWMoy+uTat5CA8XosS+qCW8Y6H0aPYPjri+wRP?= =?us-ascii?Q?BnqxCwa05sfuVoW9GO65R2UTt1kQijxgjkxp5pvwZL7fdb7J/2PLB7wWK/zT?= =?us-ascii?Q?hARdmONazvE13qD6cPfenFxoO1SXUQ9wRz3MxWRLaH6nCDWIfnHsvdkq//fG?= =?us-ascii?Q?/IEz2kd0FPNJd4PcUkc4tD3fL4CyNHjPBEoZaoxJk7C4QGKhUNee7HPleZld?= =?us-ascii?Q?3l6E48r2KED1tVr8yC1G39ayQ836yLTS+701oizJIRe1KYn3j4OhZuull8QU?= =?us-ascii?Q?n1rkB2BoGjAeJOcbznHy3l4GnbuQ+NPXzB7Fivq4mR7Le9ND9lom4RvGY8qF?= =?us-ascii?Q?21MBFkWsGvVsl+T4Sioa4BzVVkBCondNLsWB12Migt7P1aFIPXPoMbgQ1Rse?= =?us-ascii?Q?MdApeNnnY7carnTKIHT97IoY2v8eEnNYqtiTCI1calEC6h97SDwrgnJSi0VD?= =?us-ascii?Q?b4gYLCFyacY/mRmKDqU0Mh9ufb0KcGaRYjMc6XrxRJFCL/Ij2546Sz0sb1Kd?= =?us-ascii?Q?veCdPOJaXnrP0MVO02/fq6V7v5iNzkTze9lg9NyqpnM9VH66gqzMLI2LUJ8T?= =?us-ascii?Q?/mihOz6kalq3L5bbToPwqILrgQ80l7y8P9djMi3Di1K/tm/GicxU3jLHEYfm?= =?us-ascii?Q?6nXk5ke/KXzGitnnAD83elVRVaRarvx6lrlNhsz9nDHtqiusumLFL/7+4802?= =?us-ascii?Q?xUHW9GcJuvJ6qUPWVy8Mh1gnKLDy9MgsJgborahqRLcWY7/jxF/EYiNu/HHE?= =?us-ascii?Q?Mvg63IFXbUdvHoJ1Puh3Q8VwdgvESdCWjoz8Wqu3gqwOf6znG9rZ8+ITuS0l?= =?us-ascii?Q?AsOXmpNNJhnMWUP0Zy89VscOjFz6taKB1nBV6wl8hTh4Cc/KEPAaDHbp2MLn?= =?us-ascii?Q?5y8ZbiRGTjE7N3ygg0kuPry5G80xRo/PLEpbFMDcRf/aXnOcYTBltti1RT2+?= =?us-ascii?Q?Gj+9oPTaKGxg7mr7MxImP9yFrWXWKPFTssuAznMhtOFAbEaWnx9YlMLshWkK?= =?us-ascii?Q?VDE73VDYr6lPEAs4qEDd5eovItIF4zgoQeBcuu14EtfNXgUju1mIAzw9s2CU?= =?us-ascii?Q?AA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a99f2da-0f4e-4f6c-c021-08dc43ab2709 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Mar 2024 22:15:55.2741 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GDNQStwZASmj2FF85S5t0QF9EgJi5CZk1UNpF65/ccZHOwxZp/Tjfo4KEFN/yTkR/fh/HCFnL+DFRXeKNlU7albqjMM0LwTnKX+q6O2z+A0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4639 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Akhil Goyal > Sent: Wednesday, March 13, 2024 7:22 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Power, Ciara > Subject: RE: [EXTERNAL] [PATCH] app/crypto-perf-test: fix unset crc algor= ithm >=20 > > Because net crc api is not thread-safe, setting crc algorithm by the > > application will prevent race condition in the calc function. > > Race condition still may occur when any of the threads will call this > > function again. Function is called with the highest possible SIMD > > extension, which is AVX512, but if this is not found, CRC API will > > pick the other highest possible extension, or scalar if no SIMD > > available. > > > > Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test > > application") > > > > Signed-off-by: Arkadiusz Kusztal > > --- > > app/test-crypto-perf/main.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c > > index 40c0b4b54f..58496797d7 100644 > > --- a/app/test-crypto-perf/main.c > > +++ b/app/test-crypto-perf/main.c > > @@ -11,6 +11,7 @@ > > #include > > #include > > #include > > +#include > > #ifdef RTE_CRYPTO_SCHEDULER > > #include > > #endif > > @@ -599,6 +600,8 @@ main(int argc, char **argv) > > goto err; > > } > > > > + rte_net_crc_set_alg(RTE_NET_CRC_AVX512); > > + > > ret =3D cperf_verify_devices_capabilities(&opts, enabled_cdevs, > > nb_cryptodevs); > > if (ret) { > > -- > Not sure what is the use of this API here. > Which calc function is it fixing. Yes, this deserves some explanation, rte_net_crc_calc function, when alg no= t set, will first try to set it during the first run. Yet it is done in thread-unsafe manner, causing perf-test to most likely se= gfault because of that, when more than one thread used. =20 >=20 > Also will it ever pick neon handler? No, it won't, currently only qat is using this api though. This api needs to be fixed, so eventually this will look different, but for= now, not many choices available.