From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC495A054A; Wed, 25 May 2022 08:37:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D0BC140146; Wed, 25 May 2022 08:37:17 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id BB767400EF for ; Wed, 25 May 2022 08:37:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653460636; x=1684996636; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=xjVnjPmGEgMpcSnLdfCXNSPvCDDn4SqrdlnyS4s0Vnc=; b=H+52/1gdUZYoKNvl/a2PB1YFy7Ag9k2yhkL0kt4PC1MR1hfWA4dQrXKH 4lPGbuCZWvtrkA+AaWPQ+1ikRe2vEUC2DcpB/x5qWbFzYZ4zoUac3RyBE dyq0eDtWKUEpu3xGfhTg1Aw0RhAlRTdzsQ9somJJJvLrIuQ39Ep45wTcQ BnWr4rO2ZttKfjcFcwEYgqlvxCjnF6oQ+h5n5SwB+I1773FShLaIBx2GY /TjutZNorVY9by46BH7tdO+C2J0h+DseLZ7xYR3dmbTSQ+tml/790g6H3 75Aw4ihJ9sUJg7sgHlNVYZENX6r+PX06LPG88zdtvBnKIgBnis62KLN8h w==; X-IronPort-AV: E=McAfee;i="6400,9594,10357"; a="334375703" X-IronPort-AV: E=Sophos;i="5.91,250,1647327600"; d="scan'208";a="334375703" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 23:37:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,250,1647327600"; d="scan'208";a="573055784" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga007.jf.intel.com with ESMTP; 24 May 2022 23:37:15 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 24 May 2022 23:37:14 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 24 May 2022 23:37:14 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 24 May 2022 23:37:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HiIHfAWPxy78tVeOABMb7FbAJexTgZ4JtQT0aZCs0xIpCMJN8ARIB9cp15NOrrEMmgwEk2bhDY7qTt/LQ+TSRxNK82odtrONbSoD9cmAOrAOzUn3Muzd1Mqcwd0SWTdtcaa0VJXjNVfdWv2F41wk6Jg7nyg4GgpiWJIghZvOKTRq0wXXBYcumU7SBMIGycx15Ucj3A+sLdxlj/ND0iOXfY9iuis4OHjJGxdjYchXJraqEzgIrnW3vDiGOC5OzJB8GMdGwzBpREZ68x39s6FIcwaIEVpMjHbhVjYkIXY/2NjFV7QUBbZnSoebKILHoY9S+UaxRo2qcQhVFZORGCT9qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FDPDgtDrywhW5olN9Ri8z685IsA0CQZggkwfWOgxjLQ=; b=fisSPZiLMB+AWAsiz89tgFZC0GXNVzk7a7IAEmzm2IlUNvvJjabAnv9/4t9BVlcpdaEgmj0wU+w64by5SnMl/hi6qdG7aRWaNsLpfoQ7/FuYrP372nJQA42dUOrxkNZQVyI+7Wq+nCpbPz1LjlbtVpULv7KR34nw0YyO6rxz3PvWq0/L12V4gj6KTRrI76Is8E5CU3UQ73EmXfbaBzjDnwp0+9+nnyIm9L5OcRJJyM6RTXYiAxkWq1PSYIJPWB+tG5Lpg5iXipr1jWMwGIH+uZkRF7KlkmT7d6kIxMWE/Tx3fIuud5+IyZg8xc82kYIwGE9ciLa5u4azIWXtflEriw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by BN6PR11MB1988.namprd11.prod.outlook.com (2603:10b6:404:48::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Wed, 25 May 2022 06:37:12 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::fc0f:1644:98b5:be1]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::fc0f:1644:98b5:be1%5]) with mapi id 15.20.5273.023; Wed, 25 May 2022 06:37:12 +0000 From: "Kusztal, ArkadiuszX" To: Akhil Goyal , "dev@dpdk.org" CC: Anoob Joseph , "Zhang, Roy Fan" Subject: RE: [EXT] [PATCH 38/40] cryptodev: clarify usage of private key in dh Thread-Topic: [EXT] [PATCH 38/40] cryptodev: clarify usage of private key in dh Thread-Index: AQHYbBfSa8ljPLJwUU2D14eIKmC2V60uAyYAgAAY3dCAAQfnAIAAB48w Date: Wed, 25 May 2022 06:37:12 +0000 Message-ID: References: <20220520055445.40063-1-arkadiuszx.kusztal@intel.com> <20220520055445.40063-39-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 82658bf8-6783-4949-d5ad-08da3e190066 x-ms-traffictypediagnostic: BN6PR11MB1988:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: //TduFWdhqVQvM1y2RGMsZO4LaqIc4utnNg/UkKxOVnpvYstqzZiKGYBo9L/IWxtn7IYBUqfVieEFrO0j5Y1c5qUhjIedGOcrkrOj7WT3C7MLqYA4plj3VfD9NBw9e9MexLl16jm+lXQqSwd6DW4zB6exhxlFGHio06Q4nzyrRHcze6d3z3e3VB6ykKUc0IFIWB1jyswiDn9fWBsOyuLpXoWqoFZZbwWUmtzDTEhuMg27V0VoGMVMl1mBD1FqEd5qfhF1vCvHRZw6Ksd3X9vU67TGC7yIDnSji6/VMMGdnk7kL2hpoxZaibViz01mApnivbIDWsZ7jc7d0S3AuHlIupSubxEjWGPcBbczD8/g9I7xPayDnBZXAMMQra+gnn+k6pM/i//zA6DjwgcxMBzrG28WiPm85nm0tYOHwlcKl/IIPr11NUB+kdkaluInX/f7SCM0DMUKkcTTONeNa2MbpoX/UCXUAgrnNmO5cKvpftUVagfDsdGgDZRSw3hm0cMap5qkO8CibP1DFdiZrMktHW9My5FX4leWZXQoEsZkUTeebaY9oQfTMAQYR/QhTwanLWhpDNf3cXqykcaxomXDfh8bz322EMaBo6oI9rQafjO9eK6WX8I2gBxh15NSBvXj6ltz0874IlvwOgOLgEyPzhZys4qoOEuiS8PIuBFuRBHFAahKgClhlLDjD64OaaET6Najh8cJX6VAQpUZnZxvw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(4326008)(5660300002)(8676002)(64756008)(66476007)(66946007)(66556008)(66446008)(76116006)(55016003)(83380400001)(110136005)(107886003)(54906003)(316002)(8936002)(508600001)(52536014)(2906002)(71200400001)(186003)(33656002)(6506007)(7696005)(122000001)(82960400001)(38070700005)(9686003)(86362001)(26005)(53546011)(38100700002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jan3xX+S8s0ZqovcHg3IqBngy73rsdGHApR0uwaq/YNgot3FBJ40jOyIuEjG?= =?us-ascii?Q?8yGM/PwrE+54vf2Hj56zoXfT2yqN76TRHlM6LLHEUhGnhe2/OzqRMOw5Y1JH?= =?us-ascii?Q?w/8eDnmKPbtSruoQAz+sbor3FbGLOVbaC9yXJ6rGR5s9qME8IwB6dq+kECv+?= =?us-ascii?Q?ZxJiPGFe34qaUppm0AET9Nm975WxcXh5x1VtpYpU/cCxHUGMTkpTaX/ixmcC?= =?us-ascii?Q?quQxzzT5V3YADz2fk2Oi6td9Uu5otsoevWROHpLG4wTMTgkJNRY9iM4tzG+w?= =?us-ascii?Q?Bl87yYb9/C4sw2qlyU7lZAvB/DAtrpRHcmDugYVo6U6zGBQawWyws13OI2LI?= =?us-ascii?Q?Z41XrYmXchs3pVBvwIAk2lH+pCVOBHOmb72Pkdz2f6FVGBRd0UxcjWsKjzsg?= =?us-ascii?Q?ExXDNh60BW3I6+NBZP4jrsTokgGNHkzatg11GdsIwQFN1+FNvkb9fhwmUE1x?= =?us-ascii?Q?lzz5OZvYLeNG4tJVesoCFwVwLP5gk6QcYyNICAzGr8CN1ctnPlGV9zqhAZ1p?= =?us-ascii?Q?ASVZ8SWm3F+khxjAKQoBolQHI3OV7ZDj5I3OjiPWADp4LUz6c283i+H9AdRu?= =?us-ascii?Q?9/MEI8DHDESfKQqwz2NyZ0Qh13PzuA0IquUqA7abrQwuGTa9udF0Nf6KEzJH?= =?us-ascii?Q?e7cVm0eEl2whjQMXAhVRfJYC8tH7AKv6FGB4Oi3euJMrWVI//uQi49z1LqzO?= =?us-ascii?Q?gMwMT18Z4RKvz5OwmTH/zWJgrDV9cWH5av43gdKcQjNz6wPwxfBnr9LL2NsM?= =?us-ascii?Q?nQKPMeQjsNRxKokwZ2yQeInBrmLgsTWqMQFu16lHE4JE3bj1skTrX9AeFDJE?= =?us-ascii?Q?geQzyOUPJjF3E67QP8bF54IxXl1jlcjTyI0KR1JFVZMldFI09+E0wOAkm5f4?= =?us-ascii?Q?b59TJSOGsXjstqBr87C0yd8d6SzDYT91e6+Tj1jUayZ8+1NfOPPshmc/4GyO?= =?us-ascii?Q?5yzplNtz+Jxau7ErCEONErkkZhf1YC6zM2Y91x1HC55kEJug9Eyz756lew0u?= =?us-ascii?Q?Gn2gClJGiK+xO6tgQx+VsftQkeElNAUR/Qvg0KjsMwv3Rn+w8R4I1MDpycsG?= =?us-ascii?Q?MfGDBVtdv3D99fGZyok4EHIxHv+Y6oLmI8Bf9O5+WgakqnO00XihPXBOkW7y?= =?us-ascii?Q?OVYSzsaJA1vvihpBJrbVjDThuWZiZjyZNbOIG6zMur5atW2boWcMXBbH+Ly3?= =?us-ascii?Q?Qr44ahomnqtIpacpiGmM2ylhhJ+Y6ctAs/dLRAhYN89Hw0JVFR/iWn+6WUW2?= =?us-ascii?Q?uXG1lz02wf7fRbzeMfJ/UVrabvCkb2au9D7J8SD5GIJpO3Gu7o8LDI+2JeUA?= =?us-ascii?Q?YErxizNpRo3V//DXxvklfJhDcKfGm+eVXL+S94HGpszUH2XyatVXgrpq/na1?= =?us-ascii?Q?VRiv2B3bPtWbZQTK7qnlZjv6BSvP77QRwupvxRLRcgaYuaxDjsBYpyf6M8mN?= =?us-ascii?Q?kUX0GhZ764+i4Q59qZwbMZxpJE58BXikgFG97AlLg17AhrPsny1m7K2DPspt?= =?us-ascii?Q?KMUlMuEv36j4GO7ClJDcJ5i/GRxpmRETQINyki2wj1ULtRM/v3LaD+JfzoGY?= =?us-ascii?Q?L8Tdf0EQdqK2TpP/rn0gWfsYW4an3LOF4z5KdJS+23F1UpCN0wG7TWuisp6c?= =?us-ascii?Q?iGKAkbrM4+/M62rKXh50I1/0xNpKNQZoBpNwqPswSMHNsQHXN0BY5upm1NEF?= =?us-ascii?Q?h96mFCBOqMCxONvJu0VNvUR+Zln1ElBumQz5L4Ur8KEJlefc8er7KroMSm6i?= =?us-ascii?Q?Z1/0aZDAUE+eTIZqUkBpqWoEMVbGREc=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82658bf8-6783-4949-d5ad-08da3e190066 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2022 06:37:12.7565 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nu2vgztBc0rvNJVI04tc8TfZsS6iFEv0pkA02aTSRpZwAioR9bQstVLvJeUw/U0W64YiBa3dNDZ9u6U9wNvGfc5DDORtBRJxq+3ONQuviUQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1988 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Akhil Goyal > Sent: Wednesday, May 25, 2022 8:10 AM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Anoob Joseph ; Zhang, Roy Fan > > Subject: RE: [EXT] [PATCH 38/40] cryptodev: clarify usage of private key = in dh >=20 > > > > - clarified usage of private key in Diffie-Hellman. > > > > CSRNG capable device should generate private key and then use it > > > > for public key generation. > > > > > > > > Signed-off-by: Arek Kusztal > > > > --- > > > > lib/cryptodev/rte_crypto_asym.h | 4 ++++ > > > > 1 file changed, 4 insertions(+) > > > > > > > > diff --git a/lib/cryptodev/rte_crypto_asym.h > > > > b/lib/cryptodev/rte_crypto_asym.h index 01b1fdd074..a6bb70ca3f > > > > 100644 > > > > --- a/lib/cryptodev/rte_crypto_asym.h > > > > +++ b/lib/cryptodev/rte_crypto_asym.h > > > > @@ -459,6 +459,10 @@ struct rte_crypto_dh_op_param { > > > > * Output generated private key when op_type is > > > > * DH PRIVATE_KEY_GENERATION > > > > * Input for RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE > > > > + * In case priv_key.length is 0 and op_type is set with > > > > + * RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE, CSRNG capable > > > > + * device will generate private key and use it for public > > > > + * key generation. > > > > > > What is expected for the device which does not support this? > > > How will the application decide? > > [Arek] - it is similar issue as in DSA/ECDSA 'k'. Or we will add some > > PMD flag to determine if PMD is CSRNG capable or it will be stated in > > PMD .rst file. If device does not support random, packet will be > > rejected (send to response queue with NOT_PROCESSED). This comment > should probably be added. >=20 > I believe this can be covered in the capability patch that you are workin= g on. + 1