From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09A4442649; Tue, 26 Sep 2023 22:07:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED89B40269; Tue, 26 Sep 2023 22:07:50 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 2DAE4400D5 for ; Tue, 26 Sep 2023 22:07:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695758869; x=1727294869; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ehXRBevALhZmPH+CVhl2MaSVpfSpeyQIhUjPBV3z/2M=; b=OvJwcK3VWoJfeEYwVk7R1ox4Ij33bNNmGA5yspyDYC2wqxxgJrGPhEC+ QOwWvShAw3MK5T6rnHoRYh8Go+vEY02WLPjzwYUSY/sIf6y02mqLOJUW2 ed0quejwTiHWCK4zl49t10hH7CyxjRtPkFMhbRq+Gi/E900o8dNw8u6iu jY4Jv43g+xZ8GjkPgOrSXAlO2KYA8ut9ctP7IvsqYLha77KrzWla3ZteX 2DuMRDPXrGKgP9LAUEC0ULFdNjwd/2YCu/2//gV4qhHNmMbQvFvAx5h9T 67NRo96GHBnTf3PPjovzq0SYXzrEpvHp2VXbSN8kYsWnZB/GXlL3A30WS Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10845"; a="384437592" X-IronPort-AV: E=Sophos;i="6.03,178,1694761200"; d="scan'208";a="384437592" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 13:05:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10845"; a="814597350" X-IronPort-AV: E=Sophos;i="6.03,178,1694761200"; d="scan'208";a="814597350" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 26 Sep 2023 13:05:11 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 26 Sep 2023 13:05:12 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 26 Sep 2023 13:05:12 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Tue, 26 Sep 2023 13:05:12 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Tue, 26 Sep 2023 13:05:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dOV0LkFCpMQ5YUcLaVtxZGbIu7LpH0uU6Rwz/WaBmje6LcWIYFJXeqvjQmFMX+7yyPwa+hbKIT8uayYZOk6AysA8lTQ1Yy4jUHcIF8xue47Ocz56xqAG0o0GQlHu5tFtqQBaFO9muK8hp7KhebShnXj6j6wvDC8dBVFGkJo3z1b20dG65WMUO6GsESC9YkUh9V6pTDpmJuYOEzl7M12KhtLgpj02ymfKju19SSZWZPp4NxZlOEIyu9ouQl7EuUeA8IUznryVe9O35ewII92FUifRAObWv4PWOK5YdbYsVwBM6iVEtNEuX2DGWtkjQo5jBTqh6OgW1CPRYGZU/GVIIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B0RKOi3Jx6ldMZxOheaAwDezmedpTCwo30E3k73uRPo=; b=Gq2VNm5bIwGtJ+qExm4cR07gkJQ/R8HcqjaZcsiHiGqpGk14K9ey84o+W8iR86+J90JcTbqZQWQB31aCJT8Agwj1V/Y0SBr69bubjAnq/HMXdx+HYIs46LqOvK8U5/ktyzPISs+YGvbnuNcj46WiviaAyFtOztRjgw1LdImJR+Dtggb+mzaymWqQighS1CPZWjxDvISbMBaVK64PhGiVTghvwEK8lubqz0d7xKx1SYsz9XvLbfEW134LbauqHtUdaK+dGOCly6+tCvCgp6XUtb+8xaXaWHVqlWNFJ4W2x0vpG5deYhKpMIBgc2X2Jri2MDlY5sbSkxdRvQz0FZqZDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by CH3PR11MB8546.namprd11.prod.outlook.com (2603:10b6:610:1ae::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Tue, 26 Sep 2023 20:05:00 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::88e9:812b:618b:1fd3]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::88e9:812b:618b:1fd3%5]) with mapi id 15.20.6813.017; Tue, 26 Sep 2023 20:05:00 +0000 From: "Kusztal, ArkadiuszX" To: Gowrishankar Muthukrishnan , "dev@dpdk.org" CC: "anoobj@marvell.com" , Akhil Goyal , Fan Zhang , "Ji, Kai" Subject: RE: [v1 4/6] cryptodev: use generic EC xform params for SM2 Thread-Topic: [v1 4/6] cryptodev: use generic EC xform params for SM2 Thread-Index: AQHZy3CBjO2FhZYFW0yzJzvcOBLLc7At0nzA Date: Tue, 26 Sep 2023 20:05:00 +0000 Message-ID: References: <463ed192eecb0f45116b4487741039d16f5e3aea.1691658879.git.gmuthukrishn@marvell.com> In-Reply-To: <463ed192eecb0f45116b4487741039d16f5e3aea.1691658879.git.gmuthukrishn@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5013:EE_|CH3PR11MB8546:EE_ x-ms-office365-filtering-correlation-id: 16fe6ef0-eeb8-4c1c-d6df-08dbbecbdd89 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Xnj4fjPVBj34qvpKUOF/O98cYhJAj/e0bFKxPFGAxNSP2SRrZivzXrve335CDeTQjwKeznPuGI46iVwVyFknDVNTP57unz7bN1EKqv9+GRDuI7OBmIpXFzbRUsUHIPWxiJlCCbvhGhAbOKOE1ur1JZ9uLgXn1kG6bWuc24PmmOVpBCt9Z0Jlq/pjpkYyRsxyQs13AZQbmXUBMzTNsxxyljyJ+lJatyuQt9719nyw2Mg/0PpxsO+9Hazli2rO3wRHxWI5aB7IXyE6n5kTNZyD7i5myqbkhHMREI3wxG1nmWChD5NbKB7zH98PG2M0HhGwL1AJy7E8jtF+SyJ3CcZCmTA/JRYRbRRFYVcli9X8ZtfLEbLV+ROI5FEzua1KlfDFGdh9BXALDg5ePWLQ4Hm7HOYexUPih+JesKBKLU8dH6D5jxtjVoWW95g82zeHZSprySxm9jOelxdASkd7CPetiWsVhQnShTSGHytf/SWB8fe9pgBIL2nuCDRQW8kvK3Xh/MFzBRf9zNHVVG3IqEsCNDjVPNEu7q3899l3KeRfHybOKa0SzeqOoVM6UI80PDYs0eWNAnBxlD9+eDTB6TTq4qHiX3XgTxCYXPEK+9VKZHm7SJW+tthDebzgUP9hjR8t x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(366004)(396003)(39860400002)(376002)(346002)(230922051799003)(186009)(1800799009)(451199024)(9686003)(76116006)(316002)(66946007)(64756008)(2906002)(66476007)(66556008)(66446008)(110136005)(54906003)(41300700001)(52536014)(4326008)(8676002)(8936002)(478600001)(71200400001)(5660300002)(33656002)(6506007)(38070700005)(7696005)(122000001)(55016003)(53546011)(966005)(107886003)(38100700002)(82960400001)(26005)(83380400001)(86362001)(41533002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?i4urU3NUkqiOCblZ5KDzjFSuEHJxuF3yUcxJ9eOOOdqBeiyztvhkELsqyCJg?= =?us-ascii?Q?YkIBXnk4TVUYXhuL6iYpIeK9nGnxeunnVfw7VC4THnypwhAMITU/X34eTMld?= =?us-ascii?Q?4nfDwVUdWxDjwUWJNE7PCetRvHrXFXVXIBq/1k3BA69hGXsjAMnu/Fcg0haN?= =?us-ascii?Q?xTpFJfcz7PFb/a1gNqbH5GCrbyvNAd2+cGfSkQJkgihrnBfl4RWnKL4rZkYx?= =?us-ascii?Q?tlQKLMN7FdqhDPup+Qs4Z99takVCXsseJrP5b1rokGZ56ytLZvhPtE6hCDzT?= =?us-ascii?Q?VLh/0Aq4S+eIsxyWRrhpooQyTEvVqiJCaRVAg0c8tSRT5qcqvBhGZDaeQYgr?= =?us-ascii?Q?QUa7k+ePQHjOFiPD0ztVmHSpLfAsoGmwgt4ptiXT5Db8IlobA4p93Img4OXt?= =?us-ascii?Q?VdIse1mpVshzvpkbseSpoWCBH0VWgZsOF1iWhvit2Bb5jtO7HP8gMXVzAsi1?= =?us-ascii?Q?Ssg6OwGLDRa/hOpHLJHujuMdcAzZtB/I0OqylOu1LUAh0RMrpHcRls8yDgcP?= =?us-ascii?Q?DblPM/xT0RL0B5NLAon88PRkoNcG67PiUy0rmWHeOFrpo9ROWmBujI1gzkwt?= =?us-ascii?Q?iY6w4frauCkuDd1Kk6jkyZEfyUdbp1ZX5u5c1L+ZHRumB6JQq4M7pzQFlu6n?= =?us-ascii?Q?YCYXWQBRCEXf7FaaH8hQOsU7IF01TzM0fuQ2Dn3agWMj8pIEuLPQH7gxiQby?= =?us-ascii?Q?fOr0IBMkfnYZOfQSSa/yv37AVYWXUCXFyvFFncU1jmXWVo52OSp+A/BumQ+F?= =?us-ascii?Q?7Sgl0h6pgIiL51vMH99Pev+6YECHZ1aIp2Q3MRdjFzxoAOY/8p0eW14VePFP?= =?us-ascii?Q?LAtcWIQHoldTXim6mdZL6P56M4B8QfBtZLTZdbSDXzpPKLfiliq3saTVw9Sr?= =?us-ascii?Q?B7yzh/XAvj4kPwp03T35FFw2O5EloM4zGnY9XyS0IbO7jyP2NnaLUeDRwKmS?= =?us-ascii?Q?j6nriXUBINikcnGg0LiQU9quDfi8eH24EA1gfY6xwuFspMcpY/sAPi40BkCN?= =?us-ascii?Q?dGCB9+zKUhT4XMkhv270PUETeZ2NStjUS34T3mfMgOhs8ySSKpLhgMSXhoj6?= =?us-ascii?Q?Zmbxp3jCaIPIjEvU4meZSouEmQ2nawSb73vWwFitQzeBu+PeCcuA7RsKvPJE?= =?us-ascii?Q?yLFUk/oAKEeSHbYQIblL/yHpofpbphC5cGw6EkRkTKWyQ3pAdCnaLy9+O5/a?= =?us-ascii?Q?OnUN/lqCiQ6UO4OHT/DWlG3BwJ5860nU2Q2Lq4mXuiWPNFTNc9vdt5BBtsFc?= =?us-ascii?Q?6oIDxxka5BcNBKGnPpZ06VL+NjXelYSbdR2C6YZTPrrNWbHslXQ1rg3MnGfK?= =?us-ascii?Q?m3BRnm7O8l282oNlzF25XxbSmlyGxl9jpxhJ4BpU8hRo7pvXuDg+azzg/U/T?= =?us-ascii?Q?A8yUNdU0bO0Hi5V3OQhVqx/Oi8mapB/anbSC+R0ttvsy9cVB6tfyQgQlQo92?= =?us-ascii?Q?O4KhAQpvRuvpIRwACg9yMkjKza9MWCyNrSS9ijsvxd9vYqwIxkoh03j8OE7m?= =?us-ascii?Q?diu4xNvV3p1BAfo8tBGCqH4r3N1o/n+2tL60wdDMKxs7qu2FA+e9T0M4LNY5?= =?us-ascii?Q?39sA2CW20hGq1Gy9jq4Vbk6q45xED1GxjPj5EXgqQ4acGcB/8+6EmeeIt6LQ?= =?us-ascii?Q?Eg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 16fe6ef0-eeb8-4c1c-d6df-08dbbecbdd89 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2023 20:05:00.7092 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 98OPXTH9OeIieHEfhV96e3S70kFu6hwvVrVmGNoig41GGjYju0epAoQTRF5I/LWXaF03jhZ5zY5ji5rfnlxVtNHv62UtYw4Vcrz97AH3taE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8546 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Gowrishankar Muthukrishnan > Sent: Thursday, August 10, 2023 11:35 AM > To: dev@dpdk.org > Cc: anoobj@marvell.com; Akhil Goyal ; Fan Zhang > ; Ji, Kai ; Gowrishankar > Muthukrishnan > Subject: [v1 4/6] cryptodev: use generic EC xform params for SM2 >=20 > Now, generic EC xform parameters include hash algorithm field. > Hence, SM2 curve can use this generic struct for setting hash algorithm, = which > would also require SM2 curve ID enumerated along with other curves, as li= sted > in: > https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml >=20 > Signed-off-by: Gowrishankar Muthukrishnan > --- > app/test/test_cryptodev_asym.c | 12 ++++++++---- > app/test/test_cryptodev_sm2_test_vectors.h | 4 +++- > doc/guides/rel_notes/release_23_11.rst | 2 ++ > drivers/crypto/openssl/rte_openssl_pmd_ops.c | 2 +- > lib/cryptodev/rte_crypto_asym.h | 16 ++-------------- > 5 files changed, 16 insertions(+), 20 deletions(-) >=20 > diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asy= m.c > index 0ef2642fdd..b08772a9bf 100644 > --- a/app/test/test_cryptodev_asym.c > +++ b/app/test/test_cryptodev_asym.c > @@ -1838,7 +1838,8 @@ _test_sm2_sign(bool rnd_secret) > /* Setup asym xform */ > xform.next =3D NULL; > xform.xform_type =3D RTE_CRYPTO_ASYM_XFORM_SM2; > - xform.sm2.hash =3D RTE_CRYPTO_AUTH_SM3; > + xform.ec.curve_id =3D input_params.curve; > + xform.ec.hash =3D RTE_CRYPTO_AUTH_SM3; >=20 > ret =3D rte_cryptodev_asym_session_create(dev_id, &xform, sess_mpool, > &sess); > if (ret < 0) { > @@ -2019,7 +2020,8 @@ test_sm2_verify(void) > /* Setup asym xform */ > xform.next =3D NULL; > xform.xform_type =3D RTE_CRYPTO_ASYM_XFORM_SM2; > - xform.sm2.hash =3D RTE_CRYPTO_AUTH_SM3; > + xform.ec.curve_id =3D input_params.curve; > + xform.ec.hash =3D RTE_CRYPTO_AUTH_SM3; >=20 > ret =3D rte_cryptodev_asym_session_create(dev_id, &xform, sess_mpool, > &sess); > if (ret < 0) { > @@ -2120,7 +2122,8 @@ _test_sm2_enc(bool rnd_secret) > /* Setup asym xform */ > +++ b/lib/cryptodev/rte_crypto_asym.h > @@ -69,7 +69,8 @@ enum rte_crypto_curve_id { > RTE_CRYPTO_EC_GROUP_SECP224R1 =3D 21, > RTE_CRYPTO_EC_GROUP_SECP256R1 =3D 23, > RTE_CRYPTO_EC_GROUP_SECP384R1 =3D 24, > - RTE_CRYPTO_EC_GROUP_SECP521R1 =3D 25 > + RTE_CRYPTO_EC_GROUP_SECP521R1 =3D 25, > + RTE_CRYPTO_EC_GROUP_SM2 =3D 41, > }; >=20 > /** > @@ -382,16 +383,6 @@ struct rte_crypto_ec_xform { > /**< Hash algorithm used in EC op. */ > }; >=20 > -/** > - * Asymmetric SM2 transform data. > - * > - * Structure describing SM2 xform params. > - */ > -struct rte_crypto_sm2_xform { > - enum rte_crypto_auth_algorithm hash; > - /**< Hash algorithm used in SM2 op. */ > -}; > - > /** > * Operations params for modular operations: > * exponentiation and multiplicative inverse @@ -649,9 +640,6 @@ struct > rte_crypto_asym_xform { > /**< EC xform parameters, used by elliptic curve based > * operations. > */ > - > - struct rte_crypto_sm2_xform sm2; > - /**< SM2 xform parameters */ > }; > }; >=20 > -- > 2.25.1 Acked-by: Arkadiusz Kusztal