From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30201A0506; Tue, 17 May 2022 13:45:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DC81E4068B; Tue, 17 May 2022 13:45:57 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 8E3E840041 for ; Tue, 17 May 2022 13:45:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652787955; x=1684323955; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=5hz/ziXQh8eEYSPT6sUUhjsehGFdw5I9KA/cm7U8osQ=; b=G6iBFE/+3rIvfMLQeOtAOia4laS/hKBlr8jtj1y2XfKluLfjt6t7M+fw oR6tz0/NVkZDJI6QUPQfe2it668+rzN8z9v20iFtSUUFCLpA2TePvFJpI 2zIB1hwuac5n7qRe7mb5SLuziTNLp0Hj6tVDljKChTRaY9vINA7CxMBrJ 8c/k5vFYE2H7YFZ1w/Y8poR4DjYVWql2/xmv/UwV1PWRO6Ku2EFtYMnV5 TiVdpDaowC+5VvpGQodX6+n/IxwHNEcLVJRog7q3q2khYuFvQg/YNbtqX GgRRAO1x78rUWzBv9uMPL24qMzRakiASmal0L+h/IvEXqDamoSD7Zxcpc Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10349"; a="270843493" X-IronPort-AV: E=Sophos;i="5.91,232,1647327600"; d="scan'208";a="270843493" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2022 04:45:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,232,1647327600"; d="scan'208";a="568849521" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga007.jf.intel.com with ESMTP; 17 May 2022 04:45:54 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 17 May 2022 04:45:53 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 17 May 2022 04:45:53 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 17 May 2022 04:45:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B6E49cOkIj+LuWTshYJevptFns3+hevnXevNY+VAgVoz1sRTi6KuPBGnEeMQPSTwhaIcXJi+di0FKoNL3qNg+wIDPs2NPUOJlRWiMF3r5VkeaUbBQtSOZ9QrlI1p7/FPr9wzSP9XfMzuAhYGvQ2VqpwIG3VeHfvPmKOw/rC/hiTf+r8wQMjSkgqwv9wHJrqDI0igKKlMpR4tKz0D+pAEcNAbxqJe+PCqW9DDJ0LcZdVmPz6YTV1OdFJsnCAENRfVEmlNQYs83Z7kIQdvpU45ebpfOEzRu24yJ4ZsViRvC8zG6YsdMd3oPQZNIhQC1mSwiXWplZnvBrvPxCkeZDxD7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SfP84n4a+zznYJASpfIAd6HDHhUAIPeGQjwcQznrNEs=; b=BOPjM/j/8OJxFg2ZUqsVZVBqH5rErLAsbDhAV2FPa0RpD1HuwtPjQWd8RlfDudsuhPXsgoRRXh2aH0C5lPM9f/S36qgUDk/2o1y0BcNq4Z3cxPJBuSlKxrNN6RBxgvkjT78yGdxvuQww026MDY/VsDcCgoRnwGq/7Yv98oZkdmHEhCmuNECJe7PS5ubYeq+yg+xiO7RVLVVNaEDTUeeJ0AILAn1cy/nK8lje0Hfd6tm2yul58XcgB5UK7e+v2jRpzK5ALSy1EuqOwVVr4oHVl+VfjfhLvV3ON0kgRK4riS911gJvrzaNB2LwzMOwzLNRmYokdQw8IkDLmPXKn4UnKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by BN8PR11MB3827.namprd11.prod.outlook.com (2603:10b6:408:90::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Tue, 17 May 2022 11:45:51 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::fc0f:1644:98b5:be1]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::fc0f:1644:98b5:be1%4]) with mapi id 15.20.5250.018; Tue, 17 May 2022 11:45:51 +0000 From: "Kusztal, ArkadiuszX" To: Akhil Goyal , "dev@dpdk.org" CC: "Zhang, Roy Fan" Subject: RE: [EXT] [PATCH] cryptodev: add support for 25519 and 448 curves Thread-Topic: [EXT] [PATCH] cryptodev: add support for 25519 and 448 curves Thread-Index: AQHYSoWEbOKfDI5+JEKb+UOUXNOO8a0iGI0AgAEZm1A= Date: Tue, 17 May 2022 11:45:51 +0000 Message-ID: References: <20220407134334.20226-1-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.401.20 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 11d7d608-5893-4b7d-dc04-08da37facb51 x-ms-traffictypediagnostic: BN8PR11MB3827:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OsXnDNvP/MZilJ6f0M0DcZHWYqrL80CnzUKEAYDtBmRYOzoWfwr151heWoFSTRLzTp8HzggiKooytj1LH1gc9X9lEht25ZTWnRHD7iHCr25lrAbh6K8JDfJgRax+IoPaxKo6xueeqABSynEg1yo4+4DCVkKLKJycdU4ubIjijTyqOlrhraIKPw36eoYDC5sGam4AwT2S8d3ri3RdgncxTDTUOxo+5EUDxeAlA9n24JRoRo5ufbQDd5H8DZ4jvBwXIC/PKF/ZhCG77avqs5/BjHSrKZWivX1EoZEJupsL7fEZzXsVDLKRTbSur6gMGXOVwXKpOjlvCFYkwhThmYWMxQjD/Tv4I2MUjoqAJnhg29PM314uywktOAKZZC1ePkF5JZcBBMt3BYxjonsteqn1h674TBUZ7vdAnvHaacb36ViKUd/RCShBfJO+cNcKJ2Tj5dNav/OsBcNwsLuToHqezYxwVooh+rSyZxB/bPUvvJQzJr3LqxnDm06AeWIR/pBagvzv8qzTQ3HiZG8nazjLGpLMXwUPk9y+5fGw8gSjen9DzXscaCKiOUkiTmrkVCjsI7dymM71NO/znTvnIyyLev1xAJ88mcoOnjznLBCsF33gRRtMauq+Jl1WKcBIs2WA/Mnbf4K5uI+UVjCLB67XrYRBAvARJ0GVTozBWwKr+mlh5NxzVT/0j5bvUmabYw3iXMZwq02A/ccNLz+90jCbUA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(52536014)(83380400001)(2906002)(7696005)(38100700002)(8936002)(122000001)(66446008)(64756008)(66556008)(66476007)(55016003)(33656002)(38070700005)(66946007)(71200400001)(82960400001)(6506007)(8676002)(86362001)(107886003)(110136005)(53546011)(186003)(316002)(26005)(9686003)(5660300002)(508600001)(4326008)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kTRGb+XMRwl1NKGYU1RHBU67/S3ayPfJOgL/8UtxlJq8Dl4sig5hIM1LVLhx?= =?us-ascii?Q?cABcXwD5gmF+Cip5cfxhZxSvG0kXdQGC+dq1iCPLrZGAosmvOZeZ3Va1+j9H?= =?us-ascii?Q?mI6KlOluQKHo+114YoL/vzJu7PTo1tSLmZLEfNIUDWqU7yYgkGg1st3SXZUy?= =?us-ascii?Q?3BXf1dLQ2XPc7dLMYsT5rVIcq7f7Wk+8sIiPoIuEUd7bGJqy9cZ8w4jMzhMT?= =?us-ascii?Q?ef+9ST51Fxs5d/p3EoDrBakDy6pCdigamGOKcf+greHnw8v+CmX2KdbXuMHb?= =?us-ascii?Q?wv+oNhpTlrGy0EbS2n896rRckddoxPrEDaaRea6BzcSEiZU8la29u5jjU75j?= =?us-ascii?Q?181biK4f0Bi4FzmWP+Naouq2051xACka5tYpT7cNAr8zdER0b73B5pQjRSKc?= =?us-ascii?Q?62lFoh8YKT1a9Cl3UangRSLYuT7sxqUByfVhC3qF9426bRe39PfOW0y/q2Vj?= =?us-ascii?Q?oQTl+A8gyjT4G+8ZvafqgLJzS9rSth963OvbqtCzMX2kegE5uDes4qyqJeq+?= =?us-ascii?Q?XDn347XafhUpVpd74joeAtZqb1kgD33d26S/N9bmiFyVE1E3kvcY8mcEAkxR?= =?us-ascii?Q?bD6ueOC7YxCu1+jgcDMtUWkDsCX2S1wv0sDz1D0AtUbtXkJyt1dQ2ksMS+Ty?= =?us-ascii?Q?Dvhnjxv1tS37ybyQQOoDTiQh4RGOUcJwuoUP38XmLC2QzSljV1cCmmMv4nfn?= =?us-ascii?Q?7YZbnUOQ9UUHoWNfOMQ9lZhN9uB3CIyvzBlw81OIjXq+4RjgvTafJLhpfBvM?= =?us-ascii?Q?264zgLTjeKh/74WqCS/tUtEKV2WGxBqXg0fSLVXDZzd90QPQwSoFDf3Mpeid?= =?us-ascii?Q?SOVs6B0HQCoK6eoykWcScCv53bmjcivF4JPUQml66QiwuOXsEkYIOIEKRAng?= =?us-ascii?Q?9eDbd9ZZ010rQSb00/PSYfg1Bz9g8aTHkpbVfxMgMv8xsa544MRmQ+qxyaXt?= =?us-ascii?Q?EStOHzQNmYFRPEc/eCGZjPF65IAxItX2Xz2wuZEpL9uxQuqOXg7p3zFvcKHv?= =?us-ascii?Q?y729Q6mpnVxrnoe/t7sqgqR8YaMHxWKQHQL0IyvT2Z9BGJ9xME3SuMwPUpi7?= =?us-ascii?Q?vZ+EudrLpW2FUgWCaulKEDBn4jh2A36fSgARFtuSKutPiM85eu4HqvI0YZPh?= =?us-ascii?Q?LqgNxmzTUjkZq1UBdNPALPwI2LvMn2Qk6RVYZlHkwlf3HQNJgYyPHwHhEuak?= =?us-ascii?Q?VyMbaNAWuIg8FzzrNbPju3BEy9zlFFrNevrPUPtPOwY48AyJ9pwr68D4fOi/?= =?us-ascii?Q?SqT0X6GD21FYbyFeIyRqhNm7+JrlH2pUgmpt60dYVIWsp0xti5H7y2PX067M?= =?us-ascii?Q?Ovz2zBP5mcU6HsrPX775x98gAizeGbbXtVHm5kPNqkN6li9GvRQQJCR5wTuC?= =?us-ascii?Q?Ola+lbDoZJGq9FFcqxjQDaVRebfEBG6Q18rQ2KnlcK3nSYr2vp+RjKIF28BU?= =?us-ascii?Q?63S0G0TeJ+ZnmunsfH+0N9xa+YssjuhMOEvplQOZI0MpK+ZOhrATfZib2phM?= =?us-ascii?Q?lAaU/ylZdkUcshgIhP9pE8uoisz0mKX9ZadKfCKRyDeW2ssYF++USewcuO7d?= =?us-ascii?Q?o3x+NeCsj8OGFhhbEmzTfYosv4WTFoibxneJzM7oKQ3NnbCBtO2hmhNdB7LP?= =?us-ascii?Q?1NH4hbm7c+MXqfo6QQMNhX08vzqBQzNIyrX9s03MV0f7Gh7ysSzVhiJCQTye?= =?us-ascii?Q?jYhdYihKW+QgswZCW96bMkdAs4dkLcXgfvGIW2uj8LLPOzYd62Trkp4dCF65?= =?us-ascii?Q?7ecIk9wmYU1Y1FDC/bpggnSH7NgOAIg=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 11d7d608-5893-4b7d-dc04-08da37facb51 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2022 11:45:51.8681 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IhesdJ7uzrtlskO9UIeB2m0MGQRf98g31lc+zAlfA90DtFfcm/2Z+VyG8ssaJsictSxGyYCSqS4dVZBcSCwrrmc/wcAchtJc+5twWrBQEbY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3827 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Akhil Goyal > Sent: Monday, May 16, 2022 8:58 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH] cryptodev: add support for 25519 and 448 curve= s >=20 > > This commit adds support for following elliptic curves: > > 1) Curve25519 > > 2) Curve448 > > > > Signed-off-by: Arek Kusztal > > --- > > lib/cryptodev/rte_crypto_asym.h | 14 ++++++++++++-- > > 1 file changed, 12 insertions(+), 2 deletions(-) > > > > diff --git a/lib/cryptodev/rte_crypto_asym.h > > b/lib/cryptodev/rte_crypto_asym.h index cd24d4b07b..775b2f6277 100644 > > --- a/lib/cryptodev/rte_crypto_asym.h > > +++ b/lib/cryptodev/rte_crypto_asym.h > > @@ -48,6 +48,8 @@ enum rte_crypto_ec_group { > > RTE_CRYPTO_EC_GROUP_SECP256R1 =3D 23, > > RTE_CRYPTO_EC_GROUP_SECP384R1 =3D 24, > > RTE_CRYPTO_EC_GROUP_SECP521R1 =3D 25, > > + RTE_CRYPTO_EC_GROUP_CURVE25519 =3D 29, > > + RTE_CRYPTO_EC_GROUP_CURVE448 =3D 30, > > }; > > > > /** > > @@ -180,9 +182,17 @@ typedef rte_crypto_param rte_crypto_uint; > > */ > > struct rte_crypto_ec_point { > > rte_crypto_param x; > > - /**< X coordinate */ > > + /**< > > + * X coordinate > > + * For curve25519 and curve448 - little-endian integer > > + * otherwise, big-endian integer > > + */ > > rte_crypto_param y; > > - /**< Y coordinate */ > > + /**< > > + * Y coordinate > > + * For curve25519 and curve448 - little-endian integer > > + * otherwise, big-endian integer > > + */ > Can you give reference of the document which specify this endianness? [Arek] - sure, I may give rfc reference here, but if it will go into crypod= ev in this form I am not yet sure. These curves could be used with DH, but cannot be used with ECDSA. Even wit= h DH it may be that we will go with separate {dh_op, ecdh_op, x25519_op, x4= 48_op} but this would make TLS group reference pointless, and we would not = add Montgomery/Edwards curves at all as an enum. >=20 > And if it is implicit as per the protocol, do we need to add explicit com= ments > here?