From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4EED2A0555; Thu, 26 May 2022 12:03:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EDF3B40E78; Thu, 26 May 2022 12:03:15 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 2663940DF7 for ; Thu, 26 May 2022 12:03:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653559394; x=1685095394; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=34Npz3pn/Agf/m75047EDp3TuL1Uh8D5771VmxfdQPg=; b=D096STzFgY/w846+Y9sTfULU2RM9HIATBGNgoK4lTdbYT2oJjApX+A45 45T6TGX39jHz8l5bJj0dHrpV030HU+sbTHShnRvNW8A03NZR53o1p+bKu d7GT/fWBPes1w+d8iymfSjX+yjeldOfZT0heo65M40KLpox4ZPF1LxKLZ VZD4IUQlFvqxpcqsYLjRsjXWHHzrEB7nSKTkTUjsF1fvUhMrm3z/E4jaN n046Sqw6k/tVR9dyOcSDmAZ5yBzoguPsrhVERnQzrEyXFGz265EyrT8hD XcUPZTRx+eBD87DkiNxlD0m1JltK3+WkV5BvRAG0sssmJMd9rmfAa/vjW g==; X-IronPort-AV: E=McAfee;i="6400,9594,10358"; a="256171659" X-IronPort-AV: E=Sophos;i="5.91,252,1647327600"; d="scan'208";a="256171659" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 May 2022 03:03:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,252,1647327600"; d="scan'208";a="642806707" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga004.fm.intel.com with ESMTP; 26 May 2022 03:03:12 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 26 May 2022 03:03:12 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 26 May 2022 03:03:12 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 26 May 2022 03:03:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mNFxO7KP/4YYWty3aMVt4LbRpeHnjNsok9kEjqOtG8nOhnPW+m/f7PyW50qtss0kk+XS09gjkt9w7yDfqktWgOZ3AbQiRAlW+GFMpuwtyj3G5r8bLC4/Yy4lybY1f7Me+c14MWzJjlYBMa6mM8X04Jit1Wsq463Oao2T6pupCcUP9Zu5RYQTtRSHa0AvdmnmqNp4gT5Cvha5+ni78HO37/x6pYrxzFGV5IayBZs6GnwKerkLU7nXyvaHJ8UDthcU6IIiEHoIQ9gvvYLQPU7hmgwxIM4nMstM84iodzrd3kLlWucN+Mpit60e/Mf0snMIFgZbI5UaExUfLrlM9y0vbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eU4hE7tdHeUl9/DiWIwkAknH9yt9sRm1aMoDjiT0aTM=; b=WHOZKP59kqQt/Ig8Af9aTzu6wi4f+Fj0qKq4C9IZR3t2aZEImcBYOU4HEdM5CA+M2/K+9paHu0RsEdRbrWUcUMFIT1TQyhW1Dz/o21pdxNcMc3mOiNTRshQ2ZIVR3H0I+1gclxf+KnItWcFRlpPpbsNnVSHEZS8x/bkpjQzI0/WDh0DkwsaitAHYnwE+3wxX3WPKRUXHK3RF6JYmP4SPKwWMg6pucFwJs4f3Avz/ZZBI4SguCjL/BqViT/w/LwUERRbK3SpP6v6j89s5gyQgymzsOj10rNBJI3kfIyOjFOfuu+xqZPm23tsMHPVM39avhDQ9x8ysiNEUrPqk16hkuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by MWHPR11MB1406.namprd11.prod.outlook.com (2603:10b6:300:23::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 10:03:10 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::c1de:722f:b4f3:91b5]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::c1de:722f:b4f3:91b5%3]) with mapi id 15.20.5293.013; Thu, 26 May 2022 10:03:10 +0000 From: "Kusztal, ArkadiuszX" To: Akhil Goyal , "dev@dpdk.org" CC: "Zhang, Roy Fan" Subject: RE: [EXT] [PATCH v2 02/14] cryptodev: reduce number of comments in asym xform Thread-Topic: [EXT] [PATCH v2 02/14] cryptodev: reduce number of comments in asym xform Thread-Index: AQHYcFkUSM+eeRHHNEi+47hjpTz8Oq0w6+AAgAAAf7A= Date: Thu, 26 May 2022 10:03:10 +0000 Message-ID: References: <20220525155324.9288-1-arkadiuszx.kusztal@intel.com> <20220525155324.9288-3-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ebb00351-0786-4de8-d4e7-08da3efef062 x-ms-traffictypediagnostic: MWHPR11MB1406:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: o8tC7DMp+NHUWg2plfNN+cGq1Htb/lj0yb8exhUjNASvUu3iU4YU5XMgBSTJCeC8Wroz4QxRMS46aYz4JmDIvNtu6yVX5FJ3nl8JiFdWj6QxXLXRSvu1PMBUrk/t3yDb2LbqeIsBVA9oJTvWWWBnaOK2TONAqtmQbvjm/L8+ch+qu1wcBB1szoEvlZVdWslNP8qiZpMdVPKX7du10cjoFwQAIkKI77KnZlR4ymLxVHHlC7DYuUHCSKNTwN+D6ODUnQVnGpBqF/dE0ixVWD+y4TLrmcAPspa37ay4U4W7afZwIB7j6TFvpOHJsbpg2JkPRbxwcnaPYypym98KUiydGuG7OvO5qQpV98KGIUHPqtATE7NByCNE3M9Ok5779CPSo8BGrRErDkLC0dBIjGrAfiS6/V1QnQ/iLJn9ZiO9Bpd22Kem1zJqTassUJyBYqegVaFia/7khrtXF6t3vDwiR9eydDU8gVvO9m98MndrndZqfSR/cblQy55WcuuWrM3UAW2hcXurTELWgCBZBFkrbrpQ/oA4bbWcICz9QLB94FJhAw+/LWiOrWjpbbsBgEfZhST9+mH56E7I0rB8AgGCQqpfSkh8Mv6vH0Ggx7JKZZ6UL8f3mXaF1y53VCfFZqybxrlNDkPFCNd0pR4yVjAGr4gENDZbYKK8+/XMcR3febVYbxbeBESdNGirgFVJSQwgcKIJs5NsECOdeqtjFhPkAA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(53546011)(6506007)(82960400001)(186003)(110136005)(122000001)(38070700005)(38100700002)(8676002)(66946007)(66556008)(76116006)(26005)(66446008)(66476007)(9686003)(86362001)(64756008)(4326008)(316002)(33656002)(8936002)(52536014)(7696005)(107886003)(55016003)(508600001)(71200400001)(83380400001)(2906002)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hlRxJCJ/2YFzTnbXePD5pMlO1D8gMx2n3y2T+xzeU78gVc+4nrEd7hOl5e7l?= =?us-ascii?Q?+Qp3lDqdLtNOuEO3ayFT8Aq2PBVcpTu9pBazQLcs0qP7CzXC6mGxYQ8ev9xf?= =?us-ascii?Q?tHEj6kPJ2Bm4EI8AbzxJ798terwHAHavVCgFCkGAe+POw2AFpre9H05jkXIO?= =?us-ascii?Q?HOBjGpUwB1BViFXV2zye5tRkyyXuPMDHPbMJ7lBpE9S3qV/1whhd/l/f1Nt9?= =?us-ascii?Q?f5h9pCuTwGWRAYwjRWrntJ/2N3OKjRV4fWLhQc4jWPUUzibeLGq67jaBR7Cs?= =?us-ascii?Q?gKhbZqT73OGWcY+kPTF6ypyb149BSzodYbNK8f4xjZWa+lVvpVxCFHjS65QY?= =?us-ascii?Q?W5+c1PhZVPJ5yhGQoCc+7A2hZcl7Mitv0MiA9JgYjJH0QvO+5XAEoXYVEDD4?= =?us-ascii?Q?vhiSzhh0CV40kvHG2Wx7HBcJKc7YFF5bS4Xo8FKJ9I4k3o6KqH7CwgupIORe?= =?us-ascii?Q?Ny0qHKvzvE6pn/GTaiCSLAlhe50njKuS6DH2FwRQLbOSQ8b4B4sLHeAVbrtP?= =?us-ascii?Q?64jAbmebT0ys2XJSxQaPHzKW8Xta5Ni+OdmZbxOscXRMUei1N7RGZkqltLVT?= =?us-ascii?Q?gjZdUERsuQuLxbIpOXgjWTfkIUXWu0cDpC7Fky79fdvJfTgmhuX1opmbtFWS?= =?us-ascii?Q?e364uCOk/sT5bwCDQmKSRFeEvIB8DD8+oDkq/vGHhLDhiIXCpRodjmyd/7hB?= =?us-ascii?Q?jwZQLKCaNNoDJMU3SxYVv/ZSHPzAfowlUDEU7txNenZa3ALXxsMnFTDAcqN1?= =?us-ascii?Q?mxoWSYtZe46ZvKzg9gTBgRdNt2Cx0BVc5gdcdV6jCm2dLwL+M6YMXEK1beBU?= =?us-ascii?Q?pfzYQrANNkRQ5flMTTQX9lDHWXmPon3Ma0C/hoH6Tp6udiDt1uF5xfnDp3d5?= =?us-ascii?Q?N76ZVm0RvGel+bhTDXbax1LZO7JcwKW9qr3VS4scM90SxyMXNWI8tNkcfp+/?= =?us-ascii?Q?ajm2zgCUyiVo3DFjJMx78YtUsiWSPPcVVpVbBDHKc420IOjDR6ZPY5+hBk7h?= =?us-ascii?Q?VgiB0jHyqQS7E05GYB0Dy21BRSY+YYz1qu51c/csZWYh0iTct+hBzmCkGg7R?= =?us-ascii?Q?3UZHdTrh1FtjUCYDA3GLyaHTAIZg3VgXhUWR2i7QNkHtp+1SHvg3GhdkYZ9Z?= =?us-ascii?Q?jzVAhxm2OCjM0MvGXi1TcQJmMwTVqd/gFSPqm12zx+sDhelxo2DWMU0gIiLD?= =?us-ascii?Q?YKXcqoac1lEPLnZB2zqIzKX7gVxQEEXEqjHUF1ex6peYvJTPlsu+QakCbyEi?= =?us-ascii?Q?TcIhshG3jjP6IFzAXCDp+mfdbXaAKj6B5PoFVT18riwOQLWechPjv9NuSApu?= =?us-ascii?Q?g/+tWdNarw0lCM0IJRpctSaujgvmIHQlOOAc2AtNV6sutEbL9PirHB3UdOKH?= =?us-ascii?Q?oDdoxa87l01be3a+tgEP1hMWOwLAPRVeL/6hbEyGJEWTJfsrRrxADKzZKIg8?= =?us-ascii?Q?mUh+o5bqg86+qtwqZCk43hYxYE9JVxZG+7rv3RB5/5BGyGqpPL3YdMcVTllQ?= =?us-ascii?Q?9f1EJ1vL6H0+EvxWxRT67NOhYSBmUk0naxFeS2ogLNtnhhAyyHXqidywiv8q?= =?us-ascii?Q?vdtjIzpwMhFcZXlJoyIhL/1gw6hlwN8GsiZv+lMJDeSyCyZuKZqThSa8ATdO?= =?us-ascii?Q?r7zU4RSAlxw+cbV+5JE3SusuMuCeZ9GgvA8EJRcDvBooJMaCfYdBBVBpht0Y?= =?us-ascii?Q?+//iaq3ReVZuqy0GGEI70p6AQIuUIiLnjmDG7RAN18JMcIv6OcjLOtRLp5Vb?= =?us-ascii?Q?rciwtoC+FLKQOKqRjvOee3wDyUmEGsY=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ebb00351-0786-4de8-d4e7-08da3efef062 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2022 10:03:10.1814 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ssmcceEH9RDOEQsWqiDSPUTNrhUGs3gp5T9Out6xd1/91y8B2PlwQV0/ikLiTX8ShrWs40QbkglGiYBSJnw+G4wp4UIgTg5t0RCykRS4hIo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1406 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, May 26, 2022 11:52 AM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v2 02/14] cryptodev: reduce number of comments = in > asym xform >=20 > > - Reduced number of comments in asymmetric xform. > > Information describing basic functionality of well known algorithms > > are unnecessary. > > - Removed NONE asymetric xform. >=20 > I commented on v1 not to remove this and I do not see comment from your s= ide > for removing it. [Arek] - yeah, sorry for that, I will keep it in v3. >=20 > > > > Signed-off-by: Arek Kusztal > > --- > > app/test/test_cryptodev_asym.c | 2 - > > lib/cryptodev/rte_crypto_asym.h | 114 ++++++++++++++++----------------= ------- > - > > lib/cryptodev/rte_cryptodev.c | 1 - > > 3 files changed, 46 insertions(+), 71 deletions(-) > > > > diff --git a/app/test/test_cryptodev_asym.c > > b/app/test/test_cryptodev_asym.c index 573af2a537..5aa9d65395 100644 > > --- a/app/test/test_cryptodev_asym.c > > +++ b/app/test/test_cryptodev_asym.c > > @@ -288,7 +288,6 @@ test_cryptodev_asym_ver(struct rte_crypto_op *op, > > break; > > case RTE_CRYPTO_ASYM_XFORM_DH: > > case RTE_CRYPTO_ASYM_XFORM_DSA: > > - case RTE_CRYPTO_ASYM_XFORM_NONE: > > case RTE_CRYPTO_ASYM_XFORM_UNSPECIFIED: > > default: > > break; > > @@ -440,7 +439,6 @@ test_cryptodev_asym_op(struct > > crypto_testsuite_params_asym *ts_params, > > break; > > case RTE_CRYPTO_ASYM_XFORM_DH: > > case RTE_CRYPTO_ASYM_XFORM_DSA: > > - case RTE_CRYPTO_ASYM_XFORM_NONE: > > case RTE_CRYPTO_ASYM_XFORM_UNSPECIFIED: > > default: > > snprintf(test_msg, ASYM_TEST_MSG_LEN, diff --git > > a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h > > index 7206652458..66ffb29743 100644 > > --- a/lib/cryptodev/rte_crypto_asym.h > > +++ b/lib/cryptodev/rte_crypto_asym.h > > @@ -38,6 +38,40 @@ extern const char * rte_crypto_asym_op_strings[]; > > > > /** > > + * Buffer to hold crypto params required for asym operations. > > + * > > + * These buffers can be used for both input to PMD and output from PMD= . > > When > > + * used for output from PMD, application has to ensure the buffer is > > +large > > + * enough to hold the target data. > > + * > > + * If an operation requires the PMD to generate a random number, > > + * and the device supports CSRNG, 'data' should be set to NULL. > > + * The crypto parameter in question will not be used by the PMD, > > + * as it is internally generated. > > + */ > > +typedef struct rte_crypto_param_t { > > + uint8_t *data; > > + /**< pointer to buffer holding data */ > > + rte_iova_t iova; > > + /**< IO address of data buffer */ > > + size_t length; > > + /**< length of data in bytes */ > > +} rte_crypto_param; > > + > > +/** Unsigned big-integer in big-endian format */ typedef > > +rte_crypto_param rte_crypto_uint; > > + > > +/** > > + * Structure for elliptic curve point */ struct rte_crypto_ec_point > > +{ > > + rte_crypto_param x; > > + /**< X coordinate */ > > + rte_crypto_param y; > > + /**< Y coordinate */ > > +}; >=20 > Why is this movement of code done? [Arek] - well this was to be part of previous patches accepted in last rele= ase. It just look more clear having this structs on top. But this is matter= of opinion, can be dropped from v3. But we need to keep in mind that there is already structure like crypto_par= am -> crypto_vec, and we discussed last release to unify it. Especially tha= t tot_len in rte_crypto_vec would be bit more useful in asymmetric cryptogr= aphy than symmetric. But definitely not before RC1 >=20 > > + > > +/** > > * List of elliptic curves. This enum aligns with > > * TLS "Supported Groups" registry (previously known as > > * NamedCurve registry). FFDH groups are not, and will not @@ -55,46 > > +89,23 @@ enum rte_crypto_curve_id { }; > > > > /** > > - * Asymmetric crypto transformation types. > > - * Each xform type maps to one asymmetric algorithm > > - * performing specific operation > > - * > > + * Asymmetric crypto algorithms >=20 > Since you are deferring the change for xform, it is better to keep the Ab= ove > description as well. So no need for this above change. +1 >=20 > > */ > > enum rte_crypto_asym_xform_type { > > - RTE_CRYPTO_ASYM_XFORM_UNSPECIFIED =3D 0, > > + RTE_CRYPTO_ASYM_XFORM_UNSPECIFIED, > > /**< Invalid xform. */ > > - RTE_CRYPTO_ASYM_XFORM_NONE, > > - /**< Xform type None. > > - * May be supported by PMD to support > > - * passthrough op for debugging purpose. > > - * if xform_type none , op_type is disregarded. > > - */ > > RTE_CRYPTO_ASYM_XFORM_RSA, > > - /**< RSA. Performs Encrypt, Decrypt, Sign and Verify. > > - * Refer to rte_crypto_asym_op_type > > - */ > > + /**< RSA */ >=20 > I believe it is better to have a short one line description is good to ha= ve For > someone who is new to asymmetric cryptography. [Arek] - ok, so this patch probably could be dropped considering above comm= ents. >=20 > You can remove "* Refer to rte_crypto_asym_op_type " >=20 > > RTE_CRYPTO_ASYM_XFORM_DH, > > - /**< Diffie-Hellman. > > - * Performs Key Generate and Shared Secret Compute. > > - * Refer to rte_crypto_asym_op_type > > - */ > > + /**< Diffie-Hellman */ > > RTE_CRYPTO_ASYM_XFORM_DSA, > > - /**< Digital Signature Algorithm > > - * Performs Signature Generation and Verification. > > - * Refer to rte_crypto_asym_op_type > > - */ > > + /**< Digital Signature Algorithm */ > > RTE_CRYPTO_ASYM_XFORM_MODINV, > > - /**< Modular Multiplicative Inverse > > - * Perform Modular Multiplicative Inverse b^(-1) mod n > > - */ > > + /**< Modular Multiplicative Inverse */ > > RTE_CRYPTO_ASYM_XFORM_MODEX, > > - /**< Modular Exponentiation > > - * Perform Modular Exponentiation b^e mod n > > - */ > > + /**< Modular Exponentiation */ > > RTE_CRYPTO_ASYM_XFORM_ECDSA, > > - /**< Elliptic Curve Digital Signature Algorithm > > - * Perform Signature Generation and Verification. > > - */ > > + /**< Elliptic Curve Digital Signature Algorithm */ > > RTE_CRYPTO_ASYM_XFORM_ECPM, > > /**< Elliptic Curve Point Multiplication */ > > RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END > > @@ -126,11 +137,12 @@ enum rte_crypto_asym_op_type { > > * Padding types for RSA signature. > > */ > > enum rte_crypto_rsa_padding_type { > > - RTE_CRYPTO_RSA_PADDING_NONE =3D 0, > > + RTE_CRYPTO_RSA_PADDING_NONE, > > /**< RSA no padding scheme */ > > RTE_CRYPTO_RSA_PADDING_PKCS1_5, > > - /**< RSA PKCS#1 PKCS1-v1_5 padding scheme. For signatures block type > > 01, > > - * for encryption block type 02 are used. > > + /**< RSA PKCS#1 PKCS1-v1_5 padding scheme. > > + * For signatures block type 01, for encryption > > + * block type 02 are used. > > */ > > RTE_CRYPTO_RSA_PADDING_OAEP, > > /**< RSA PKCS#1 OAEP padding scheme */ @@ -156,40 +168,6 @@ > enum > > rte_crypto_rsa_priv_key_type { }; > > > > /** > > - * Buffer to hold crypto params required for asym operations. > > - * > > - * These buffers can be used for both input to PMD and output from PMD= . > > When > > - * used for output from PMD, application has to ensure the buffer is > > large > > - * enough to hold the target data. > > - * > > - * If an operation requires the PMD to generate a random number, > > - * and the device supports CSRNG, 'data' should be set to NULL. > > - * The crypto parameter in question will not be used by the PMD, > > - * as it is internally generated. > > - */ > > -typedef struct rte_crypto_param_t { > > - uint8_t *data; > > - /**< pointer to buffer holding data */ > > - rte_iova_t iova; > > - /**< IO address of data buffer */ > > - size_t length; > > - /**< length of data in bytes */ > > -} rte_crypto_param; > > - > > -/** Unsigned big-integer in big-endian format */ -typedef > > rte_crypto_param rte_crypto_uint; > > - > > -/** > > - * Structure for elliptic curve point > > - */ > > -struct rte_crypto_ec_point { > > - rte_crypto_param x; > > - /**< X coordinate */ > > - rte_crypto_param y; > > - /**< Y coordinate */ > > -}; > > - > > -/** > > * Structure describing RSA private key in quintuple format. > > * See PKCS V1.5 RSA Cryptography Standard. > > */ > > diff --git a/lib/cryptodev/rte_cryptodev.c > > b/lib/cryptodev/rte_cryptodev.c index e16e6802aa..691625bd04 100644 > > --- a/lib/cryptodev/rte_cryptodev.c > > +++ b/lib/cryptodev/rte_cryptodev.c > > @@ -160,7 +160,6 @@ rte_crypto_aead_operation_strings[] =3D { > > * Asymmetric crypto transform operation strings identifiers. > > */ > > const char *rte_crypto_asym_xform_strings[] =3D { > > - [RTE_CRYPTO_ASYM_XFORM_NONE] =3D "none", > > [RTE_CRYPTO_ASYM_XFORM_RSA] =3D "rsa", > > [RTE_CRYPTO_ASYM_XFORM_MODEX] =3D "modexp", > > [RTE_CRYPTO_ASYM_XFORM_MODINV] =3D "modinv", > > -- > > 2.13.6