From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60E02A0548; Tue, 31 May 2022 16:09:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 115354067B; Tue, 31 May 2022 16:09:10 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 0259340143 for ; Tue, 31 May 2022 16:09:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654006149; x=1685542149; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=61W4sSDYDw7CsG3nRxoCM9pyGP9zJhSspRx8D0H9xQE=; b=Wifzo/zHHf1jwhR9fkfBf1fNUJ+GozWgDZZGqAhP6AY3z2M3NzAv9xRp 7maACUoeU95AEusHwK7x6I09j5x8sLMaPmfKIP4rL2VPU5vnWj+hVY6xc to5StNeHlIpyH2XQqcQto+bv9xwmWO8GtEfT/05JnpaV4CwjSfQca2Bfc 1FQNFL2NmYt9zAjpbuFRtkZnwrlK13VtOgKun3bq7A9FMb+T/kfRh4BnA LTdpAv6tJXR0GuLxH/CtjpJQkbrx4QKbwJ1M1gRcsEBG5WoGbTTG0N3ac VgtaUGCNP825sXMr9m4bekR753aFp8aQQcQR5djmE2HEWfWBqOZ6OgJlT g==; X-IronPort-AV: E=McAfee;i="6400,9594,10364"; a="275344809" X-IronPort-AV: E=Sophos;i="5.91,265,1647327600"; d="scan'208";a="275344809" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2022 07:08:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,265,1647327600"; d="scan'208";a="903984582" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP; 31 May 2022 07:08:13 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 31 May 2022 07:08:12 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 31 May 2022 07:08:12 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.49) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 31 May 2022 07:08:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RbNL71AetLiFISuldAa+mdLTMVJa0GCle6rP7/dQFkv2xw88jYKi3yMcxpZGP4BhusrZEILSWVzd+tqoKrT36x8AJ0iGrOPAmhGeKooPTxBgmoxK7oyhRPsktK0g2DdxR8UuOu8pzMnatNl7zHfQXF92Z1MY5v2+XbBmBGOal7q18wESvNbYwzO7BhqLs+FYlQxKNvu2VbyzGNJ6T0QxKhJhKPPh3CX3c9p+YL6XpnQL9e8BycastTU73u9GxKU45JR47TQuEBWf0sIzN5e1ZssRU8xC/hxL5Q9FCIknJb8IiUeMFUOvcFWeXpHqyBSku81GwsZWfevKTHmR6COrvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q29PiPluP7PLnt66x7LKAte01BAF5OdtAl0Wl139uR8=; b=jEKfGD765DJkQ+KnLndJ8SpxXdws1dHGTXeFNvelU7OVOQC8wXhj36scopZSKGMCQy10RRD5bW4gndH8qoP2H/iK2GxIzSHU9cjTy108lmS/Dwl/Pjm/9otmHvFrWhBn8mCL33u3fl7wLYdHvDR/qD2h+mUaPx1wO00P1E2G54CrFF6hblCOow8JeJNSz58BBoaWXLPexHlQeGRE1nVOQSG23lud3DLDlN9cpup2/vUHoPwAJz5FMS/4OYxZvKoTF+cIEIcE740jWAuAEMQ3I8N2dzV4HRzl0leIwk0e8iG/JFSgZTsSkNx3GgbMv5X+a1aKSK0xPWUP3J2fx0xkvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by MWHPR1101MB2269.namprd11.prod.outlook.com (2603:10b6:301:4d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Tue, 31 May 2022 14:08:10 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::c1de:722f:b4f3:91b5]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::c1de:722f:b4f3:91b5%3]) with mapi id 15.20.5293.019; Tue, 31 May 2022 14:08:10 +0000 From: "Kusztal, ArkadiuszX" To: Akhil Goyal , "dev@dpdk.org" CC: "Zhang, Roy Fan" Subject: RE: [EXT] [PATCH v4 02/12] cryptodev: separate key exchange operation enum Thread-Topic: [EXT] [PATCH v4 02/12] cryptodev: separate key exchange operation enum Thread-Index: AQHYdK0Ohqlh7Udw5kqb33ma5u6cha043u+AgAAeQxCAAAjQYA== Date: Tue, 31 May 2022 14:08:10 +0000 Message-ID: References: <20220531040439.15862-1-arkadiuszx.kusztal@intel.com> <20220531040439.15862-3-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0b455a37-affe-4132-ce5b-08da430efe7a x-ms-traffictypediagnostic: MWHPR1101MB2269:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1hP3R6AXEAeUDHx4LNUHpynRSkUaCvuUEKCfVV4ykxre95VJ+eqnUpUi2VfuL3yXHOKtNCabd7QlS5Xr+TlPMXKJVsYFUuo0wcMAenXaV4JXJgxQNk+n1tmOpS1DYaQ41snIYWAASEkVM153wtxYUtuW6LQOETVqREzS0DAaAIJthu3r6N4shKPI02rVcffvAGivuwYMw7cdr2D6zYIMS0Tf2zI/rODOPSwyjIm7j9rgEb1S/8ezhE2etOlAW7Std87cCg4KXqKYDtEhMOVeb+pLi5PzsBspkGBvcMu63NaxriGVKoN5u+Fz90dNjy72yd/xM8VXq+K68xnoC897C5pxX6ivKDe/Ggi/gzZgRoVE8+aKzaiG9lzhIjNU6e1Qx/ZZ9P3fPMEsPbJLWkD89XZcR/AuwqOIEVOl96AF40FnZVvQlRlfuuDbWpWx8VMbp64YNUu6A5KRWYSUBaRykn9y5TsxKDai6x+JkX+4k55hDxrapPbsVcpJugu9MN3DvKOxqBHbgeDtb7wBeLy/FHykcmzflX+4S6rBbyicTUBX/82uzjH2VyK8w9mxhCfM6BJGpWnUugi05OczksiTwCE3/x2afAL04i8X98lQ7XJqps79B5SP9KmWPOVV0e1dg2fc9S3p7FjUjJNRVRlwkmejC8i+099iBhT2YdVyvDjviNY1NhvedM67z5Do/e1ozfI07eQ4ktWYdjJV99jJXA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(53546011)(52536014)(5660300002)(33656002)(8936002)(7696005)(508600001)(86362001)(6506007)(2940100002)(26005)(9686003)(2906002)(122000001)(82960400001)(64756008)(66946007)(55016003)(38100700002)(107886003)(186003)(83380400001)(38070700005)(316002)(4326008)(110136005)(8676002)(66446008)(76116006)(71200400001)(66476007)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dPZL2QjY0b1AhCV/ezYbPo69/XD3TduarL1NqbNOGXYOiFIVQcHGZcNRnbnG?= =?us-ascii?Q?Ef884Yfc5ANUb1gOhwHCXu0WyEOjbnzW/VeSUPl8dEq5bUVbRNuKEJGdTIdi?= =?us-ascii?Q?v4trRX9h7ox0z+I8+L6PEnL0kmzt2DA7doqeeEL37z8N/iDEsNTS1rf3iLKy?= =?us-ascii?Q?1SRpuAnUXOHTjoao9O0sS9LbaVsf4lKSU3eTGJYP1Md75Gc4hNSH9ao6WWen?= =?us-ascii?Q?facWaYqFnoO0Bg5uRYIppoA7ISEB2lxsi8ZfESk6OBRVP1ofIPxbsSx5UMXh?= =?us-ascii?Q?xM5C47YoiHjoxFe/yES+5398BIzlytI1C7HhlG48oBb+DaIWqyIWre1jxDqY?= =?us-ascii?Q?WVBYPiANxf8ZNI28z45u5Yeb34BJKuutLDWEc3EkCS269/FByk/0xPyUF+tj?= =?us-ascii?Q?DTuSB9y44Ug/2PNJe+NsHX5DoPZ2ztSeI7DHnjchMXf3xNozKhezg2DfEVKy?= =?us-ascii?Q?RSoMcA5gBIm9Et2oVlR9YC2EM3bBsQehO5M2gxSi33AS2aRm83Sch3VzOMF2?= =?us-ascii?Q?71A5ycj4P0BKwWUDDBUmDoLZNEO72puyh7/opVzaO0DwMtFsJBPP2irGWswM?= =?us-ascii?Q?cfEugXEV0ZhdYTcwh1HwfQ8+Cyf5l4yJYfaWO7guKoXJRk6ZPKUG1IAPKa+o?= =?us-ascii?Q?YSVSfzzK3ScEN1oydg6e/KSRdsm2IM+lc2GhuMZzhCTXTVgnUnZ7XkTlN9QF?= =?us-ascii?Q?gxM1jMn1wLDHY9fYw56Hhfm+HHC0ILHtRdVsGUFsFniYO1W7t9hNETa9/xQO?= =?us-ascii?Q?I4IjFHxJYfvOTN9ARCsAL9vBISGnPjpQ+Gbv3yjCEVZ2vwOQYMaMPbspGU7l?= =?us-ascii?Q?0yRHgh+IIfr0Yf+dZpTImerdP7SYFL9Ut/TRqwe0UiNenhjFMVMRX//FtN7n?= =?us-ascii?Q?cl3cUb1UBWPPLA5u4LH12I9NSygJsvXZ3MOWlWFOR0dSpK+q3vuRt1jbF3ID?= =?us-ascii?Q?5QjptFrIXJTVEuV7WIPBKgi2lhihVTkx3JWCF4jQ/AQPDIp2QSrJvsrlKJ2R?= =?us-ascii?Q?QSV0zfkU9nq1iooFRpDuM9kEolRJqTyIPy8MMYfsUf0/UUtQ4YB4vp8Qc596?= =?us-ascii?Q?jrljLM5Udn/H2kc1JftcwxSxAjW5pHx2GgkJhlxzin8BIyaFnWW/N9TzxBF5?= =?us-ascii?Q?NF6btzKMAflumusveyR6vDLbD+HZWSXfl+iPNPEM0YUVLTOpKhoMj6lgPMjT?= =?us-ascii?Q?IvYUjJTmcuMJFzyMP4LRaJpNrDObPNL6nFW5mTVx72nP2VXfR+4CxkcMKu3v?= =?us-ascii?Q?CFQbbOwGMtvRHSjk/7UwArw+vYHkeaOPNqdYa2Fmwdzw1qXEnt6QMw7RLVWc?= =?us-ascii?Q?8X3F0xAt5aHXdzZdhFfad4pT9xHRPpYfWXFXoGRw/n/emfS+XW79C1V219p+?= =?us-ascii?Q?ylqP2/AVdwceg3xlLcVSrrzoL8btqnbGiVgQamjGxuRsTL84/zohyVEyRAAm?= =?us-ascii?Q?gBibY1Ja0H9qu5RUL3aHi1kpRYVfTbWB7kF6ZlwMgtJetkFQaV6RBW09/Ci6?= =?us-ascii?Q?mrZYc7z8b27F4wV6ke6o/NJOxx4ISv4/ODaAeCXodlO94GNbEn8jlssdHytb?= =?us-ascii?Q?YXRtJHPf5WlJq/TwGupkSHbgotPaf7cmANNK66Kh4JcXliUXfW2quA09l4PD?= =?us-ascii?Q?0i5efSXoyswbUq67DFHH/QnOoIHBQQoOsF+ZDIF86NBA1Lq8qMtiOI8pE0jM?= =?us-ascii?Q?+0fM7LgwmO/PBGJ07X7/ojrzrgNgr+8Dwb/W2dDZoS2n8Jb0ufep0fo2szwS?= =?us-ascii?Q?w+fUq87zmcZ4uECq/nZpcxD7Mpv8P0g=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b455a37-affe-4132-ce5b-08da430efe7a X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2022 14:08:10.4098 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bJaxz+V5IO1njPbCCDNH34kqCbczwsyhaFw5gTvOVe0s0dEchEuRuDeRaIm9SWTMFOfX5sgdhECZoNLs8wSJg90Q29NyuGMudUgQe4EnZQo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2269 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Kusztal, ArkadiuszX > Sent: Tuesday, May 31, 2022 3:50 PM > To: Akhil Goyal ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v4 02/12] cryptodev: separate key exchange > operation enum >=20 >=20 >=20 > > -----Original Message----- > > From: Akhil Goyal > > Sent: Tuesday, May 31, 2022 1:47 PM > > To: Kusztal, ArkadiuszX ; dev@dpdk.org > > Cc: Zhang, Roy Fan > > Subject: RE: [EXT] [PATCH v4 02/12] cryptodev: separate key exchange > > operation enum > > > > > /** > > > diff --git a/lib/cryptodev/rte_cryptodev.h > > > b/lib/cryptodev/rte_cryptodev.h index 2c2c2edeb7..7d683fd728 100644 > > > --- a/lib/cryptodev/rte_cryptodev.h > > > +++ b/lib/cryptodev/rte_cryptodev.h > > > @@ -168,7 +168,9 @@ struct rte_cryptodev_asymmetric_xform_capability = { > > > /**< Transform type: RSA/MODEXP/DH/DSA/MODINV */ > > > > > > uint32_t op_types; > > > - /**< bitmask for supported rte_crypto_asym_op_type */ > > > + /**< bitmask for supported rte_crypto_asym_op_type or > > > + * rte_crypto_asym_ke_type > > > + */ > > > > How is this supposed to work? > > Ke_type and op_type are 2 separate enums which can have same value. > > How will the user identify which one to use? > [Arek] - by algorithm - xform_type. > > Shouldn't we split this too? > [Arek] - for me both options are ok. For some SM2 may be bit challenging = here, [Arek] - wanted to say here that I prefer not to split it. > but in such situations we should have different op types for KE and OP. T= his > would spare this API from having one op with majority of fields unused. > Though it may be split too, not big problem. >=20 > > > > > > > > __extension__ > > > union { > > > diff --git a/lib/cryptodev/version.map b/lib/cryptodev/version.map > > > index f0abfaa47d..dbf1f62199 100644 > > > --- a/lib/cryptodev/version.map > > > +++ b/lib/cryptodev/version.map > > > @@ -108,6 +108,7 @@ EXPERIMENTAL { > > > > > > #added in 22.07 > > > rte_cryptodev_session_event_mdata_set; > > > + rte_crypto_asym_ke_strings; > > > }; > > > > > > INTERNAL { > > > -- > > > 2.13.6