From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B20C1A0553; Thu, 26 May 2022 14:15:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A3E3C40151; Thu, 26 May 2022 14:15:14 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 09F2340150 for ; Thu, 26 May 2022 14:15:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653567313; x=1685103313; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=u02DetoajzBn5P3Xpzzd7ejYqyrmVVf3wRH1K7+vHdc=; b=Mm5hLE8vmiZRrN8wKm1qo6yxtHlrtdili1uIkXStjcQH4WFzj7cZmRGw 6f/4UiOrG1SLm/VBAWn6cH1z0nZu+JsSORXb3xdtpDHNNGVRiIBesdQvL zjdO/dBmymNL1wlLI/BurhPUvoG8J3cGfcUcfWE01+7hEwPKZvtPKzwME ZeMEVy5kqC9P9186xNS0CE/AVm4LlKqBFJtbN0T9ZqnpvbNLeOIfTGmbN u8nMv0KKfkyMIj/u2mUVKGOPViP3CirKWlhGIe6X56VPUWe9Erl65ZcXq Ks39kJdRmRxVSFwd2+fLkjZ4737A9NRRJpkI8SKo0pbHb7Dx/+aK25KpW w==; X-IronPort-AV: E=McAfee;i="6400,9594,10358"; a="254010386" X-IronPort-AV: E=Sophos;i="5.91,252,1647327600"; d="scan'208";a="254010386" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 May 2022 05:15:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,252,1647327600"; d="scan'208";a="560180074" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga002.jf.intel.com with ESMTP; 26 May 2022 05:15:11 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 26 May 2022 05:15:11 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 26 May 2022 05:15:11 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 26 May 2022 05:15:11 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 26 May 2022 05:15:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JgHaaUMNRrKLPTkCu4MHyjVs6hdoFFLpP+gYbBOrLjTs1GWL2khlTxpPvAflv88ay5Ye/xfk02+QUSDQ84uciLXk2Dpq15rq9W6qpDjtTGIT4CvlNTAqDG1Lm4hKPj0MF/PIJzb+2rPv7vMhRCbFm5lyf7Ei+Ri1vZ2jKciqoXjhhKsgIy3KMq6nv7OBXlem8i6GhUQLI6PZ4dmE3LKEa9GX3WImnD5SXnc39o5CWKR7pRZTN4eUnpTPWgMEXEBtSLK3f9bn2qDkkUw8b6FAE5bC/DRVmog/ncxlxXIU9ratW8r3cYJzj9KKgb9hSU/i/fgIT74AndtFFCeeJnty5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=as+kFF5BFQD4agI3q5n5qn1X1aWGVGfAD+tjAKbWMN8=; b=Rh0WhfS48vwTalhZW+RxIg0Xpv+NE9wnuEiWM0UOduX93tnlaf5mOJ1irVAxUBuxrIcyS1oN2PI1NuQ+Cpew9dqfLABX6fbnPFTvWXMo//kZaPSh8Ivzdq7TZvSZgP7FCLBiRa/7RDUkM6F5w6fl92K8CG3zE+CAkFDuRjosOAyfooGRWZUhvN+lrfPVjvw8gIvlv1/smLpkiVwYoRr3Cpt3UD5rlfCHtoDCQjI3wzzkCR+fSCnQuWP/PQIedt2Qrq0vEtHhbW4nncFe+ieF2SndOjvlZLI6a57r/xnngxSH+hMg4SdNaaWNGzApeC63XSwUunJauM13rCWheHm7sw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by BN9PR11MB5468.namprd11.prod.outlook.com (2603:10b6:408:101::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 12:15:09 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::c1de:722f:b4f3:91b5]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::c1de:722f:b4f3:91b5%3]) with mapi id 15.20.5293.013; Thu, 26 May 2022 12:15:09 +0000 From: "Kusztal, ArkadiuszX" To: Akhil Goyal , "dev@dpdk.org" CC: "Zhang, Roy Fan" Subject: RE: [EXT] [PATCH v2 12/14] cryptodev: clarify rsa verify with none padding Thread-Topic: [EXT] [PATCH v2 12/14] cryptodev: clarify rsa verify with none padding Thread-Index: AQHYcFkisYcTcbcXhUaV1XDqDFCuk60xEXyAgAACK5A= Date: Thu, 26 May 2022 12:15:09 +0000 Message-ID: References: <20220525155324.9288-1-arkadiuszx.kusztal@intel.com> <20220525155324.9288-13-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: aba1b44e-be4b-45d9-35a7-08da3f116062 x-ms-traffictypediagnostic: BN9PR11MB5468:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6O3ck3fdyZaYXgMg7L6WYUoH2/eSgpaHuMylof9gA0PXgVL7aJbl2FQuMUqGV1NaMIWAndo8jgZK/75c1mQjU9ZTDxrG/xRi3BN7NkyjK1MbloPmX+goUU9wjmK4uru6HzeHqlae2IO3828nNyEB1CoxOgGsmjq4uJoPwjNXvot7RV4BqwzPnhvdFJjxeWXtwaBE/QTqoh53ARDHYMpH0B3UEJiFDgs7TaXxF2UbqxD+vo4ynO8FN2FgJj4wlzmLwyw+2WvzCrd9sFf+I10Cpsryysr+wVhkTdmM373ukzw6AhHso9Fp4H+Yotk2KFlHmmETwyr8Dq6ZxpClDwArj12+1Er6FtSyRap5l4/ZVNj7aVlhP44Aj1vZFOagiv2TWSKTd8Vn+/efhxCHY2j+gb9HVLjQ8WKugkA6IDW9A0B8ndE3L/heQP/wIYRb0KIxHvQmrj+xA0FJPE4GbRGYS6qdJylZzMdvvvaksmNxEiWPBF3AfaeWTutHYuo55ksnB7byR7/IKvjy9JAl+6j1Nym1Nn1yrzKk6iWAW4ipaWkRMXuw8WWelr3EnHja8NTpViitPwGl4g5t+uPN6SWvXLPOkVvNyQG1SJ7lPA+P3Cj/z2B9WzvS4sgfeFysnLSBm9Ou9Voqc4qJZaaw6kTSDnZstljKT5vDpmRxt/TCkBB8amuV//ccqJQ/xLGjXfVAEXUOhrlktNMA3NNbd2K9VA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(15650500001)(71200400001)(52536014)(76116006)(38100700002)(316002)(38070700005)(8936002)(7696005)(26005)(107886003)(4326008)(8676002)(186003)(86362001)(53546011)(6506007)(122000001)(2906002)(55016003)(508600001)(5660300002)(64756008)(83380400001)(66556008)(9686003)(66446008)(66476007)(110136005)(66946007)(82960400001)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2j5rBdXDvRN7cNBAcK7mPc4hTjrYyGkvAi/8EXLDo4p2Tk2XmRonQzFTN5ou?= =?us-ascii?Q?giKIqWk8O5KTjb4+d0AuUgoLae6EbijKBFkr0o19LauLUV/wrdlJVGToN432?= =?us-ascii?Q?AGDPijPwLOjzvqGpzOllSpPSdDrsGOA9ttuzbwVOvpyiXhttEFROFAMGmq/V?= =?us-ascii?Q?tpLpgJ6a11+lCCznVrMSqG0xqvppq9Re152OHSOtzWqoIfzIJnPFDPGYdCGx?= =?us-ascii?Q?kD92UktjuwOmiT5hQiR7c0n7+hZjIF7n/htp9vw4r+IYfmfDBotHFyiOysS8?= =?us-ascii?Q?cuaDbluOm98BAg00ApEOgwKzQVKykHgWHpcf1JuVRU4kKXBeqZNj23jBNtau?= =?us-ascii?Q?pHZL2dR5ILTfUPMHzXRbKpghmvIvKGDmD4JtU55WZ3LOLSC3DJV+MUEfak4N?= =?us-ascii?Q?jttWs5BYGhA70vjo58O/dFzRTtxAP223tUlL5IxJWeQarieBc+cPutA+28/D?= =?us-ascii?Q?ZoFC4UK8h6Whr2bTjE2qjZcOGe7FtUlhHlGyRsFQz6ZdmmFwCuYWVORuX/mb?= =?us-ascii?Q?7TetUR2QFqv1PDgP/BxHylvSjZPoenI3ByvMm4Tj+eiJNoyZSf/OfPr8eJ3Q?= =?us-ascii?Q?JOC5LX1oCM+VKxE7Gce1SrNLg21BZIfPcSBg/69yi9MwjP4AduyksbR6m+rd?= =?us-ascii?Q?Rf+ejBp9fUt3RNe4fwMzNqjZNI7ncitjrHBvrzzM/inTmIx04jIemYKhNw3O?= =?us-ascii?Q?4zlcQzl0ACJStbZEt8YB8uDMhQuprgwUQJhUmHup8Pr5ywPC9RDzKvSeRvQa?= =?us-ascii?Q?p1R1JIx22MnOkg71xYJmqZVktMaj6l2S/d95I1brref4STv0tpscsg2JbZRs?= =?us-ascii?Q?B7PMAlPUkfibTM8ZhuExncmgAmu5DHwFY5wOnUP9UjPJg81xpjEmnACknrZk?= =?us-ascii?Q?f4xWuklDdcI599UGI8UjpQDfJJBq69UENo0tUKprRZuJ6ukce+7TjN8Pyvi9?= =?us-ascii?Q?mbKuMLf2WrOmW3t0uf6sJWMZB2ep4AyDCTOYsdDcJTjdxhTujgxYauF/GVYB?= =?us-ascii?Q?ipHk48qbHN6/vec4MgLpvpndGVOYWibNqy8KbN8NNtzAI4JD+3PBJ6CRTz6e?= =?us-ascii?Q?+NwuxkFgQ9rGwVABdBD/v6NthRkMZ7BE96hdDwJgT6VIY4RM10SuvWVzsRdC?= =?us-ascii?Q?IDXErmUaeWmc48hTJui4wxz1uBABT3mJjCmqFeqH2FP8n0Yy9Hnx3PZOkpjf?= =?us-ascii?Q?+G7cFuv6bvIPsNvLVXhWm9J5xJodEXfbaeohQqF7zLFEvPCyQtMTwokvFLon?= =?us-ascii?Q?ApWm2XcsI7rh75dueGNcWN2x2E4CX5EVBElRptzDsXaa6t8N7lrbd61IFrOp?= =?us-ascii?Q?2NkgQRT1MAazgnXq6IIhyYb8IlIglMM07c3pa1T1i+/3ZEQfbjAOg5Iz+Tqg?= =?us-ascii?Q?WoP9WMxzA36uB0m10cujiPfUHtVvkmW8iHhe/6sh1PDC+xYecwzgNDgEMDk3?= =?us-ascii?Q?XYQgWQkxIw1cFuzOk9wyCn78FqETqdeN3UZj9IXKzvtBP2+fO/xmqlioNDQ5?= =?us-ascii?Q?9MUOFGgG8BU8xsQSpcPOE/dHN5/DVJZHxDvT+asM/E8UbYIPRA9jqhGpf39p?= =?us-ascii?Q?elGRP9Q4LqG4yzq2AcU2K/WDPV2UWrfccyj2snS2eUZ+vpTaQUsGKue7Tb3f?= =?us-ascii?Q?l3DqJBHzob0aNOD1iWxstU+wdE9JatCb/yo46KHHmmhTHGrixhdcdc9vZwGf?= =?us-ascii?Q?MWT8IwLrleHHKTSBXmjUYrW3ljPzc+4b0ZT1zxVzy2/0tSTwyyqfJH22PptS?= =?us-ascii?Q?oN7f7gnEQt6CWswA/5lQMjc3QNfc8fk=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aba1b44e-be4b-45d9-35a7-08da3f116062 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2022 12:15:09.0233 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZorCdX6bIOQDHSg7a73I97glsnwIJwICNJ1GpVA9FIsKMhqbdDLn17QE4CMXIc3G/PvN4bfHaS2ACEcevoBSjqaOnAbUsfw3inV4Kbhu2fs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5468 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, May 26, 2022 2:07 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v2 12/14] cryptodev: clarify rsa verify with no= ne > padding >=20 > > - Clarified where should output be stored of signature decryption with > > padding none. > > PMD is not able to know what padding algorithm was used, therefore > > decrypted signature should be returned to the user. > > > > Signed-off-by: Arek Kusztal > > --- > > lib/cryptodev/rte_crypto_asym.h | 7 ++----- > > 1 file changed, 2 insertions(+), 5 deletions(-) > > > > diff --git a/lib/cryptodev/rte_crypto_asym.h > > b/lib/cryptodev/rte_crypto_asym.h index ee0988d3cf..9f7fba3758 100644 > > --- a/lib/cryptodev/rte_crypto_asym.h > > +++ b/lib/cryptodev/rte_crypto_asym.h > > @@ -372,8 +372,6 @@ struct rte_crypto_rsa_op_param { > > * (i.e. must be at least RSA key size). The message.length > > * field should be 0 and will be overwritten by the PMD > > * with the decrypted length. > > - * > > - * All data is in Octet-string network byte order format. > > */ > Patch description and title does not match with this change. I will add a comment to commit message then. >=20 > > > > rte_crypto_param cipher; > > @@ -388,7 +386,8 @@ struct rte_crypto_rsa_op_param { > > * at least RSA key size). The cipher.length field should > > * be 0 and will be overwritten by the PMD with the encrypted length. > > * > > - * All data is in Octet-string network byte order format. > > + * When RTE_CRYPTO_RSA_PADDING_NONE and > > RTE_CRYPTO_ASYM_OP_VERIFY > > + * selected, this is an output of decrypted signature. > > */ > > > > rte_crypto_param sign; > > @@ -402,8 +401,6 @@ struct rte_crypto_rsa_op_param { > > * with enough memory to hold signature output (i.e. must be > > * at least RSA key size). The sign.length field should > > * be 0 and will be overwritten by the PMD with the signature length. > > - * > > - * All data is in Octet-string network byte order format. > > */ > > > > struct rte_crypto_rsa_padding padding; > > -- > > 2.13.6